sensu-plugins-influxdb-metrics-checker 0.4.0 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ed89e4ad1b835c997279a3afc967efc91e6579fa
-  data.tar.gz: 5813fe0fa863a0e278620862bad7aeeae75651be
+  metadata.gz: 89eb5ded52962e841d56e247226c498c626eb122
+  data.tar.gz: 5dab8ae7bbfd8408658e385a6e1303cd8cac73ea
 SHA512:
-  metadata.gz: b8638d8b0b9a343b0233a5e39e2425cb5c238c58a97124d81452dc0da5478ae7b3886393b507b4be6a8ac4aa8680fe6faf02e41bd03e955fb96f6724dbb6e139
-  data.tar.gz: 0cacd9d9ee2257904253403682edb271ed8f7431ca6b4bdeb0d17d3d847baae81c682e57647f9d0b616eb89a60de9d1fc2382becea3df2c96ec5bd710486d9b4
+  metadata.gz: 33db0900a25d7533b421c4d913872a3c69095fbb5f6cd6d2b26328a3f492ebc1d638dad8e4008bbe567b675f292ef5127c9dac2f05b9e67c5487af64dcbda593
+  data.tar.gz: 907c4d77e84f18221292f798c7fce8f6bf1dec428f9aac5740c5e1713eef024675c42ffece9a569e0ff2a9bafb8daff8a1fe092e9c1b99c21a8bea8a8e40bb24

data/CHANGELOG.md

@@ -3,6 +3,11 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachangelog.com/)
 
+# [0.4.2] - 2017-01-20
+- eight release
+Small fix when printing numbers
+
+
 # [0.4.0] - 2017-01-20
 - seventh release
 New feature: Triangulation. Added the ability to get percentage of metric A, get percentage of metric B, and compare the distance between them. Useful when the metrics are related together by some business rule.
@@ -46,4 +51,6 @@ Leaving 5 minutes to the data to consolidate.
 [0.2.1]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.2.1...0.3.0
 [0.3.0]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.3.0...0.3.2
 [0.3.2]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.3.2...0.3.4
-[0.3.3]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.3.4...HEAD
+[0.3.4]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.3.4...0.4.0
+[0.4.0]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.4.0...0.4.2
+[0.4.2]: https://github.com/pliyosenpai/sensu-plugins-influxdb-metrics-checker/0.4.2...HEAD

data/README.md

@@ -66,17 +66,26 @@ ruby check-influxdb-metrics.rb --host=metrics-influxdb.internal.com --port=8086
 
 **Triangulation**
 
-In trigonometry and geometry, triangulation is the process of determining the location of a point by forming triangles to it from known points. This feature of the script is inspired in that idea.
-
+In trigonometry and geometry, [triangulation](https://en.wikipedia.org/wiki/Triangulation) is the process of determining the location of a point by forming triangles to it from known points. This feature of the script is inspired in that idea.
 
 [![triangulation_01.png](https://s24.postimg.org/kjihvilvp/triangulation_01.png (2KB))](https://postimg.org/image/hcnybw1fl/)
 
-Once we have a given metric A (ex: messages.sent), we'll normally compare that to yesterday's weather A', we'll get the percentage of difference and according to our threshold we'll fire an alert. Cool. Now let's go one step further.
-We may have a metric B (ex: sessions.generated), that has a business dependency on B. And if we dig further in our metrics, we may even relate that to, let's say, an average of 5 metrics A for each metric B. (In this example, you'll need 5 messages sent to build a session).
+Once we have a given metric A (ex: messages.sent), we'll normally compare that to yesterday's weather A', we'll get the percentage of difference (X in the picture) and according to our threshold we'll fire an alert. Cool. Now let's go one step further.
+We may have a metric B (ex: sessions.generated), that has a business dependency on A. And if we dig further in our metrics, we may discover that, let's say, for every 5 metrics in A we have 1 in B. (In this example, let's say that you'll need 5 messages sent to build 1 session).
+
+If we could say that every 5 As relates to 1 B, then the % of difference for A (X in the picture) and the percentage of difference for B (Y in the picture) will always be the same
+```
+Ex: A' = 15500, A = 20500, X = 32.26%. B' = 3100, B = 4100, Y =  32.26%. So ideally C (distance) = 1.92
+```
+Realistically, it's not always like that in production applications, sometimes you may need 7 messages, others only 4, so your average would be something around 5.333. Therefore, we can't say that the % in difference will always be the same, but once we look at the *distance* between these percentages (C in the picture), we'll see that they are pretty close. And that's the spirit of it, the ability to diagnose when the distance is higher than expected.
 
-If we could say that every 5 As relates to 1 B, then the % of difference for A and B will always be the same. Realistically, it's not always like that in production applications, sometimes you may need 7 messages, others only 4, so your average would be something around 5.333. Therefore, we can't say that the % in difference will always be the same, but once we look at the *distance* between these percentages, we'll see that they are pretty close. And that's the spirit of this feature, the ability to diagnose when the distance is higher than expected.
+A more real example will be:
+
+```
+A' = 15500, A = 20500, X = 32.26%. B' = 3081, B = 4134, Y =  34.18%. Therefore C (distance) = 1.92
+```
 
-Let's say that the system that sends items has an increase of 150%, and you are using this tool to verify that, therefore you don't get any exceptions because there is no drop in the metrics, but the system that process sessions keeps in the same 2% increase, which is a big distance up to 148. We clearly have a problem here. Maybe some bottleneck is happening somewhere, maybe some messages are lost due to this huge increase, and hopefully this feature will allow you to identify that something fussy is going on.
+Let's say that the system that sends items has an increase of 150%, and you are using this tool to verify that, therefore you don't get any exceptions because there is no drop in the metrics, but the system that process sessions keeps in the same 2% increase, which is a big distance of 148 up to 150. We clearly have a problem here. Maybe some bottleneck is happening somewhere, maybe some messages are lost due to this huge increase, and hopefully this feature will allow you to identify that something fussy is going on.
 
 **How it works**
 

data/bin/check-influxdb-metrics.rb

@@ -266,7 +266,7 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
       ok 'no metrics found'
     elsif @today_metric_count > @yesterday_metric_count
       display_metrics
-      critical 'For ' + config[:metric] + ' more metrics tracked today (' + @today_metric_count + ') than yesterday (' + @yesterday_metric_count + ') See above'
+      critical 'For ' + config[:metric] + ' more metrics tracked today (' + @today_metric_count.to_s + ') than yesterday (' + @yesterday_metric_count.to_s + ')'
     elsif @today_metric_count == @yesterday_metric_count
       compare_each_metric_in_regex
     else
@@ -279,13 +279,25 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
     evaluate_percentage_and_notify(difference)
   end
 
+  def difference_for_regex_queries(today, yesterday)
+    difference = difference_between_two_metrics(today, yesterday)
+    evaluate_percentage_for_regex(difference)
+  end
+
   def compare_each_metric_in_regex
     @today_metrics.each do |today_key, today_value|
       @yesterday_metrics.each do |yesterday_key, yesterday_value|
-        if today_key.eql? yesterday_key
-          puts yesterday_value.to_s + ' vs ' + today_value.to_s + ' for ' + today_key
-          difference_for_standard_queries(today_value, yesterday_value)
-        end
+        iterate_through_each_value_in_regex(today_key, today_value, yesterday_key, yesterday_value)
+      end
+    end
+    ok 'all regex metrics seems fine'
+  end
+
+  def iterate_through_each_value_in_regex(today_key, today_value, yesterday_key, yesterday_value)
+    if today_key.eql? yesterday_key
+      puts yesterday_value.to_s + ' vs ' + today_value.to_s + ' for ' + today_key
+      if today_value > yesterday_value
+        difference_for_regex_queries(today_value, yesterday_value)
       end
     end
   end
@@ -307,6 +319,17 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
     )
   end
 
+  def evaluate_percentage_for_regex(difference)
+    puts 'Difference of: ' + difference.round(3).to_s + ' %  for a period of ' + config[:period].to_s + 'm'
+    if difference > config[:crit]
+      critical "\"#{config[:metric]}\" difference is above allowed minimum of #{config[:crit]} %"
+    elsif difference > config[:warn]
+      warning "\"#{config[:metric]}\" difference is above warn threshold of #{config[:warn]}"
+    else
+      puts 'this metric seems ok'
+    end
+  end
+
   def evaluate_percentage_and_notify(difference)
     puts 'Difference of: ' + difference.round(3).to_s + ' %  for a period of ' + config[:period].to_s + 'm'
     if difference < config[:crit]
@@ -320,7 +343,8 @@ class CheckInfluxDbMetrics < Sensu::Plugin::Check::CLI
 
   def evaluate_distance_and_notify(distance)
     if distance > config[:distance].to_f
-      critical config[:metric] + ' vs ' + config[:triangulate] + ' distance is greater than allowed minimum of ' + config[:distance]
+      puts 'distance of ' + distance.to_s
+      critical config[:metric] + ' vs ' + config[:triangulate] + ' distance is greater than allowed minimum of ' + config[:distance].to_s
     else
       ok 'distance ok'
     end

data/lib/sensu-plugins-influxdb-metrics-checker/version.rb

@@ -2,7 +2,7 @@ module SensuPluginsInfluxDbMetricsChecker
   module Version
     MAJOR = 0
     MINOR = 4
-    PATCH = 0
+    PATCH = 4
 
     VER_STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sensu-plugins-influxdb-metrics-checker
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.4
 platform: ruby
 authors:
 - Juanjo Guerrero Cerezuela
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-20 00:00:00.000000000 Z
+date: 2017-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sensu-plugin