sensu-plugins-eventstore 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fed7594889235965a1b644d4e98a73fa6fa1c453
-  data.tar.gz: 4a1bbc6a87744a2a98b2780f9f30ae98ee2469ef
+  metadata.gz: 38994ee87db4e297cdec9d70ef832775a29e1b33
+  data.tar.gz: 59436bc00a7b1e9bc17ad38bad1e398344a5bc75
 SHA512:
-  metadata.gz: 75267c5e0d10958ba2a5ffdab23a4aba284adb8ce5092994733252eb92b3ca5894f8bf0331cd3e46efd1805473e63a444b91298ee86567b3fa1789021711e189
-  data.tar.gz: 5300dcf48fa5a5aca75fe29e6eb0e9eec8626de0ec716db662232433ce18f875f6e17c917a34e505f097677885cb80bc5fdfc522a2d0da00c4d8458f04d29aba
+  metadata.gz: c5112ccfa0d8a846abc8c7d3181b136794d74f463726075c12c6db4c1665891f4aff7b17c6eb22ed894b8451ac2512dd695aba85df3a8d2d33130ee73cc1ce02
+  data.tar.gz: bfa6f88dcdf913849037905f1a4b38a8294877d8e86a3186bbb22e829412cdeb88ff80e8e1bfa7a870487b258566f32a7e899c9b083b8cce9ccfba20b17dd400

data/bin/check-gossip.rb

@@ -73,6 +73,7 @@ class CheckGossip < Sensu::Plugin::Check::CLI
 
       current_machine_ips = get_current_machine_ipv4s
       event_store_ips = get_event_store_ips_from_dns cluster_dns
+      critical_failure_from_no_event_store_ips cluster_dns unless event_store_ips.any?
       gossip_address = get_matching_ips current_machine_ips, event_store_ips
       expected_nodes = event_store_ips.count
     end
@@ -84,7 +85,7 @@ class CheckGossip < Sensu::Plugin::Check::CLI
     matched_ips = machine_ips.select do |ip_to_look_for|
       event_store_ips.find { |ip_to_match| ip_to_look_for == ip_to_match }
     end
-    critical "#{matched_ips.count} ips were found for this machine in the event store dns lookup, cannot figure out where to check gossip from" unless matched_ips.one?
+    critical_failure_from_no_matching_ips machine_ips, event_store_ips unless matched_ips.one?
     matched_ips[0]
   end
 
@@ -111,25 +112,52 @@ class CheckGossip < Sensu::Plugin::Check::CLI
 
   def nodes_all_alive?(document)
     nodes = get_is_alive_nodes document
-    nodes.all? { |node| node.content == 'true' }
+    nodes.all? { |node| node_is_alive? node }
   end
 
   def check_node(gossip_address, gossip_port, expected_nodes)
     puts "\nchecking gossip at #{gossip_address}:#{gossip_port}"
-    gossip = open("http://#{gossip_address}:#{gossip_port}/gossip?format=xml")
+
+    begin
+      connection_url = "http://#{gossip_address}:#{gossip_port}/gossip?format=xml";
+      gossip = open(connection_url)
+
+    rescue StandardError
+      critical "Could not connect to #{connection_url} to check gossip, has event store fallen over on this node? "
+    end
 
     xml_doc = Nokogiri::XML(gossip.readline)
 
-    puts "\tchecking for #{expected_nodes} nodes"
-    critical "\twrong number of nodes, was #{get_members(xml_doc).count} should be exactly #{expected_nodes}" unless node_count_is_correct? xml_doc, expected_nodes
+    puts "Checking for #{expected_nodes} nodes"
+    critical_failure_from_missing_nodes xml_doc, expected_nodes unless node_count_is_correct? xml_doc, expected_nodes
 
-    puts "\tchecking nodes for IsAlive state"
-    critical "\tat least 1 node is not alive" unless nodes_all_alive? xml_doc
+    puts "Checking nodes for IsAlive state"
+    critical_failure_from_dead_nodes xml_doc, expected_nodes unless nodes_all_alive? xml_doc
+
+    puts "Checking for exactly 1 master"
+    critical_failure_from_incorrect_master_count xml_doc unless only_one_master? xml_doc
+
+    ok "#{gossip_address} is gossiping with #{expected_nodes} nodes. All nodes are marked as alive and one master node was found."
+  end
 
-    puts "\tchecking for exactly 1 master"
-    critical "\twrong number of node masters, there should be exactly 1" unless only_one_master? xml_doc
+  def critical_failure_from_no_matching_ips(machine_ips, event_store_ips)
+    critical "this machine has ips of #{machine_ips}, event store (according to dns lookup) has ips of #{event_store_ips}. There should be exactly one match, but wasn't. "
+  end
+  def critical_failure_from_no_event_store_ips(dns_name)
+    critical "could not find any ips at dns name #{dns_name} so cannot check gossips"
+  end
+  def critical_failure_from_missing_nodes(xml_doc, expected_nodes)
+    critical "Wrong number of nodes, was #{get_members(xml_doc).count} should be exactly #{expected_nodes}"
+  end
+  def critical_failure_from_dead_nodes(xml_doc, expected_nodes)
+    critical "Only #{get_is_alive_nodes(xml_doc).count { |node| node_is_alive? node}} alive nodes, should be #{expected_nodes} alive"
+  end
+  def critical_failure_from_incorrect_master_count(xml_doc)
+    critical "Wrong number of node masters, there should be exactly 1 but there were #{get_masters(xml_doc)} masters"
+  end
 
-    ok "Gossiping with #{expected_nodes} nodes, all of which alive and with one master node."
+  def node_is_alive?(node)
+    node.content == 'true'
   end
 
   def print_all(collection, type)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sensu-plugins-eventstore
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Jamie Wroe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-12 00:00:00.000000000 Z
+date: 2016-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yard