sensible-cinema 0.23.4 → 0.23.5

data/TODO

@@ -17,6 +17,7 @@
 == high prio like blocking bugs ==  
   
 == under next release specific items: ==
+  mplayerx work?
   latest dir "conflict" for grabbing sintel from file
   can I just use ffmpeg for -> ts ? http://eotmsnotes.wordpress.com/2011/04/25/tsmuxer-notes/
   cheap minimize demo "fake auto" :)
@@ -147,7 +148,8 @@
   investigate: can I use zoomplayer max?
   investigate dvdrsbvdl (windows media center edl plugin)
 
-== DVD/DVD-realtime backlog (totally unordered, some very low prio, basically all never do) ==
+== DVD+-DVD-realtime backlog (totally unordered, some very low prio, basically all never do) ==
+  the auto-matcher filename to subtitles [?]
   "media browser" plugin?
   @makemkv: show us the title numbers, and number them *by those*
   @macports: set notestxt \
@@ -338,6 +340,7 @@ ask swank if individuals can rent too?
 
 == random non-DVD backlog ... or never do DVD. note: just plow forward, to "grab" available ideas...except that for now, just what *I* plan on needing for myself (filters for what I need/want). ==
 
+@mplayer: you return the wrong return code, sillys! https://gist.github.com/1056292
 @smplayer: bounty or me fix: their for their display [if they use get_time_pos isn't that enough ?]
   @mplayer is it really too slow [link], and there thus no hope for EDL working right? maybe it could change to be based off the get_time_pos ?
 Also things skip-worthy include The prefix/endfix of Netflix

data/VERSION

@@ -1 +1 @@
-0.23.4
+0.23.5

data/bin/sensible-cinema

@@ -114,7 +114,7 @@ module SensibleSwing
     
     def force_accept_license_first
         require_blocking_license_accept_dialog 'Sensible Cinema', 'gplv3', 'http://www.gnu.org/licenses/gpl.html', 'Sensible Cinema license agreement', 
-          "Sensible Cinema is distributed under the gplv3.\nBY CLICKING \"accept\" YOU SIGNIFY THAT YOU HAVE READ, UNDERSTOOD AND AGREED TO ABIDE BY THE TERMS OF THIS AGREEMENT"
+          "Sensible Cinema is distributed under the gplv3 (http://www.gnu.org/licenses/gpl.html).\nBY CLICKING \"accept\" YOU SIGNIFY THAT YOU HAVE READ, UNDERSTOOD AND AGREED TO ABIDE BY THE TERMS OF THIS AGREEMENT"
         require_blocking_license_accept_dialog 'Sensible Cinema', 'is_it_legal_to_copy_dvds.txt file', File.expand_path(File.dirname(__FILE__) + "/../documentation/is_it_legal_to_copy_dvds.txt"), 
           'is_it_legal_to_copy_dvds.txt file', 'I acknowledge that I have read, understand, accept and agree to abide by the implications noted in the documentation/is_it_legal_to_copy_dvds.txt file'
         Storage['main_license_accepted'] = VERSION
@@ -503,7 +503,7 @@ module SensibleSwing
     
     def show_assert_dialog message
       returned = JOptionPane.showConfirmDialog self, message, message, JOptionPane::YES_NO_CANCEL_OPTION
-      assert_confirmed_dialog returned
+      assert_confirmed_dialog returned, nil
     end
       
     def require_blocking_license_accept_dialog program, license_name, license_url_should_also_be_embedded_by_you_in_message, 
@@ -511,7 +511,7 @@ module SensibleSwing
       puts 'Please confirm license agreement in open window.'
       old = ['no', 'yes', 'ok'].map{|name| 'OptionPane.' + name + 'ButtonText'}.map{|name| [name, UIManager.get(name)]}
       UIManager.put("OptionPane.yesButtonText", 'Accept')
-      UIManager.put("OptionPane.noButtonText", "View File (#{license_name})")
+      UIManager.put("OptionPane.noButtonText", "View #{license_name}")
       # cancel button stays the same...
 
       message ||= "Sensible Cinema requires a separately installed program (#{program}).  You can install this program
@@ -523,19 +523,21 @@ module SensibleSwing
         You agree that you are responsible for the download and use of this program, within sensible cinema or otherwise."
       
       returned = JOptionPane.showConfirmDialog self, message, title, JOptionPane::YES_NO_CANCEL_OPTION
-      assert_confirmed_dialog returned
+      assert_confirmed_dialog returned, license_url_should_also_be_embedded_by_you_in_message
       p 'confirmed license noted: ' + license_name
       throw unless returned == 0
       old.each{|name, old_setting| UIManager.put(name, old_setting)}
     end
     
-    def assert_confirmed_dialog returned
+    def assert_confirmed_dialog returned, license_url_should_also_be_embedded_by_you_in_message
       # 1 is view button was clicked
       # 0 is accept
       # 2 is cancel
       if returned == 1
-        system_non_blocking("start #{license_url_should_also_be_embedded_by_you_in_message}")
-        puts "Please restart after reading license agreement, to be able to then accept it."
+        if license_url_should_also_be_embedded_by_you_in_message
+          system_non_blocking("start #{license_url_should_also_be_embedded_by_you_in_message}")
+          puts "Please restart after reading license agreement, to be able to then accept it."
+        end
         System.exit 1
       end
       if returned == 2
@@ -754,13 +756,20 @@ module SensibleSwing
         save_to_file_name = save_to_file_name.gsub(' ', '_').gsub( /\W/, '') # no punctuation or spaces for now...
         fc.set_file(get_drive_with_most_space_with_slash + save_to_file_name)
         save_to = fc.go
+        begin
+          FileUtils.touch save_to
+          File.delete save_to
+        rescue Errno::EACCES => e
+          show_blocking_message_dialog "unable to write to that directory, please pick again: " + e.to_s
+          raise 'pick again!'
+        end
         a = File.open(File.dirname(save_to) + "/test_file_to_see_if_we_have_permission_to_write_to_this_folder", "w")
         a.close
         File.delete a.path
         freespace = get_freespace(save_to)
-        if freespace < 16_000_000_000
+        if freespace < 8_000_000_000
           show_blocking_message_dialog("Warning: there may not be enough space on the disk for #{save_to} 
-          (depending on DVD size, you may need like 16G free, but typically will need around 10GB free--you have #{freespace/1_000_000_000}GB free).  Click OK to continue.")
+          (depending on DVD size, you may need around 10G free--you have #{freespace/1_000_000_000}GB free).  Click OK to continue.")
         end
         raise 'cannot save to filname with spaces yet (ask for it)' if save_to =~ / /
         save_to
@@ -920,7 +929,7 @@ module SensibleSwing
           show_blocking_message_dialog "Done--you may now watch file\n #{saved_to}\n in VLC player (or possibly smplayer)"
         end
       else
-        show_blocking_message_dialog("Failed--please examine console output and report back!\nAlso consult the troubleshooting section of the README file.", "Failed", JOptionPane::ERROR_MESSAGE)
+        show_blocking_message_dialog("Failed--please examine console output and report back!\nAlso consult the documentation/troubleshooting file.", "Failed", JOptionPane::ERROR_MESSAGE)
       end
     end
     

data/change_log_with_feature_list.txt

@@ -1,6 +1,12 @@
+== 0.23.5 ==
+
+Cleanup some terminology/minor bug fix/usability fixes.
+
 == 0.23.4 ==
 
-Can process by filename now if no DVD is inserted (warns and asserts they must own it).
+Can process by filename now if no DVD is inserted (warns and asserts they must own it, then uses it).
+It also memorizes directory names auto-magically according to source line location.
+This one was quickly superceded by 0.23.5 to accomodate for some fatal bug.
 
 == 0.23.3 ==
 

data/sensible-cinema.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{sensible-cinema}
-  s.version = "0.23.4"
+  s.version = "0.23.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Roger Pack"]
@@ -23,7 +23,7 @@ Gem::Specification.new do |s|
     "Rakefile",
     "TODO",
     "VERSION",
-    "_DO_NOT_RUN_IT_FROM_HERE_DOWNLOAD_THE_RELEASE_ZIP_INSTEAD",
+    "_DO_NOT_RUN_IT_FROM_HERE_DOWNLOAD_THE_RELEASE_ZIP_FROM_SOURCEFORGE_INSTEAD",
     "bin/sensible-cinema",
     "bin/sensible-cinema-cli",
     "business_ideas.txt",
@@ -100,6 +100,7 @@ Gem::Specification.new do |s|
     "spec/tsmuxer.output",
     "spec/vlc_programmer.spec.rb",
     "template_bats/RUN SENSIBLE CINEMA CLICK HERE.bat",
+    "template_bats/_DO_NOT_RUN_IT_FROM_HERE_DOWNLOAD_THE_RELEASE_ZIP_FROM_SOURCEFORGE_INSTEAD",
     "template_bats/advanced--create or edit sensible cinema delete list files.bat",
     "todo.build_library.txt",
     "todo.inventionzy.txt",

metadata

@@ -2,7 +2,7 @@
 name: sensible-cinema
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.23.4
+  version: 0.23.5
 platform: ruby
 authors: 
   - Roger Pack
@@ -217,7 +217,7 @@ files:
   - Rakefile
   - TODO
   - VERSION
-  - _DO_NOT_RUN_IT_FROM_HERE_DOWNLOAD_THE_RELEASE_ZIP_INSTEAD
+  - _DO_NOT_RUN_IT_FROM_HERE_DOWNLOAD_THE_RELEASE_ZIP_FROM_SOURCEFORGE_INSTEAD
   - bin/sensible-cinema
   - bin/sensible-cinema-cli
   - business_ideas.txt
@@ -294,6 +294,7 @@ files:
   - spec/tsmuxer.output
   - spec/vlc_programmer.spec.rb
   - template_bats/RUN SENSIBLE CINEMA CLICK HERE.bat
+  - template_bats/_DO_NOT_RUN_IT_FROM_HERE_DOWNLOAD_THE_RELEASE_ZIP_FROM_SOURCEFORGE_INSTEAD
   - template_bats/advanced--create or edit sensible cinema delete list files.bat
   - todo.build_library.txt
   - todo.inventionzy.txt