sensible-cinema 0.19.6 → 0.19.7

data/ChangeLog

@@ -1,3 +1,7 @@
+== 0.19.7 ==
+
+Slightly more user friendly error handling.
+
 == 0.19.6 ==
 
 Update terminology to make it more clear what can play what when it's done.

data/README

@@ -8,11 +8,10 @@ a few freely available open source programs [3]
 to accomplish the editing for you.  Then you can sit back and relax as you watch the "sensible"
 version of your DVD.
 
-To use it, basically install it then run it (see installation, below).
-It will come up with some windows where you choose what you want to do
+To use it, basically install it, insert an original DVD that you want to see edited, then run sensible cinema.
+It will pop up some windows where you choose what to do for that DVD, hopefully easily.
 
-If you try to make a copy of your DVD, note that it will take about one and a half times
-as long as the playtime of the movie itself, so budget some time for it.
+Note that the whole process can at times take hours, so budget some time for it.
 
 Also note that just because a video lacks profanity...does not immediately make it an inspiring experience.
 I'd suggest carefully evaluating your motives, and going with those.
@@ -43,7 +42,8 @@ See the accompanied how_to_create.txt file.
 
 Q. How do I watch these on my TV, not just on my computer?
 A. You could burn a new DVD with it.  First create it on your hard drive.  Then use some burning utility.
-  Dvd Flick is a good one for windows.  Heere's a screencast of using it: http://rogerdpack.t28.net/sensible-cinema
+  Dvd Flick is a good one for windows.  There's a screencast of using it within: http://rogerdpack.t28.net/sensible-cinema
+  DeVeDe almost might work for windows users: http://www.majorsilence.com/devede though it looks less user friendly.
   For OS X : iDVD might work well.
   You might be able to move your laptop over to near your TV and hook it in from there.  
   Or buy a very long cord and plug it in as an extra monitor from your desktop.
@@ -66,53 +66,53 @@ Also note that if your DVD has scratches that cause it to skip, the time signatu
 
 == Motivation ==
 
-The initial motivation for the project was that I dislike profanity in movies.
-It's jarring, if you're not used to it in real life.
-Also sometimes certain scenes in movies offend, and don't contribute to the overall plot,
-and I'd rather not watch a movie that has them.
-Clearplay (a realtime filtering DVD player)
-(for me) didn't cut it.  It costs (I'm too cheap to pay--and many
+The initial motivation for the project was that I dislike deity profanity in movies.
+And reall any profanity is jarring, if you're not used to it in real life, and can
+make you a bit on edge when you watch a movie.
+Also sometimes only certain scenes in movies offend, and don't contribute to the overall plot,
+and I'd rather not watch a movie that has them.  But I still want to be able to watch movies at all :)
+I tried Clearplay (a realtime filtering DVD player)
+but (for me) it didn't seem to cut it.  It costs money (I'm too cheap to pay--and many
 many other people don't/can't use it...).  Their
 filters sometimes don't cut out all unwanted content (ex: Saints and
 Soldiers left profanity in its filtered version...which wasn't what I had
 anticipated.  Others have noted that sometimes the edit timings
-are off so that it will mute out sections just previous to the profanity, while
-leaving the profanity in, etc.).  Also clearplay apparently runs a rather 
-confusing subscription policy, as well, so I'm told [1].
-Also sometimes clearplay "mutes out" profanity but you can easily still lip read it,
-so it's almost as if you were exposed to it anyway.  Not ideal.
-There is no little community collaboration/review.
-They don't even have a "request a filter" option anymore.
-They don't have filters for movies that I want edited (Condorman and Tron
-lacked last time I checked...probably because they are too
-obscure.) Also I watch movies only on computer, and they no
-longer have a computer player.  They also don't edit streamed
+are slightly off so that it will mute out sections just previous to profanity, while
+leaving the profanity itself in, etc.).  Clearplay apparently also runs a rather 
+confusing subscription policy, as well, I'm told [1].
+Clearplay also has little community collaboration/review (though they do have some feedback).
+They don't even have a "request a filter" option anymore, like they used to.
+They also don't have filters for all the movies that I want to see edited (Condorman and Tron
+lacked last time I checked were lacking...probably because they are too
+obscure.) Also I watch movies only on computer, and they
+have no computer filter player, only DVD players.  They also don't edit streamed
 online movies either (last time I checked, anyway).  So overall I
 wanted to build my own that overcame some of these hurdles and was
 also more accessible/open.
 
-I also wanted to get a prototype out there of some ideas so that
-people can't patent them and pretend that they were inventors :)
+I also wanted to get a prototype out there of some of my ideas so that
+others can't patent them and pretend that they were inventors :)
 
-So the project started off as a prototype that could "watch hulu (online) movies
+So originally the project started off as a prototype that could "watch hulu (online) and netflix instant movies
 edited" (it uses screen tracking and OCR's the on-screen
 timestamp, monitors it for specific times, and reacts appropriately).
-However, I do not currently release that version to the public for patent
-reasons (clearplay has a patent on realtime tracking,
-which is similar).  I have released older versions that do, but not
-anymore.
-Then I realized I could basically have the same effect by using
-pre-processing and Edit Decision Lists (basically by using playlists with
-VLC, to play from second x to y, then from x to mu, etc.).
+However, this functionality, though working, is disabled for patent
+reasons (clearplay has a patent on realtime tracking).  
+Some older released versions had it enabled, but not anymore.
+Then I realized I could basically create the same effect using
+(more patent friendly) pre-processing and deletion lists (basically 
+Edit Decision Lists enforced using playlists for
+VLC, like play from second x to y, then from x to mu, etc.).
 I just pass in a playlist, it does all the work for me.
 There are a few released versions that do this exactly.
 Then it occurred to me that you could grab the several clean segments
 off a DVD, and piece them together to create an edited copy.  This avoids 
-realtime tracking.  Which is where we are now.
+realtime tracking.  This seems reasonably patent friendly, so it is
+what I release here. 
 
 See also the LICENSE.TXT file.
 
-[1] http://www.amazon.com/review/R27VK5BR9NDHBD/ref=cm_cr_pr_viewpnt#R27VK5BR9NDHBD
+[1] http://www.amazon.com/review/R27VK5BR9NDHBD/ref=cm_cr_pr_viewpnt#R27VK5BR9NDHBD amazon review of clearplay product
 
 == License ==
 

data/Rakefile

@@ -122,8 +122,10 @@ end
 
 task 'deploy' do
   name = 'sensible-cinema-' + File.read('VERSION').strip + ".zip"
+  p 'copying in'
   raise unless system("scp #{name} rdp@ilab1.cs.byu.edu:~/incoming")
-  raise unless system ("ssh rdp@ilab1.cs.byu.edu \"scp ~/incoming/#{name} wilkboar@myfavoritepal.com:~/www/rogerdpackt28/sensible-cinema\"")
+  p 'copying over'
+  raise unless system("ssh rdp@ilab1.cs.byu.edu \"scp ~/incoming/#{name} wilkboar@myfavoritepal.com:~/www/rogerdpackt28/sensible-cinema\"")
 end
 
 desc 'j -S rake bundle_dependencies create_distro_dir ... (releases with clean cache dir, which we need now)'
@@ -133,6 +135,7 @@ task 'full_release' => [:bundle_dependencies, :create_distro_dir, :build] do # :
   system("#{Gem.ruby} -S gem push #{gems[-1]}")
   FileUtils.rm_rf 'pkg'
   Rake::Task["zip"].execute
+  Rake::Task["deploy"].execute
   system("git push origin master")
   puts "don't forget to blog about it...and upload .zip of it..."
 end

data/TODO

@@ -2,33 +2,36 @@
   
 == up next release ==
 
+  edl straight is broken on HP at 2 hours
+    compare with cars
+  clear runnings finish
+    have ben and chris test it out
+
 == slightly lower than that, somewhat ordered ==
 
-  edl straight is broken on HP at 2 hours
-  warn on low disk
-  temple EDL at home
-  cars bring home :)
   linearize edl's
     don't use them linear, just linearize
-      not this release
-  partner for filters (Jon, Karlie if interested...give beta)
-    lotsa filters somehow
-      my dvd's (loose timestamps...)
-      partners'...
-      only after linearize
-  mpeg is lossy (at least my current one pass conversion still is...) AND SO SLOW FOR EDITING and smplayer can't play it right unedited
-    frame accurate splitter
+  mpeg is lossy (at least my current one pass conversion still is...)  and smplayer can't play it right unedited
+    frame accurate splitter naive
+  more filters
+    my dvd's (loose timestamps...)
+      cars backport real EDL :)
+    enlist chris' help
+      need mac port [?]
+    friend dvd's, me DL
+    partner for filters (Jon, Karlie if interested...give beta)
+      all only after linearize, new year, frame accurate
+  temple EDL at home
+  can have the mouse jerk "only every so often"
   can I use ffmpeg to re-sync audio, and be able to re-play the edited copy, and thus avoid the small but extra harddup overhead (basically "just avoid")?
     I can live with "watching while grabbing" being lack luster...or maybe I can grab it with acodec copy (typically), then reencode it somehow later into something that is friendlier to computer players...or is it encoders?
       appears the only messed up audio one is smplayer...and probably mplayer with DVD's [?]
         do this after frame accurate
   button start EDL playback here [?] (for create mode)
-  beta release/rinse and repeat with various ppl (once it's releasable...)
+  beta release/rinse and repeat with various ppl
   a real'ish-er website
-    link to ML
   compare computer DVD timings with physical player's timings...
     if same, add imdb todo's up here
-  cleaner user error on locked file :)
   propaganda-ize
     advertise in christian places
     blogs that have ever mentioned clearplay :P
@@ -36,11 +39,19 @@
     advertise urug, ruby flow :)
     only after new year
   add they 'play from unedited from grab till it hits the first bad spot', if useful [?]
-  md5 and verify the fulli version... [?]
-    only useful once I get the frame accurate stuff done, and any audio tweakage, etc.
   
 == DVD backlog (unordered, some very low prio, basically all never do) ==
 
+  @smplayer: unable to seek in cars (once I figure out if this is specific to a particular DVD)
+    @mplayer: edl disworks after a certain timestamp (after...)
+  disallow:
+    "0:45:00.0" , "00:450:10.0",  # second 2700
+  issues
+  a website that gives you a "wholesome meter"
+  md5 and verify the fulli version... [?]
+    only useful once I get the frame accurate stuff done, and any audio tweakage, etc.
+  frame accurate splitter could be optimized, perhaps, split wise, speed wise?
+  speedify things (the whole process takes approximately...eternity?)
   can I combine commands onto one command line for a quicker anything?
   can I get the original audio tracks back?
   show them how to use smplayer with subtitles
@@ -357,6 +368,7 @@ create a "book edit list" (word x is at position y...)
 @mencoder: can't split
 something like you watch it *with* you friends and can all chat together...hmm...
 donate money to several projects I use/like :)
+  after have LLC
 
 @mencoder: ripping like this results in an (avidemux, VLC) fourcc of 'ugh':  mencoder2 dvdnav://1  -oac copy -ovc copy -o D:\raw_rip_mpeg_example.avi -endpos 20 -dvd-device E:\
 

data/VERSION

@@ -1 +1 @@
-0.19.6
+0.19.7

data/bin/sensible-cinema

@@ -192,7 +192,7 @@ EOL
         drive, volume, md5 = choose_dvd_drive
         # display it, allow them to copy and paste it out
         get_user_input("#{drive} #{volume} for your copying+pasting pleasure (highlight, then ctrl+c to copy)        \n
-        This is used to identify a disk to match it to its EDL, later.", "\"disk_unique_id\" => \"#{md5}\",")
+        This is USED to identify a disk to match it to its EDL, later.", "\"disk_unique_id\" => \"#{md5}\",")
       }
       
       @upload = new_jbutton( "Upload/E-mail suggestion/Submit anything", true).on_clicked {
@@ -215,7 +215,7 @@ EOL
       increment_button_location
       increment_button_location
 
-      setSize 410, @starting_button_y
+      setSize @button_width+80, @starting_button_y
 
       check_for_dependencies
     end
@@ -344,6 +344,10 @@ EOL
       EdlParser.parse_file path, ignore_settings
     end
     
+    def get_freespace path
+      JFile.new(path).get_usable_space
+    end
+    
     def choose_dvd_and_edl_for_it
       drive, dvd_volume_name, md5sum = choose_dvd_drive
       @_edit_list_path ||= 
@@ -352,7 +356,7 @@ EOL
         edit_list_path = single_edit_list_matches_dvd(md5sum)
         if !edit_list_path
           fc = FileDialog.new(self)
-          fc.set_title "Please pick a DVD Delete List File"
+          fc.set_title "Please pick a DVD Delete List File (non matching found)"
           fc.set_directory EDL_DIR
           edit_list_path = fc.go
         end
@@ -389,6 +393,9 @@ EOL
         a = File.open(File.dirname(save_to) + "/test_file_to_see_if_we_have_permission_to_write_to_this_folder", "w")
         a.close
         File.delete a.path
+        if get_freespace(save_to) < 16_000_000_000
+          show_blocking_message_dialog("Warning: there may not be enough space on the disk for #{save_to} (depending on DVD size, you may need like 16G free, but typically will need around 10GB free).  Click OK to continue.")
+        end
         save_to
       end
     end
@@ -446,6 +453,9 @@ EOL
       rescue MencoderWrapper::TimingError => e
         show_blocking_message_dialog("Appears you chose a time frame with no deletion segment in it--please try again:" + e)
         return
+      rescue Errno::EACCES => e
+        show_blocking_message_dialog("Appears a file on the system is locked: perhaps you need to close down some instance of mplayer?" + e)
+        return
       end
       temp_dir = Dir.tmpdir
       temp_file = temp_dir + '/vlc.temp.bat'
@@ -533,7 +543,7 @@ EOL
         @saved_opticals = opticals
         return @_choose_dvd_drive
       else
-        puts 'did not select a drive...exiting'
+        puts 'did not select a drive...hard exiting'
         java.lang.System.exit 1
       end
     end

data/sensible-cinema.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{sensible-cinema}
-  s.version = "0.19.6"
+  s.version = "0.19.7"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Roger Pack"]
-  s.date = %q{2010-12-23}
+  s.date = %q{2010-12-28}
   s.email = %q{rogerdpack@gmail.com}
   s.executables = ["sensible-cinema", "sensible-cinema-cli"]
   s.extensions = ["ext/mkrf_conf.rb"]
@@ -29,7 +29,7 @@ Gem::Specification.new do |s|
     "VERSION",
     "bin/sensible-cinema",
     "bin/sensible-cinema-cli",
-    "create or edit sensible cinema decision list files.bat",
+    "create or edit sensible cinema delete list files.bat",
     "experimental_readme.txt",
     "ext/mkrf_conf.rb",
     "go.bat",

data/spec/notes

@@ -1,9 +1,53 @@
+monsters inc. overlaps at 25 minutes, 50'ish, 70, "when they land" and there's like 30 'select scenes' (chapters) in that time frame...
+
+bob "they will come" has no mplayer overlap (45 minutes long)
+
+HP 2 "full and edited version" had a twidge off of audio even in VLC (unsure if that was copy or lavc audio)
+  seems consistent
+  The DVD (flick) appeared to have audio in perfect sync, always.
+  seems to play fine in smplayer
+  the fulli version was *totally off* in smplayer
+  fulli, edited version had some artifacts in VLC
+  fulli version had perfect audio in VLC
+  audio looks barely off VLC for the whole thing
+
+mplayer (updated) playing dvd:// (bob) can't seek if past 30 minutes or so (pause/hang)
+
+mplayer (updated) playback, if it ever goes off the screen, chokes and hurles and dies (or if it goes under a window that is always on top).
+
+an edl with (updated mplayer and) dvdnav:// (bob) results in a crash when seeking the first few seconds, at least.
+
+Seeking using the "forward 10, back 10" works in mplayer console, 
+  also works (!) with smplayer (+10, back 10).
+  
+Also edl works *perfectly* when playing from the ripped file.
+
+There is only one break in cars DVD. A:3756
+  Is it the same in other large DVD's?
+  so certainly, mplayer's edl playback is broken currently, for DVD's.
+
+if I change the mute to 2:13, then it works [!], though probably doubly.
+
+"enable dvd menus" in mplayer doesn't seem to help with seeking weirdness in smplayer
+
+smplayer edl against cars DVD *fails* on later ones (1:05), but succeeds on 15:00, mute-wise.
+Like epic fail.
+also seeking totally fails:
+  58 -> 58 works (cars)
+  transition to broken seeking:1:02:44
+  also always thinks its chapter 1 :)
+  
+smplayer playing cars fulli (of some sort) seems to be a split second off, audio-wise
+
 smplayer on HP2 -> edited version (ffmpeg through mencoder) with oac copy, is off by an annoying split second when replayed in smplayer
- at other times, it fails everywhere almost sync-wise
+ at other times, it fails everywhere almost, sync-wise
   that "might" have been with HP and -oac lavc, but without harddup.  or maybe it was -oac copy
   VLC plays the audio splendidly on the same.
   plays well from DVD, though.  Just that one file isn't playable with mplayer...
   how does EDL fit into all of this, though?
+  also note that mplayer originally couldn't cut right because of audio (with oac copy, I believe)
+
+ffmpeg said that the huge HP grab was always 48 minute duration [?] (then proceeded to work right)
 
 edl *fails* with HP at the 2 hour mark, audio.  The audio did seem to line up, at least, with their lips.
   and if it's video--fails the same. Seems to think it's at second 2678, or minute 44, not minute 120?

data/spec/sensible_cinema_gui.spec.rb

@@ -35,16 +35,16 @@ module SensibleSwing
       MainWindow.new.single_edit_list_matches_dvd(nil).should be nil
     end
     
-    it "should not die if you choose a poorly formed edl" do
+    it "should not die if you choose a poorly formed edl (should warn)" do
       time_through = 0
       @subject.stub!(:single_edit_list_matches_dvd) {
-        'fake filename doesnt even matter because we fake the parsing of it later'
+        'fake filename doesnt matter because we fake its being parsed'
       }
       
       @subject.stub!(:parse_edl) {
         if time_through == 0
           time_through += 1
-          eval("a-----") # throws Syntax Error first time
+          eval("a-----") # force it to throw a Syntax Error first time
         else
           "stuff"
         end
@@ -53,6 +53,23 @@ module SensibleSwing
       @show_blocking_message_dialog_last_args.should_not be nil
     end
     
+    it "should warn if you don't have enough disk space" do
+      @subject.get_freespace('.').should be > 0
+      @subject.stub!(:get_freespace) {
+        0
+      }
+      @subject.get_save_to_filename 'dvd_title'
+      @show_blocking_message_dialog_last_args[0].should =~ /may not be enough/
+    end
+    
+    it "should not warn if you have enough free disk space" do
+      @subject.stub!(:get_freespace) {
+        16_000_000_000
+      }
+      @subject.get_save_to_filename 'dvd_title'
+      @show_blocking_message_dialog_last_args.should be nil
+    end
+    
     it "should not select a file if poorly formed" do
       @subject.stub!(:parse_edl) {
         eval("a----")
@@ -120,6 +137,16 @@ module SensibleSwing
         Thread.new {} # fake out the return...
       }
       @subject.stub!(:open_file_to_edit_it) {}
+      
+      PlayAudio.stub!(:play) {
+        # don't play anything, by default :)
+      }
+      
+      @subject.stub!(:get_freespace) {
+        # during testing, we *always* have enough free space :)
+        16_000_000_000
+      }
+      
     end
     
     after do
@@ -215,6 +242,22 @@ module SensibleSwing
       @command.should match(/smplayer/)
     end
     
+    it "should not die if you pass it the same start and end time frames--graceful acceptance" do
+      @subject.stub!(:get_mencoder_commands) {
+        raise MencoderWrapper::TimingError
+      }
+      click_button(:@rerun_preview)
+      @show_blocking_message_dialog_last_args[0].should =~ /you chose a time frame/
+    end
+    
+    it "should not die if you pass it the same start and end time frames--graceful acceptance" do
+      @subject.stub!(:get_mencoder_commands) {
+        raise Errno::EACCES
+      }
+      click_button(:@rerun_preview) # lodo rspec error: wrong backtrace if no => e!
+      @show_blocking_message_dialog_last_args[0].should =~ /a file/
+    end
+
     it "should warn if you watch an edited time frame with no edits in it" do
       @subject.unstub!(:get_mencoder_commands)
       click_button(:@preview_section)
@@ -279,8 +322,7 @@ module SensibleSwing
       wrote.should include("380.85 1")
     end
     
-    
-    def should_allow_for_changing_file corrupt_file = false
+    def should_allow_for_changing_file corrupt_the_file = false
        with_clean_edl_dir_as 'temp' do
         File.binwrite('temp/a.txt', "\"disk_unique_id\" => \"abcdef1234\"")
         @subject.stub!(:choose_dvd_drive) {
@@ -288,9 +330,9 @@ module SensibleSwing
         }
         @subject.choose_dvd_and_edl_for_it[4]['mutes'].should == []
         new_file_contents = '"disk_unique_id" => "abcdef1234","mutes"=>["0:33", "0:34"]'
-        new_file_contents = '"a syntax error' if corrupt_file
+        new_file_contents = '"a syntax error' if corrupt_the_file
         File.binwrite('temp/a.txt', new_file_contents)
-        # it changed!
+        # file has been modified!
         @subject.choose_dvd_and_edl_for_it[4]['mutes'].should_not == []
       end
     end
@@ -319,7 +361,7 @@ module SensibleSwing
       count.should == 1
     end
     
-    describe 'cacheing dvd drive' do
+    describe 'with unstubbed choose_dvd_drive' do
       before do
         DriveInfo.stub!(:get_dvd_drives_as_openstruct) {
           a = OpenStruct.new
@@ -333,8 +375,7 @@ module SensibleSwing
       it "should only prompt for drive once" do
         count = 0
         DriveInfo.stub!(:md5sum_disk) {
-          raise if count == 1
-          count = 1
+          count += 1
           '19d121ae8dc40cdd70b57ab7e8c74f76'
         }
         @subject.choose_dvd_and_edl_for_it

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
     - 0
     - 19
-    - 6
-  version: 0.19.6
+    - 7
+  version: 0.19.7
 platform: ruby
 authors: 
   - Roger Pack
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-12-23 00:00:00 -07:00
+date: 2010-12-28 00:00:00 -07:00
 default_executable: 
 dependencies: 
   - !ruby/object:Gem::Dependency 
@@ -167,7 +167,7 @@ files:
   - VERSION
   - bin/sensible-cinema
   - bin/sensible-cinema-cli
-  - create or edit sensible cinema decision list files.bat
+  - create or edit sensible cinema delete list files.bat
   - experimental_readme.txt
   - ext/mkrf_conf.rb
   - go.bat