sensible-cinema 0.15.0 → 0.16.1

data/ChangeLog

@@ -1,7 +1,21 @@
+== 0.16.0 ==
+
+Change the YAML style so that it can have filterable categories (disabled for now, but there are unit tests
+that show the use of such as a form of "combining user preferences" with the EDL to produce a 
+new customized one.
+
+Allow for quite more easily user creation/editing of EDL's by allowing users to access just specific "scenes" of the video edited.
+
+Disable title auto selection use, now use md5sum of the DVD's IFO files for auto-selection of EDL.
+
 == 0.15.0 ==
 
 Use all i-frames for more accurate precision in cutting segments.
 Also use ffmpeg and mencoder for the same (no more VLC for encoding). Phew.
+Note that by at least this version, auto DVD title selection as a parameter has been built in (see git log).
+Note that by at least this version, it could compute an md5sum of a DVD's IFO files to compute
+a unique ID for that disk.
+Note that before this, I was using the volume name to generate filenames.
 
 == 0.14.8 ==
 
@@ -13,7 +27,7 @@ Auto-select EDL depending on which disk they have.
 
 == 0.14.5 ==
 
-Make it distributable more easily.
+Made it distributable more easily.
 
 == 0.14.4 ==
 

data/LICENSE

@@ -1,42 +1,53 @@
-All files released under the GPLv3 license [1] unless otherwise specified.  Ping me if you want this changed.
-
-May contain some 3rd party libraries under their own (separate, open source) licenses.
-
-Note that this software should be legal in the EU, 
-as it is only software and therefore theoretically not subject to patents (see "What about patent licenses?" in [2]).
-It's basically for use in the EU.
+All files released under the GPLv3 license [1] unless otherwise specified.  Ping me if you want/need this changed.
+
+May contain some 3rd party libraries/executables under their own (separate, open source) licenses.
+
+Is this legal?  
+
+Unclear.  In general ripping personal DVD's is fine.
+It is controversial to use open source software to play/rip DVD's.
+There are a few conflicting views.  
+Sensible-cinema doesn't actually do any decryption or decoding, nor has any knowledge of it,
+but calls out to another separate program to rip.  It doesn't even have knowledge
+as to whether it is ripping something encrypted or not.  We don't distribute sensible-cinema with
+that program, either.
+You can ask the authors of that program if it is legal.  Apparently
+libdvdcss that it uses has never been challenged in court, and uses a slightly different algorithm
+than those that have.
+Note also that fair use does allow one to "record" things (especially things that they own)
+for personal use/backup.
+Using sensible-cinema is probably not any more unethical than ripping your DVD collection to your hard
+drive so you can keep your DVD's all in one place.
+Also note that if you watch an edited DVD, your are using a DVD player that conforms
+with DMCA specifications, so that might have some influence.
+
+In general, you are responsible for your actions and use of this program.
+It is possible that the authors of sensible-cinema are not cupable of anything
+regarding its use themselves, since they re-distribute no edited media, 
+nor distribute cracking codes.  In general, check your country's rules first.
+
+In terms of copyright, it could indeed be legal, at least in the United States, when viewed
+using the "playlist" option (v 0.10'ish).
+In general, if I have the original DVD sitting next to my TV, I don't feel bad about watching
+its edited copy at the same time, but please consult a laywer first if you have any concerns.
+
+Do not redistribute copied commercial DVD's.  We have learned from clean flicks that
+redistributing edited commercial DVD's is illegal in the US.  We hope that sensible-cinema
+is more legal, since you can get the DVD's from wherever you want, and it doesn't change their
+structure at all.  Please don't redistribute.
+
+DO NOT MAKE ILLEGAL COPIES.
+
+Note that this software might well be legal in the EU, 
+as it is only software and therefore thus possibly not subject to patents (see "What about patent licenses?" in [2]).
 If it's not legal in your country, don't use it!
 
-The http://en.wikipedia.org/wiki/Family_Entertainment_and_Copyright_Act describes a recent 
-US law that appears related (and is in its favor).
-
-A history of various related thoughts was described here:
+A more ancient history of various related thoughts was described here:
 http://betterlogic.com/roger/?p=2618
 
-Enjoy!
+Also note that several ideas have been released in the code that are disabled in the final release.  Please see the blog
+for release notes http://betterlogic.com/roger, as well as http://ruby-forum.com (ruby talk ML there), and rubygems.org
+which lists the various releases, and github.com/rdp/sensible-cinema which lists commits and changes and releases.
 
 [1] http://www.gnu.org/licenses/gpl.html, also gplv3 file.
 [2] http://www.videolan.org/support/faq.html
-
-add note "we don't distribute anything that breaks encryption keys" like http://k9copy.sourceforge.net/
-
-honest about DMCA (we don't distribute the cracker, we don't redistribute, don't perform any acts, etc.)
-if you burn you'll eventually be using a DMCA compatible player :P
-long list of players...we're not alone :)
-the authors of the program might not be liable for damages.  We don't feel dishonest about it, as long as 
-we own the DVD and have it with us when we watch the edited version.
-
-not more unethical than ripping your DVD collection to hard drive so you can keep your DVD's all in one 
-place and don't have to worry about losing them.  Then you edit them manually to remove cruft, and watch them
-from there.
-
-for me, the images and audio are unencrypted, so storing/saving those away might well be fair use, but check your countries rules first 
-(similar to how recording using a VCR might well not be illegal under fair use). But don't take my word for it.
-
-note that you are watching it using only bits and pieces of the original, similar to said bill.  And the
-authors of the program might not be cupable of copyright infringement themselves, since they distribute no infringed materials.
-
-Not responsible for your actions. Don't redistribute. "You run the risk on your own"
-"should the courts someday rule..."  If DVD next to me...
-
-fair use may apply

data/Rakefile

@@ -69,19 +69,11 @@ task 'bundle_dependencies' => 'gemspec' do
      dependencies.each{|d|
        system("#{Gem.ruby} -S gem unpack #{d.name}")
      }
-     # add imagemagick
-     puts 'copying in imagemagick'
-     Dir.mkdir 'imagemagick'
-     im_identify_command = RubyWhich.new.which('identify').select{|dir| dir =~ /ImageMagick/}[0]
-     #  "d:\\installs\\ImageMagick-6.6.2-Q16\\identify.EXE",
-     Dir["#{File.dirname im_identify_command}/*"].each{|file|
-       FileUtils.cp_r(file, 'imagemagick') rescue nil # some fail for some odd reason
-     }
      puts 'downloading in jruby-complete.jar file' 
      # jruby complete .jar file
      Net::HTTP.start("jruby.org.s3.amazonaws.com") { |http|
        resp = http.get("/downloads/1.5.5/jruby-complete-1.5.5.jar")
-       puts 'copying... '
+       puts 'copying it... '
        open("jruby-complete-1.5.5.jar", "wb") { |file|
          file.write(resp.body)
        }
@@ -107,6 +99,11 @@ task 'create_distro_dir' do
   FileUtils.mkdir_p dir_out
   FileUtils.cp_r(existing, dir_out)
   # this one belongs in the trunk
-  FileUtils.cp("#{dir_out}/run_sensible_cinema.bat", "#{dir_out}/..")
+  FileUtils.cp(Dir["#{dir_out}/*.bat"], "#{dir_out}/..")
   p 'created (still need to zip it) ' + dir_out
 end
+
+desc 'j -S rake bundle_dependencies create_distro_dir ...'
+task 'full_release' => [:bundle_dependencies, :create_distro_dir, :build] do # :release
+  system("#{Gem.ruby} -S gem push pkg/*.gem") 
+end

data/TODO

@@ -1,107 +1,104 @@
 == medium ==
-
   
 == probably next up+low prio ==
 
- use mencoder from the gui
- use mencoder + ffmpeg
-     re-do various EDL's I have :P
- split the two projects somehow (project + distribution)
-    two releases: experimental, normal (no imagemagick)
- preferences merger...hmm...;
  compare computer DVD playback with physical player...
+ release .zip
 
 == slightly lower than that ==
 
+  make sure no subtitles on national treasure...
+  partner for filters (Jon, Karlie if interested...give beta)
+    lotsa filters somehow
+  beta release/rinse and repeat with various ppl (once it's releasable...)
+  can generate mplayer EDL's and play them...hmm...smplayer them?
+    update license too...
+  a real'ish website
+  "run create mode" button (?)
+  license the first time they run it (gplv3)
+  bring that window to the top! (before done dialog...)
+
+== DVD backlog (unordered, some very low prio) ==
+
+ DRY up dependency installation code
+  install them to cache2 or something...so I can cleanup..
+ using+burning screencast
+ editing screencast
+  instructions on how to do their own (private) EDL or do one and submit it (public), or email their friends :P
+  note how to get the title number
+    add a way to get the label rather easily...
+     add an option "just save full disk (unedited) to hard drive..."
+       note to people: can edit those to your liking
+
+
+ advertise urug, ruby flow :)
+ "Re-run most recent" disabled when there isn't one [?]
+ unit test the GUI
+ re-do DVD EDL's that need it :P
+   all dogs go to heaven...finish EDL
+ warn when labels exist and don't match...
+ kill old mencoder instances more often...
+  auto-download imagemagick, too
+  check all the various options to see if there's a "cross platform way to split files accurately" besides my hacky kludge.
+  popup "you may now watch": bring it to the front...
+  can rip from a DVD-like folder (?)
   ripping "redoes" a large last section, for combining. Can I avoid this?
     plus I do some copy, some ac3?
-  easy installer for x,y,z
-  unit test the GUI
-  no subtitles on national treasure...
-  
-  ask if there's a "cross platform way to split files accurately" besides my hacky kludge.
-  
-  popup "you may now watch": bring it to the front...
-  
-  easy editor for this style of edit
-  partner (Jon, Karlie if interested...give beta)
-    create lotsa filters
-  beta release
-  some better ripper...
-    maybe vlc is bound by the same constrains mplayer is?
-    maybe rip it to a more precise encoding, then edit it?
-
-== DVD monetary backlog (unordered) ==
-
-@mencoder.exe distributor: OCI plz? puh-lease?
-@dvd flick do you need that frequent i-frames?
+@dvd flick do you need that frequent of i-frames?
   rename bat as template.bat
   can parse IMDB (require they put in the URL by hand fer now)
     add stuffs to imdb hmmm
     IMDB easy mapping
-  all dogs go to heaven...
   can blank out the video, with audio continuing through...
-add an option "just save full disk (unedited) to hard drive..."
   add an option "just save full disk (edited) to hard drive...well compressed"
-    or do we want to do that by default anyway? (does it help burning? it helps with file size...hmm...)
+    or do we want to do that by default anyway? (does it help burning? file size...hmm...)
 @VLC: hard crash when ripping that one DVD...long one, about the constitution...
-auto-zip it with my rake task :)
-check DVD patent expiration date
-better burning screencast
+in general, fine tune burning with various things...
 
 make sure can work with very large DVD's...
   can use a fast temp drive, save through to other :P
     only prompt if have two...
-  pass a better title through when ripping so it doesn't just say dvd://1 always
   can have collaborators re-selling EDL's
     good license for their stuff like "public domain" or what not :P Can't be a hypocrite now, can I?
-    80/20
-  .ts doesn't seem too awesome....
-
+a real website
 k9 might preserve/shrink well...hmm...auto calculation may be possible...hmm...
-better icon...
+better .exe icon...
 ensure file exists after we created it...and has a reasonable size, before declaring success
       148 cars_widescreen_2006_edited.ps
+blu-ray support somehow (real-time? rip?)
 use DVD navigator ?
   http://msdn.microsoft.com/en-us/library/dd388584(v=VS.85).aspx
   with an avi file sink?
-authorize.net instead of paypal?
-blu-ray support somehow (real-time? rip?)
-legal shtuff (LICENSE)
-some type of installer that can setup the registry...
-auto-assignment of EDL's to media:
-  DVD's (right click on DVD player, rip with SC?)
-a real website
-instructions on how to do their own (private) EDL or do one and submit it (public), or email their friends :P
 double buffering hard drive/incoming copying from DVD might speed things, if your HD is fast.
-personalized copier might be faster than the "type" command.
-merge with preferences
-For the monetized version: nothing but cut and paste, no merging et al
-mplayer EDL's
-add option to "just rip a DVD of your own straight full thing"
-avisynth?
 make the progress bar map "better" to the size of the various sections...
-detect occurrence of these type errors: dvdnav warning: cannot get next block (Error reading from DVD.) somehow (file size...)
-per movie, various EDL's, one includes profanity, one just violence, one paranoid, etc.
+detect occurrence of these type errors (DVD read failure): dvdnav warning: cannot get next block (Error reading from DVD.) somehow (file size...)
+per movie, several EDL's, one includes profanity, one just violence, one paranoid, etc.
 when there are several, it lets you just choose between the ones that are valid (?)
 
-ask VLC is "adding 0.23 expected?" "do you have the same constraints as mplayer?"
-ask VLC "fuzzy menus on the happiest baby dvd expected?"
-slightly faster copying possible (664 versus 887 seconds to combine them all together.)
-@mplayer "when it says nearest keyframe, that could be in the future?" 
-@mplayer "when I say play for 3.2, and the keyframe is 0.5 before, does it end up playing for 3.2 or 3.7?"
 burnable to DVD/CD/multi DVD automagically... (auto-burn insert your new disk!)
     can *re-use* original navigation stuffs, less the profanity (is that possible? VobBlanker help, perhaps?)
   can lop off sections to save space (?)
   can burn extras from the DVD, too?
     optionally ?
-  transcode to condense...
+  transcode to condense..?
   split to allow?
-@smplayer: playing DVD's doesn't work currently
 try to compile transcode in cygwin (yipes)
-the ac3 thing
+legal shtuff (LICENSE)
 
-== random backlog ... note: just plow forward, to "grab" available ideas...except that for now, just what *I* plan on needing for myself (filters for what I need/want). ==
+== random non-DVD backlog ... note: just plow forward, to "grab" available ideas...except that for now, just what *I* plan on needing for myself (filters for what I need/want). ==
+
+the ac3 thing
+ask VLC "fuzzy menus on the happiest baby dvd expected?"
+right click on DVD player, rip edited with SC?
+auto-zip it with my rake task :)
+split the two projects somehow (project + distribution)
+    two releases: experimental, developer/experimental
+    bring back the old :)    
+button for "suck in EDL's"
+ split out the EDL's to a separate project (?)
+make the other stuff work again, since I no longer use YAML...
+advertise my "splitting joining" google doc page. also test the various options there for accurateness :)
+also note that mencoder doesn't do splitting very well, for some reason.
 
 pass unit tests again jruby
 
@@ -137,9 +134,6 @@ a descriptor for some closed source app player...
 
 can "overlay-audio/video"
 
-GUI:
- preferences for levels, etc.
-  
 blanker: allow for one side of the screen or another...
 
 PISH
@@ -280,6 +274,6 @@ create a "book edit list" (word x is at position y...)
   are your highest settings optimal?
   accept subtitled video...
   
-  @smplayer: your CD config is awful.
+@smplayer: your CD config is awful.
 @mencoder: can't split
 something like you watch it *with* you friends and can all chat together...hmm...

data/VERSION

@@ -1 +1 @@
-0.15.0
+0.16.1

data/bin/sensible-cinema

@@ -5,21 +5,20 @@ puts 'Loading Sensible Cinema...'
 require File.dirname(__FILE__) + "/../lib/add_any_bundled_gems_to_load_path.rb"
 require 'sane'
 
-for file in ['vlc_programmer']
-  require_relative '../lib/' + file
-end
+require_relative '../lib/mencoder_wrapper'
+require_relative '../lib/storage'
+require_relative '../lib/edl_parser'
 
-require 'ruby-wmi'
 require 'tmpdir'
 require_relative '../lib/swing_helpers'
 require_relative '../lib/drive_info'
+require 'whichr'
 
-# add some common locations for vlc.exe to the path...
-# lodo use the registry to pull out the 'right' path...
-ENV['PATH'] = ENV['PATH'] + ";C:\\Program Files\\VideoLAN\\VLC"+ ";D:\\Program Files\\VideoLAN\\VLC" + ";E:\\Program Files\\VideoLAN\\VLC"
+ENV['PATH'] = ENV['PATH'] + ';' + File.expand_path(File.dirname(__FILE__)) + '/../vendor/cache/mencoder'.to_filename
 
 module SensibleSwing
  class MainWindow < JFrame
+   Storage = Storage.new("sc")
    def initialize
      super "Sensible-Cinema"
      setDefaultCloseOperation JFrame::EXIT_ON_CLOSE
@@ -28,136 +27,214 @@ module SensibleSwing
      setSize 350,400
      add panel # why can't I just slap these down?
  
-     jlabel = JLabel.new 'Welcome to Sensible Cinema'
+     jlabel = JLabel.new 'Welcome to Sensible Cinema!'
      happy = Font.new("Tahoma", Font::PLAIN, 11)
      jlabel.setFont(happy)
      jlabel.set_bounds(44,44,136,14)
      panel.add jlabel
-     b = JButton.new( "Play Hulu, Youtube, or a DVD (Tracking)" ).on_clicked {
-      load File.dirname(__FILE__) +  '/sensible-cinema-cli'
-      Thread.new { go_sc([]) } # needs to be in its own thread becuase it blocks,
-      # so "this thread" is the uni-swing thread, gets blocked, and the overlayer can't repaint
-      self.close
-     }
-     button_width = 230
-     b.set_bounds(44,120,button_width,23)
-     panel.add b
     
-     c=JButton.new( "Copy edited copy of DVD to Hard Drive" )
+     button_width = 270
+    
+     c = JButton.new( "Create edited copy of DVD on Your Hard Drive" )
      c.on_clicked {
-       do_copy_dvd_to_hard_drive true
+       do_copy_dvd_to_hard_drive false
      }
-     c.set_bounds(44,220,button_width,23)
-     panel.add c    
+     c.set_bounds(44,120,button_width,23)
+     panel.add c
     
-     d=JButton.new( "Play edited DVD with VLC" )
+     b = JButton.new("Watch current DVD unedited")
+     b.on_clicked {
+       ENV['PATH'] = ENV['PATH'] + ";d:\\Program Files\\SMPlayer;c:\\Program Files\\SMPlayer"
+       path = RubyWhich.new.which('smplayer')
+       if(path.length == 0)
+            JOptionPane.showMessageDialog(self, "It appears that you need to install a dependency: SMPlayer.\n
+         Click ok to be directed to its download website.
+         Also note that if it ever hangs, kill the process, and then use VLC instead
+         (though VLC only has approximate timings).", "Lacking dependency", JOptionPane::ERROR_MESSAGE)      
+         system("start http://smplayer.sourceforge.net/downloads.php")
+       else
+         drive, volume, md5 = choose_dvd_drive
+         system("smplayer dvd:// -dvd-device #{drive}")
+       end 
+     }
+     b.set_bounds(44,150,button_width,23)
+     panel.add b
+    
+     d = JButton.new( "Preview edited section of current DVD" )
      d.on_clicked {
-       do_copy_dvd_to_hard_drive false
+       do_copy_dvd_to_hard_drive true
      }
     
      d.set_bounds(44,180,button_width,23)
-     panel.add d
+     panel.add d if ARGV.index("--create-mode")
+   
+     f = JButton.new("Open/Edit an Edit Decision List")
+     f.on_clicked {
+       dialog = FileDialog.new(self, "Pick file to edit")
+       dialog.set_directory EDL_DIR
+       filename = dialog.go
+       system("notepad \"#{filename}\"") if filename
+     }
+     f.set_bounds(44,260,button_width,23)
+     panel.add f if ARGV.index("--create-mode")
+  
+     e = JButton.new( "Re-run most recent preview segment" )
+     e.on_clicked {
+       repeat_last_copy_dvd_to_hard_drive
+     }
+    
+     e.set_bounds(44,220,button_width,23)
+     panel.add e if ARGV.index("--create-mode")
+    
+     reload = JButton.new( "Get a disk's unique ID" ).on_clicked {
+       drive, volume, md5 = choose_dvd_drive
+       # display it, allow them to copy and paste it out
+       JOptionPane.showInputDialog("#{drive} #{volume} for your copying+pasting pleasure (highlight, then ctrl+c to copy)        \n
+      This is used to identify a disk to match it to its EDL, later.", "\"disk_unique_id\" => \"#{md5}\",")
+     }
     
+     reload.set_bounds(44,290,button_width,20)
+     panel.add reload  if ARGV.index("--create-mode")
+
      @exit = JButton.new("Exit").on_clicked {
        self.close
      }
      @exit.set_bounds(44,320,button_width,23)
-     panel.add @exit
-    
-     if ARGV.find{|a| a == '--test'}
-       reload = JButton.new( "reload code" ).on_clicked {
-        eval File.read(__FILE__), nil, __FILE__
-        p 're-evaled the code ...'
-       }
-       reload.set_bounds(20,300,20,20)
-       panel.add reload 
-     end
+     panel.add @exit    
      
      @progress_bar = JProgressBar.new(0, 100)
      @progress_bar.set_bounds(44,280,button_width,23)
-     @progress_bar.visible=false
+     @progress_bar.visible = false
      panel.add @progress_bar
-     @buttons = [b,c,d,@exit]    
+     @buttons = [b,c,d,e,reload,@exit]
+     check_for_dependencies
    end
   
-   def vlc_currently_installed?
-     if !system("vlc  --qt-start-minimized vlc://quit 2>NUL")
-       JOptionPane.showMessageDialog(nil, "Appears you do not yet have VLC Media Player installed. Click ok to download it.", "VLC Player not found", JOptionPane::ERROR_MESSAGE)
-       system("start http://www.videolan.org/")
-       false
-     else
-      true
-     end
-   end
+  def download full_url, to_here
+    require 'open-uri'
+    writeOut = open(to_here, "wb")
+    writeOut.write(open(full_url).read)
+    writeOut.close
+  end
   
-  def single_edit_list_matches_dvd volume_name
+  def check_for_dependencies
+    ffmpeg = RubyWhich.new.which('ffmpeg')
+    if ffmpeg.length == 0
+      JOptionPane.showMessageDialog(self, "It appears that you need to install a dependency: imagemagick.\n
+      Click ok to be directed to its download website.\nYou'll probably want to download and install the \"windows-dll.exe\" package.\n
+      Then restart Sensible-Cinema.", "Lacking dependency", JOptionPane::ERROR_MESSAGE)      
+      system("start http://www.imagemagick.org/script/binary-releases.php#windows")
+      java.lang.System.exit(1)
+    end
+    mencoder = RubyWhich.new.which('mencoder')
+    if mencoder.length == 0
+      answer = JOptionPane.showConfirmDialog(nil, "Appears that you need to install a dependency: mencoder.
+      Its license is at: http://www.gnu.org/licenses/gpl-2.0.html.
+      Also this will download 7z locally (license: http://www.7-zip.org/license.txt).
+      Click yes if you accept the terms of the several license agreements. They will then be installed automatically.
+      Or click no to cancel.", "Lacking dependency", JOptionPane::YES_NO_OPTION)
+      if answer == 1
+        p 'exiting, no mencoder...'
+        sleep 10
+        java.lang.System.exit(1)
+      end
+      vendor_cache = File.expand_path(File.dirname(__FILE__)) + "/../vendor/cache/"
+      ENV['PATH'] = ENV['PATH'] + ';' + vendor_cache + '\\..;' + vendor_cache
+      Dir.chdir(vendor_cache) do
+        Kernel.print 'downloading unzip utility...'
+        download("http://downloads.sourceforge.net/project/sevenzip/7-Zip/9.20/7za920.zip", "7za920.zip")
+        system("unzip -o 7za920.zip") # -o means "overwrite" without prompting
+        # now we have 7za.exe
+        Kernel.print 'downloading mencoder'
+        download("http://downloads.sourceforge.net/project/mplayer-win32/MPlayer%20and%20MEncoder/revision%2032492/MPlayer-rtm-svn-32492.7z", "mencoder.7z")
+        system("7za e mencoder.7z -y -omencoder")
+        Kernel.puts 'done'
+      end
+    end
+  end
+  
+  def single_edit_list_matches_dvd md5
+    return unless md5 # ignore nil searches, where it wasn't set in the .txt file
     matching =  Dir[EDL_DIR + '/*.txt'].select{|file|
-      YAML.load_file(file)["dvd_drive_label"] == volume_name      
+      EdlParser.parse_file(file)["disk_unique_id"] == md5
     }
     if matching.length == 1
       file = matching[0]
-      p "selecting only matching file #{file}"
-      return file
-    end    
-    nil
+      p "selecting the one matching file #{file}"
+      file
+    else
+      nil
+    end
   end
   
-  EDL_DIR = __dir__  + "/../zamples/edit_decision_lists/dvds"
+  EDL_DIR = File.expand_path(__dir__  + "/../zamples/edit_decision_lists/dvds").to_filename
+  
+  def repeat_last_copy_dvd_to_hard_drive
+    generate_and_run_bat_file *Storage['last_params']
+  end
   
-  def do_copy_dvd_to_hard_drive should_save_file
-      return unless vlc_currently_installed?
-      drive, volume_name = choose_dvd_drive
-      if !(edit_list_path = single_edit_list_matches_dvd(volume_name))
-        fc = JFileChooser.new
-        fc.setFileSelectionMode(nil)
-        fc.set_dialog_title "Please pick a DVD Edit List File"
-        fc.set_current_directory(JFile.new EDL_DIR)
+  def do_copy_dvd_to_hard_drive should_prompt_for_start_and_end_times
+      drive, dvd_volume_name, md5sum = choose_dvd_drive
+      edit_list_path = single_edit_list_matches_dvd(md5sum)
+      if !edit_list_path
+        fc = FileDialog.new(self)
+        fc.set_title "Please pick a DVD Edit List File"
+        fc.set_directory EDL_DIR
         edit_list_path = fc.go
       end
-      descriptors = YAML.load_file edit_list_path
-      dvd_title = descriptors['title']
-      if should_save_file
-        fc = JFileChooser.new 
-        # LODO allow for spaces in the save to file
-        fc.set_dialog_title "Pick where to save #{dvd_title || "the file"} edited to"
-        save_to_file_name = ((dvd_title || "my dvd") + ' edited copy').gsub(' ', '_').gsub( /\W/, '') # no punctuation for now...
-        fc.setSelectedFile(JFile.new(DriveInfo.get_drive_with_most_space_with_slash + save_to_file_name)) 
-        save_to = fc.go
-      else
-        save_to = nil
+      descriptors = EdlParser.parse_file edit_list_path
+      
+      dvd_title = descriptors['title'] || dvd_volume_name
+      
+      fc = JFileChooser.new
+      # LODO allow for spaces in the save to filename
+      
+      if should_prompt_for_start_and_end_times
+        JOptionPane.showMessageDialog(nil, "Ok, let's preview just a portion of it. \nNote that you'll want to preview a section that wholly includes an edit decision in it\n For example, if it mutes from second 1 to second 10, you'll want to play from 00:00 to 00:12 or what not.\nAlso note that the first time you preview a section of a video, it will take like 20 minutes as it sets up the video for previewing.\nSubsequent previews will be faster, though, as long as you use the same filename.", "Preview!", JOptionPane::INFORMATION_MESSAGE)
+        start_time = JOptionPane.showInputDialog("At what point in the video would you like to start your preview? (like 01:00 for starting at 1 minute)", Storage['start_time'])
+        Storage['start_time'] = start_time
+        end_time = JOptionPane.showInputDialog("At what point in the video would you like to finish your preview? (like 02:00 for ending at the 2 minute mark)", Storage['end_time'])
+        Storage['end_time'] = end_time
+        unless start_time and end_time
+          JOptionPane.showMessageDialog(nil, " Please choose start and end", "Failed", JOptionPane::ERROR_MESSAGE)
+          return
+        end
       end
+      
+      fc.set_title "Pick where to save #{dvd_title} edited to"
+      
+      save_to_file_name = dvd_title + ' edited copy'
+      save_to_file_name += ' single segment' if should_prompt_for_start_and_end_times
+      save_to_file_name=save_to_file_name.gsub(' ', '_').gsub( /\W/, '') # no punctuation for now...
+      fc.setFile(DriveInfo.get_drive_with_most_space_with_slash + save_to_file_name)
+      save_to = fc.go
       dvd_title_track = descriptors["dvd_title_track"]
-      bat_file_or_xspf = VLCProgrammer.convert_to_full_xspf(descriptors, save_to, drive, dvd_title_track, dvd_title)
- 
-      temp_dir = Dir.tmpdir
-      temp_file = temp_dir + '/' + 'vlc.temp.xspf'
-      File.write(temp_file, bat_file_or_xspf)
-      puts bat_file_or_xspf
-      if should_save_file
-        popup = ModeLessDialog.new(          "Copying to #{save_to}.\n" + 
-          "Running edit list #{File.basename edit_list_path} against \n" +
-           "    #{drive} (#{dvd_title})...\n" +
-          "This could take quite awhile, and will prompt you when it is done.\n" +
-          "It may also cause small popup ballon dialogs to appear.\n" +
-          "You can close this window and continue working while it runs.",
-          "OK")      
-        
-        # this allows our popups to still be serviced while it is running
-        Thread.new {
-          run_copy_commands bat_file_or_xspf, save_to
-          popup.dispose
-        }
-      else
-        command = "vlc \"#{temp_file.to_filename}\" vlc://quit"
-        puts 'running playlist for DVD: ', command
-        system(command) # blocks the current window while running...
-        p 'done playing DVD'
-      end
-      # LODO warn if they will overwrite a file in the end
+      generate_and_run_bat_file save_to, edit_list_path, descriptors, drive, dvd_title, start_time, end_time, dvd_title_track
    end
   
-   def run_copy_commands batch_commands, save_to
-      p 'saving to ' +  save_to + '.ps' # lodo cleanup the .ps here...
+    def generate_and_run_bat_file save_to, edit_list_path, descriptors, drive, dvd_title, start_time, end_time, dvd_title_track
+      Storage['last_params'] = [save_to, edit_list_path, descriptors, drive, dvd_title, start_time, end_time, dvd_title_track]
+      bat_file = MencoderWrapper.get_bat_commands descriptors, drive, save_to, start_time, end_time, dvd_title_track
+      temp_dir = Dir.tmpdir
+      temp_file = temp_dir + '/vlc.temp.bat'
+      File.write(temp_file, bat_file)
+      puts 'commands located for debugging purposes at: ' + bat_file
+      popup = ModeLessDialog.new(          "Copying to #{save_to}.\n" + 
+        "Running #{File.basename edit_list_path} against #{drive} (#{dvd_title}).\n" +
+        "This could take quite awhile, and will prompt you when it is done.\n" +
+        "You can close this window and continue working while it runs.\n" + 
+        "NB that the created file will be playable with SMplayer or VLC player.",
+        "OK")
+      
+      # allow our popups to still be serviced while it is running
+      Thread.new {
+        run_create_commands bat_file, save_to
+        popup.dispose
+      }
+      # LODO warn if they will overwrite a file in the end...
+    end
+  
+   def run_create_commands batch_commands, save_to
       @buttons.each{|b| b.set_enabled false}
       success = true
       lines = batch_commands.lines.to_a
@@ -166,26 +243,32 @@ module SensibleSwing
       @progress_bar.set_value(10) # start at 10% always, so they can see something.
       lines.each_with_index{|l, idx|
         if success
-          success = system(l) unless ARGV.find{|a| a == '--test'} # this doesn't seem to cancel out early for some reason..
-          @progress_bar.set_value(10 + idx/total_size*90)
+          success = system(l) unless ARGV.find{|a| a == '--test'} # this might not actually cancel out early for some reason...
+          if l =~ /@rem /
+            success = true # these fail fof some reason?
+          else
+            p 'line failed ' + l unless success
+          end
         end
+        @progress_bar.set_value(10 + idx/total_size*90)
       }
       @progress_bar.visible=false
       @buttons.each{|b| b.set_enabled true}
       if success
-        JOptionPane.showMessageDialog(nil, " Done--you may now watch file #{save_to}.ps in VLC player", "Done!", JOptionPane::INFORMATION_MESSAGE)
-        show_file = "explorer /e,/select,\"#{File.expand_path(save_to).to_filename}.ps\""
+        saved_to = save_to + '.avi' # LODO pass this out?
+        JOptionPane.showMessageDialog(nil, " Done--you may now watch file #{saved_to} in SMPlayer or VLC player", "Done!", JOptionPane::INFORMATION_MESSAGE)
+        show_file = "explorer /e,/select,\"#{File.expand_path(saved_to).to_filename}\""
         system show_file
-        self.close
+        #self.close # ?
       else
         JOptionPane.showMessageDialog(nil, " Failed--please examine screen output and report back!", "Failed", JOptionPane::ERROR_MESSAGE)
       end
    end
   
-  # returns e:\, win32ole instance
+  # returns e:\, volume, md5sum
    def choose_dvd_drive
     opticals = DriveInfo.get_dvd_drives_as_win32ole
-    names = opticals.map{|d| d.Name + "\\" + " (" +  (d.VolumeName || 'empty') + ")"}
+    names = opticals.map{|d| d.Name + "\\" + " (" +  (d.VolumeName || 'please insert DVD before proceeding if you want to use this drive') + ")"}
     
     if opticals.length != 1
       dialog = GetDisk.new(self, names)
@@ -194,13 +277,14 @@ module SensibleSwing
       selected_idx = dialog.selected_idx
     else
       selected_idx = 0
-      p 'selecting only disk drive ' + names[0]
-    end    
+      p 'selecting user\'s only disk drive ' + names[0]
+    end
+    
     if selected_idx
       disk = opticals[selected_idx]
-      return names[selected_idx][0..2], opticals[selected_idx].VolumeName
+      return names[selected_idx][0..2], opticals[selected_idx].VolumeName, DriveInfo.md5sum_disk(opticals[selected_idx].Name)
     else
-      puts 'did not select a drive'
+      puts 'did not select a drive...exiting'
       java.lang.System.exit 1      
     end
   end
@@ -229,9 +313,7 @@ module SensibleSwing
      add box
      pack
     end
-   
  end
- 
 end
 
 if $0 == __FILE__