send_sonar 1.0.9 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0a992ed4a40afb9c3758650a5e7989113cdc0218
-  data.tar.gz: 92cc9c9113773985488b5739c30c0082a7c3aa86
+  metadata.gz: 476f08ec59419ef64eacb5231bb79ebcb295b75f
+  data.tar.gz: 4b88361e84d2fe3b96779dd831315deb3baa4c58
 SHA512:
-  metadata.gz: 6b93de74f4e6bbb51e64ca1327e38ffca6a61028ac224ebd41995bd1a2782da403da1bddffb541287eb57f559704a41d7a7e5a27b64fd9d7898d2898641fd2cf
-  data.tar.gz: 1dea28fa9d30f7b136239aabbb4ea99a56a2b8f6d01768d05216f9733e5a407433b8e1929f245090d8b494bc01b74e4fc7e19d3c98e6d5f802750dbce8232f97
+  metadata.gz: a5d67356fb0e828950c788a4ffdc7665559473caee492b647c60b49650a5bb9b0cb6c3b408b0d8ecf609d98057f204f91bde47a3f601e3559d703c37ed045e93
+  data.tar.gz: ab3a82a0ac0e0eea7ff9d4aeb45ff1b77c844cba244f4641c10eac6f676da405c2b37e5145ba10f5998aae4da6a2612e4655d50a7ff537e35cc9db9367146156

data/RELEASE.md

@@ -1,3 +1,7 @@
+v 1.1.0
+-------
+Added invalid phone number error and tests for it.
+
 v 1.0.9
 -------
 Temporary solution giving more information about why a request failed.

data/lib/send_sonar/exceptions.rb

@@ -33,6 +33,7 @@ module SendSonar
   end
 
   class BadToken < RequestException; end
+  class InvalidPhoneNumber < RequestException; end
   class NoActiveSubscription < RequestException; end
   class ApiDisabledForCompany < RequestException; end
   class UnknownRequestError < RequestException; end
@@ -47,7 +48,8 @@ module SendSonar
       "Bad Token" => BadToken,
       "No Active Subscription" => NoActiveSubscription,
       "Api Disabled For Company" => ApiDisabledForCompany,
-      "Request Timed Out" => RequestTimeout
+      "Request Timed Out" => RequestTimeout,
+      "Invalid Phone Number" => InvalidPhoneNumber
     }
   end
 end

data/lib/send_sonar/version.rb

@@ -1,3 +1,3 @@
 module SendSonar
-  VERSION = "1.0.9"
+  VERSION = "1.1.0"
 end

data/spec/integrations/simple_desk_spec.rb

@@ -98,6 +98,17 @@ describe 'SendSonar' do
       end
     end
 
+    context 'with an invalid phone number' do
+      let(:token) { 'tKux9Vwkt0UuTVJqGUO80MGJHCAeebpe' }
+
+      it 'raises a Invalid Phone Number error' do
+        VCR.use_cassette("#{cassette_group}_invalid_phone_number") do
+          expect { response }.to raise_error(SendSonar::BadRequest,
+            '400 Bad Request: {"error":"Invalid Phone Number"}')
+        end
+      end
+    end
+
     context 'with proper params, active subscription' do
       it 'returns a new customer' do
         VCR.use_cassette('add_customer') do
@@ -148,6 +159,17 @@ describe 'SendSonar' do
       end
     end
 
+    context 'with an invalid phone number' do
+      let(:token) { 'tKux9Vwkt0UuTVJqGUO80MGJHCAeebpe' }
+
+      it 'raises a Invalid Phone Number error' do
+        VCR.use_cassette("#{cassette_group}_invalid_phone_number") do
+          expect { response }.to raise_error(SendSonar::BadRequest,
+            '400 Bad Request: {"error":"Invalid Phone Number"}')
+        end
+      end
+    end
+
     context 'with proper params, active subscription' do
       it 'returns a new customer' do
         VCR.use_cassette('message_customer') do

data/spec/vcr_cassettes/add_customer_bad_token.yml

@@ -12,7 +12,7 @@ http_interactions:
       Accept-Encoding:
       - gzip, deflate
       Token:
-      - FAKE_TOKEN
+      - ts9mOO_O5Dc7TOBaEAQym-00RGEl3Uel
       Client:
       - rubygem 0.0.1
       Content-Length:
@@ -45,6 +45,6 @@ http_interactions:
     body:
       encoding: UTF-8
       string: '{"error":"Bad Token"}'
-    http_version: 
+    http_version:
   recorded_at: Fri, 19 Sep 2014 20:22:08 GMT
 recorded_with: VCR 2.9.2

data/spec/vcr_cassettes/add_customer_invalid_phone_number.yml

@@ -0,0 +1,44 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: http://localhost:3000/api/v1/customers
+    body:
+      encoding: US-ASCII
+      string: phone_number=111&email=user%40example.com&first_name=john&last_name=doe&properties[great_customer]=true
+    headers:
+      Accept:
+      - "*/*; q=0.5, application/xml"
+      Accept-Encoding:
+      - gzip, deflate
+      Token:
+      - ts9mOO_O5Dc7TOBaEAQym-00RGEl3Uel
+      Client:
+      - rubygem 1.0.9
+      Content-Length:
+      - '110'
+      Content-Type:
+      - application/x-www-form-urlencoded
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 400
+      message: Unauthorized
+    headers:
+      Content-Type:
+      - application/json
+      Cache-Control:
+      - no-cache
+      X-Request-Id:
+      - 865a266f-9351-4021-b216-7984090f75e8
+      X-Runtime:
+      - '1.139514'
+      Content-Length:
+      - '21'
+    body:
+      encoding: UTF-8
+      string: '{"error":"Invalid Phone Number"}'
+    http_version:
+  recorded_at: Tue, 20 Oct 2015 05:46:37 GMT
+recorded_with: VCR 2.9.3

data/spec/vcr_cassettes/message_customer_invalid_phone_number.yml

@@ -0,0 +1,50 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: http://localhost:3000/api/v1/messages
+    body:
+      encoding: US-ASCII
+      string: to=111&text=this%20is%20the%20message%20text
+    headers:
+      Accept:
+      - '*/*; q=0.5, application/xml'
+      Accept-Encoding:
+      - gzip, deflate
+      Token:
+      - ts9mOO_O5Dc7TOBaEAQym-00RGEl3Uel
+      Client:
+      - rubygem 0.0.1
+      Content-Length:
+      - '51'
+      Content-Type:
+      - application/x-www-form-urlencoded
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 400
+      message: 'Bad Request '
+    headers:
+      Content-Type:
+      - application/json
+      Content-Length:
+      - '36'
+      Cache-Control:
+      - no-cache
+      X-Request-Id:
+      - 091f4623-a053-46fc-8680-3f2ea4a1ffbb
+      X-Runtime:
+      - '0.028476'
+      Server:
+      - WEBrick/1.3.1 (Ruby/2.1.0/2013-12-25)
+      Date:
+      - Fri, 19 Sep 2014 20:48:59 GMT
+      Connection:
+      - Keep-Alive
+    body:
+      encoding: UTF-8
+      string: '{"error":"Invalid Phone Number"}'
+    http_version:
+  recorded_at: Fri, 19 Sep 2014 20:48:59 GMT
+recorded_with: VCR 2.9.2

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: send_sonar
 version: !ruby/object:Gem::Version
-  version: 1.0.9
+  version: 1.1.0
 platform: ruby
 authors:
 - Matthew Berman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-19 00:00:00.000000000 Z
+date: 2015-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -136,11 +136,13 @@ files:
 - spec/vcr_cassettes/add_customer_api_disabled.yml
 - spec/vcr_cassettes/add_customer_bad_params.yml
 - spec/vcr_cassettes/add_customer_bad_token.yml
+- spec/vcr_cassettes/add_customer_invalid_phone_number.yml
 - spec/vcr_cassettes/add_customer_no_subscription.yml
 - spec/vcr_cassettes/message_customer.yml
 - spec/vcr_cassettes/message_customer_api_disabled.yml
 - spec/vcr_cassettes/message_customer_bad_params.yml
 - spec/vcr_cassettes/message_customer_bad_token.yml
+- spec/vcr_cassettes/message_customer_invalid_phone_number.yml
 - spec/vcr_cassettes/message_customer_no_subscription.yml
 homepage: http://github.com/sendsonar/send_sonar_gem
 licenses:
@@ -173,9 +175,11 @@ test_files:
 - spec/vcr_cassettes/add_customer_api_disabled.yml
 - spec/vcr_cassettes/add_customer_bad_params.yml
 - spec/vcr_cassettes/add_customer_bad_token.yml
+- spec/vcr_cassettes/add_customer_invalid_phone_number.yml
 - spec/vcr_cassettes/add_customer_no_subscription.yml
 - spec/vcr_cassettes/message_customer.yml
 - spec/vcr_cassettes/message_customer_api_disabled.yml
 - spec/vcr_cassettes/message_customer_bad_params.yml
 - spec/vcr_cassettes/message_customer_bad_token.yml
+- spec/vcr_cassettes/message_customer_invalid_phone_number.yml
 - spec/vcr_cassettes/message_customer_no_subscription.yml