semaphore_test_boosters 1.7.2 → 1.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 57dd8bd888bd5a630d3485e7b8b9db556a37df58
-  data.tar.gz: 4ed23a8ecf0d1bcf75fe34cf7debf021f46eb63d
+  metadata.gz: 55ecf357e070533847ba7fc22764a026d0ec2918
+  data.tar.gz: 52e0d4afb19f129f079378600b871bb0c47e9d4f
 SHA512:
-  metadata.gz: e40d9816e4ae51156325c0d182ff0c8356176353f8cb4689ef797eee30fc9810fa19ede74a9e4f51700a13f751f467d18846e44995701a9780045004cc310c61
-  data.tar.gz: 3a9f94e95adfd8976bebdcf4178cb90df532344a1cb2ffed0a85e19defcac26ee19825ceba75d5045267b18d7e77d1f5565534bc7d203ce8cd72a4ac26984c73
+  metadata.gz: ecb7d0fb08e4a94de4bc17d9adefe2b2694185666b0c16fa0b4c0fcee4483c5f2de5b484646ea8f83448a5647b38b89e074648080fba0bec43e2160630541e31
+  data.tar.gz: 866a3b4b308094b0f3ffb1d9593f6595ed74ba5683c191178f8738915f00fddccd21e41c30fcfa7f55955a35e0de38cead7218eb14420d5d886d9d1eb9bd3270

data/config.reek

@@ -2,61 +2,14 @@
 IrresponsibleModule:
   enabled: false
 
-NestedIterators:
-  exclude:
-  - TestBoosters::CliParser#parse
-  - TestBoosters::LeftoverFiles#select
-
-TooManyStatements:
-  exclude:
-  - initialize
-  - TestBoosters::CliParser#parse
-  - TestBoosters::CucumberBooster#run
-  - TestBoosters::CucumberBooster#select
-  - TestBoosters::CucumberBooster#with_fallback
-  - TestBoosters::LeftoverFiles#select
-  - TestBoosters::RspecBooster#run
-  - TestBoosters::RspecBooster#run_command
-  - TestBoosters::RspecBooster#select
-  - TestBoosters::RspecBooster#with_fallback
-
-UncommunicativeVariableName:
-  exclude:
-  - TestBoosters::CucumberBooster#with_fallback
-  - TestBoosters::LeftoverFiles#select
-  - TestBoosters::LeftoverFiles#sort_descending_by_size
-  - TestBoosters::RspecBooster#run
-  - TestBoosters::RspecBooster#with_fallback
-
 FeatureEnvy:
   enabled: false
 
 ControlParameter:
   enabled: false
 
-NilCheck:
-  exclude:
-  - TestBoosters::LeftoverFiles#select
-
-UncommunicativeMethodName:
-  exclude:
-  - a
-  - b
-  - c
-  - Setup#a
-  - Setup#b
-  - Setup#c
-  - Setup::Cucumber#a
-  - Setup::Cucumber#b
-  - Setup::Cucumber#c
-
 UtilityFunction:
-  exclude:
-  - a
-  - b
-  - c
-  - expected_specs
-  - input_specs
+  enabled: false
 
 exclude_paths:
   - vendor

data/lib/test_boosters/cli_parser.rb

@@ -2,6 +2,8 @@ module TestBoosters
   module CliParser
     module_function
 
+    # :reek:TooManyStatements
+    # :reek:NestedIterators
     def parse
       options = {}
 

data/lib/test_boosters/cucumber/booster.rb

@@ -27,10 +27,10 @@ module TestBoosters
 
       def threads
         @threads ||= Array.new(@thread_count) do |thread_index|
-          known_files = all_specs & split_configuration.files_for_thread(thread_index)
-          leftover_files = TestBoosters::LeftoverFiles.select(all_leftover_specs, thread_count, thread_index)
+          known    = all_specs & split_configuration.files_for_thread(thread_index)
+          leftover = leftover_specs.select(:index => thread_index, :total => thread_count)
 
-          TestBoosters::Cucumber::Thread.new(known_files, leftover_files)
+          TestBoosters::Cucumber::Thread.new(known, leftover)
         end
       end
 
@@ -38,8 +38,8 @@ module TestBoosters
         @all_specs ||= Dir["#{specs_path}/**/*.feature"].sort
       end
 
-      def all_leftover_specs
-        @all_leftover_specs ||= all_specs - split_configuration.all_files
+      def leftover_specs
+        @leftover_specs ||= TestBoosters::LeftoverFiles.new(all_specs - split_configuration.all_files)
       end
 
       def split_configuration

data/lib/test_boosters/leftover_files.rb

@@ -1,29 +1,39 @@
 module TestBoosters
-  module LeftoverFiles
-    module_function
+  class LeftoverFiles
 
-    def select(all_leftover_files, thread_count, thread_index)
-      all_leftover_files = sort_descending_by_size(all_leftover_files)
+    attr_reader :files
 
-      return [] if all_leftover_files.empty?
+    def initialize(files)
+      @files = files
+    end
+
+    def select(options = {})
+      index = options.fetch(:index)
+      total = options.fetch(:total)
+
+      file_distribution(total)[index]
+    end
 
-      files = all_leftover_files
-        .each_slice(thread_count)
-        .reduce { |acc, slice| acc.map { |a| a }.zip(slice.reverse) }
-        .map { |f| f.is_a?(Array) ? f.flatten : [f] } [thread_index]
+    private
 
-      if    files.nil?            then []
-      elsif files.is_a?(Array) then files.compact
+    def file_distribution(thread_count)
+      # create N empty boxes
+      threads = Array.new(thread_count) { [] }
+
+      # distribute files in Round Robin fashion
+      sorted_files_by_file_size.each.with_index do |file, index|
+        threads[index % thread_count] << file
       end
+
+      threads
+    end
+
+    def sorted_files_by_file_size
+      @sorted_files_by_file_size ||= existing_files.sort_by { |file| -File.size(file) }
     end
 
-    def sort_descending_by_size(files)
-      files
-        .select { |f| File.file?(f) }
-        .map { |f| [f, File.size(f)] }
-        .sort_by { |a| a[1] }
-        .map { |a| a[0] }
-        .reverse
+    def existing_files
+      @existing_files ||= @files.select { |file| File.file?(file) }
     end
 
   end

data/lib/test_boosters/rspec/booster.rb

@@ -27,10 +27,10 @@ module TestBoosters
 
       def threads
         @threads ||= Array.new(@thread_count) do |thread_index|
-          known_files = all_specs & split_configuration.files_for_thread(thread_index)
-          leftover_files = TestBoosters::LeftoverFiles.select(all_leftover_specs, thread_count, thread_index)
+          known    = all_specs & split_configuration.files_for_thread(thread_index)
+          leftover = leftover_specs.select(:index => thread_index, :total => thread_count)
 
-          TestBoosters::Rspec::Thread.new(known_files, leftover_files)
+          TestBoosters::Rspec::Thread.new(known, leftover)
         end
       end
 
@@ -38,8 +38,8 @@ module TestBoosters
         @all_specs ||= Dir["#{specs_path}/**/*_spec.rb"].sort
       end
 
-      def all_leftover_specs
-        @all_leftover_specs ||= all_specs - split_configuration.all_files
+      def leftover_specs
+        @leftover_specs ||= TestBoosters::LeftoverFiles.new(all_specs - split_configuration.all_files)
       end
 
       def split_configuration

data/lib/test_boosters/version.rb

@@ -1,3 +1,3 @@
 module TestBoosters
-  VERSION = "1.7.2".freeze
+  VERSION = "1.7.3".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: semaphore_test_boosters
 version: !ruby/object:Gem::Version
-  version: 1.7.2
+  version: 1.7.3
 platform: ruby
 authors:
 - Developers at Rendered Text
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-24 00:00:00.000000000 Z
+date: 2017-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: semaphore_cucumber_booster_config
@@ -171,14 +171,6 @@ files:
 - lib/test_boosters/split_configuration.rb
 - lib/test_boosters/version.rb
 - test_boosters.gemspec
-- test_data/a.feature
-- test_data/a_spec.rb
-- test_data/b.feature
-- test_data/b_spec.rb
-- test_data/c.feature
-- test_data/c_spec.rb
-- test_data_fail/fail_spec.rb
-- test_data_pass/pass_spec.rb
 homepage: https://github.com/renderedtext/test-boosters
 licenses:
 - MIT

data/test_data/a.feature

@@ -1 +0,0 @@
-12345678901234567890

data/test_data/a_spec.rb

@@ -1 +0,0 @@
-12345678901234567890

data/test_data/b.feature

@@ -1 +0,0 @@
-123

data/test_data/b_spec.rb

@@ -1 +0,0 @@
-123

data/test_data/c.feature

@@ -1 +0,0 @@
-123456789

data/test_data/c_spec.rb

@@ -1 +0,0 @@
-123456789

data/test_data_fail/fail_spec.rb

@@ -1,7 +0,0 @@
-require 'spec_helper'
-
-describe TestBoosters::RspecBooster do
-  it 'fails' do
-    expect(TestBoosters::VERSION).to be "wrong"
-  end
-end

data/test_data_pass/pass_spec.rb

@@ -1,7 +0,0 @@
-require 'spec_helper'
-
-describe TestBoosters::RspecBooster do
-  it 'passes' do
-    expect(0).to eq(0)
-  end
-end