semaphore_test_boosters 1.6.2 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: df85dec09c1a32896336062203c66c589f66812e
-  data.tar.gz: 4a9c3efd75db2ff2374a0888476b4c329a2812e5
+  metadata.gz: d2d856d4423e513d330d8ac0e488916dd7086917
+  data.tar.gz: b75f81f4225d010278f15d2c6ac3261833dee343
 SHA512:
-  metadata.gz: 91cae9271ceeb83e3e57f376a157917fbb71e179d337de6a07e001029c43244cdc6cba98bc8958bec4d6620e01a624fa257c14b1cd3c4be0015a1ffeff060f19
-  data.tar.gz: 23285fca6e7c98434685aa03967b849adc2d19fa2448e3c0e831032e9fed0b6eb2035f00bb1e14a22a3ec100d7f8d7ba98991ca6b37aede537e6b3cf802eb22e
+  metadata.gz: 315807874e3dd7792d1bb3c52549667924e6a54974de2b1354c2b714469610a4c8d68813a72d96f076497e0bd1214eca462ad9dee8cdf074fbad9c8b6acdb9e6
+  data.tar.gz: 5040e37162ced1bbb7de4663070d36442e0e236699b2772e685716247ae4503de562054a324da415917eb0675b5c50b9ca451a1ea99bdbced17f092be5497e6d

data/.rubocop.yml

@@ -90,3 +90,15 @@ RSpec/SubjectStub:
 
 RSpec/DescribeClass:
   Enabled: false
+
+RSpec/LeadingSubject:
+  Enabled: false
+
+Style/WordArray:
+  Enabled: false
+
+RSpec/NotToNot:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false

data/lib/test_boosters/cucumber/booster.rb

@@ -11,24 +11,17 @@ module TestBoosters
       end
 
       def run
+        TestBoosters::Shell.display_title("Cucumber Booster v#{TestBoosters::VERSION}")
         display_system_info
 
-        unless split_configuration.valid?
-          puts "[ERROR] The split configuration file is malformed!"
-
-          return 1 # failure exit status
-        end
-
         threads[@thread_index].run
       end
 
       def display_system_info
-        TestBoosters::Shell.display_title("Cucumber Booster v#{TestBoosters::VERSION}")
-
         TestBoosters::ProjectInfo.display_ruby_version
         TestBoosters::ProjectInfo.display_bundler_version
         TestBoosters::ProjectInfo.display_cucumber_version
-
+        TestBoosters::ProjectInfo.display_split_configuration_info(split_configuration)
         puts
       end
 

data/lib/test_boosters/project_info.rb

@@ -26,5 +26,11 @@ module TestBoosters
       puts "Cucumber Version: #{version}"
     end
 
+    def display_split_configuration_info(split_configuration)
+      puts "Split configuration present: #{split_configuration.present? ? "yes" : "no"}"
+      puts "Split configuration valid: #{split_configuration.valid? ? "yes" : "no"}"
+      puts "Split configuration file count: #{split_configuration.all_files.size}"
+    end
+
   end
 end

data/lib/test_boosters/rspec/booster.rb

@@ -11,24 +11,17 @@ module TestBoosters
       end
 
       def run
+        TestBoosters::Shell.display_title("RSpec Booster v#{TestBoosters::VERSION}")
         display_system_info
 
-        unless split_configuration.valid?
-          puts "[ERROR] The split configuration file is malformed!"
-
-          return 1 # failure exit status
-        end
-
         threads[@thread_index].run
       end
 
       def display_system_info
-        TestBoosters::Shell.display_title("RSpec Booster v#{TestBoosters::VERSION}")
-
         TestBoosters::ProjectInfo.display_ruby_version
         TestBoosters::ProjectInfo.display_bundler_version
         TestBoosters::ProjectInfo.display_rspec_version
-
+        TestBoosters::ProjectInfo.display_split_configuration_info(split_configuration)
         puts
       end
 

data/lib/test_boosters/split_configuration.rb

@@ -5,6 +5,7 @@ module TestBoosters
 
     def initialize(path)
       @path = path
+      @valid = true
     end
 
     def present?
@@ -13,9 +14,8 @@ module TestBoosters
 
     def valid?
       threads # try to load data into memory
-      true
-    rescue
-      false
+
+      @valid
     end
 
     def all_files
@@ -23,23 +23,41 @@ module TestBoosters
     end
 
     def files_for_thread(thread_index)
-      threads[thread_index].files
+      thread = threads[thread_index]
+
+      thread ? thread.files : []
     end
 
     def threads
-      @threads ||= load_data.map.with_index do |raw_thread, index|
-        TestBoosters::SplitConfiguration::Thread.new(raw_thread["files"].sort, index)
-      end
+      @threads ||= present? ? load_data : []
     end
 
     private
 
+    # :reek:TooManyStatements
     def load_data
-      if present?
-        JSON.parse(File.read(@path))
-      else
-        []
+      @valid = false
+
+      content = JSON.parse(File.read(@path)).map.with_index do |raw_thread, index|
+        TestBoosters::SplitConfiguration::Thread.new(raw_thread.fetch("files").sort, index)
       end
+
+      @valid = true
+
+      content
+    rescue TypeError, KeyError => ex
+      log_error("Split Configuration has invalid structure", ex)
+
+      []
+    rescue JSON::ParserError => ex
+      log_error("Split Configuration is not parsable", ex)
+
+      []
+    end
+
+    def log_error(message, exception)
+      TestBoosters::Logger.error(message)
+      TestBoosters::Logger.error(exception.inspect)
     end
 
   end

data/lib/test_boosters/version.rb

@@ -1,3 +1,3 @@
 module TestBoosters
-  VERSION = "1.6.2".freeze
+  VERSION = "1.7.0".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: semaphore_test_boosters
 version: !ruby/object:Gem::Version
-  version: 1.6.2
+  version: 1.7.0
 platform: ruby
 authors:
 - Developers at Rendered Text