semanticart-is_paranoid 0.9.5 → 0.9.6

data/CHANGELOG

@@ -1,5 +1,8 @@
 This will only document major changes.  Please see the commit log for minor changes.
 
+-2009-09-25
+* fixing bug with has_many :through not respecting is_paranoid conditions (thanks, Ben Johnson)
+
 -2009-09-18
 * making is_paranoid play nice with habtm relationships
 

data/README.textile

@@ -1,5 +1,15 @@
 h1. is_paranoid ( same as it ever was )
 
+h3. advice and disclaimer
+
+You should always declare is_paranoid before any associations in your model unless you have a good reason for doing otherwise.  Some relationships might not behave properly if you fail to do so.  If you know what you're doing (and have written tests) and want to supress the warning then you can pass :suppress_load_order_warning => true as an option.
+
+<pre>
+  is_paranoid :suppress_load_order_warning => true
+</pre>
+
+You should never expect _any_ library to work or behave exactly how you want it to:  test, test, test and file an issue if you have any problems.  Bonus points if you include sample failing code.  Extra bonus points if you send a pull request that implements a feature/fixes a bug.
+
 h3. and you may ask yourself, well, how did I get here?
 
 Sometimes you want to delete something in ActiveRecord, but you realize you might need it later (for an undo feature, or just as a safety net, etc.).  There are a plethora of plugins that accomplish this, the most famous of which is the venerable acts_as_paranoid which is great but not really actively developed any more.  What's more, acts_as_paranoid was written for an older version of ActiveRecord and, with default_scope in 2.3, it is now possible to do the same thing with significantly less complexity.  Thus, *is_paranoid*.
@@ -91,7 +101,7 @@ And now the validates_uniqueness_of will ignore items that are destroyed.
 
 h3. and you may ask yourself, where does that highway go to?
 
-If you find any bugs, have any ideas of features you think are missing, or find things you're like to see work differently, feel free to send me a message or a pull request.
+If you find any bugs, have any ideas of features you think are missing, or find things you're like to see work differently, feel free to file an issue or send a pull request.
 
 Currently on the todo list:
 * add options for merging additional default_scope options (i.e. order, etc.)
@@ -100,4 +110,4 @@ h3. Thanks
 
 Thanks to Rick Olson for acts_as_paranoid which is obviously an inspiration in concept and execution, Ryan Bates for mentioning the idea of using default_scope for this on Ryan Daigle's "post introducing default_scope":defscope, and the Talking Heads for being the Talking Heads. 
 
-[defscope]http://ryandaigle.com/articles/2008/11/18/what-s-new-in-edge-rails-default-scoping
+[defscope]http://ryandaigle.com/articles/2008/11/18/what-s-new-in-edge-rails-default-scoping

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
-:minor: 9
-:patch: 5
+:patch: 6
 :major: 0
+:minor: 9

data/is_paranoid.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{is_paranoid}
-  s.version = "0.9.5"
+  s.version = "0.9.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jeffrey Chupp"]
-  s.date = %q{2009-09-18}
+  s.date = %q{2009-09-26}
   s.description = %q{}
   s.email = %q{jeff@semanticart.com}
   s.extra_rdoc_files = [

data/lib/is_paranoid.rb

@@ -15,6 +15,10 @@ module IsParanoid
     class_inheritable_accessor :destroyed_field, :field_destroyed, :field_not_destroyed
     self.destroyed_field, self.field_destroyed, self.field_not_destroyed = opts[:field]
 
+    if self.reflect_on_all_associations.size > 0 && ! opts[:suppress_load_order_warning]
+      warn "is_paranoid warning in class #{self}:  You should declare is_paranoid before your associations"
+    end
+
     # This is the real magic. All calls made to this model will append
     # the conditions deleted_at => nil (or whatever your destroyed_field
     # and field_not_destroyed are). All exceptions require using
@@ -27,6 +31,25 @@ module IsParanoid
   end
 
   module ClassMethods
+    def is_or_equals_not_destroyed
+      if [nil, 'NULL'].include?(field_not_destroyed)
+        'IS NULL'
+      else
+        "= #{field_not_destroyed}"
+      end
+    end
+
+    # ensure that we respect the is_paranoid conditions when being loaded as a has_many :through
+    # NOTE: this only works if is_paranoid is declared before has_many relationships.
+    def has_many(association_id, options = {}, &extension)
+       if options.key?(:through)
+        conditions = "#{options[:through].to_s.pluralize}.#{destroyed_field} #{is_or_equals_not_destroyed}"
+        options[:conditions] = "(" + [options[:conditions], conditions].compact.join(") AND (") + ")"
+      end
+      super
+    end
+
+
     # Actually delete the model, bypassing the safety net. Because
     # this method is called internally by Model.delete(id) and on the
     # delete method in each instance, we don't need to specify those

data/spec/is_paranoid_spec.rb

@@ -72,6 +72,24 @@ describe IsParanoid do
         Android.count_with_destroyed.should == 2
       end
 
+      it "shouldn't have problems with has_many :through relationships" do
+        # TODO: this spec can be cleaner and more specific, replace it later
+        # Dings use a boolean non-standard is_paranoid field
+        # Scratch uses the defaults.  Testing both ensures compatibility
+        [[:dings, Ding], [:scratches, Scratch]].each do |method, klass|
+          @r2d2.dings.should == []
+
+          dent = Dent.create(:description => 'really terrible', :android_id => @r2d2.id)
+          item = klass.create(:description => 'quite nasty', :dent_id => dent.id)
+          @r2d2.reload
+          @r2d2.send(method).should == [item]
+
+          dent.destroy
+          @r2d2.reload
+          @r2d2.send(method).should == []
+        end
+      end
+
       it "should not choke has_and_belongs_to_many relationships" do
         @r2d2.places.should include(@tatooine)
         @tatooine.destroy
@@ -298,5 +316,4 @@ describe IsParanoid do
       uuid.destroy.should be_true
     end
   end
-
 end

data/spec/models.rb

@@ -4,14 +4,16 @@ class Person < ActiveRecord::Base #:nodoc:
 end
 
 class Android < ActiveRecord::Base #:nodoc:
+  is_paranoid
   validates_uniqueness_of :name
   has_many :components, :dependent => :destroy
   has_one :sticker
   has_many :memories, :foreign_key => 'parent_id'
+  has_many :dents
+  has_many :dings, :through => :dents
+  has_many :scratches, :through => :dents
   has_and_belongs_to_many :places
 
-  is_paranoid
-
   # this code is to ensure that our destroy and restore methods
   # work without triggering before/after_update callbacks
   before_update :raise_hell
@@ -20,6 +22,23 @@ class Android < ActiveRecord::Base #:nodoc:
   end
 end
 
+class Dent < ActiveRecord::Base #:nodoc:
+  is_paranoid
+  belongs_to :android
+  has_many :dings
+  has_many :scratches
+end
+
+class Ding < ActiveRecord::Base #:nodoc:
+  is_paranoid :field => [:not_deleted, true, false]
+  belongs_to :dent
+end
+
+class Scratch < ActiveRecord::Base #:nodoc:
+  is_paranoid
+  belongs_to :dent
+end
+
 class Component < ActiveRecord::Base #:nodoc:
   is_paranoid
   belongs_to :android, :dependent => :destroy

data/spec/schema.rb

@@ -7,6 +7,24 @@ ActiveRecord::Schema.define(:version => 20090317164830) do
     t.datetime "updated_at"
   end
 
+  create_table "dents", :force => true do |t|
+    t.integer  "android_id"
+    t.string   "description"
+    t.datetime "deleted_at"
+  end
+
+  create_table "dings", :force => true do |t|
+    t.integer  "dent_id"
+    t.string   "description"
+    t.boolean  "not_deleted"
+  end
+
+  create_table "scratches", :force => true do |t|
+    t.integer  "dent_id"
+    t.string   "description"
+    t.datetime "deleted_at"
+  end
+
   create_table "androids_places", :force => true, :id => false do |t|
     t.integer  "android_id"
     t.integer  "place_id"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: semanticart-is_paranoid
 version: !ruby/object:Gem::Version 
-  version: 0.9.5
+  version: 0.9.6
 platform: ruby
 authors: 
 - Jeffrey Chupp
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-09-18 00:00:00 -07:00
+date: 2009-09-26 00:00:00 -07:00
 default_executable: 
 dependencies: []