semantic_logger 2.5.0 → 2.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 758d812e95b3b1643fa451574e705b85d2fd5870
-  data.tar.gz: 4a4c5722a4222a1c8dc4d03b5a14318d2677fc3c
+  metadata.gz: 829b38191d8058cc50bd558cc22e5af6a10d61d5
+  data.tar.gz: b4c7d0fca2c607da3c0804d63b856c62034026ac
 SHA512:
-  metadata.gz: 62b30c9df3a64a577c12791dc4ee61d5cbcba35371ee874ea3379c7020c9eb36c915a5385fec6c798724269484e78d7a7471f119ff91e0435ae6fbe1585e1173
-  data.tar.gz: 1daa2ae91c65e34cdb0d90747d7a80da362af7e7c80c96de270338c0653aa9bee63f878ecc6cba3fda7ee15f863ea1a00a1aec8be5861df8c4baed988c318cd9
+  metadata.gz: cbafd799f1667daf4465c482811bde21bfbeae462d6db1c0c5bdebee1b9a4118b933c435134fc9b5ff76e7a84fdf481450fd33ad47c304ec6d0150a171263b16
+  data.tar.gz: 9b7dff017d6e41e465000f363d43c839cfeccbc5c23636078f92dc1605c154bcdbef5f12f3d5f5e0d098fd6c818f4bc5ae09a78ba4691f6001becefb7cab106c

data/LICENSE.txt

@@ -186,7 +186,7 @@
       same "printed page" as the copyright notice for easier
       identification within third-party archives.
 
-   Copyright 2012 Clarity Services, Inc.
+   Copyright 2012, 2013 Reid Morrison
 
    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.

data/README.md

@@ -956,7 +956,7 @@ Marc Bellingrath :: marrrc.b@gmail.com
 License
 -------
 
-Copyright 2012,2013 Reid Morrison
+Copyright 2012, 2013 Reid Morrison
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

data/lib/semantic_logger.rb

@@ -15,3 +15,9 @@ module SemanticLogger
     autoload :Syslog,  'semantic_logger/appender/syslog'
   end
 end
+
+# Flush all appenders at exit, waiting for outstanding messages on the queue
+# to be written first
+at_exit do
+  SemanticLogger.flush
+end

data/lib/semantic_logger/appender/base.rb

@@ -34,7 +34,7 @@ module SemanticLogger
         Proc.new do |log|
           tags = log.tags.collect { |tag| "[#{tag}]" }.join(" ") + " " if log.tags && (log.tags.size > 0)
 
-          message = log.message.to_s
+          message = log.message.to_s.dup
           message << " -- " << log.payload.inspect if log.payload
           message << " -- " << "#{log.exception.class}: #{log.exception.message}\n#{(log.exception.backtrace || []).join("\n")}" if log.exception
 

data/lib/semantic_logger/base.rb

@@ -156,22 +156,26 @@ module SemanticLogger
     # Previous method for supplying tags
     alias_method :with_tags, :tagged
 
-    # Returns [Array] of [String] tags currently active for this thread
+    # Returns a copy of the [Array] of [String] tags currently active for this thread
     # Returns nil if no tags are set
     def tags
-      Thread.current[:semantic_logger_tags] ||= []
+      # Since tags are stored on a per thread basis this list is thread-safe
+      t = Thread.current[:semantic_logger_tags]
+      t.nil? ? [] : t.clone
     end
 
     # Add tags to the current scope
-    #   To support: ActiveSupport::TaggedLogging V4 and above
     def push_tags *tags
-      Thread.current[:semantic_logger_tags] = self.tags.concat(tags.flatten.collect(&:to_s).reject(&:empty?))
+      # Need to flatten and reject empties to support calls from Rails 4
+      new_tags = tags.flatten.collect(&:to_s).reject(&:empty?)
+      t = Thread.current[:semantic_logger_tags]
+      Thread.current[:semantic_logger_tags] = t.nil? ? new_tags : t.concat(new_tags)
     end
 
     # Remove specified number of tags from the current tag list
-    #   To support: ActiveSupport::TaggedLogging V4 and above
     def pop_tags(quantity=1)
-      tags.pop(quantity)
+      t = Thread.current[:semantic_logger_tags]
+      t.pop(quantity) unless t.nil?
     end
 
     # Thread specific context information to be logged with every log entry

data/lib/semantic_logger/loggable.rb

@@ -2,10 +2,10 @@ require 'sync_attr'
 
 # Logger class variable mix-in
 #
-#   Lazy initialize and a logger class variable with instance accessor
+#   Lazy initialize a logger class variable with instance accessor
 #
 #   By including this mix-in into any class it will define a class level logger
-#   and make it accessible via instance methods
+#   and also make it accessible via instance methods
 #
 # Example
 #

data/lib/semantic_logger/logger.rb

@@ -128,7 +128,7 @@ module SemanticLogger
     def self.logger
       @@logger ||= begin
         l = SemanticLogger::Appender::File.new(STDERR, :warn)
-        l.name = self.class.name
+        l.name = name
         l
       end
     end
@@ -212,14 +212,5 @@ module SemanticLogger
       end
     end
 
-    # Flush all appenders at exit, waiting for outstanding messages on the queue
-    # to be written first
-    at_exit do
-      flush
-    end
-
-    # Start appender thread on load to workaround intermittent startup issues
-    # with JRuby 1.8.6 under Trinidad in 1.9 mode
-    start_appender_thread
   end
 end

data/lib/semantic_logger/semantic_logger.rb

@@ -99,6 +99,11 @@ module SemanticLogger
       SemanticLogger::Appender::Wrapper.new(appender, &block)
     end
     @@appenders << appender_instance
+
+    # Start appender thread if it is not already running
+    SemanticLogger::Logger.start_appender_thread
+    
+    appender_instance
   end
 
   # Remove an existing appender
@@ -113,7 +118,7 @@ module SemanticLogger
   # Use SemanticLogger.add_appender and SemanticLogger.remove_appender
   # to manipulate the active appenders list
   def self.appenders
-    @@appenders.dup
+    @@appenders.clone
   end
 
   # Wait until all queued log messages have been written and flush all active
@@ -128,12 +133,14 @@ module SemanticLogger
   # Note: Only appenders that implement the reopen method will be called
   def self.reopen
     @@appenders.each {|appender| appender.reopen if appender.respond_to?(:reopen)}
+    # After a fork the appender thread is not running, start it if it is not running
+    SemanticLogger::Logger.start_appender_thread
   end
 
   ############################################################################
   protected
 
-  @@appenders     = ThreadSafe::Array.new
+  @@appenders = ThreadSafe::Array.new
 
   ############################################################################
   private

data/lib/semantic_logger/version.rb

@@ -1,3 +1,3 @@
 module SemanticLogger #:nodoc
-  VERSION = "2.5.0"
+  VERSION = "2.6.0"
 end

data/test/logger_test.rb

@@ -38,9 +38,9 @@ class LoggerTest < Test::Unit::TestCase
       end
     end
 
-    context "with_tags logging" do
+    context "tagged logging" do
       should "add tags to log entries" do
-        @logger.with_tags('12345', 'DJHSFK') do
+        @logger.tagged('12345', 'DJHSFK') do
           @logger.info('Hello world')
           SemanticLogger.flush
           assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ \w \[\d+:.+\] \[12345\] \[DJHSFK\] LoggerTest -- Hello world/, @mock_logger.message
@@ -48,8 +48,8 @@ class LoggerTest < Test::Unit::TestCase
       end
 
       should "add embedded tags to log entries" do
-        @logger.with_tags('First Level', 'tags') do
-          @logger.with_tags('Second Level') do
+        @logger.tagged('First Level', 'tags') do
+          @logger.tagged('Second Level') do
             @logger.info('Hello world')
             SemanticLogger.flush
             assert_match /\d+-\d+-\d+ \d+:\d+:\d+.\d+ \w \[\d+:.+\] \[First Level\] \[tags\] \[Second Level\] LoggerTest -- Hello world/, @mock_logger.message

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: semantic_logger
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 2.6.0
 platform: ruby
 authors:
 - Reid Morrison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-08 00:00:00.000000000 Z
+date: 2013-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sync_attr
@@ -68,7 +68,7 @@ files:
 - test/loggable_test.rb
 - test/logger_test.rb
 - test/mock_logger.rb
-homepage: https://github.com/ClarityServices/semantic_logger
+homepage: https://github.com/reidmorrison/semantic_logger
 licenses:
 - Apache License V2.0
 metadata: {}
@@ -88,7 +88,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
 summary: Improved logging for Ruby