semantic_date_time_tags 0.1.18 → 0.1.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1c20d269f312b59d4fbe3f925ea9878228bb0861
-  data.tar.gz: d000cff436dc9d5c2a1bbe3b773386411084ab7d
+  metadata.gz: e4d40ba7c943dbe95a16f44f0ebc1d4bb8ca3fc6
+  data.tar.gz: ab9b461a807586e6b691017341bedef720a45a63
 SHA512:
-  metadata.gz: e80126f88f83a8572d12158c5d6cfa3d7e14eaf6b44cd9cd3d18611df72aa4e5339f04ff7df42e3d346f6fae3091c797096a4eb1ffb71bb6180e41ec5ea02ee3
-  data.tar.gz: d7cb59136ca69351eb869cfbb0708e7e58a3d1a07f8a1f2b249b235477c6c43bf19d8e4f3a4c1684bbbfd945c60c4b7514d80574c8048c3128ab6adfe8ae0475
+  metadata.gz: 69ec4bf645200146542a4868b918dbd21144cc4a8469e8b273c232a442a42ce4b8099dd7e1c081116ed5ed37b955a1caaf4fa67789b5fc5436071a9811d59cfc
+  data.tar.gz: 2fdfa402ad731cd536738ba7169bd87d7b41368a58ffc31d8cd2064dcb9b74318ebaa0374ba0c179a3ea00875d790c59e5608e69f6d28a8a8ed7aa4276ad49c8

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 0.1.19
+
+* removed `:format` from options passed to the `time` tag (in effect producing invalid HTML)
+
 ## 0.1.18
 
 * removed `:separator` from options passed to the `time` tag (in effect producing invalid HTML)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    semantic_date_time_tags (0.1.18)
+    semantic_date_time_tags (0.1.19)
       rails (>= 3)
 
 GEM
@@ -56,7 +56,7 @@ GEM
       tins (~> 1.6)
     crass (1.0.2)
     docile (1.1.5)
-    erubi (1.6.1)
+    erubi (1.7.0)
     ffi (1.9.18)
     formatador (0.2.5)
     globalid (0.4.0)

data/lib/semantic_date_time_tags/tag.rb

@@ -14,7 +14,7 @@ module SemanticDateTimeTags
 
     def initialize(obj, options = {})
       @obj = obj
-      @options = options.tap { |opts| opts.delete(:scope) }
+      @options = options.except(*%i(scope))
     end
 
     # ---------------------------------------------------------------------

data/lib/semantic_date_time_tags/tag/date.rb

@@ -7,7 +7,7 @@ module SemanticDateTimeTags
         raise 'object must be Date or DateTime' unless [::Date, ::DateTime].any? { |c| obj.instance_of? c }
 
         options = options.except(*%i(separator))
-        
+
         super(obj, options)
       end
 
@@ -24,7 +24,7 @@ module SemanticDateTimeTags
 
         value = SemanticDateTimeTags::FormatParser.new(format_string, localized_obj).to_html.html_safe
 
-        content_tag(tag_name, options) { value }.html_safe
+        content_tag(tag_name, options.except(*%i(format))) { value }.html_safe
       end
 
       private # =============================================================

data/lib/semantic_date_time_tags/tag/date_time.rb

@@ -24,7 +24,7 @@ module SemanticDateTimeTags
 
         value = SemanticDateTimeTags::FormatParser.new(format_string, localized_obj).to_html.html_safe
 
-        time_tag(obj, options) { value }.html_safe
+        time_tag(obj, options.except(*%i(format))) { value }.html_safe
       end
 
       private # =============================================================

data/lib/semantic_date_time_tags/tag/time.rb

@@ -21,7 +21,7 @@ module SemanticDateTimeTags
 
         value = SemanticDateTimeTags::FormatParser.new(format_string, localized_obj).to_html
 
-        content_tag(tag_name, options) { value }.html_safe
+        content_tag(tag_name, options.except(*%i(format))) { value }.html_safe
       end
 
       private # =============================================================

data/lib/semantic_date_time_tags/version.rb

@@ -1,3 +1,3 @@
 module SemanticDateTimeTags
-  VERSION = '0.1.18'.freeze
+  VERSION = '0.1.19'.freeze
 end

data/test/semantic_date_time_tags/view_helpers_test.rb

@@ -80,6 +80,7 @@ describe SemanticDateTimeTags::ViewHelpers do
       semantic_time_tag(time_object, format: :test).must_include '~'
       semantic_time_tag(time_object, format: :test).must_include 'data-format="test"'
       semantic_time_tag(time_object, format: '%-l:%M %P').must_include 'data-format="%-l:%M %P"'
+      semantic_time_tag(time_object, format: '%-l:%M %P').wont_include ' format='
     end
   end
 
@@ -126,9 +127,10 @@ describe SemanticDateTimeTags::ViewHelpers do
       semantic_date_tag(Date.today, format: :test).must_include '~'
       semantic_date_tag(Date.today, format: :test).must_include 'data-format="test"'
       semantic_date_tag(Date.today, format: '%a, %b %-d, %Y').must_include 'data-format="%a, %b %-d, %Y"'
+      semantic_date_tag(Date.today, format: '%a, %b %-d, %Y').wont_include ' format='
     end
   end
-
+  
   # ---------------------------------------------------------------------
 
   describe '#semantic_date_time_tag' do
@@ -160,6 +162,7 @@ describe SemanticDateTimeTags::ViewHelpers do
       semantic_date_time_tag(date_time_object, format: :test).must_include '~'
       semantic_date_time_tag(date_time_object, format: :test).must_include 'data-format="test"'
       semantic_date_time_tag(date_time_object, format: '%a, %b %-d, %Y, %-l:%M %P').must_include 'data-format="%a, %b %-d, %Y, %-l:%M %P"'
+      semantic_date_time_tag(date_time_object, format: '%a, %b %-d, %Y, %-l:%M %P').wont_include ' format='
     end
   end
 
@@ -215,6 +218,7 @@ describe SemanticDateTimeTags::ViewHelpers do
       semantic_date_time_range_tag(date_object, date_tomorrow_object, format: :test).must_include '~'
       semantic_date_time_range_tag(date_object, date_tomorrow_object, format: :test).must_include 'data-format="test"'
       semantic_time_tag(time_object, format: '%a, %b %-d, %Y, %-l:%M %P').must_include 'data-format="%a, %b %-d, %Y, %-l:%M %P"'
+      semantic_time_tag(time_object, format: '%a, %b %-d, %Y, %-l:%M %P').wont_include ' format='
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: semantic_date_time_tags
 version: !ruby/object:Gem::Version
-  version: 0.1.18
+  version: 0.1.19
 platform: ruby
 authors:
 - Tomas Celizna
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-29 00:00:00.000000000 Z
+date: 2017-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails