selenium-webdriver 3.5.1 → 3.5.2

data/CHANGES

@@ -1,3 +1,22 @@
+3.5.2 (2017-09-07)
+  ==================
+
+Ruby:
+  * Removed platformVersion from W3C payload (issue #4641)
+  * Fixed a bug when proxy type was not compliant to specification (issue #4574)
+  * Added support for passing speed to flick action (issue #4549)
+  * Using TouchActionBuilder no longer prints mouse/key deprecations
+  * Deprecated Alert#authenticate
+  * Added support for DEBUG environment variable which enables full debug mode in gem
+
+Firefox:
+  * Fixed a bug when page load timeout was not properly constructed in new session payload
+  * Fixed a bug when GeckoDriver error stacktrace was not displayed (issue #3683)
+
+Chrome:
+  * Added workardound for the case when findElements call returns null (issue #4555)
+  * Chrome::Driver now includes touch actions by default
+
 3.5.1 (2017-08-15)
 ==================
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    selenium-webdriver (3.5.0)
+    selenium-webdriver (3.5.1)
       childprocess (~> 0.5)
       rubyzip (~> 1.0)
 
@@ -10,7 +10,7 @@ GEM
   specs:
     addressable (2.5.1)
       public_suffix (~> 2.0, >= 2.0.2)
-    childprocess (0.7.0)
+    childprocess (0.7.1)
       ffi (~> 1.0, >= 1.0.11)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
@@ -53,4 +53,4 @@ DEPENDENCIES
   yard (~> 0.9.9)
 
 BUNDLED WITH
-   1.15.3
+   1.15.4

data/lib/selenium/webdriver/chrome/driver.rb

@@ -27,6 +27,7 @@ module Selenium
       #
 
       class Driver < WebDriver::Driver
+        include DriverExtensions::HasTouchScreen
         include DriverExtensions::HasWebStorage
         include DriverExtensions::TakesScreenshot
 

data/lib/selenium/webdriver/chrome/options.rb

@@ -129,11 +129,11 @@ module Selenium
         #
         # @example Start Chrome in mobile emulation mode by device name
         #   options = Selenium::WebDriver::Chrome::Options.new
-        #   options.add_emulated_device(device_name: 'iPhone 6')
+        #   options.add_emulation(device_name: 'iPhone 6')
         #
         # @example Start Chrome in mobile emulation mode by device metrics
         #   options = Selenium::WebDriver::Chrome::Options.new
-        #   options.add_emulated_device(device_metrics: {width: 400, height: 800, pixelRatio: 1, touch: true})
+        #   options.add_emulation(device_metrics: {width: 400, height: 800, pixelRatio: 1, touch: true})
         #
         # @param [String] device_name Name of the device or a hash containing width, height, pixelRatio, touch
         # @param [Hash] device_metrics Hash containing width, height, pixelRatio, touch

data/lib/selenium/webdriver/common/alert.rb

@@ -44,6 +44,7 @@ module Selenium
       end
 
       def authenticate(username, password)
+        WebDriver.logger.deprecate 'Alert#authenticate'
         @bridge.authentication(username: username, password: password)
         accept
       end

data/lib/selenium/webdriver/common/driver_extensions/has_touch_screen.rb

@@ -22,7 +22,7 @@ module Selenium
     module DriverExtensions
       module HasTouchScreen
         def touch
-          TouchActionBuilder.new mouse, keyboard, touch_screen
+          TouchActionBuilder.new Mouse.new(@bridge), Keyboard.new(@bridge), touch_screen
         end
 
         private

data/lib/selenium/webdriver/common/logger.rb

@@ -101,13 +101,20 @@ module Selenium
       end
 
       #
-      # Marks code as deprecated with replacement.
+      # Marks code as deprecated with/without replacement.
       #
       # @param [String] old
-      # @param [String] new
+      # @param [String, nil] new
       #
-      def deprecate(old, new)
-        warn "[DEPRECATION] #{old} is deprecated. Use #{new} instead."
+      def deprecate(old, new = nil)
+        message = "[DEPRECATION] #{old} is deprecated"
+        message << if new
+                     ". Use #{new} instead."
+                   else
+                     ' and will be removed in the next releases.'
+                   end
+
+        warn message
       end
 
       private
@@ -115,13 +122,21 @@ module Selenium
       def create_logger(output)
         logger = ::Logger.new(output)
         logger.progname = 'Selenium'
-        logger.level = ($DEBUG ? DEBUG : WARN)
+        logger.level = default_level
         logger.formatter = proc do |severity, time, progname, msg|
           "#{time.strftime('%F %T')} #{severity} #{progname} #{msg}\n"
         end
 
         logger
       end
+
+      def default_level
+        if $DEBUG || ENV.key?('DEBUG')
+          DEBUG
+        else
+          WARN
+        end
+      end
     end # Logger
   end # WebDriver
 end # Selenium

data/lib/selenium/webdriver/common/touch_screen.rb

@@ -83,13 +83,14 @@ module Selenium
           element, xoffset, yoffset, speed = args
 
           assert_element element
-          flick_speed = FLICK_SPEED[speed.to_sym]
 
-          unless flick_speed
-            raise ArgumentError, "expected one of #{FLICK_SPEED.keys.inspect}, got #{speed.inspect}"
+          if (speed.is_a?(String) || speed.is_a?(Symbol)) && FLICK_SPEED.keys.include?(speed.to_sym)
+            WebDriver.logger.deprecate "Passing #{speed.inspect} speed",
+                                       "Integer or Selenium::WebDriver::TouchScreen::FLICK_SPEED[:#{speed}]"
+            speed = FLICK_SPEED[speed.to_sym]
           end
 
-          @bridge.touch_element_flick element.ref, Integer(xoffset), Integer(yoffset), flick_speed
+          @bridge.touch_element_flick element.ref, Integer(xoffset), Integer(yoffset), Integer(speed)
         else
           raise ArgumentError, "wrong number of arguments, expected 2 or 4, got #{args.size}"
         end

data/lib/selenium/webdriver/remote/oss/bridge.rb

@@ -558,6 +558,8 @@ module Selenium
                   else
                     execute :find_elements, {}, {using: how, value: what}
                   end
+            # see https://github.com/SeleniumHQ/selenium/issues/4555
+            ids ||= []
 
             ids.map { |id| Element.new self, element_id_from(id) }
           end

data/lib/selenium/webdriver/remote/response.rb

@@ -22,6 +22,8 @@ module Selenium
     module Remote
       # @api private
       class Response
+        STACKTRACE_KEY = 'stackTrace'.freeze
+
         attr_reader :code, :payload
         attr_writer :payload
 
@@ -73,11 +75,25 @@ module Selenium
         end
 
         def add_backtrace(ex)
-          return unless value.is_a?(Hash) && value['stackTrace']
+          return unless error_payload.is_a?(Hash)
+
+          server_trace = error_payload[STACKTRACE_KEY] ||
+                         error_payload[STACKTRACE_KEY.downcase] ||
+                         error_payload['value'][STACKTRACE_KEY]
+          return unless server_trace
 
-          server_trace = value['stackTrace']
+          backtrace = case server_trace
+                      when Array
+                        backtrace_from_remote(server_trace)
+                      when String
+                        server_trace.split("\n")
+                      end
 
-          backtrace = server_trace.map do |frame|
+          ex.set_backtrace(backtrace + ex.backtrace)
+        end
+
+        def backtrace_from_remote(server_trace)
+          server_trace.map do |frame|
             next unless frame.is_a?(Hash)
 
             file = frame['fileName']
@@ -91,8 +107,6 @@ module Selenium
 
             "[remote server] #{file}:#{line}:in `#{meth}'"
           end.compact
-
-          ex.set_backtrace(backtrace + ex.backtrace)
         end
 
         def error_payload

data/lib/selenium/webdriver/remote/w3c/capabilities.rb

@@ -35,29 +35,32 @@ module Selenium
         # @api private
         #
 
-        # TODO - uncomment when Mozilla fixes this:
-        # https://bugzilla.mozilla.org/show_bug.cgi?id=1326397
         class Capabilities
 
           EXTENSION_CAPABILITY_PATTERN = /\A[\w-]+:.*\z/
 
-          # TODO (alex): compare with spec
           KNOWN = [
             :browser_name,
             :browser_version,
             :platform_name,
-            :platform_version,
             :accept_insecure_certs,
             :page_load_strategy,
             :proxy,
+            :set_window_rect,
+            :timeouts,
+            :unhandled_prompt_behavior,
+
+            # remote-specific
             :remote_session_id,
+
+            # TODO (alex): deprecate in favor of Firefox::Options?
             :accessibility_checks,
             :device,
+
+            # TODO (alex): deprecate compatibility with OSS-capabilities
             :implicit_timeout,
             :page_load_timeout,
             :script_timeout,
-            :unhandled_prompt_behavior,
-            :timeouts,
           ].freeze
 
           KNOWN.each do |key|
@@ -96,7 +99,7 @@ module Selenium
               opts[:platform_name] = opts.delete(:platform) if opts.key?(:platform)
               opts[:timeouts] = {}
               opts[:timeouts]['implicit'] = opts.delete(:implicit_timeout) if opts.key?(:implicit_timeout)
-              opts[:timeouts]['page load'] = opts.delete(:page_load_timeout) if opts.key?(:page_load_timeout)
+              opts[:timeouts]['pageLoad'] = opts.delete(:page_load_timeout) if opts.key?(:page_load_timeout)
               opts[:timeouts]['script'] = opts.delete(:script_timeout) if opts.key?(:script_timeout)
               new({browser_name: 'firefox', marionette: true}.merge(opts))
             end
@@ -114,7 +117,6 @@ module Selenium
               caps.browser_name = data.delete('browserName')
               caps.browser_version = data.delete('browserVersion')
               caps.platform_name = data.delete('platformName')
-              caps.platform_version = data.delete('platformVersion')
               caps.accept_insecure_certs = data.delete('acceptInsecureCerts') if data.key?('acceptInsecureCerts')
               caps.page_load_strategy = data.delete('pageLoadStrategy')
               timeouts = data.delete('timeouts')
@@ -196,7 +198,6 @@ module Selenium
           # @option :browser_name             [String] required browser name
           # @option :browser_version          [String] required browser version number
           # @option :platform_name            [Symbol] one of :any, :win, :mac, or :x
-          # @option :platform_version         [String] required platform version number
           # @option :accept_insecure_certs    [Boolean] does the driver accept insecure SSL certifications?
           # @option :proxy                    [Selenium::WebDriver::Proxy, Hash] proxy configuration
           #
@@ -253,7 +254,10 @@ module Selenium
               when :platform
                 hash['platform'] = value.to_s.upcase
               when :proxy
-                hash['proxy'] = value.as_json if value
+                if value
+                  hash['proxy'] = value.as_json
+                  hash['proxy']['proxyType'] &&= hash['proxy']['proxyType'].downcase
+                end
               when String, :firefox_binary
                 hash[key.to_s] = value
               when Symbol

data/selenium-webdriver.gemspec

@@ -5,7 +5,7 @@ raise "cwd must be #{root} when reading gemspec" if root != Dir.pwd
 
 Gem::Specification.new do |s|
   s.name = 'selenium-webdriver'
-  s.version = '3.5.1'
+  s.version = '3.5.2'
 
   s.authors = ['Alex Rodionov', 'Titus Fortner']
   s.email = ['p0deje@gmail.com', 'titusfortner@gmail.com']

metadata

@@ -2,7 +2,7 @@
 name: selenium-webdriver
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 3.5.1
+  version: 3.5.2
 platform: ruby
 authors: 
   - Alex Rodionov
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2017-08-15 00:00:00 +07:00
+date: 2017-09-07 00:00:00 +07:00
 default_executable: 
 dependencies: 
   - !ruby/object:Gem::Dependency