selenium-webdriver 3.1.0 → 3.2.0

data/CHANGES

@@ -1,3 +1,10 @@
+3.2.0 (2017-02-22)
+===================
+
+Ruby:
+  * Implement new Logger class
+  * Fix issue with chromedriver process leader incompatibility on Win7 (issue 3512)
+
 3.1.0 (2017-02-14)
 ===================
 

data/lib/selenium/webdriver.rb

@@ -50,15 +50,20 @@ module Selenium
     #
     # Create a new Driver instance with the correct bridge for the given browser
     #
-    # @param browser [:ie, :internet_explorer, :edge, :remote, :chrome, :firefox, :ff, :phantomjs, :safari]
-    #   the driver type to use
-    # @param *rest
-    #   arguments passed to Bridge.new
+    # @overload for(browser)
+    #   @param [:ie, :internet_explorer, :edge, :remote, :chrome, :firefox, :ff, :phantomjs, :safari] browser The browser to
+    #     create the driver for
+    # @overload for(browser, opts)
+    #   @param [:ie, :internet_explorer, :edge, :remote, :chrome, :firefox, :ff, :phantomjs, :safari] browser The browser to
+    #     create the driver for
+    #   @param [Hash] opts Options passed to Bridge.new
     #
     # @return [Driver]
     #
     # @see Selenium::WebDriver::Remote::Bridge
+    # @see Selenium::WebDriver::Remote::W3CBridge
     # @see Selenium::WebDriver::Firefox::Bridge
+    # @see Selenium::WebDriver::Firefox::W3CBridge
     # @see Selenium::WebDriver::IE::Bridge
     # @see Selenium::WebDriver::Edge::Bridge
     # @see Selenium::WebDriver::Chrome::Bridge
@@ -67,9 +72,9 @@ module Selenium
     #
     # @example
     #
-    #   WebDriver.for :firefox, :profile => "some-profile"
-    #   WebDriver.for :firefox, :profile => Profile.new
-    #   WebDriver.for :remote,  :url => "http://localhost:4444/wd/hub", :desired_capabilities => caps
+    #   WebDriver.for :firefox, profile: 'some-profile'
+    #   WebDriver.for :firefox, profile: Profile.new
+    #   WebDriver.for :remote,  url: "http://localhost:4444/wd/hub", desired_capabilities: caps
     #
     # One special argument is not passed on to the bridges, :listener.
     # You can pass a listener for this option to get notified of WebDriver events.
@@ -81,5 +86,15 @@ module Selenium
     def self.for(*args)
       WebDriver::Driver.for(*args)
     end
+
+    #
+    # Returns logger instance that can be used across the whole Selenium.
+    #
+    # @return [Logger]
+    #
+
+    def self.logger
+      @logger ||= WebDriver::Logger.new
+    end
   end # WebDriver
 end # Selenium

data/lib/selenium/webdriver/chrome/service.rb

@@ -37,10 +37,9 @@ module Selenium
 
         def start_process
           server_command = [@executable_path, "--port=#{@port}", *@extra_args]
-          @process       = ChildProcess.build(*server_command)
-
-          @process.io.inherit! if $DEBUG
-          @process.leader = true
+          @process = ChildProcess.build(*server_command)
+          @process.io.stdout = @process.io.stderr = WebDriver.logger.io
+          @process.leader = true unless Platform.windows?
           @process.start
         end
 

data/lib/selenium/webdriver/common.rb

@@ -37,6 +37,7 @@ require 'selenium/webdriver/common/target_locator'
 require 'selenium/webdriver/common/navigation'
 require 'selenium/webdriver/common/timeouts'
 require 'selenium/webdriver/common/window'
+require 'selenium/webdriver/common/logger'
 require 'selenium/webdriver/common/logs'
 require 'selenium/webdriver/common/options'
 require 'selenium/webdriver/common/w3c_options'

data/lib/selenium/webdriver/common/action_builder.rb

@@ -69,11 +69,13 @@ module Selenium
       #    el = driver.find_element(id: "some_id")
       #    driver.action.key_down(el, :shift).perform
       #
-      # @param [:shift, :alt, :control, :command, :meta] The key to press.
-      # @param [Selenium::WebDriver::Element] element An optional element
+      # @overload key_down(key)
+      #   @param [:shift, :alt, :control, :command, :meta] key The modifier key to press
+      # @overload key_down(element, key)
+      #   @param [Element] element An optional element to move to first
+      #   @param [:shift, :alt, :control, :command, :meta] key The modifier key to press
       # @raise [ArgumentError] if the given key is not a modifier
-      # @return [ActionBuilder] A self reference.
-      #
+      # @return [ActionBuilder] A self reference
 
       def key_down(*args)
         @actions << [:mouse, :click, [args.shift]] if args.first.is_a? Element
@@ -95,10 +97,13 @@ module Selenium
       #   el = driver.find_element(id: "some_id")
       #   driver.action.key_up(el, :alt).perform
       #
-      # @param [:shift, :alt, :control, :command, :meta] The modifier key to release.
-      # @param [Selenium::WebDriver::Element] element An optional element
-      # @raise [ArgumentError] if the given key is not a modifier key
-      # @return [ActionBuilder] A self reference.
+      # @overload key_up(key)
+      #   @param [:shift, :alt, :control, :command, :meta] key The modifier key to release
+      # @overload key_up(element, key)
+      #   @param [Element] element An optional element to move to first
+      #   @param [:shift, :alt, :control, :command, :meta] key The modifier key to release
+      # @raise [ArgumentError] if the given key is not a modifier
+      # @return [ActionBuilder] A self reference
       #
 
       def key_up(*args)
@@ -124,9 +129,12 @@ module Selenium
       #
       #   driver.action.send_keys("help").perform
       #
-      # @param [Selenium::WebDriver::Element] element An optional element
-      # @param [String] keys The keys to be sent.
-      # @return [ActionBuilder] A self reference.
+      # @overload send_keys(keys)
+      #   @param [Array, Symbol, String] keys The key(s) to press and release
+      # @overload send_keys(element, keys)
+      #   @param [Element] element An optional element to move to first
+      #   @param [Array, Symbol, String] keys The key(s) to press and release
+      # @return [ActionBuilder] A self reference
       #
 
       def send_keys(*args)
@@ -147,7 +155,7 @@ module Selenium
       #    el = driver.find_element(id: "some_id")
       #    driver.action.click_and_hold(el).perform
       #
-      # @param [Selenium::WebDriver::Element] element the element to move to and click.
+      # @param [Element] element the element to move to and click.
       # @return [ActionBuilder] A self reference.
       #
 
@@ -330,8 +338,6 @@ module Selenium
       # @param [Selenium::WebDriver::Element] source Element to emulate button down at.
       # @param [Integer] right_by horizontal move offset.
       # @param [Integer] down_by vertical move offset.
-      # @param [Selenium::WebDriver::Element] target Element to move to and release the
-      #   mouse at.
       # @return [ActionBuilder] A self reference.
       #
 

data/lib/selenium/webdriver/common/driver.rb

@@ -221,7 +221,7 @@ module Selenium
       #
       # @param [String] script
       #   JavaScript source to execute
-      # @param [WebDriver::Element,Integer, Float, Boolean, NilClass, String, Array] *args
+      # @param [WebDriver::Element, Integer, Float, Boolean, NilClass, String, Array] args
       #   Arguments will be available in the given script in the 'arguments' pseudo-array.
       #
       # @return [WebDriver::Element,Integer,Float,Boolean,NilClass,String,Array]
@@ -241,7 +241,7 @@ module Selenium
       #
       # @param [String] script
       #   JavaScript source to execute
-      # @param [WebDriver::Element,Integer, Float, Boolean, NilClass, String, Array] *args
+      # @param [WebDriver::Element,Integer, Float, Boolean, NilClass, String, Array] args
       #   Arguments to the script. May be empty.
       #
       # @return [WebDriver::Element,Integer,Float,Boolean,NilClass,String,Array]
@@ -274,7 +274,7 @@ module Selenium
       # Get the first element matching the given selector. If given a
       # String or Symbol, it will be used as the id of the element.
       #
-      # @param  [String,Hash] id or selector
+      # @param  [String,Hash] sel id or selector
       # @return [WebDriver::Element]
       #
       # Examples:

data/lib/selenium/webdriver/common/driver_extensions/rotatable.rb

@@ -30,7 +30,7 @@ module Selenium
         #
         # Change the screen orientation
         #
-        # @param [:landscape, :portrait] Orientation
+        # @param [:landscape, :portrait] orientation
         #
         # @api public
         #

data/lib/selenium/webdriver/common/element.rb

@@ -108,10 +108,8 @@ module Selenium
       #
       # class, readonly
       #
-      # @param [String]
-      #   attribute name
-      # @return [String,nil]
-      #   attribute value
+      # @param [String] name attribute name
+      # @return [String, nil] attribute value
       #
 
       def attribute(name)
@@ -122,10 +120,8 @@ module Selenium
       # Get the value of a the given property with the same name of the element. If the value is not
       # set, nil is returned.
       #
-      # @param [String]
-      #   property name
-      # @return [String,nil]
-      #   property value
+      # @param [String] name property name
+      # @return [String, nil] property value
       #
 
       def property(name)
@@ -145,7 +141,7 @@ module Selenium
       #
       # Send keystrokes to this element
       #
-      # @param [String, Symbol, Array]
+      # @param [String, Symbol, Array] args keystrokes to send
       #
       # Examples:
       #

data/lib/selenium/webdriver/common/interactions/key_actions.rb

@@ -22,8 +22,8 @@ module Selenium
     module KeyActions
       #
       # Performs a key press. Does not release the key - subsequent interactions may assume it's kept pressed.
-      # Note that the modifier key is never released implicitly - either #key_up(key) or #release_actions must be
-      # called to release the key.
+      # Note that the key is never released implicitly - either W3CActionBuilder#key_up(key) or W3CActionBuilder#release_actions
+      # must be called to release the key.
       #
       # @example Press a key
       #
@@ -34,10 +34,14 @@ module Selenium
       #    el = driver.find_element(id: "some_id")
       #    driver.action.key_down(el, :shift).perform
       #
-      # @param [Selenium::WebDriver::Element] element An optional element
-      # @param [:shift, :alt, :control, :command, :meta, 'a'] key The key to press.
-      # @param [Symbol || String] device optional name of the KeyInput device to press the key on
-      # @return [W3CActionBuilder] A self reference.
+      # @overload key_down(key, device: nil)
+      #   @param [Symbol, String] key The key to press
+      #   @param [Symbol, String] device Optional name of the KeyInput device to press the key on
+      # @overload key_down(element, key, device: nil)
+      #   @param [Element] element An optional element to move to first
+      #   @param [Symbol, String] key The key to press
+      #   @param [Symbol, String] device Optional name of the KeyInput device to press the key on
+      # @return [W3CActionBuilder] A self reference
       #
 
       def key_down(*args, device: nil)
@@ -45,8 +49,8 @@ module Selenium
       end
 
       #
-      # Performs a modifier key release.
-      # Releasing a non-depressed modifier key will yield undefined behaviour.
+      # Performs a key release.
+      # Releasing a non-depressed key will yield undefined behaviour.
       #
       # @example Release a key
       #
@@ -57,10 +61,14 @@ module Selenium
       #   el = driver.find_element(id: "some_id")
       #   driver.action.key_up(el, :alt).perform
       #
-      # @param [Selenium::WebDriver::Element] element An optional element
-      # @param [:shift, :alt, :control, :command, :meta, 'a'] key The modifier key to release.
-      # @param [Symbol || String] device optional name of the KeyInput device to release the key on
-      # @return [W3CActionBuilder] A self reference.
+      # @overload key_up(key, device: nil)
+      #   @param [Symbol, String] key The key to press
+      #   @param [Symbol, String] device Optional name of the KeyInput device to press the key on
+      # @overload key_up(element, key, device: nil)
+      #   @param [Element] element An optional element to move to first
+      #   @param [Symbol, String] key The key to release
+      #   @param [Symbol, String] device Optional name of the KeyInput device to release the key on
+      # @return [W3CActionBuilder] A self reference
       #
 
       def key_up(*args, device: nil)
@@ -83,10 +91,14 @@ module Selenium
       #
       #   driver.action.send_keys("help").perform
       #
-      # @param [Selenium::WebDriver::Element] element An optional element
-      # @param [String] keys The keys to be sent.
-      # @param [Symbol || String] device optional name of the KeyInput device to send keys with
-      # @return [W3CActionBuilder] A self reference.
+      # @overload send_keys(keys, device: nil)
+      #   @param [Array, Symbol, String] keys The key(s) to press and release
+      #   @param [Symbol, String] device Optional name of the KeyInput device to press and release the keys on
+      # @overload send_keys(element, keys, device: nil)
+      #   @param [Element] element An optional element to move to first
+      #   @param [Array, Symbol, String] keys The key(s) to press and release
+      #   @param [Symbol, String] device Optional name of the KeyInput device to press and release the keys on
+      # @return [W3CActionBuilder] A self reference
       #
 
       def send_keys(*args, device: nil)
@@ -100,6 +112,27 @@ module Selenium
 
       private
 
+      #
+      # @api private
+      #
+      # @overload key_down(key, action: nil, device: nil)
+      #   @param [Symbol, String] key The key to press
+      #   @param [Symbol] action The name of the key action to perform
+      #   @param [Symbol, String] device Optional name of the KeyInput device to press the key on
+      # @overload key_down(element, key, action: nil, device: nil)
+      #   @param [Element] element An optional element to move to first
+      #   @param [Symbol, String] key The key to press
+      #   @param [Symbol] action The name of the key action to perform
+      #   @param [Symbol, String] device Optional name of the KeyInput device to press the key on
+      #
+      # @param [Array] args
+      # @option args [Element] element An optional element to move to first
+      # @option args [Symbol, String] key The key to perform the action with
+      # @param [Symbol] action The name of the key action to perform
+      # @param [Symbol, String] device optional name of the KeyInput device to press the key on
+      # @return [W3CActionBuilder] A self reference
+      #
+
       def key_action(*args, action: nil, device: nil)
         key_input = get_device(device) || key_inputs.first
         click(args.shift) if args.first.is_a? Element

data/lib/selenium/webdriver/common/logger.rb

@@ -0,0 +1,79 @@
+# encoding: utf-8
+#
+# Licensed to the Software Freedom Conservancy (SFC) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The SFC licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+require 'forwardable'
+require 'logger'
+
+module Selenium
+  module WebDriver
+    #
+    # @example Enable full logging
+    #   Selenium::WebDriver.logger.level = :debug
+    #
+    # @example Log to file
+    #   Selenium::WebDriver.logger.output = 'selenium.log'
+    #
+    # @example Use logger manually
+    #   Selenium::WebDriver.logger.info('This is info message')
+    #   Selenium::WebDriver.logger.warn('This is warning message')
+    #
+    class Logger
+      extend Forwardable
+
+      def_delegators :@logger, :debug, :debug?,
+                     :info, :info?,
+                     :warn, :warn?,
+                     :error, :error?,
+                     :fatal, :fatal?,
+                     :level, :level=
+
+      def initialize
+        @logger = ::Logger.new($stdout)
+        @logger.progname = 'Selenium'
+        @logger.level = ($DEBUG ? :debug : :warn)
+        @logger.formatter = proc do |severity, time, progname, msg|
+          "#{time.strftime('%F %T')} #{severity} #{progname} #{msg}\n"
+        end
+      end
+
+      def output=(io)
+        @logger.reopen(io)
+      end
+
+      #
+      # Returns IO object used by logger internally.
+      #
+      # Normally, we would have never needed it, but we want to
+      # use it as IO object for all child processes to ensure their
+      # output is redirected there.
+      #
+      # It is only used in debug level, in other cases output is suppressed.
+      #
+      # @api private
+      #
+      def io
+        if debug?
+          @logger.instance_variable_get(:@logdev).instance_variable_get(:@dev)
+        else
+          File.new(Platform.null_device, 'w')
+        end
+      end
+    end # Logger
+  end # WebDriver
+end # Selenium

data/lib/selenium/webdriver/common/port_prober.rb

@@ -47,7 +47,7 @@ module Selenium
           begin
             TCPServer.new(host, port).close
           rescue *IGNORED_ERRORS => ex
-            $stderr.puts "port prober could not bind to #{host}:#{port} (#{ex.message})" if $DEBUG
+            WebDriver.logger.info("port prober could not bind to #{host}:#{port} (#{ex.message})")
             # ignored - some machines appear unable to bind to some of their interfaces
           end
         end

data/lib/selenium/webdriver/common/search_context.rb

@@ -35,20 +35,23 @@ module Selenium
       }.freeze
 
       #
-      # Find the first element matching the given arguments.
+      # Find the first element matching the given arguments
       #
       # When using Element#find_element with :xpath, be aware that webdriver
       # follows standard conventions: a search prefixed with "//" will search
       # the entire document, not just the children of this current node. Use
       # ".//" to limit your search to the children of the receiving Element.
       #
-      # @param [:class, :class_name, :css, :id, :link_text, :link, :partial_link_text, :name, :tag_name, :xpath] how
-      # @param [String] what
+      # @overload find_element(how, what)
+      #   @param [Symbol, String] how The method to find the element by
+      #   @param [String] what The locator to use
+      # @overload find_element(opts)
+      #   @param [Hash] opts Find options
+      #   @option opts [Symbol] :how Key named after the method to find the element by, containing the locator
       # @return [Element]
       #
       # @raise [Error::NoSuchElementError] if the element doesn't exist
       #
-      #
 
       def find_element(*args)
         how, what = extract_args(args)
@@ -67,10 +70,6 @@ module Selenium
       #
       # @see SearchContext#find_element
       #
-      # @param [:class, :class_name, :css, :id, :link_text, :link, :partial_link_text, :name, :tag_name, :xpath] how
-      # @param [String] what
-      # @return [Array<Element>]
-      #
 
       def find_elements(*args)
         how, what = extract_args(args)

data/lib/selenium/webdriver/common/socket_lock.rb

@@ -65,7 +65,7 @@ module Selenium
 
         true
       rescue SocketError, Errno::EADDRINUSE, Errno::EBADF => ex
-        $stderr.puts "#{self}: #{ex.message}" if $DEBUG
+        WebDriver.logger.info("#{self}: #{ex.message}")
         false
       end
 

data/lib/selenium/webdriver/common/socket_poller.rb

@@ -90,7 +90,7 @@ module Selenium
           true
         rescue *NOT_CONNECTED_ERRORS
           sock.close if sock
-          $stderr.puts [@host, @port].inspect if $DEBUG
+          WebDriver.logger.info("polling for socket on #{[@host, @port].inspect}")
           false
         end
       end

data/lib/selenium/webdriver/edge/service.rb

@@ -37,9 +37,8 @@ module Selenium
 
         def start_process
           server_command = [@executable_path, "--port=#{@port}", *@extra_args]
-          @process       = ChildProcess.build(*server_command)
-
-          @process.io.inherit! if $DEBUG
+          @process = ChildProcess.build(*server_command)
+          @process.io.stdout = @process.io.stderr = WebDriver.logger.io
           @process.start
         end
 

data/lib/selenium/webdriver/firefox/binary.rb

@@ -77,7 +77,7 @@ module Selenium
         def execute(*extra_args)
           args = [self.class.path, '-no-remote'] + extra_args
           @process = ChildProcess.build(*args)
-          @process.io.inherit! if $DEBUG
+          @process.io.stdout = @process.io.stderr = WebDriver.logger.io
           @process.start
         end
 

data/lib/selenium/webdriver/firefox/profile.rb

@@ -214,7 +214,7 @@ module Selenium
           destination = File.join(directory, 'extensions')
 
           @extensions.each do |name, extension|
-            p extension: name if $DEBUG
+            WebDriver.logger.info({extenstion: name}.inspect)
             extension.write_to(destination)
           end
         end

data/lib/selenium/webdriver/firefox/service.rb

@@ -41,29 +41,11 @@ module Selenium
 
         def start_process
           server_command = [@executable_path, "--binary=#{Firefox::Binary.path}", "--port=#{@port}", *@extra_args]
-          @process       = ChildProcess.build(*server_command)
-
-          if $DEBUG
-            @process.io.inherit!
-          elsif Platform.windows?
-            # workaround stdio inheritance issue
-            # https://github.com/mozilla/geckodriver/issues/48
-            @process.io.stdout = @process.io.stderr = File.new(Platform.null_device, 'w')
-          end
-
+          @process = ChildProcess.build(*server_command)
+          @process.io.stdout = @process.io.stderr = WebDriver.logger.io
           @process.start
         end
 
-        def stop_process
-          super
-          return unless Platform.windows? && !$DEBUG
-          begin
-            @process.io.close
-          rescue
-            nil
-          end
-        end
-
         def cannot_connect_error_text
           "unable to connect to Mozilla geckodriver #{@host}:#{@port}"
         end

data/lib/selenium/webdriver/ie/service.rb

@@ -37,9 +37,8 @@ module Selenium
 
         def start_process
           server_command = [@executable_path, "--port=#{@port}", *@extra_args]
-          @process       = ChildProcess.new(*server_command)
-
-          @process.io.inherit! if $DEBUG
+          @process = ChildProcess.new(*server_command)
+          @process.io.stdout = @process.io.stderr = WebDriver.logger.io
           @process.start
         end
 

data/lib/selenium/webdriver/phantomjs/service.rb

@@ -34,27 +34,10 @@ module Selenium
         def start_process
           server_command = [@executable_path, "--webdriver=#{@port}", *@extra_args]
           @process = ChildProcess.build(*server_command.compact)
-
-          if $DEBUG
-            @process.io.inherit!
-          elsif Platform.jruby?
-            # apparently we need to read the output for phantomjs to work on jruby
-            @process.io.stdout = @process.io.stderr = File.new(Platform.null_device, 'w')
-          end
-
+          @process.io.stdout = @process.io.stderr = WebDriver.logger.io
           @process.start
         end
 
-        def stop_process
-          super
-          return unless Platform.jruby? && !$DEBUG
-          begin
-            @process.io.close
-          rescue
-            nil
-          end
-        end
-
         def cannot_connect_error_text
           "unable to connect to phantomjs @ #{uri} after #{START_TIMEOUT} seconds"
         end

data/lib/selenium/webdriver/remote/bridge.rb

@@ -33,11 +33,7 @@ module Selenium
         attr_reader :capabilities
 
         #
-        # Initializes the bridge with the given server URL.
-        #
-        # @param url         [String] url for the remote server
-        # @param http_client [Object] an HTTP client instance that implements the same protocol as Http::Default
-        # @param desired_capabilities [Capabilities] an instance of Remote::Capabilities describing the capabilities you want
+        # @see W3CBridge#Initialize
         #
 
         def initialize(opts = {})
@@ -665,7 +661,7 @@ module Selenium
             raise ArgumentError, "#{opts.inspect} invalid for #{command.inspect}"
           end
 
-          puts "-> #{verb.to_s.upcase} #{path}" if $DEBUG
+          WebDriver.logger.info("-> #{verb.to_s.upcase} #{path}")
           http.call verb, path, command_hash
         end
 

data/lib/selenium/webdriver/remote/http/common.rb

@@ -51,10 +51,8 @@ module Selenium
               headers['Content-Type']   = "#{CONTENT_TYPE}; charset=utf-8"
               headers['Content-Length'] = payload.bytesize.to_s if [:post, :put].include?(verb)
 
-              if $DEBUG
-                puts "   >>> #{url} | #{payload}"
-                puts "     > #{headers.inspect}"
-              end
+              WebDriver.logger.info("   >>> #{url} | #{payload}")
+              WebDriver.logger.info("     > #{headers.inspect}")
             elsif verb == :post
               payload = '{}'
               headers['Content-Length'] = '2'
@@ -78,7 +76,7 @@ module Selenium
             code = code.to_i
             body = body.to_s.strip
             content_type = content_type.to_s
-            puts "<- #{body}\n" if $DEBUG
+            WebDriver.logger.info("<- #{body}")
 
             if content_type.include? CONTENT_TYPE
               raise Error::WebDriverError, "empty body: #{content_type.inspect} (#{code})\n#{body}" if body.empty?

data/lib/selenium/webdriver/remote/http/curb.rb

@@ -85,7 +85,7 @@ module Selenium
               c.max_redirects   = MAX_REDIRECTS
               c.follow_location = true
               c.timeout         = @timeout if @timeout
-              c.verbose         = $DEBUG
+              c.verbose         = WebDriver.logger.info?
 
               c
             )

data/lib/selenium/webdriver/remote/w3c_bridge.rb

@@ -36,11 +36,12 @@ module Selenium
         attr_reader :capabilities
 
         #
-        # Initializes the bridge with the given server URL.
-        #
-        # @param url         [String] url for the remote server
-        # @param http_client [Object] an HTTP client instance that implements the same protocol as Http::Default
-        # @param desired_capabilities [Capabilities] an instance of Remote::Capabilities describing the capabilities you want
+        # Initializes the bridge with the given server URL
+        # @param [Hash] opts options for the driver
+        # @option opts [String] :url url for the remote server
+        # @option opts [Integer] :port port number for the remote server
+        # @option opts [Object] :http_client an HTTP client instance that implements the same protocol as Http::Default
+        # @option opts [Capabilities] :desired_capabilities an instance of Remote::Capabilities describing the capabilities you want
         #
 
         def initialize(opts = {})
@@ -621,7 +622,7 @@ module Selenium
             raise ArgumentError, "#{opts.inspect} invalid for #{command.inspect}"
           end
 
-          puts "-> #{verb.to_s.upcase} #{path}" if $DEBUG
+          WebDriver.logger.info("-> #{verb.to_s.upcase} #{path}")
           http.call verb, path, command_hash
         end
 

data/lib/selenium/webdriver/safari/service.rb

@@ -47,9 +47,8 @@ module Selenium
 
         def start_process
           server_command = [@executable_path, "--port=#{@port}", *@extra_args]
-          @process       = ChildProcess.build(*server_command)
-
-          @process.io.inherit! if $DEBUG
+          @process = ChildProcess.build(*server_command)
+          @process.io.stdout = @process.io.stderr = WebDriver.logger.io
           @process.start
         end
 

data/selenium-webdriver.gemspec

@@ -5,7 +5,7 @@ raise "cwd must be #{root} when reading gemspec" if root != Dir.pwd
 
 Gem::Specification.new do |s|
   s.name = 'selenium-webdriver'
-  s.version = '3.1.0'
+  s.version = '3.2.0'
 
   s.authors = ['Alex Rodionov', 'Titus Fortner']
   s.email = ['p0deje@gmail.com', 'titusfortner@gmail.com']
@@ -26,7 +26,7 @@ HTML of the application.'
   s.add_runtime_dependency 'childprocess', ['~> 0.5']
   s.add_runtime_dependency 'websocket', ['~> 1.0']
 
-  s.add_development_dependency 'rspec', ['< 3.5']
+  s.add_development_dependency 'rspec', ['~> 3.0']
   s.add_development_dependency 'rack', ['~> 1.0']
   s.add_development_dependency 'ci_reporter', ['~> 1.6', '>= 1.6.2']
   s.add_development_dependency 'webmock', ['~> 2.0']

metadata

@@ -2,7 +2,7 @@
 name: selenium-webdriver
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 3.1.0
+  version: 3.2.0
 platform: ruby
 authors: 
   - Alex Rodionov
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2017-02-14 00:00:00 -06:00
+date: 2017-02-23 00:00:00 -06:00
 default_executable: 
 dependencies: 
   - !ruby/object:Gem::Dependency 
@@ -53,9 +53,9 @@ dependencies:
     requirement: &id004 !ruby/object:Gem::Requirement 
       none: false
       requirements: 
-        - - <
+        - - ~>
           - !ruby/object:Gem::Version 
-            version: "3.5"
+            version: "3.0"
     type: :development
     version_requirements: *id004
   - !ruby/object:Gem::Dependency 
@@ -151,6 +151,7 @@ files:
   - lib/selenium/webdriver/common/keyboard.rb
   - lib/selenium/webdriver/common/keys.rb
   - lib/selenium/webdriver/common/log_entry.rb
+  - lib/selenium/webdriver/common/logger.rb
   - lib/selenium/webdriver/common/logs.rb
   - lib/selenium/webdriver/common/mouse.rb
   - lib/selenium/webdriver/common/navigation.rb