selenium-webdriver 3.12.0 → 3.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1e7904f54f32f24552260a185e59adae4f08dc44
-  data.tar.gz: 4983d6f3db1619a3cad1686235dc2fc3bcbe9857
+  metadata.gz: a6e897acdd72c3d8d0e246985f91744dc7e6ea1e
+  data.tar.gz: 0fa878705e019d7af8ff26a10405ea3ebf38f5ae
 SHA512:
-  metadata.gz: fd65f44de6eb59601fee4816fb1439f7fc3d225291a6662a5d845f5b9d33fbadd2dd718c09b9a7a430be3068630c939e15040c3e99ae711eab572ceb4ccb8f3e
-  data.tar.gz: da56a1181546a60011aa218c40adba5b08fa66ef00082bb7fb3c74f147b4ea73f8d79b8b93ce19449d5ac5bfc6d3174a18e7034cbb653450475f771fdc4dfb07
+  metadata.gz: 9a20b24a1b499183f484a9efb95ba3cc58697eefc5d873d4f06a6189e70b0b56dac1409446bbd7854bd282451ab7d97d7811750593c4a6d0a25cd86ba2554dfc
+  data.tar.gz: 399698c8a1800e9e28c2f63cdf85c7f98ca24ec8aa3afb8b06a795de1111deb61b9e74276d961302d773469797f1caeece98add4f3051e9c5862ff8e3753456e

data/CHANGES

@@ -1,3 +1,14 @@
+3.13.0 (2018-06-25)
+===================
+
+Ruby:
+  * Address warnings for redefined methods and uninitialized instance variables
+
+Chrome:
+  * Chrome options capabilities updated to use goog:chromeOptions.
+    Note that Selenium now requires ChromeDriver v2.31 at minimum.
+  * Added ability to tell headless Chrome to save files using Driver#download_path= (thanks @pelly)
+
 3.12.0 (2018-05-08)
 ===================
 

data/LICENSE

@@ -187,7 +187,7 @@
       same "printed page" as the copyright notice for easier
       identification within third-party archives.
 
-   Copyright 2016 Software Freedom Conservancy (SFC)
+   Copyright 2018 Software Freedom Conservancy (SFC)
 
    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.

data/lib/selenium/webdriver/chrome/bridge.rb

@@ -22,7 +22,8 @@ module Selenium
 
         COMMANDS = {
           get_network_conditions: [:get, '/session/:session_id/chromium/network_conditions'.freeze],
-          set_network_conditions: [:post, '/session/:session_id/chromium/network_conditions'.freeze]
+          set_network_conditions: [:post, '/session/:session_id/chromium/network_conditions'.freeze],
+          send_command: [:post, '/session/:session_id/chromium/send_command'.freeze]
         }.freeze
 
         def commands(command)
@@ -33,6 +34,10 @@ module Selenium
           execute :get_network_conditions
         end
 
+        def send_command(command_params)
+          execute :send_command, {}, command_params
+        end
+
         def network_conditions=(conditions)
           execute :set_network_conditions, {}, {network_conditions: conditions}
         end

data/lib/selenium/webdriver/chrome/driver.rb

@@ -29,6 +29,7 @@ module Selenium
         include DriverExtensions::HasTouchScreen
         include DriverExtensions::HasWebStorage
         include DriverExtensions::TakesScreenshot
+        include DriverExtensions::DownloadsFiles
 
         def initialize(opts = {})
           opts[:desired_capabilities] = create_capabilities(opts)
@@ -102,7 +103,7 @@ module Selenium
           end
 
           options = options.as_json
-          caps[:chrome_options] = options unless options.empty?
+          caps.merge!(options) unless options.empty?
 
           caps[:proxy] = opts.delete(:proxy) if opts.key?(:proxy)
           caps[:proxy] ||= opts.delete('proxy') if opts.key?('proxy')

data/lib/selenium/webdriver/chrome/options.rb

@@ -22,6 +22,8 @@ module Selenium
         attr_reader :args, :prefs, :options, :emulation, :extensions, :encoded_extensions
         attr_accessor :binary
 
+        KEY = 'goog:chromeOptions'.freeze
+
         #
         # Create a new Options instance.
         #
@@ -175,7 +177,8 @@ module Selenium
           opts[:extensions] = extensions if extensions.any?
           opts[:mobileEmulation] = @emulation unless @emulation.empty?
           opts[:prefs] = @prefs unless @prefs.empty?
-          opts
+
+          {KEY => opts}
         end
       end # Options
     end # Chrome

data/lib/selenium/webdriver/chrome/profile.rb

@@ -77,7 +77,7 @@ module Selenium
 
           extensions.concat(@encoded_extensions)
 
-          opts = {directory: @directory || layout_on_disk}
+          opts = {directory: directory || layout_on_disk}
           opts[:extensions] = extensions if extensions.any?
           opts
         end

data/lib/selenium/webdriver/common.rb

@@ -50,6 +50,7 @@ require 'selenium/webdriver/common/html5/session_storage'
 require 'selenium/webdriver/common/driver_extensions/takes_screenshot'
 require 'selenium/webdriver/common/driver_extensions/rotatable'
 require 'selenium/webdriver/common/driver_extensions/has_web_storage'
+require 'selenium/webdriver/common/driver_extensions/downloads_files'
 require 'selenium/webdriver/common/driver_extensions/has_location'
 require 'selenium/webdriver/common/driver_extensions/has_session_id'
 require 'selenium/webdriver/common/driver_extensions/has_touch_screen'

data/lib/selenium/webdriver/common/driver_extensions/downloads_files.rb

@@ -0,0 +1,43 @@
+# Licensed to the Software Freedom Conservancy (SFC) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The SFC licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+module Selenium
+  module WebDriver
+    module DriverExtensions
+      module DownloadsFiles
+
+        #
+        # Sets download path for Chromium.
+        #
+        # @param [String] path
+        #
+
+        def download_path=(path)
+          params = {
+            'cmd' => 'Page.setDownloadBehavior',
+            'params' => {
+              'behavior' => 'allow',
+              'downloadPath' => path
+            }
+          }
+          @bridge.send_command(params)
+        end
+
+      end # DownloadsFiles
+    end # DriverExtensions
+  end # WebDriver
+end # Selenium

data/lib/selenium/webdriver/common/service.rb

@@ -129,7 +129,7 @@ module Selenium
       end
 
       def process_running?
-        @process && @process.alive?
+        defined?(@process) && @process && @process.alive?
       end
 
       def process_exited?

data/lib/selenium/webdriver/remote/capabilities.rb

@@ -37,10 +37,13 @@ module Selenium
         }.freeze
 
         DEFAULTS.each_key do |key|
-          define_method key do
-            @capabilities.fetch(key)
+          if key != :javascript_enabled
+            define_method key do
+              @capabilities.fetch(key)
+            end
           end
 
+          next if key == :proxy
           define_method "#{key}=" do |value|
             @capabilities[key] = value
           end

data/lib/selenium/webdriver/remote/w3c/capabilities.rb

@@ -60,6 +60,7 @@ module Selenium
               @capabilities.fetch(key)
             end
 
+            next if key == :proxy
             define_method "#{key}=" do |value|
               @capabilities[key] = value
             end

data/lib/selenium/webdriver/version.rb

@@ -17,6 +17,6 @@
 
 module Selenium
   module WebDriver
-    VERSION = '3.12.0'.freeze
+    VERSION = '3.13.0'.freeze
   end # WebDriver
 end # Selenium

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: selenium-webdriver
 version: !ruby/object:Gem::Version
-  version: 3.12.0
+  version: 3.13.0
 platform: ruby
 authors:
 - Alex Rodionov
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-05-08 00:00:00.000000000 Z
+date: 2018-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -139,6 +139,7 @@ files:
 - lib/selenium/webdriver/common/alert.rb
 - lib/selenium/webdriver/common/bridge_helper.rb
 - lib/selenium/webdriver/common/driver.rb
+- lib/selenium/webdriver/common/driver_extensions/downloads_files.rb
 - lib/selenium/webdriver/common/driver_extensions/has_addons.rb
 - lib/selenium/webdriver/common/driver_extensions/has_debugger.rb
 - lib/selenium/webdriver/common/driver_extensions/has_location.rb