selenium-webdriver 2.53.0 → 2.53.1

data/CHANGES

@@ -1,16 +1,16 @@
-2.53.0 (2016-03-15)
+2.53.1 (2016-06-09)
+===================
+
+Firefox:
+  * Support for latest geckodriver (formerly wires)
+  * Escape selector when converting to CSS (issue 2235)
+
+2.53.0 (2016-03-16)
 ===================
 
 Ruby:
   * Removed dependency on "multi_json" (issue 1632)
   * Properly handle namespaces in install manifest of Firefox add-ons (issue 1143)
-  * Improve error handling when stopping browsers (thanks bsedat)
-  * Fix deselecting options in select lists (thanks glib-briia)
-  * Fix w3c error handling
-  * Update w3c Capabilities support
-
-IE:
-  * support for alert credentials (issue #1698, thanks Alan Baird & trabulmonkee)
 
 2.52.0 (2016-02-12)
 ===================

data/lib/selenium/webdriver/common/platform.rb

@@ -168,7 +168,8 @@ module Selenium
 
         binary_names.each do |binary_name|
           paths.each do |path|
-            exe = File.join(path, binary_name)
+            exe = Dir.glob(File.join(path, binary_name)).first
+            next unless exe
             return exe if File.executable?(exe)
           end
         end

data/lib/selenium/webdriver/firefox/service.rb

@@ -29,11 +29,11 @@ module Selenium
         SOCKET_LOCK_TIMEOUT = 45
         STOP_TIMEOUT        = 5
         DEFAULT_PORT        = 4444
-        MISSING_TEXT        = "Unable to find Mozilla Wires. Please download the executable from https://github.com/jgraham/wires/releases"
+        MISSING_TEXT        = "Unable to find geckodriver. Please download the executable from https://github.com/mozilla/geckodriver/releases"
 
         def self.executable_path
           @executable_path ||= (
-            path = Platform.find_binary "wires"
+            path = Platform.find_binary("geckodriver*") || Platform.find_binary("wires*")
             path or raise Error::WebDriverError, MISSING_TEXT
             Platform.assert_executable path
 
@@ -109,7 +109,7 @@ module Selenium
           @socket_poller = SocketPoller.new @host, @port, START_TIMEOUT
 
           unless @socket_poller.connected?
-            raise Error::WebDriverError, "unable to connect to Mozilla Wires #{@host}:#{@port}"
+            raise Error::WebDriverError, "unable to connect to Mozilla geckodriver #{@host}:#{@port}"
           end
         end
 

data/lib/selenium/webdriver/remote/w3c_bridge.rb

@@ -599,13 +599,13 @@ module Selenium
           case how
           when 'class name'
             how = 'css selector'
-            what = ".#{what}"
+            what = ".#{escape_css(what)}"
           when 'id'
             how = 'css selector'
-            what = "##{what}"
+            what = "##{escape_css(what)}"
           when 'name'
             how = 'css selector'
-            what = "*[name='#{what}']"
+            what = "*[name='#{escape_css(what)}']"
           when 'tag name'
             how = 'css selector'
           end
@@ -652,6 +652,20 @@ module Selenium
           @escaper ||= defined?(URI::Parser) ? URI::Parser.new : URI
         end
 
+        ESCAPE_CSS_REGEXP = /(['"\\#.:;,!?+<>=~*^$|%&@`{}\-\[\]\(\)])/
+        UNICODE_CODE_POINT = 30
+
+        # Escapes invalid characters in CSS selector.
+        # @see https://mathiasbynens.be/notes/css-escapes
+        def escape_css(string)
+          string = string.gsub(ESCAPE_CSS_REGEXP) { |match| "\\#{match}" }
+          if !string.empty? && string[0] =~ /[[:digit:]]/
+            string = "\\#{UNICODE_CODE_POINT + Integer(string[0])} #{string[1..-1]}"
+          end
+
+          string
+        end
+
       end # W3CBridge
     end # Remote
   end # WebDriver

data/lib/selenium/webdriver/remote/w3c_capabilities.rb

@@ -32,15 +32,12 @@ module Selenium
           :platform_name => :any,
           :platform_version => :any,
           :accept_ssl_certs => false,
-          :takes_screenshot => false,
-          :takes_element_screenshot => false,
           :page_load_strategy => 'normal',
           :proxy => nil
         }
 
         KNOWN = [
             :remote_session_id,
-            :specification_level,
             :xul_app_id,
             :raise_accessibility_exceptions,
             :rotatable,
@@ -113,8 +110,6 @@ module Selenium
             caps.platform_name = data.delete("platformName") if data.key? "platformName"
             caps.platform_version = data.delete("platformVersion") if data.key? "platformVersion"
             caps.accept_ssl_certs = data.delete("acceptSslCerts") if data.key? "acceptSslCerts"
-            caps.takes_screenshot = data.delete("takesScreenshot") if data.key? "takesScreenshot"
-            caps.takes_element_screenshot = data.delete("takesElementScreenshot") if data.key? "takesElementScreenshot"
             caps.page_load_strategy = data.delete("pageLoadStrategy") if data.key? "pageloadStrategy"
             proxy = data.delete('proxy')
             caps.proxy = Proxy.json_create(proxy) unless proxy.nil? || proxy.empty?
@@ -127,7 +122,6 @@ module Selenium
             data.delete('cssSelectorsEnabled')
 
             # Marionette Specific
-            caps[:specification_level] = data.delete("specificationLevel")
             caps[:xul_app_id] = data.delete("XULappId")
             caps[:raise_accessibility_exceptions] = data.delete('raisesAccessibilityExceptions')
             caps[:rotatable] = data.delete('rotatable')
@@ -146,8 +140,6 @@ module Selenium
         # @option :platform_name            [Symbol] one of :any, :win, :mac, or :x
         # @option :platform_version         [String] required platform version number
         # @option :accept_ssl_certs         [Boolean] does the driver accept SSL Cerfifications?
-        # @option :takes_screenshot         [Boolean] can this driver take screenshots?
-        # @option :takes_element_screenshot [Boolean] can this driver take element screenshots?
         # @option :proxy                    [Selenium::WebDriver::Proxy, Hash] proxy configuration
         #
         # @api public

data/selenium-webdriver.gemspec

@@ -7,7 +7,7 @@ end
 
 Gem::Specification.new do |s|
   s.name    = "selenium-webdriver"
-  s.version = "2.53.0"
+  s.version = "2.53.1"
 
   s.authors     = ["Jari Bakken"]
   s.email       = "jari.bakken@gmail.com"

metadata

@@ -2,7 +2,7 @@
 name: selenium-webdriver
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 2.53.0
+  version: 2.53.1
 platform: ruby
 authors: 
   - Jari Bakken
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2016-03-15 00:00:00 -05:00
+date: 2016-06-09 00:00:00 -07:00
 default_executable: 
 dependencies: 
   - !ruby/object:Gem::Dependency 
@@ -118,7 +118,6 @@ extra_rdoc_files: []
 files: 
   - CHANGES
   - Gemfile
-  - Gemfile.lock
   - LICENSE
   - README.md
   - selenium-webdriver.gemspec

data/Gemfile.lock

@@ -1,53 +0,0 @@
-PATH
-  remote: .
-  specs:
-    selenium-webdriver (2.53.0dev)
-      childprocess (~> 0.5)
-      rubyzip (~> 1.0)
-      websocket (~> 1.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    addressable (2.4.0)
-    builder (3.2.2)
-    childprocess (0.5.9)
-      ffi (~> 1.0, >= 1.0.11)
-    ci_reporter (1.9.3)
-      builder (>= 2.1.2)
-    crack (0.4.2)
-      safe_yaml (~> 1.0.0)
-    diff-lcs (1.2.5)
-    ffi (1.9.10)
-    hashdiff (0.2.3)
-    rack (1.6.4)
-    rspec (2.99.0)
-      rspec-core (~> 2.99.0)
-      rspec-expectations (~> 2.99.0)
-      rspec-mocks (~> 2.99.0)
-    rspec-core (2.99.2)
-    rspec-expectations (2.99.2)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.99.4)
-    rubyzip (1.2.0)
-    safe_yaml (1.0.4)
-    webmock (1.22.3)
-      addressable (>= 2.3.6)
-      crack (>= 0.3.2)
-      hashdiff
-    websocket (1.2.2)
-    yard (0.8.7.6)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  ci_reporter (~> 1.6, >= 1.6.2)
-  rack (~> 1.0)
-  rspec (~> 2.99.0)
-  selenium-webdriver!
-  webmock (~> 1.7, >= 1.7.5)
-  yard (~> 0.8.7)
-
-BUNDLED WITH
-   1.11.2