selenium-client 1.2.14 → 1.2.15

data/README.markdown

@@ -10,6 +10,7 @@ Mission
  With screenshots, HTML snapshopts and log captures,
  investigating test failures becomes a breeze.
  
+
 Install It
 ==========
 
@@ -80,7 +81,7 @@ Plain API
     # Sample Ruby script using the Selenium client API
     #
     require "rubygems"
-    gem "selenium-client", ">=1.2.13"
+    gem "selenium-client", ">=1.2.15"
     require "selenium/client"
     
     begin
@@ -113,7 +114,7 @@ Writing Tests
     #
     require "test/unit"
     require "rubygems"
-    gem "selenium-client", ">=1.2.13"
+    gem "selenium-client", ">=1.2.15"
     require "selenium/client"
     
     class ExampleTest < Test::Unit::TestCase
@@ -150,8 +151,8 @@ Writing Tests
  If BDD is more your style, here is how you can achieve the same thing  using RSpec:
 
     require 'rubygems'
-    gem "rspec", "=1.1.12"
-    gem "selenium-client", ">=1.2.13"
+    gem "rspec", "=1.2.6"
+    gem "selenium-client", ">=1.2.15"
     require "selenium/client"
     require "selenium/rspec/spec_helper"
     
@@ -218,8 +219,12 @@ Start/Stop a Selenium Remote Control Server
       rc.port = 4444
       rc.timeout_in_seconds = 3 * 60
     end
-    
- Check out [RemoteControlStartTask](http://selenium-client.rubyforge.org/classes/Selenium/Rake/RemoteControlStartTask.html) and [RemoteControlStopTask](http://selenium-client.rubyforge.org/classes/Selenium/Rake/RemoteControlStopTask.html) for more 
+
+  If you do not explicitly specify the path to selenium remote control jar
+  it will be "auto-discovered" in `vendor` directory using the following
+  path : `vendor/selenium-remote-control/selenium-server*-standalone.jar`
+
+  Check out [RemoteControlStartTask](http://selenium-client.rubyforge.org/classes/Selenium/Rake/RemoteControlStartTask.html) and [RemoteControlStopTask](http://selenium-client.rubyforge.org/classes/Selenium/Rake/RemoteControlStopTask.html) for more 
 details. 
 
 State-of-the-Art RSpec Reporting
@@ -254,20 +259,34 @@ Grid](http://selenium-grid.openqa.org))
     require "selenium/client"
     require "selenium/rspec/spec_helper"
 
+Other Resources
+===============
+
+* Report bugs at http://github.com/ph7/selenium-client/issues
+* Browse API at http://selenium-client.rubyforge.org
+
 
 Contribute and Join the Fun!
 ============================
 
-  We welcome new features, add-ons, bug fixes, example, documentation, etc. Make the gem work the way you
-  envision!
+  We welcome new features, add-ons, bug fixes, example, documentation, 
+  etc. Make the gem work the way you envision!
+
+* Report bugs at http://github.com/ph7/selenium-client/issues
   
-* I recommend cloning the selenium-client [reference repository](http://github.com/ph7/selenium-client/tree/master)
+* I recommend cloning the selenium-client 
+  [reference repository](http://github.com/ph7/selenium-client/tree/master)
   
-* You can also check out the [RubyForge page](http://rubyforge.org/projects/selenium-client) and the [RDoc](http://selenium-client.rubyforge.org)
+* You can also check out the [RubyForge page](http://rubyforge.org/projects/selenium-client) 
+  and the [RDoc](http://selenium-client.rubyforge.org)
   
 * We also have a [continuous integration server](http://xserve.openqa.org:8080/view/Ruby%20Client)
 
 * Stories live in [Pivotal Tracker](https://www.pivotaltracker.com/projects/6280)
+* To build, run `rake clean default package`. You can then install the
+generated gem with `sudo gem install pkg/*.gem`
+* You can also run all integration tests with `rake ci:integration`
+
 
 Core Team
 =========
@@ -279,12 +298,20 @@ Contributors
 ============
   
 * Aaron Tinio (`aptinio`):
-   - Patch for more robust Selenium RC shutdown
-   - Patch to support locator including single quotes in `wait_for_...` methods
+   - More robust Selenium RC shutdown
+   - Support for locator including single quotes in `wait_for_...` methods
+   - Do not capture system state on execution errors for pending examples
+     (ExamplePendingError, NotYetImplementedError)
 
 * Rick Lee-Morlang (`rleemorlang`):
-   - Patch for incremental calls to `wait_for_text`
+   - Fix for incremental calls to `wait_for_text`
    - Regex support in `wait_for_text`
-
   
- 
+* [Paul Boone](http://www.mindbucket.com) (`paulboone`)
+   - Fixed method_missing in selenium_helper to only delegate to methods 
+     that @selenium responds to
+
+* [Adam Greene](http://blog.sweetspot.dm) (`skippy`)
+   - Added the ability to redirect output to a log file, when
+     launching Selenium Remote Control with the Rake task
+   

data/examples/rspec/google_spec.rb

@@ -1,6 +1,6 @@
 require 'rubygems'
-gem "rspec", "=1.1.12"
-gem "selenium-client", ">=1.2.13"
+gem "rspec", "=1.2.6"
+gem "selenium-client", ">=1.2.15"
 require "selenium/client"
 require "selenium/rspec/spec_helper"
 
@@ -38,4 +38,4 @@ describe "Google Search" do
 		page.element?("link=Cached").should be_true		
   end
     
-end
+end

data/examples/script/google.rb

@@ -3,7 +3,7 @@
 # Sample Ruby script using the Selenium client API
 #
 require "rubygems"
-gem "selenium-client", ">=1.2.13"
+gem "selenium-client", ">=1.2.15"
 require "selenium/client"
 
 begin

data/examples/testunit/google_test.rb

@@ -4,7 +4,7 @@
 #
 require "test/unit"
 require "rubygems"
-gem "selenium-client", ">=1.2.13"
+gem "selenium-client", ">=1.2.15"
 require "selenium/client"
 
 class ExampleTest < Test::Unit::TestCase

data/lib/selenium/client.rb

@@ -6,7 +6,8 @@ require 'net/http'
 require 'uri'
 require 'cgi'
 require "digest/md5"
-require "fileutils"
+require 'fileutils'
+require 'tmpdir'
 require File.expand_path(File.dirname(__FILE__) + '/../tcp_socket_extension')
 require File.expand_path(File.dirname(__FILE__) + '/../nautilus/shell')
 require File.expand_path(File.dirname(__FILE__) + '/command_error')

data/lib/selenium/client/base.rb

@@ -60,8 +60,16 @@ module Selenium
         not @session_id.nil?
       end
 
-      def start_new_browser_session
-        result = string_command "getNewBrowserSession", [@browser_string, @browser_url, @extension_js]
+      # Starts a new browser session (launching a new browser matching 
+      # configuration provided at driver creation time).
+      #
+      # Browser session specific option can also be provided. e.g.
+      #
+      #    driver.start_new_browser_session(:captureNetworkTraffic => true)
+      #
+      def start_new_browser_session(options={})
+        options_as_string = options.collect {|key,value| "#{key.to_s}=#{value.to_s}"}.sort.join(";")
+        result = string_command "getNewBrowserSession", [@browser_string, @browser_url, @extension_js, options_as_string]
         @session_id = result
         # Consistent timeout on the remote control and driver side.
         # Intuitive and this is what you want 90% of the time

data/lib/selenium/client/generated_driver.rb

@@ -1140,7 +1140,7 @@ module Selenium
         end
 
 
-        # Returns every instance of some attribute from all known windows.
+        # Returns an array of JavaScript property values from all known windows having one.
         #
         # 'attributeName' is name of an attribute on the windows
         def get_attribute_from_all_windows(attributeName)
@@ -1210,21 +1210,21 @@ module Selenium
         end
 
 
-        # Returns the IDs of all windows that the browser knows about.
+        # Returns the IDs of all windows that the browser knows about in an array.
         #
         def get_all_window_ids()
             return string_array_command("getAllWindowIds", [])
         end
 
 
-        # Returns the names of all windows that the browser knows about.
+        # Returns the names of all windows that the browser knows about in an array.
         #
         def get_all_window_names()
             return string_array_command("getAllWindowNames", [])
         end
 
 
-        # Returns the titles of all windows that the browser knows about.
+        # Returns the titles of all windows that the browser knows about in an array.
         #
         def get_all_window_titles()
             return string_array_command("getAllWindowTitles", [])

data/lib/selenium/client/idiomatic.rb

@@ -410,6 +410,38 @@ module Selenium
         string_array_command "getAllWindowTitles"
       end
 
+      # Returns a string representation of the network traffic seen by the
+      # browser, including headers, AJAX requests, status codes, and timings.
+      # When this function is called, the traffic log is cleared, so the
+      # returned content is only the traffic seen since the last call.
+      #
+      # The network traffic is returned in the format it was requested. Valid
+      # values are: :json, :xml, or :plain.
+      # 
+      # Warning: For browser_network_traffic to work you need to start your 
+      # browser session with the option "captureNetworkTraffic=true", which 
+      # will force ALL traffic to go to the Remote Control proxy even for
+      # more efficient browser modes like `*firefox` and `*safari`.
+      def browser_network_traffic(format = :plain)
+        raise "format must be :plain, :json, or :xml"   \
+            unless [:plain, :json, :xml].include?(format)
+              
+        remote_control_command "captureNetworkTraffic", [format.to_s]
+      end
+
+      # Allows choice of a specific XPath libraries for Xpath evualuation
+      # in the browser (e.g. to resolve XPath locators).
+      #
+      # `library_name' can be:
+      #     * :ajaxslt          : Google's library
+      #     * :javascript-xpath : Cybozu Labs' faster library
+      #     * :default          : Selenium default library.
+      def browser_xpath_library=(library_name)
+        raise "library name must be :ajaxslt, :javascript-xpath, or :default"   \
+            unless [:ajaxslt, :'javascript-xpath', :default].include?(library_name)
+        remote_control_command "useXpathLibrary", [library_name.to_s]
+      end
+
     end
   
   end

data/lib/selenium/client/protocol.rb

@@ -86,7 +86,7 @@ module Selenium
         http.open_timeout = default_timeout_in_seconds
         http.read_timeout = default_timeout_in_seconds
         response = http.post('/selenium-server/driver/', data, HTTP_HEADERS)
-        # puts "RESULT: #{response.inspect}\n"       
+        # puts "RESULT: #{response.body.inspect}\n"
         [ response.body[0..1], response.body[3..-1] ]
       end
      

data/lib/selenium/client/selenium_helper.rb

@@ -7,29 +7,27 @@ module Selenium
     
   module SeleniumHelper
     
-      # Overrides standard "open" method with @selenium.open
-      def open(addr)
-        @selenium.open(addr)
+      # Overrides default open method to actually delegates to @selenium
+      def open(url)
+        @selenium.open url
       end
     
-      # Overrides standard "type" method with @selenium.type
-      def type(inputLocator, value)
-        @selenium.type(inputLocator, value)
+      # Overrides default type method to actually delegates to @selenium
+      def type(locator, value)
+        @selenium.type locator, value
       end
     
-      # Overrides standard "select" method with @selenium.select
-      def select(inputLocator, optionLocator)
-        @selenium.select(inputLocator, optionLocator)
+      # Overrides default select method to actually delegates to @selenium
+      def select(input_locator, option_locator)
+        @selenium.select input_locator, option_locator
       end
 
-      # Passes all calls to missing methods to @selenium
+      # Delegates to @selenium on method missing 
       def method_missing(method_name, *args)
-        if args.empty?
-            @selenium.send(method_name)
-        else
-            @selenium.send(method_name, *args)
-        end
-      end      
+        return super unless @selenium.respond_to?(method_name)
+        
+        @selenium.send(method_name, *args)
+      end                  
     end
     
   end

data/lib/selenium/rake/remote_control_start_task.rb

@@ -1,16 +1,39 @@
 module Selenium
   module Rake
   
+    # Rake tasks to start a Remote Control server.
+    # 
+    # require 'selenium/rake/tasks' 
+    # 
+    # Selenium::Rake::RemoteControlStartTask.new do |rc|
+    #   rc.port = 4444
+    #   rc.timeout_in_seconds = 3 * 60
+    #   rc.background = true
+    #   rc.wait_until_up_and_running = true
+    #   rc.jar_file = "/path/to/where/selenium-rc-standalone-jar-is-installed"
+    #   rc.additional_args << "-singleWindow"
+    # end
+    # 
+    # If you do not explicitly specify the path to selenium remote control jar
+    # it will be "auto-discovered" in `vendor` directory using the following
+    # path : `vendor/selenium-remote-control/selenium-server*-standalone.jar`
+    # 
+    # To leverage all selenium-client capabilities I recommend downloading 
+    # a recent nightly build of a standalone packaging of Selenium Remote 
+    # Control. You will find the mightly build at 
+    # http://archiva.openqa.org/repository/snapshots/org/openqa/selenium/selenium-remote-control/1.0-SNAPSHOT/
     class RemoteControlStartTask
       attr_accessor :port, :timeout_in_seconds, :background, 
-                    :wait_until_up_and_running, :additional_args
+                    :wait_until_up_and_running, :additional_args,
+                    :log_to
       attr_reader :jar_file
 
       def initialize(name = :'selenium:rc:start')
         @name = name
         @port = 4444
         @timeout_in_seconds = 5
-        @jar_file = "vendor/selenium/selenium-server-1.0-standalone.jar"
+        project_specific_jar = Dir["vendor/selenium-remote-control/selenium-server*-standalone.jar"].first
+        @jar_file = project_specific_jar
         @additional_args = []
         @background = false
         @wait_until_up_and_running = false
@@ -29,6 +52,7 @@ module Selenium
           remote_control = Selenium::RemoteControl::RemoteControl.new("0.0.0.0", @port, @timeout_in_seconds)
           remote_control.jar_file = @jar_file
           remote_control.additional_args = @additional_args
+          remote_control.log_to = @log_to
           remote_control.start :background => @background
           if @background && @wait_until_up_and_running
             puts "Waiting for Remote Control to be up and running..."

data/lib/selenium/rake/remote_control_stop_task.rb

@@ -1,6 +1,14 @@
 module Selenium
   module Rake
 
+    # Rake task to stop a Selenium Remote Control Server
+    #
+    # Selenium::Rake::RemoteControlStopTask.new do |rc|
+    #   rc.host = "localhost"
+    #   rc.port = 4444
+    #   rc.timeout_in_seconds = 3 * 60
+    # end
+    #    
     class RemoteControlStopTask
       attr_accessor :host, :port, :timeout_in_seconds, :wait_until_stopped
 

data/lib/selenium/remote_control/remote_control.rb

@@ -3,7 +3,7 @@ module Selenium
     
     class RemoteControl
       attr_reader :host, :port, :timeout_in_seconds
-      attr_accessor :additional_args, :jar_file
+      attr_accessor :additional_args, :jar_file, :log_to
       
       def initialize(host, port, timeout_in_seconds = 2 * 60)
         @host, @port, @timeout_in_seconds = host, port, timeout_in_seconds
@@ -16,6 +16,7 @@ module Selenium
         command << " -port #{@port}"
         command << " -timeout #{@timeout_in_seconds}"
         command << " #{additional_args.join(' ')}" unless additional_args.empty?
+        command << " > #{log_to}" if log_to
         
         @shell.run command, {:background => options[:background]}
       end

data/lib/selenium/rspec/reporting/file_path_strategy.rb

@@ -3,9 +3,12 @@ module Selenium
     module Reporting
       
       class FilePathStrategy
-      
+        attr_reader :final_report_file_path
+
+        REPORT_DEFAULT_FILE_PATH = File.join(Dir::tmpdir, "selenium_test_report", "index.html")
+
         def initialize(final_report_file_path)
-          @final_report_file_path = final_report_file_path
+          @final_report_file_path = final_report_file_path || REPORT_DEFAULT_FILE_PATH
           @relative_dir = nil
         end
 
@@ -21,19 +24,23 @@ module Selenium
         end
 
         def relative_file_path_for_html_capture(example)
-          "#{relative_dir}/example_#{example_hash(example)}.html"
+          "#{relative_dir}/example_#{example.reporting_uid}.html"
         end
 
         def relative_file_path_for_system_screenshot(example)
-          "#{relative_dir}/example_#{example_hash(example)}_system_screenshot.png"
+          "#{relative_dir}/example_#{example.reporting_uid}_system_screenshot.png"
         end
 
         def relative_file_path_for_page_screenshot(example)
-          "#{relative_dir}/example_#{example_hash(example)}_page_screenshot.png"
+          "#{relative_dir}/example_#{example.reporting_uid}_page_screenshot.png"
         end
 
         def relative_file_path_for_remote_control_logs(example)
-          "#{relative_dir}/example_#{example_hash(example)}_remote_control.log"
+          "#{relative_dir}/example_#{example.reporting_uid}_remote_control.log"
+        end
+
+        def relative_file_path_for_browser_network_traffic(example)
+          "#{relative_dir}/example_#{example.reporting_uid}_browser_network_traffic.log"
         end
 
         def file_path_for_html_capture(example)
@@ -52,6 +59,10 @@ module Selenium
           file_path relative_file_path_for_remote_control_logs(example)
         end
 
+        def file_path_for_browser_network_traffic(example)
+          file_path relative_file_path_for_browser_network_traffic(example)
+        end
+
         def file_path(relative_file_path)
           the_file_path = base_report_dir + "/" + relative_file_path
           parent_dir = File.dirname(the_file_path)
@@ -59,14 +70,9 @@ module Selenium
           the_file_path
         end
 
-        def example_hash(example)
-          # backtrace is not reliable anymore using the implementation proc          
-          implementation = example.instance_variable_get :'@_implementation'
-          Digest::MD5.hexdigest implementation.inspect
-        end
-      
+       
       end
       
     end      
   end
-end
+end

data/lib/selenium/rspec/reporting/html_report.rb

@@ -19,7 +19,7 @@ module Selenium
         end
         
         def logs_and_screenshot_sections(example)
-          dom_id = "example_" + @file_path_strategy.example_hash(example)
+          dom_id = "example_" + example.reporting_uid
           system_screenshot_url = @file_path_strategy.relative_file_path_for_system_screenshot(example)
           page_screenshot_url = @file_path_strategy.relative_file_path_for_page_screenshot(example)
           snapshot_url = @file_path_strategy.relative_file_path_for_html_capture(example)
@@ -120,4 +120,4 @@ module Selenium
     end
     
   end
-end
+end

data/lib/selenium/rspec/reporting/selenium_test_report_formatter.rb

@@ -5,8 +5,9 @@
 #
 require "digest/md5"
 require "base64"
+require 'tmpdir'
 require "rubygems"
-gem "rspec", "1.1.12"
+gem "rspec", "1.2.6"
 require "spec"
 require 'spec/runner/formatter/html_formatter'
 require File.expand_path(File.dirname(__FILE__) + "/file_path_strategy")
@@ -18,14 +19,19 @@ module Selenium
       
     class SeleniumTestReportFormatter < Spec::Runner::Formatter::HtmlFormatter
 
+      def initialize(options, output)
+        super
+        raise "Unexpected output type #{output.inspect}" unless output.kind_of?(String)
+        @@file_path_strategy = Selenium::RSpec::Reporting::FilePathStrategy.new(output)
+      end
+
       def start(example_count)
         super
         # ensure there's at least 1 example group header (normally 0 with deep_test)
         # prevents js and html validity errors
         example_group = Object.new
         def example_group.description; ""; end
-        add_example_group(example_group)
-        @@file_path_strategy = Selenium::RSpec::Reporting::FilePathStrategy.new(@where)
+        example_group_started example_group
       end  
   
       def move_progress
@@ -36,19 +42,11 @@ module Selenium
         Selenium::RSpec::Reporting::HtmlReport.inject_placeholder(super)
       end
   
-      def example_passed(example)
-        include_example_group_description example
+      def example_pending(example_proxy, message, deprecated_pending_location=nil)
         super
       end
   
-      def example_pending(example, message, pending_caller)
-        include_example_group_description example
-        super
-      end
-  
-      def example_failed(example, counter, failure)
-        include_example_group_description example
-        
+      def example_failed(example, counter, failure)        
         old_output = @output
         @output = StringIO.new
         super
@@ -83,15 +81,7 @@ module Selenium
 	      # and RSpec reporting work for a proper fix.
 	      @@file_path_strategy ||= Selenium::RSpec::Reporting::FilePathStrategy.new(ENV["SELENIUM_TEST_REPORT_FILE"])
 	    end
-	
-      protected
-        
-      def include_example_group_description(example)
-        def example.description
-          self.class.description.to_s + " :: " + super
-        end
-      end
   
     end
   end
-end
+end

data/lib/selenium/rspec/reporting/system_capture.rb

@@ -49,7 +49,7 @@ module Selenium
           
           encodedImage = @selenium_driver.capture_screenshot_to_string
           pngImage = Base64.decode64(encodedImage)
-          File.open(@file_path_strategy.file_path_for_system_screenshot(@example), "w") { |f| f.write pngImage }
+          File.open(@file_path_strategy.file_path_for_system_screenshot(@example), "wb") { |f| f.write pngImage }
         end
 
         def capture_page_screenshot
@@ -57,7 +57,7 @@ module Selenium
           
           encodedImage = @selenium_driver.capture_entire_page_screenshot_to_string("")
           pngImage = Base64.decode64(encodedImage)
-          File.open(@file_path_strategy.file_path_for_page_screenshot(@example), "w") { |f| f.write pngImage }
+          File.open(@file_path_strategy.file_path_for_page_screenshot(@example), "wb") { |f| f.write pngImage }
         end
 
         def retrieve_remote_control_logs

data/lib/selenium/rspec/rspec_extensions.rb

@@ -1,5 +1,5 @@
 require "rubygems"
-gem "rspec", "=1.1.12"
+gem "rspec", "=1.2.6"
 require 'spec'
 require 'spec/example/example_group'
 
@@ -7,26 +7,36 @@ require 'spec/example/example_group'
 # Monkey-patch RSpec Example Group so that we can track whether an
 # example already failed or not in an after(:each) block
 #
-# useful to only capture Selenium screenshots when a test fails  
+# Useful to only capture Selenium screenshots when a test fails  
 #
-# Only changed execution_error to be an instance variable (in lieu of 
-# a local variable).
+# * Changed execution_error to be an instance variable (in lieu of 
+#   a local variable).
+#
+# * Introduced an unique id (example_uid) that is the same for 
+#   a real Example (passed in after(:each) when screenshot is 
+#   taken) as well as the corresponding ExampleProxy 
+#   (passed to the HTML formatter). This unique id gives us
+#   a way to correlate file names between generation and 
+#   reporting time.
 #
 module Spec
   module Example
-    
-    class ExampleGroup
+    module ExampleMethods
+
       attr_reader :execution_error
 
-      def execute(options, instance_variables)
-        options.reporter.example_started(self)
+      remove_method :execute
+      def execute(run_options, instance_variables) # :nodoc:
+        @_proxy.options[:actual_example] = self
+        
+        run_options.reporter.example_started(@_proxy)
         set_instance_variables_from_hash(instance_variables)
         
         @execution_error = nil
-        Timeout.timeout(options.timeout) do
+        Timeout.timeout(run_options.timeout) do
           begin
             before_each_example
-            eval_block
+            instance_eval(&@_implementation)
           rescue Exception => e
             @execution_error ||= e
           end
@@ -37,10 +47,50 @@ module Spec
           end
         end
 
-        options.reporter.example_finished(self, @execution_error)
+        run_options.reporter.example_finished(@_proxy.update(description), @execution_error)
         success = @execution_error.nil? || ExamplePendingError === @execution_error
       end
-      
+
+      def actual_failure?
+        case execution_error
+        when nil
+          false
+        when Spec::Example::ExamplePendingError, 
+             Spec::Example::PendingExampleFixedError,
+             Spec::Example::NoDescriptionError
+          false
+        else
+          true
+        end
+      end
+
+      def reporting_uid
+        # backtrace is not reliable anymore using the implementation proc          
+        Digest::MD5.hexdigest @_implementation.inspect
+      end
+
+      def pending_for_browsers(*browser_regexps, &block)
+        actual_browser = selenium_driver.browser_string
+        match_browser_regexps = browser_regexps.inject(false) do |match, regexp| 
+          match ||= actual_browser =~ Regexp.new(regexp.source, Regexp::IGNORECASE)
+        end
+        if match_browser_regexps
+          pending "#{actual_browser.gsub(/\*/, '').capitalize} does not support this feature yet"
+        else 
+          yield
+        end
+      end
+ 
     end
+
+    class ExampleProxy
+
+      def reporting_uid
+        options[:actual_example].reporting_uid
+      end
+
+    end
+
   end
 end
+

data/lib/selenium/rspec/spec_helper.rb

@@ -9,7 +9,9 @@ Spec::Runner.configure do |config|
 
   config.prepend_after(:each) do
     begin 
-      Selenium::RSpec::SeleniumTestReportFormatter.capture_system_state(selenium_driver, self) if execution_error
+      if actual_failure?
+        Selenium::RSpec::SeleniumTestReportFormatter.capture_system_state(selenium_driver, self)
+      end
       if selenium_driver.session_started?
         selenium_driver.set_context "Ending example '#{self.description}'"
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: selenium-client
 version: !ruby/object:Gem::Version 
-  version: 1.2.14
+  version: 1.2.15
 platform: ruby
 authors: 
 - OpenQA
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-03-07 23:00:00 -08:00
+date: 2009-05-12 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -54,6 +54,8 @@ files:
 - README.markdown
 has_rdoc: true
 homepage: http://selenium-client.rubyforge.com
+licenses: []
+
 post_install_message: 
 rdoc_options: 
 - --title
@@ -78,9 +80,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: selenium-client
-rubygems_version: 1.3.1
+rubygems_version: 1.3.2
 signing_key: 
-specification_version: 2
+specification_version: 3
 summary: Official Ruby Client for Selenium RC.
 test_files: 
 - test/all_unit_tests.rb