select_extra_columns 0.0.3 → 0.0.4

data/CHANGELOG.markdown

@@ -1,6 +1,11 @@
+2010-04-08
+==========
+* Added stricter validation for :extra_columns input.
+
+
 2010-03-08
 ==========
-* Added support for multiple input types for extra_columns
+* Added support for multiple input formats for :extra_columns
 
 2010-03-08
 ==========

data/README.markdown

@@ -67,9 +67,9 @@ Option accepts String/Symbol/Array/Hash as input.
 Example:
 
 	#String,Symbol format
-	:extra_columns => :first_name    # Single string field: `first_name`
+	:extra_columns => :first_name    # Single string field: `first_name`(type is inferred as string)
 	
-	:extra_columns => "first_name"   # Single string field: `first_name`
+	:extra_columns => "first_name"   # Single string field: `first_name`(type is inferred as string)
 	
 	# Hash format
 	:extra_columns => {              # Two string fields and a boolean field

data/lib/select_extra_columns.rb

@@ -63,8 +63,10 @@ module SelectExtraColumns
         extra_columns.each do |col_detail|
           col_detail = [col_detail] if col_detail.is_a?(Symbol) or col_detail.is_a?(String)
           next unless col_detail.is_a?(Array)
-          col_name, col_type = col_detail[0].to_s, (col_detail[1] || "string").to_s 
-          result << ActiveRecord::ConnectionAdapters::Column.new(col_name, nil, col_type)
+          col_name, col_type = col_detail[0], (col_detail[1] || "string") 
+          # ignore if not valid type
+          next unless [String, Symbol].include?(col_name.class) and [String, Symbol].include?(col_type.class)
+          result << ActiveRecord::ConnectionAdapters::Column.new(col_name.to_s, nil, col_type.to_s)
         end
       end
     end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 0
-  - 3
-  version: 0.0.3
+  - 4
+  version: 0.0.4
 platform: ruby
 authors: 
 - Kandada Boggu
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-08 00:00:00 -08:00
+date: 2010-03-09 00:00:00 -08:00
 default_executable: 
 dependencies: []