sections_rails 0.7.2 → 0.8.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: eeeef33448cd6b0e68ef9770dd85824fe160db3a
+  data.tar.gz: ee80965c2a0212282b1247cf8c4138b7c39690bb
+SHA512:
+  metadata.gz: 5251a0e3f15cc42a908f08b2be7f7747fb97f02dd290eb6331e9d67861f49cb1a69bfcc45778e936e0c30e4321db70b5a96c8308ebac202c92af15caeeca16b7
+  data.tar.gz: ec87d416e8e1e0c2d5296df248a1ccd83eae55b92ac1e93d2383bce2acc8869ad94be5909c6cbbb3fb1fa1cc1d2e9e69614ea38dc8ba612f929ca51698bf6ea3

data/README.md

@@ -1,4 +1,4 @@
-# Sections for Rails [![Build Status](https://travis-ci.org/kevgo/sections_rails.png?branch=master)](https://travis-ci.org/kevgo/sections_rails) [![Code Climate](https://codeclimate.com/github/kevgo/sections_rails.png)](https://codeclimate.com/github/kevgo/sections_rails) [![Coverage Status](https://coveralls.io/repos/kevgo/sections_rails/badge.png?branch=master)](https://coveralls.io/r/kevgo/sections_rails)
+# Sections for Rails [![Build Status](https://travis-ci.org/kevgo/sections_rails.png?branch=master)](https://travis-ci.org/kevgo/sections_rails) [![Code Climate](https://codeclimate.com/github/kevgo/sections_rails.png)](https://codeclimate.com/github/kevgo/sections_rails) [![Coverage Status](https://coveralls.io/repos/kevgo/sections_rails/badge.png?branch=master)](https://coveralls.io/r/kevgo/sections_rails) [![Dependency Status](https://gemnasium.com/kevgo/sections_rails.png)](https://gemnasium.com/kevgo/sections_rails)
 
 _A component-oriented infrastructure for the view layer of Ruby on Rails applications._
 
@@ -60,11 +60,11 @@ The generator
 
 *  creates a new folder __/app/sections__, in which you put the source code for the different sections.
 
-*  adds the folder _/app/sections_ to the asset pipeline by inserting this line into your _application.rb_ file:
+*  adds the folder /app/sections to the asset pipeline by inserting this line into your _application.rb_ file:
 
         config.assets.paths << 'app/sections'
 
-*  optionally creates a demo section called _hello_world_ that you can try out as described below.
+*  optionally creates a demo section called __hello_world__ that you can try out as described below.
 
 
 The current implementation requires two empty asset container files: __application_sections.js__ and __application_sections.css__.
@@ -158,9 +158,7 @@ To run your section tests using [Konacha](https://github.com/jfirebaugh/konacha)
 Feel free to send unit-tested pull requests! The unit tests of this project are run using `rake`.
 
 
-### Missing features
-
-_Sections_rails_ is far from complete. Some missing things are:
+### Roadmap
 
 * Support for multiple application assets, for example page-specific compiled asset files instead of one global one.
 * Support for serverside controller logic for sections, for example by integrating with https://github.com/apotonick/cells.

data/lib/sections_rails/section_asset_rendering.rb

@@ -51,42 +51,63 @@ module SectionsRails
       end
 
 
-      # Renders the assets of this section into the given result.
-      def render_assets result
-        render_js_assets result
-        render_css_assets result
+      # Renders the assets of this section into the given out.
+      def render_assets out
+        render_js_assets out
+        render_css_assets out
       end
 
       # Renders the CSS for this section.
-      def render_css_assets result
-        if @options.has_key? :css
-          if @options[:css]
-            # Custom filename for :css given --> include the given CSS file.
-            result << @view.stylesheet_link_tag(File.join(folder_includepath, @options[:css]))
-          else
-            # ":css => false" given --> don't include any CSS.
-          end
-        else
-          # No option for :css given --> include the default stylesheet.
-          css_includepath = find_css_includepath
-          result << @view.stylesheet_link_tag(css_includepath) if css_includepath
-        end
+      def render_css_assets out
+
+        # Handle default case if no options given.
+        return render_default_css_asset(out) unless @options.has_key? :css
+
+        # Do nothing if 'css: nil' given.
+        return unless @options[:css]
+
+        render_custom_css_asset @options[:css], out
       end
 
+
+      # Renders the CSS asset with the given filename.
+      def render_custom_css_asset filename, out
+        out << @view.stylesheet_link_tag(File.join(folder_includepath, @options[:css]))
+      end
+
+
+      # Renders the default CSS asset.
+      def render_default_css_asset out
+        css_includepath = find_css_includepath
+        out << @view.stylesheet_link_tag(css_includepath) if css_includepath
+      end
+
+
       # Renders the JS for this section.
-      def render_js_assets result
-        if @options.has_key? :js
-          if @options[:js]
-            result << @view.javascript_include_tag(File.join(folder_includepath, @options[:js]))
-          else
-            # :js => (false|nil) given --> don't include any JS.
-          end
-        else
-          # No :js configuration option given --> include the default script.
-          js_includepath = find_js_includepath
-          result << @view.javascript_include_tag(js_includepath) if js_includepath
-        end
+      def render_js_assets out
+
+        # Render default asset if no option given.
+        return render_default_js_asset(out) unless @options.has_key? :js
+
+        # Do nothing if 'js: nil' given.
+        return unless @options[:js]
+
+        render_custom_js_asset @options[:js], out
       end
+
+
+      # Renders the default JS asset.
+      def render_default_js_asset out
+        js_includepath = find_js_includepath
+        out << @view.javascript_include_tag(js_includepath) if js_includepath
+      end
+
+
+      # Renders the JS asset with the given filename.
+      def render_custom_js_asset filename, out
+        out << @view.javascript_include_tag(File.join(folder_includepath, filename))
+      end
+
     end
   end
 end

data/lib/sections_rails/version.rb

@@ -1,3 +1,3 @@
 module SectionsRails
-  VERSION = "0.7.2"
+  VERSION = "0.8.0"
 end

data/spec/controllers/image_assets_controller_spec.rb

@@ -4,9 +4,9 @@ describe ImageAssetsController do
   render_views
 
   before :each do
-    RSpec::Matchers.define :have_image_tag do |tag_name|
+    RSpec::Matchers.define :have_image_tag do |image_path|
       match do |body|
-        body =~ Regexp.new("<img.*src=\"#{tag_name}\"")
+        body =~ Regexp.new("<img.*src=\"#{image_path}\"")
       end
     end
   end

data/spec/controllers/script_assets_controller_spec.rb

@@ -6,7 +6,7 @@ describe ScriptAssetsController do
   before :each do
     RSpec::Matchers.define :have_script_tag do |tag_name|
       match do |body|
-        body =~ Regexp.new("<script.*src=\"#{tag_name}\".*<\/script>")
+        body =~ Regexp.new("<script src=.#{tag_name}")
       end
     end
   end

data/spec/controllers/style_assets_controller_spec.rb

@@ -6,7 +6,7 @@ describe StyleAssetsController do
   before :each do
     RSpec::Matchers.define :have_style_tag do |tag_name|
       match do |body|
-        body =~ Regexp.new("<link.*href=\"#{tag_name}\".*>")
+        body =~ Regexp.new("<link href=\"#{tag_name}")
       end
     end
   end

data/spec/dummy/config/application.rb

@@ -6,14 +6,24 @@ require "sprockets/railtie"
 # require 'rails/all'
 require 'haml'
 
-Bundler.require(*Rails.groups(:assets => %w(development test)))
-# require 'sections_rails'
+Bundler.require(:default, Rails.env)
+require 'sections_rails'
 
 module Dummy
   class Application < Rails::Application
-    config.encoding = "utf-8"
-    config.assets.enabled = true
-    config.assets.version = '1.0'
+    # Settings in config/environments/* take precedence over those specified here.
+    # Application configuration should go into files in config/initializers
+    # -- all .rb files in that directory are automatically loaded.
+
+    # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
+    # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
+    # config.time_zone = 'Central Time (US & Canada)'
+
+    # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
+    # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
+    # config.i18n.default_locale = :de
+
+    config.assets.paths += %w(../../app/sections)
   end
 end
 

data/spec/dummy/config/environments/development.rb

@@ -1,27 +1,24 @@
 Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb
+  # Settings specified here will take precedence over those in config/application.rb.
 
   # In the development environment your application's code is reloaded on
   # every request. This slows down response time but is perfect for development
   # since you don't have to restart the web server when you make code changes.
   config.cache_classes = false
 
-  # Log error messages when you accidentally call methods on nil.
-  config.whiny_nils = true
+  # Do not eager load code on boot.
+  config.eager_load = false
 
-  # Show full error reports and disable caching
+  # Show full error reports and disable caching.
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
 
-  # Print deprecation notices to the Rails logger
+  # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log
 
-  # Only use best-standards-support built into browsers
-  config.action_dispatch.best_standards_support = :builtin
-
-  # Do not compress assets
-  config.assets.compress = false
-
-  # Expands the lines which load the assets
+  # Debug mode disables concatenation and preprocessing of assets.
+  # This option may cause significant delays in view rendering with a large
+  # number of complex assets.
   config.assets.debug = true
 end
+

data/spec/dummy/config/environments/test.rb

@@ -1,5 +1,5 @@
 Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb
+  # Settings specified here will take precedence over those in config/application.rb.
 
   # The test environment is used exclusively to run your application's
   # test suite. You never need to work with it otherwise. Remember that
@@ -7,28 +7,31 @@ Dummy::Application.configure do
   # and recreated between test runs. Don't rely on the data there!
   config.cache_classes = true
 
-  # Configure static asset server for tests with Cache-Control for performance
-  config.serve_static_assets = true
-  config.static_cache_control = "public, max-age=3600"
+  # Do not eager load code on boot. This avoids loading your whole application
+  # just for the purpose of running a single test. If you are using a tool that
+  # preloads Rails for running tests, you may have to set it to true.
+  config.eager_load = false
 
-  # Log error messages when you accidentally call methods on nil
-  config.whiny_nils = true
+  # Configure static asset server for tests with Cache-Control for performance.
+  config.serve_static_assets  = true
+  config.static_cache_control = "public, max-age=3600"
 
-  # Show full error reports and disable caching
+  # Show full error reports and disable caching.
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
 
-  # Raise exceptions instead of rendering exception templates
+  # Raise exceptions instead of rendering exception templates.
   config.action_dispatch.show_exceptions = false
 
-  # Disable request forgery protection in test environment
-  config.action_controller.allow_forgery_protection    = false
+  # Disable request forgery protection in test environment.
+  config.action_controller.allow_forgery_protection = false
 
   # Tell Action Mailer not to deliver emails to the real world.
   # The :test delivery method accumulates sent emails in the
   # ActionMailer::Base.deliveries array.
-  #config.action_mailer.delivery_method = :test
+  # config.action_mailer.delivery_method = :test
 
-  # Print deprecation notices to the stderr
+  # Print deprecation notices to the stderr.
   config.active_support.deprecation = :stderr
 end
+

data/spec/dummy/config/initializers/secret_token.rb

@@ -0,0 +1 @@
+Dummy::Application.config.secret_key_base = 'eea8321616a4ab02c44c134c98059ad070bee6c215649081958cf30b9b96e5e740b0ac696426d61cdd68a31e00909feac9369a627c1f618bb7274de785ca58a0'

data/spec/dummy/config/routes.rb

@@ -1,4 +1,4 @@
 Dummy::Application.routes.draw do
-  match ':controller(/:action)'
+  get ':controller(/:action)'
 end