second_level_cache 2.2.1 → 2.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 08afc3105b0fd6181f8c5fa0deeed4c6af159e48
-  data.tar.gz: 591668829c848cd26c9c7ca7ecb7edda0a5378ad
+  metadata.gz: 88a2a566c9af218fbcb4ba47cde3b0dddfcedc2b
+  data.tar.gz: 36e45a2c4efa464094022cab997b0ece390d164b
 SHA512:
-  metadata.gz: c913f07951f4c923a33580ea6576e03ba4cc30ade72ac4451adaf1b82690e3ffd3f1879ac6fd3f645ea5ec6142b3ec9e52992ecabfb650a89f76e609116cd323
-  data.tar.gz: cbf1edab3ddabb33d5f3a12f234ee29657d232985df41018aaecbcd2aeb614be09536b5e93c6f8ba0fbd16928cadcbaa2d771c7680411ef7e8c904ddf7f2aa3d
+  metadata.gz: 2e501d209a3b2f6d9790fc813a558cea3a944457fdbda0b0d657835e30193a4592585e0a22b8f9e957298cf381e3bc902832ee11eecc69e323432d26ff934597
+  data.tar.gz: 0051c2f3c1e1110dc7088ffb2b1451e095a7872291e8efc04e42ecf68bb6fdcbfe7545e0e3d71379902495d488b5f562871dde3c3f0a148600a24db25329ddf2

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+2.2.2
+-----
+
+* Add `where(id: n).first`, `where(id: n).last` hit cache support. This improve will avoid some gems query database, for example: [devise](https://github.com/plataformatec/devise) `current_user` method.
+
 2.2.1
 -----
 

data/README.md

@@ -50,6 +50,7 @@ Then it will fetch cached object in this situations:
 User.find(1)
 user.articles.find(1)
 User.where(status: 1).find(1)
+User.where(id: 1).first # or .last
 article.user
 ```
 

data/lib/second_level_cache/active_record/finder_methods.rb

@@ -2,7 +2,7 @@ module SecondLevelCache
   module ActiveRecord
     module FinderMethods
       # TODO: find_some
-      # https://github.com/rails/rails/blob/master/activerecord/lib/active_record/relation/finder_methods.rb#L289-L309
+      # http://api.rubyonrails.org/classes/ActiveRecord/FinderMethods.html#method-i-find_one
       #
       # Cacheable:
       #
@@ -34,6 +34,31 @@ module SecondLevelCache
         record
       end
 
+      # http://api.rubyonrails.org/classes/ActiveRecord/FinderMethods.html#method-i-first
+      #
+      # Cacheable:
+      #
+      #     User.where(id: 1).first
+      #     User.where(id: 1).last
+      #
+      # Uncacheable:
+      #
+      #     User.where(name: 'foo').first
+      #     User.where(age: 18).first
+      #
+      def first(limit = nil)
+        return super(limit) if limit.to_i > 1
+        # only have primary_key condition in where
+        if where_values_hash.length == 1 && where_values_hash.key?(primary_key)
+          record = @klass.read_second_level_cache(where_values_hash[primary_key])
+          return record if record
+        end
+
+        record = super(limit)
+        record.write_second_level_cache if record
+        record
+      end
+
       private
 
       def cachable?

data/lib/second_level_cache/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SecondLevelCache
-  VERSION = '2.2.1'.freeze
+  VERSION = '2.2.2'.freeze
 end

data/test/finder_methods_test.rb

@@ -40,4 +40,18 @@ class FinderMethodsTest < ActiveSupport::TestCase
     end
     refute_equal @user.name, @from_db.name
   end
+
+  def test_where_and_first_should_with_cache
+    @user.write_second_level_cache
+    assert_no_queries do
+      assert_equal @user, User.where(id: @user.id).first
+    end
+  end
+
+  def test_where_and_last_should_with_cache
+    @user.write_second_level_cache
+    assert_no_queries do
+      assert_equal @user, User.where(id: @user.id).last
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: second_level_cache
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.2.2
 platform: ruby
 authors:
 - Hooopo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-17 00:00:00.000000000 Z
+date: 2016-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -187,7 +187,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: 'SecondLevelCache is a write-through and read-through caching library inspired