sec_id 2.0.1 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 39592f5327accec4a952728b6a609c9c2e91adce7fe3097ee7aa980631ed89d9
-  data.tar.gz: e24a61f1e3ebe25096b53c8a59bce72cbb1049fb751fee5b1f7c517aa57e3712
+  metadata.gz: 7aeb4ad8258b298a785df7243f6f7a5186b11cad7f8feaf643a2b9e367a027b2
+  data.tar.gz: 4aed13a00f680c41e9b87483dee8ce97cc6bd0a2369174e425efe288c477bc88
 SHA512:
-  metadata.gz: 87f2852f2c8fae7dcd46e0a731c38df333e210328963f64ce21dab8e4fe9529837740b15681eab82e2c3aeb7129a954d0fb8c08334f22a46673c5954e68a5a8c
-  data.tar.gz: 851b4d5bc78642ca4d184e245b1a163487cc36b51531e187f452a861b89ad378fc01e6b80ac9939b0534215da236c667bb1eee445dd7a733fec4834779d2dea1
+  metadata.gz: b1f04f9919ef3597875c5faa54a83797122b2e424ff109b0b638f2ce14696ff254c18cdc8bed34dbed8d923a16d67e1cba1933c41e39013145dbce7d719945a7
+  data.tar.gz: d73e8e860993d61133309105f87c6a9093a06deb1294c3c01f245cf3987240ae9231983cd7ce197edc3dc96ecdc3cddd41e38387bacf60ef3270f3deacdba4f9

data/.rubocop.yml

@@ -2,17 +2,26 @@ require:
   - rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.5
   DisplayCopNames: true
   DisplayStyleGuide: true
   ExtraDetails: true
 
-Metrics/LineLength:
+Layout/LineLength:
   Max: 120
 
 Style/Documentation:
   Enabled: false
 
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
 Metrics/BlockLength:
   Exclude:
     - 'spec/**/*'

data/.travis.yml

@@ -8,15 +8,16 @@ env:
     - CC_TEST_REPORTER_ID=48c33b2bc3ccdc6dafe9ed76482eca03cde47b922a7859074fc2be791247e5fd
 
 rvm:
-  - 2.3
-  - 2.4
   - 2.5
   - 2.6
+  - 2.7
   - ruby-head
+  - truffleruby
 
 matrix:
   allow_failures:
     - rvm: ruby-head
+    - rvm: truffleruby
   fast_finish: true
 
 before_script:
@@ -29,7 +30,3 @@ script:
 
 after_script:
   - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
-
-notifications:
-  recipients: leonid@svyatov.ru
-  on_failure: change

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## [3.0.0] - 2020-03-10
+
+### Breaking changes
+
+- Minimum required Ruby version is 2.5 now
+
+### Updated
+
+- Small internal refactorings
+- TravisCI config updated: dropped Ruby 2.3 and 2.4, added Ruby 2.7
+- Rubocop's Ruby target version changed to 2.5
+
 ## [2.0.0] - 2019-02-03
 
 ### Added

data/lib/sec_id/base.rb

@@ -1,29 +1,29 @@
 # frozen_string_literal: true
 
 module SecId
-  class Base
-    CHAR_TO_DIGITS = {
-      '0' => 0,      '1' => 1,      '2' => 2,      '3' => 3,      '4' => 4,
-      '5' => 5,      '6' => 6,      '7' => 7,      '8' => 8,      '9' => 9,
-      'A' => [1, 0], 'B' => [1, 1], 'C' => [1, 2], 'D' => [1, 3], 'E' => [1, 4],
-      'F' => [1, 5], 'G' => [1, 6], 'H' => [1, 7], 'I' => [1, 8], 'J' => [1, 9],
-      'K' => [2, 0], 'L' => [2, 1], 'M' => [2, 2], 'N' => [2, 3], 'O' => [2, 4],
-      'P' => [2, 5], 'Q' => [2, 6], 'R' => [2, 7], 'S' => [2, 8], 'T' => [2, 9],
-      'U' => [3, 0], 'V' => [3, 1], 'W' => [3, 2], 'X' => [3, 3], 'Y' => [3, 4], 'Z' => [3, 5],
-      '*' => [3, 6], '@' => [3, 7], '#' => [3, 8]
-    }.freeze
-
-    CHAR_TO_DIGIT = {
-      '0' => 0,  '1' => 1,  '2' => 2,  '3' => 3,  '4' =>  4,
-      '5' => 5,  '6' => 6,  '7' => 7,  '8' => 8,  '9' =>  9,
-      'A' => 10, 'B' => 11, 'C' => 12, 'D' => 13, 'E' => 14,
-      'F' => 15, 'G' => 16, 'H' => 17, 'I' => 18, 'J' => 19,
-      'K' => 20, 'L' => 21, 'M' => 22, 'N' => 23, 'O' => 24,
-      'P' => 25, 'Q' => 26, 'R' => 27, 'S' => 28, 'T' => 29,
-      'U' => 30, 'V' => 31, 'W' => 32, 'X' => 33, 'Y' => 34, 'Z' => 35,
-      '*' => 36, '@' => 37, '#' => 38
-    }.freeze
+  CHAR_TO_DIGITS = {
+    '0' => 0,      '1' => 1,      '2' => 2,      '3' => 3,      '4' => 4,
+    '5' => 5,      '6' => 6,      '7' => 7,      '8' => 8,      '9' => 9,
+    'A' => [1, 0], 'B' => [1, 1], 'C' => [1, 2], 'D' => [1, 3], 'E' => [1, 4],
+    'F' => [1, 5], 'G' => [1, 6], 'H' => [1, 7], 'I' => [1, 8], 'J' => [1, 9],
+    'K' => [2, 0], 'L' => [2, 1], 'M' => [2, 2], 'N' => [2, 3], 'O' => [2, 4],
+    'P' => [2, 5], 'Q' => [2, 6], 'R' => [2, 7], 'S' => [2, 8], 'T' => [2, 9],
+    'U' => [3, 0], 'V' => [3, 1], 'W' => [3, 2], 'X' => [3, 3], 'Y' => [3, 4], 'Z' => [3, 5],
+    '*' => [3, 6], '@' => [3, 7], '#' => [3, 8]
+  }.freeze
+
+  CHAR_TO_DIGIT = {
+    '0' => 0,  '1' => 1,  '2' => 2,  '3' => 3,  '4' =>  4,
+    '5' => 5,  '6' => 6,  '7' => 7,  '8' => 8,  '9' =>  9,
+    'A' => 10, 'B' => 11, 'C' => 12, 'D' => 13, 'E' => 14,
+    'F' => 15, 'G' => 16, 'H' => 17, 'I' => 18, 'J' => 19,
+    'K' => 20, 'L' => 21, 'M' => 22, 'N' => 23, 'O' => 24,
+    'P' => 25, 'Q' => 26, 'R' => 27, 'S' => 28, 'T' => 29,
+    'U' => 30, 'V' => 31, 'W' => 32, 'X' => 33, 'Y' => 34, 'Z' => 35,
+    '*' => 36, '@' => 37, '#' => 38
+  }.freeze
 
+  class Base
     attr_reader :full_number, :identifier, :check_digit
 
     def self.valid?(id)
@@ -72,7 +72,7 @@ module SecId
 
     private
 
-    def digitized_identifier
+    def id_digits
       raise NotImplementedError
     end
 
@@ -82,11 +82,11 @@ module SecId
     end
 
     def char_to_digits(char)
-      CHAR_TO_DIGITS.fetch(char)
+      SecId::CHAR_TO_DIGITS.fetch(char)
     end
 
     def char_to_digit(char)
-      CHAR_TO_DIGIT.fetch(char)
+      SecId::CHAR_TO_DIGIT.fetch(char)
     end
 
     def mod_10(sum)

data/lib/sec_id/cusip.rb

@@ -32,7 +32,7 @@ module SecId
     def modified_luhn_sum
       sum = 0
 
-      digitized_identifier.reverse.each_slice(2) do |even, odd|
+      id_digits.reverse.each_slice(2) do |even, odd|
         double_even = (even || 0) * 2
         sum += div_10_mod_10(double_even) + div_10_mod_10(odd || 0)
       end
@@ -40,8 +40,8 @@ module SecId
       sum
     end
 
-    def digitized_identifier
-      @digitized_identifier ||= identifier.each_char.map(&method(:char_to_digit))
+    def id_digits
+      @id_digits ||= identifier.each_char.map(&method(:char_to_digit))
     end
   end
 end

data/lib/sec_id/isin.rb

@@ -32,7 +32,7 @@ module SecId
     def luhn_sum
       sum = 0
 
-      digitized_identifier.reverse.each_slice(2) do |even, odd|
+      id_digits.reverse.each_slice(2) do |even, odd|
         double_even = (even || 0) * 2
         double_even -= 9 if double_even > 9
         sum += double_even + (odd || 0)
@@ -41,8 +41,8 @@ module SecId
       sum
     end
 
-    def digitized_identifier
-      @digitized_identifier ||= identifier.each_char.flat_map(&method(:char_to_digits))
+    def id_digits
+      @id_digits ||= identifier.each_char.flat_map(&method(:char_to_digits))
     end
   end
 end

data/lib/sec_id/sedol.rb

@@ -10,8 +10,6 @@ module SecId
 
     CHARACTER_WEIGHTS = [1, 3, 1, 7, 3, 9].freeze
 
-    attr_reader :full_number
-
     def initialize(sedol)
       sedol_parts = parse sedol
       @identifier = sedol_parts[:identifier]
@@ -31,16 +29,16 @@ module SecId
       index = 0
       sum = 0
 
-      while index < digitized_identifier.size
-        sum += digitized_identifier[index] * CHARACTER_WEIGHTS[index]
+      while index < id_digits.size
+        sum += id_digits[index] * CHARACTER_WEIGHTS[index]
         index += 1
       end
 
       sum
     end
 
-    def digitized_identifier
-      @digitized_identifier ||= identifier.each_char.map(&method(:char_to_digit))
+    def id_digits
+      @id_digits ||= identifier.each_char.map(&method(:char_to_digit))
     end
   end
 end

data/lib/sec_id/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SecId
-  VERSION = '2.0.1'
+  VERSION = '3.0.0'
 end

data/sec_id.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/svyatov/sec_id'
   spec.license       = 'MIT'
 
-  spec.required_ruby_version = '>= 2.3.0'
+  spec.required_ruby_version = '>= 2.5.0'
 
   spec.require_paths = ['lib']
   spec.files = `git ls-files -z`.split("\x0").reject do |f|
@@ -24,8 +24,8 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '>= 1.16'
   spec.add_development_dependency 'rake', '>= 10.0'
-  spec.add_development_dependency 'rspec', '~> 3.8'
-  spec.add_development_dependency 'rubocop', '~> 0.63.1'
-  spec.add_development_dependency 'rubocop-rspec', '~> 1.32'
-  spec.add_development_dependency 'simplecov', '~> 0.16.1'
+  spec.add_development_dependency 'rspec', '~> 3.9'
+  spec.add_development_dependency 'rubocop', '~> 0.80.1'
+  spec.add_development_dependency 'rubocop-rspec', '~> 1.38'
+  spec.add_development_dependency 'simplecov', '~> 0.17.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sec_id
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 3.0.0
 platform: ruby
 authors:
 - Leonid Svyatov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-03 00:00:00.000000000 Z
+date: 2020-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -44,56 +44,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.9'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.63.1
+        version: 0.80.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.63.1
+        version: 0.80.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.32'
+        version: '1.38'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.32'
+        version: '1.38'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.1
+        version: 0.17.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.1
+        version: 0.17.1
 description: 'Validate securities identification numbers with ease! Currently supported
   standards: ISIN, CUSIP, SEDOL.'
 email:
@@ -132,14 +132,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Validate securities identification numbers with ease!