search_flip 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f4e3ca349bd68555b2826d84c17b192335752947babe02ee51c5501cb04f79ca
-  data.tar.gz: e95021068918513669da2730d613157ad7151995c4a25f532f4274c3a848710f
+  metadata.gz: fb8e67eac92f6f39f78dcc6770ea46d397ab7ec26b1e461b76634367a558f734
+  data.tar.gz: 04e8445e8039e72eac4344cb67de22c04107020b63112f01c9ed76512942c314
 SHA512:
-  metadata.gz: dcb46f99778d2243e6fb4187f85eb9a1db9aedc25a5f2b8287c3cdb8dcd259253bc3430e1e36521ea5794a2a9188f91473ae8d8572edc8c775ac0d234ac2e284
-  data.tar.gz: 1dbb3ba32c9c2a16f1c2b30aba7257dffc39b708f3e68ec8552c6d6d8ac6a751027a2899a3865051f7d1fdd7a6acd7a1f456eba552c7b50f4c2956292f41d413
+  metadata.gz: 429bacd5e7d64f922bb2c20d82d8e2ead32340f8e85abacfd55f0034791cc13c7557a5973dadf7fb19681364f56f899830aecefd7ddedab58b06c9cb8c8a13bd
+  data.tar.gz: f60dfa7d6396971dadd0d960442074a1702493e8149ba885fb84a09f77031b4450603a9ece5391e55d5e747a917b95a4708a0bad3232610c4d4a75ddebc88cd0

data/.rubocop.yml

@@ -1,5 +1,12 @@
 AllCops:
   NewCops: enable
+  TargetRubyVersion: 2.4
+
+Gemspec/RequiredRubyVersion:
+  Enabled: false
+
+Style/ExplicitBlockArgument:
+  Enabled: false
 
 Style/HashTransformValues:
   Enabled: false

data/.travis.yml

@@ -5,7 +5,7 @@ env:
   - ES_IMAGE=elasticsearch:5.4
   - ES_IMAGE=docker.elastic.co/elasticsearch/elasticsearch:6.7.0
   - ES_IMAGE=docker.elastic.co/elasticsearch/elasticsearch:7.0.0
-  - ES_IMAGE=docker.elastic.co/elasticsearch/elasticsearch:7.6.0
+  - ES_IMAGE=docker.elastic.co/elasticsearch/elasticsearch:7.8.0
 rvm:
   - ruby-2.5.3
   - ruby-2.6.2

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 
 # CHANGELOG
 
+## v3.1.1
+
+* Make `SearchFlip::Result.from_hit` work with the `_source` being disabled
+
 ## v3.1.0
 
 * Added plugin support in `SearchFlip::HTTPClient`

data/README.md

@@ -949,6 +949,10 @@ It uses `after_commit` (if applicable, `after_save`, `after_destroy` and
 `after_touch` otherwise) hooks to synchronously update the index when your
 model changes.
 
+## Semantic Versioning
+
+SearchFlip is using Semantic Versioning: [SemVer](http://semver.org/)
+
 ## Links
 
 * Elasticsearch: [https://www.elastic.co/](https://www.elastic.co/)
@@ -980,5 +984,4 @@ $ rspec
 
 That's it.
 
-
 [Bulk API]: https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html

data/lib/search_flip.rb

@@ -39,6 +39,8 @@ module SearchFlip
     attr_reader :code, :body
 
     def initialize(code:, body:)
+      super
+
       @code = code
       @body = body
     end

data/lib/search_flip/aggregation.rb

@@ -40,7 +40,7 @@ module SearchFlip
         else
           filters = (filter_values || []) + (must_not_values || []).map { |must_not_value| { not: must_not_value } }
           queries = must_values ? { must: must_values } : {}
-          filters_and_queries = filters + (queries.size > 0 ? [bool: queries] : [])
+          filters_and_queries = filters + (queries.size > 0 ? [{ bool: queries }] : [])
 
           res[:filter] = filters_and_queries.size > 1 ? { and: filters_and_queries } : filters_and_queries.first
         end
@@ -101,7 +101,7 @@ module SearchFlip
     end
 
     def respond_to_missing?(name, *args)
-      target.respond_to?(name, *args)
+      target.respond_to?(name, *args) || super
     end
 
     def method_missing(name, *args, &block)

data/lib/search_flip/criteria.rb

@@ -576,7 +576,7 @@ module SearchFlip
     end
 
     def respond_to_missing?(name, *args)
-      target.respond_to?(name, *args)
+      target.respond_to?(name, *args) || super
     end
 
     def method_missing(name, *args, &block)

data/lib/search_flip/highlightable.rb

@@ -34,9 +34,10 @@ module SearchFlip
         criteria.highlight_values = (criteria.highlight_values || {}).merge(options)
 
         hash =
-          if fields.is_a?(Hash)
+          case fields
+          when Hash
             fields
-          elsif fields.is_a?(Array)
+          when Array
             fields.each_with_object({}) { |field, h| h[field] = {} }
           else
             { fields => {} }

data/lib/search_flip/result.rb

@@ -17,7 +17,7 @@ module SearchFlip
     #   SearchFlip::Result.from_hit(top_sales_hits.first)
 
     def self.from_hit(hit)
-      raw_result = hit["_source"].dup
+      raw_result = (hit["_source"] || {}).dup
 
       raw_result["_hit"] = hit.each_with_object({}) do |(key, value), hash|
         hash[key] = value if key != "_source"

data/lib/search_flip/version.rb

@@ -1,3 +1,3 @@
 module SearchFlip
-  VERSION = "3.1.0"
+  VERSION = "3.1.1"
 end

data/spec/search_flip/connection_spec.rb

@@ -36,10 +36,10 @@ RSpec.describe SearchFlip::Connection do
     it "changes the aliases" do
       connection = SearchFlip::Connection.new
 
-      connection.update_aliases(actions: [add: { index: "products", alias: "alias1" }])
+      connection.update_aliases(actions: [{ add: { index: "products", alias: "alias1" } }])
       expect(connection.get_aliases(alias_name: "alias1").keys).to eq(["products"])
 
-      connection.update_aliases(actions: [remove: { index: "products", alias: "alias1" }])
+      connection.update_aliases(actions: [{ remove: { index: "products", alias: "alias1" } }])
       expect(connection.alias_exists?("alias1")).to eq(false)
     end
   end
@@ -79,11 +79,11 @@ RSpec.describe SearchFlip::Connection do
 
         expect(connection.alias_exists?(:some_alias)).to eq(false)
 
-        connection.update_aliases(actions: [add: { index: "products", alias: "some_alias" }])
+        connection.update_aliases(actions: [{ add: { index: "products", alias: "some_alias" } }])
 
         expect(connection.alias_exists?(:some_alias)).to eq(true)
       ensure
-        connection.update_aliases(actions: [remove: { index: "products", alias: "some_alias" }])
+        connection.update_aliases(actions: [{ remove: { index: "products", alias: "some_alias" } }])
       end
     end
   end

data/spec/search_flip/result_spec.rb

@@ -13,5 +13,11 @@ RSpec.describe SearchFlip::Result do
 
       expect(result.key1[0].key2).to eq("value")
     end
+
+    it "works with the _source being disabled" do
+      result = SearchFlip::Result.from_hit("_id" => 1)
+
+      expect(result._hit._id).to eq(1)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: search_flip
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Benjamin Vetter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-18 00:00:00.000000000 Z
+date: 2020-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord