scss_lint 0.54.0 → 0.55.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aff9c12976312f5790dca3b5423ae1413cfbd1ec
-  data.tar.gz: 138c24adcf244fa81f594e3c2a1b82003da97782
+  metadata.gz: 01a5421ff7215339318f8408e67d4b9825280594
+  data.tar.gz: 7186bfb3c48b30597044c58f5626be8bd93bf278
 SHA512:
-  metadata.gz: 5f9f93bcf637bd292942415c4570a75ccecc595819e1a5890e8846c38e9f23a16cfa4a93cb73a292b8e87f824a86fb95b6334f868cc05a80b2b610e3096a86dd
-  data.tar.gz: 6a65980f9c12a3c7bdd0b085f189fcb6b0fbc7e5063acca043de4960154e825d4ebe7bcdb44837903b4571a907f108864b3dc1065d244e2031da96991e8eed02
+  metadata.gz: 8a58456b3a1dc059e1b03ad9066a5ce6d3efa3be4f313d982dc5dbe3d5b9ab20b9fa1733097f3ae23579b50aa01bb1d1e4707220de6fe67f60563c4a88d1fb8e
+  data.tar.gz: cdd7914be549c8c39a1ed144bb52d23d5c6141f3d345eb02fce248929502591ac22674f703adba17ffa94c38c3543e950023040287bf2ca7de4652a48c4b51a2

data/config/default.yml

@@ -142,6 +142,7 @@ linters:
       'ch', 'em', 'ex', 'rem',                 # Font-relative lengths
       'cm', 'in', 'mm', 'pc', 'pt', 'px', 'q', # Absolute lengths
       'vh', 'vw', 'vmin', 'vmax',              # Viewport-percentage lengths
+      'fr',                                    # Grid fractional lengths
       'deg', 'grad', 'rad', 'turn',            # Angle
       'ms', 's',                               # Duration
       'Hz', 'kHz',                             # Frequency
@@ -164,7 +165,7 @@ linters:
 
   SelectorFormat:
     enabled: true
-    convention: hyphenated_lowercase # or 'strict_BEM', or 'hyphenated_BEM', or 'snake_case', or 'camel_case', or a regex pattern
+    convention: hyphenated_lowercase # or 'classic_BEM', or 'hyphenated_BEM', or 'snake_case', or 'camel_case', or a regex pattern
 
   Shorthand:
     enabled: true

data/data/properties.txt

@@ -186,6 +186,7 @@ flood-opacity
 flow-from
 flow-into
 font
+font-display
 font-family
 font-feature-settings
 font-kerning
@@ -244,6 +245,7 @@ inline-box-align
 inline-size
 isolation
 justify-content
+justify-items
 justify-self
 kerning
 left

data/data/pseudo-elements.txt

@@ -110,6 +110,7 @@ before
 content
 first-letter
 first-line
+ng-deep
 placeholder
 selection
 shadow

data/lib/scss_lint/linter/selector_format.rb

@@ -53,6 +53,16 @@ module SCSSLint
         explanation: 'should be written in camelCase format',
         validator: ->(name) { name =~ /^[a-z][a-zA-Z0-9]*$/ },
       },
+      'classic_BEM' => {
+        explanation: 'should be written in classic BEM (Block Element Modifier) format',
+        validator: lambda do |name|
+          name =~ /
+            ^[a-z]([-]?[a-z0-9]+)*
+            (__[a-z0-9]([-]?[a-z0-9]+)*)?
+            ((_[a-z0-9]([-]?[a-z0-9]+)*){1,2})?$
+          /x
+        end
+      },
       'hyphenated_BEM' => {
         explanation: 'should be written in hyphenated BEM (Block Element Modifier) format',
         validator: ->(name) { name !~ /[A-Z]|-{3}|_{3}|[^_]_[^_]/ },

data/lib/scss_lint/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module SCSSLint
-  VERSION = '0.54.0'.freeze
+  VERSION = '0.55.0'.freeze
 end

data/spec/scss_lint/linter/selector_format_spec.rb

@@ -454,6 +454,88 @@ describe SCSSLint::Linter::SelectorFormat do
     end
   end
 
+  context 'when the classic_BEM convention is specified' do
+    let(:linter_config) { { 'convention' => 'classic_BEM' } }
+
+    context 'when a name contains no underscores or hyphens' do
+      let(:scss) { '.block {}' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when a name contains single hyphen' do
+      let(:scss) { '.b-block {}' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when a name contains multiple hyphens' do
+      let(:scss) { '.b-block-name {}' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when a name contains multiple hyphens in a row' do
+      let(:scss) { '.b-block--modifier {}' }
+
+      it { should report_lint }
+    end
+
+    context 'when a name contains a single underscore' do
+      let(:scss) { '.block_modifier {}' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when a block has name-value modifier' do
+      let(:scss) { '.block_modifier_value {}' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when a block has name-value modifier with lots of hyphens' do
+      let(:scss) { '.b-block-name_modifier-name-here_value-name-here {}' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when a name has double underscores' do
+      let(:scss) { '.b-block__element {}' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when element goes after block with modifier' do
+      let(:scss) { '.block_modifier_value__element {}' }
+
+      it { should report_lint }
+    end
+
+    context 'when element has modifier' do
+      let(:scss) { '.block__element_modifier_value {}' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when element has not paired modifier' do
+      let(:scss) { '.block__element_modifier {}' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when element has hypenated modifier' do
+      let(:scss) { '.block__element--modifier {}' }
+
+      it { should report_lint }
+    end
+
+    context 'when element has hypenated paired modifier' do
+      let(:scss) { '.block__element--modifier_value {}' }
+
+      it { should report_lint }
+    end
+  end
+
   context 'when the strict_BEM convention is specified' do
     let(:linter_config) { { 'convention' => 'strict_BEM' } }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss_lint
 version: !ruby/object:Gem::Version
-  version: 0.54.0
+  version: 0.55.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-14 00:00:00.000000000 Z
+date: 2017-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -272,7 +272,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: SCSS lint tool
@@ -369,4 +369,3 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/isolated_environment.rb
 - spec/support/matchers/report_lint.rb
-has_rdoc: