scss_lint 0.49.0 → 0.50.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 881e2595ce6e859e53e9148db36e2f3d11bcb429
-  data.tar.gz: e28e168aa7ec435017b415278fe3fc68c8b911ca
+  metadata.gz: 8c6dc8c5fb0f7ed2ced515528060a877c6c7fbaa
+  data.tar.gz: ac668a73f2506c96684d0ff3e5451256980ac6e3
 SHA512:
-  metadata.gz: f27ed9d01d9a7920c3d88d0d9345b8ba107978fd536d90618d406af9cc8209221cc220054d1f118320af98927fce38b91144c4af1c4686d2a09b7dda2394aaaa
-  data.tar.gz: c6cfb9ba3bf3a0957cbd756b7e0cf9b4702432a94275214b97c98fd2884e63bc225adaec713148d41fae2b0078e070ed6e77ded6d3c4c4139b0cb8e4aaa0b3ec
+  metadata.gz: e1e8735bf5dedb6d82cebed74dc9e100aa21f50978d54fda8f3d814def9f6377889d86bc2f9be1617dcf42e4ee0a56c999e8bc981e1d23388a00c08fb5980a54
+  data.tar.gz: 91b2605482f554c157b5c98f583bfaadede6e5c003d1c37bfe78d51e39abb570b38374e25dd811c5d3b48cd49580cfc610f1f0cfd027fe097551c30b50e564d3

data/config/default.yml

@@ -181,6 +181,11 @@ linters:
     enabled: true
     style: one_space # or 'no_space', or 'at_least_one_space'
 
+  SpaceAfterComment:
+    enabled: true
+    style: at_least_one_space # or 'no_space', or 'at_least_one_space'
+    allow_empty_comments: true
+
   SpaceAfterPropertyColon:
     enabled: true
     style: one_space # or 'no_space', or 'at_least_one_space', or 'aligned'

data/lib/scss_lint/cli.rb

@@ -63,14 +63,7 @@ module SCSSLint
 
     def scan_for_lints(options, config)
       runner = Runner.new(config)
-      files =
-        if options[:stdin_file_path]
-          [{ file: STDIN, path: options[:stdin_file_path] }]
-        else
-          FileFinder.new(config).find(options[:files]).map do |file_path|
-            { path: file_path }
-          end
-        end
+      files = files_to_lint(options, config)
       runner.run(files)
       report_lints(options, runner.lints, files)
 
@@ -83,6 +76,17 @@ module SCSSLint
       end
     end
 
+    def files_to_lint(options, config)
+      if options[:stdin_file_path]
+        [{ file: STDIN, path: options[:stdin_file_path] }]
+      else
+        patterns = Array(options[:files]).any? ? Array(options[:files]) : config.scss_files
+        FileFinder.new(config).find(patterns).map do |file_path|
+          { path: file_path }
+        end
+      end
+    end
+
     def handle_runtime_exception(exception, options) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/LineLength, Metrics/MethodLength
       case exception
       when SCSSLint::Exceptions::InvalidCLIOption

data/lib/scss_lint/config.rb

@@ -270,9 +270,9 @@ module SCSSLint
     end
 
     def linter_options(linter)
-      { 'severity' => @options['severity'] }.merge(
-        @options['linters'].fetch(self.class.linter_name(linter), {})
-      )
+      options = @options['linters'].fetch(self.class.linter_name(linter), {})
+      options['severity'] ||= @options['severity']
+      options
     end
 
     def excluded_file?(file_path)
@@ -304,8 +304,8 @@ module SCSSLint
 
     # @return Array
     def scss_files
-      if path = @options['scss_files']
-        Dir[path]
+      if path = @options['scss_files'] && Array(path).any?
+        Array(path).map { |p| Dir[p] }.flatten.uniq
       else
         []
       end

data/lib/scss_lint/engine.rb

@@ -28,11 +28,10 @@ module SCSSLint
 
       # Need to force encoding to avoid Windows-related bugs.
       # Need to encode with universal newline to avoid other Windows-related bugs.
-      # Need `to_a` for Ruby 1.9.3.
       encoding = 'UTF-8'
       @lines = @contents.force_encoding(encoding)
                         .encode(encoding, universal_newline: true)
-                        .lines.to_a
+                        .lines
       @tree = @engine.to_tree
       find_any_control_commands
     rescue Encoding::UndefinedConversionError, Sass::SyntaxError, ArgumentError => error

data/lib/scss_lint/file_finder.rb

@@ -19,8 +19,10 @@ module SCSSLint
     #
     # @param patterns [Array<String>] a list of file paths and glob patterns
     def find(patterns)
-      # If no explicit patterns given, use patterns listed in config
-      patterns = @config.scss_files if patterns.empty?
+      if patterns.empty?
+        raise SCSSLint::Exceptions::NoFilesError,
+              'No files, paths, or patterns were specified'
+      end
 
       matched_files = extract_files_from(patterns)
       if matched_files.empty?

data/lib/scss_lint/linter.rb

@@ -52,7 +52,8 @@ module SCSSLint
 
     # Helper for creating lint from a parse tree node
     #
-    # @param node_or_line_or_location [Sass::Script::Tree::Node, Fixnum, SCSSLint::Location]
+    # @param node_or_line_or_location [Sass::Script::Tree::Node, Fixnum,
+    #                                  SCSSLint::Location, Sass::Source::Position]
     # @param message [String]
     def add_lint(node_or_line_or_location, message)
       @lints << Lint.new(self,
@@ -165,6 +166,8 @@ module SCSSLint
     def extract_location(node_or_line_or_location)
       if node_or_line_or_location.is_a?(Location)
         node_or_line_or_location
+      elsif node_or_line_or_location.is_a?(Sass::Source::Position)
+        Location.new(node_or_line_or_location.line, node_or_line_or_location.offset)
       elsif node_or_line_or_location.respond_to?(:source_range) &&
             node_or_line_or_location.source_range
         location_from_range(node_or_line_or_location.source_range)

data/lib/scss_lint/linter/color_keyword.rb

@@ -4,6 +4,12 @@ module SCSSLint
   class Linter::ColorKeyword < Linter
     include LinterRegistry
 
+    FUNCTIONS_ALLOWING_COLOR_KEYWORD_ARGS = %w[
+      map-get
+      map-has-key
+      map-remove
+    ].to_set
+
     def visit_script_color(node)
       word = source_from_range(node.source_range)[/([a-z]+)/i, 1]
       add_color_lint(node, word) if color_keyword?(word)
@@ -20,7 +26,7 @@ module SCSSLint
   private
 
     def add_color_lint(node, original)
-      return if in_map?(node)
+      return if in_map?(node) || in_allowed_function_call?(node)
 
       hex_form = Sass::Script::Value::Color.new(color_keyword_to_code(original)).tap do |color|
         color.options = {} # `inspect` requires options to be set
@@ -34,5 +40,11 @@ module SCSSLint
     def in_map?(node)
       node_ancestor(node, 2).is_a?(Sass::Script::Tree::MapLiteral)
     end
+
+    def in_allowed_function_call?(node)
+      if (funcall = node_ancestor(node, 2)).is_a?(Sass::Script::Tree::Funcall)
+        FUNCTIONS_ALLOWING_COLOR_KEYWORD_ARGS.include?(funcall.name)
+      end
+    end
   end
 end

data/lib/scss_lint/linter/placeholder_in_extend.rb

@@ -12,11 +12,13 @@ module SCSSLint
       # every word boundary (so %placeholder becomes ['%', 'placeholder']).
       selector = node.selector.join
 
-      # Ignore if this is a placeholder
-      return if selector.start_with?('%')
-
-      add_lint(node, 'Prefer using placeholder selectors (e.g. ' \
-                     '%some-placeholder) with @extend')
+      if selector.include?(',')
+        add_lint(node, 'Avoid comma sequences in `@extend` directives; ' \
+                       'prefer single placeholder selectors (e.g. `%some-placeholder`)')
+      elsif !selector.start_with?('%')
+        add_lint(node, 'Prefer using placeholder selectors (e.g. ' \
+                       '%some-placeholder) with @extend')
+      end
     end
   end
 end

data/lib/scss_lint/linter/private_naming_convention.rb

@@ -27,9 +27,9 @@ module SCSSLint
       node.children.each_with_object([]) do |child_node|
         if DEFINITIONS.key?(child_node.class)
           register_node child_node
-        else
-          yield
         end
+
+        yield
       end
 
       # After we have visited everything, we want to see if any private things

data/lib/scss_lint/linter/shorthand.rb

@@ -5,11 +5,23 @@ module SCSSLint
   class Linter::Shorthand < Linter
     include LinterRegistry
 
+    def visit_root(*)
+      @shorthands_forbidden = @config['allowed_shorthands'] == []
+      yield # Continue linting children
+    end
+
     # @param node [Sass::Tree::Node]
     def visit_prop(node)
       property_name = node.name.join
       return unless SHORTHANDABLE_PROPERTIES.include?(property_name)
 
+      if @shorthands_forbidden
+        add_lint(node, "The `#{property_name}` shorthand property is " \
+                       'forbidden since the `allowed_shorthands` option ' \
+                       'is set to an empty list.')
+
+      end
+
       case node.value
       when Sass::Script::Tree::Literal
         check_script_literal(property_name, node.value)
@@ -68,6 +80,8 @@ module SCSSLint
     # @param node [Sass::Script::Value::String]
     # @param values [Array<String>]
     def check_shorthand(prop, node, values)
+      values = shorthand_values(values)
+
       add_lint(node, "Shorthands of length `#{values.count}` are not allowed. " \
                      "Value was `#{values.join(' ')}`") unless allowed?(values.count)
 
@@ -138,5 +152,9 @@ module SCSSLint
       return false unless config['allowed_shorthands']
       config['allowed_shorthands'].map(&:to_i).include?(size)
     end
+
+    def shorthand_values(values)
+      values.take(4).take_while { |value| !value.to_s.start_with?('!') }
+    end
   end
 end

data/lib/scss_lint/linter/space_after_comma.rb

@@ -89,7 +89,8 @@ module SCSSLint
         next if char == "\n" || # Ignore trailing spaces
                 valid_spaces_after_comma?(spaces)
 
-        add_lint comma_position, "Commas in #{arg_type} should be followed by a single space"
+        style_message = config['style'].tr('_', ' ')
+        add_lint comma_position, "Commas in #{arg_type} should be followed by #{style_message}"
       end
     end
 

data/lib/scss_lint/linter/space_after_comment.rb

@@ -0,0 +1,69 @@
+module SCSSLint
+  # Checks for a space after comment literals
+  class Linter::SpaceAfterComment < Linter
+    include LinterRegistry
+
+    def visit_comment(node)
+      source = source_from_range(node.source_range).strip
+      check_method = "check_#{node.type}_comment"
+      send(check_method, node, source)
+    end
+
+  private
+
+    def check_silent_comment(node, source)
+      source.split("\n").each_with_index do |line, index|
+        next if config['allow_empty_comments'] && line.strip.length <= 2
+        whitespace = whitespace_after_comment(line, 2)
+        check_for_space(node.line + index, whitespace)
+      end
+    end
+
+    def check_normal_comment(node, source)
+      whitespace = whitespace_after_comment(source, 2)
+      check_for_space(node, whitespace)
+    end
+
+    def check_loud_comment(node, source)
+      whitespace = whitespace_after_comment(source, 3)
+      check_for_space(node, whitespace)
+    end
+
+    def check_for_no_spaces(node_or_line, whitespace)
+      return if whitespace == 0
+      add_lint(node_or_line, 'Comment literal should not be followed by any spaces')
+    end
+
+    def check_for_one_space(node_or_line, whitespace)
+      return if whitespace == 1
+      add_lint(node_or_line, 'Comment literal should be followed by one space')
+    end
+
+    def check_for_at_least_one_space(node_or_line, whitespace)
+      return if whitespace >= 1
+      add_lint(node_or_line, 'Comment literal should be followed by at least one space')
+    end
+
+    def check_for_space(node_or_line, spaces)
+      case config['style']
+      when 'one_space'
+        check_for_one_space(node_or_line, spaces)
+      when 'no_space'
+        check_for_no_spaces(node_or_line, spaces)
+      when 'at_least_one_space'
+        check_for_at_least_one_space(node_or_line, spaces)
+      end
+    end
+
+    def whitespace_after_comment(source, offset)
+      whitespace = 0
+
+      while [' ', "\t"].include? source[offset]
+        whitespace += 1
+        offset += 1
+      end
+
+      whitespace
+    end
+  end
+end

data/lib/scss_lint/linter/space_before_brace.rb

@@ -34,7 +34,7 @@ module SCSSLint
                        '`{` should be preceded by at least one space')
       else
         return unless chars_before_incorrect(string)
-        style_message = (config['style'] == 'new_line') ? 'a new line' : 'one space'
+        style_message = config['style'] == 'new_line' ? 'a new line' : 'one space'
         add_lint(line, 'Opening curly brace `{` should be ' \
                        "preceded by #{style_message}")
       end

data/lib/scss_lint/linter/space_between_parens.rb

@@ -102,7 +102,7 @@ module SCSSLint
     # An unrelated right paren will sneak into the source of a node if there is no
     # whitespace between the node and the right paren.
     def trim_right_paren(source)
-      (source.count(')') == source.count('(') + 1) ? source[0..-2] : source
+      source.count(')') == source.count('(') + 1 ? source[0..-2] : source
     end
 
     def expected_spaces

data/lib/scss_lint/linter/string_quotes.rb

@@ -3,8 +3,6 @@ module SCSSLint
   class Linter::StringQuotes < Linter
     include LinterRegistry
 
-    CHARSET_DIRECTIVE_LENGTH = '@charset'.length
-
     def visit_script_stringinterpolation(node)
       # We can't statically determine what the resultant string looks like when
       # string interpolation is used, e.g. "one #{$var} three" could be a very
@@ -26,13 +24,6 @@ module SCSSLint
       check_quotes(node, source_from_range(node.source_range))
     end
 
-    def visit_charset(node)
-      # `@charset` source range includes entire declaration, so exclude that prefix
-      source = source_from_range(node.source_range)[CHARSET_DIRECTIVE_LENGTH..-1]
-
-      check_quotes(node, source)
-    end
-
   private
 
     def check_quotes(node, source)

data/lib/scss_lint/linter/unnecessary_mantissa.rb

@@ -9,6 +9,7 @@ module SCSSLint
     def visit_script_string(node)
       return unless node.type == :identifier
       return if node.value =~ /^'|"/
+      return if url_literal?(node)
 
       node.value.scan(REAL_NUMBER_REGEX) do |number, integer, mantissa, units|
         if unnecessary_mantissa?(mantissa)
@@ -41,5 +42,9 @@ module SCSSLint
     def unnecessary_mantissa?(mantissa)
       mantissa !~ /[^0]/
     end
+
+    def url_literal?(node)
+      node.value.start_with?('url(')
+    end
   end
 end

data/lib/scss_lint/rake_task.rb

@@ -50,7 +50,7 @@ module SCSSLint
     # Create the task so it is accessible via +Rake::Task['scss_lint']+.
     def initialize(name = :scss_lint)
       @name = name
-      @files = ['.'] # Search for everything under current directory by default
+      @files = []
       @quiet = false
 
       yield self if block_given?
@@ -102,7 +102,13 @@ module SCSSLint
       # command line or in a custom task definition.
       explicit_files = Array(task_args[:files]) + Array(task_args.extras)
 
-      explicit_files.any? ? explicit_files : files
+      if explicit_files.any?
+        explicit_files
+      elsif files.any?
+        files
+      else
+        [] # Will fall back to scss_files option if defined
+      end
     end
 
     # Friendly description that shows the full command that will be executed.

data/lib/scss_lint/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module SCSSLint
-  VERSION = '0.49.0'.freeze
+  VERSION = '0.50.0'.freeze
 end

data/spec/scss_lint/file_finder_spec.rb

@@ -14,30 +14,8 @@ describe SCSSLint::FileFinder do
     context 'when no patterns are given' do
       let(:patterns) { [] }
 
-      context 'and there are no SCSS files under the current directory' do
-        it 'raises an error' do
-          expect { subject }.to raise_error SCSSLint::Exceptions::NoFilesError
-        end
-      end
-
-      context 'and there are SCSS files under the current directory' do
-        before do
-          FileUtils.touch('blah.scss')
-          FileUtils.mkdir_p('more')
-          FileUtils.touch(File.join('more', 'more.scss'))
-        end
-
-        it { should == ['blah.scss', File.join('more', 'more.scss')] }
-      end
-
-      context 'and a default set of files is specified in the config' do
-        let(:files) { ['file1.scss', 'file2.scss'] }
-
-        before do
-          config.stub(:scss_files).and_return(files)
-        end
-
-        it { should == files }
+      it 'raises an error' do
+        expect { subject }.to raise_error SCSSLint::Exceptions::NoFilesError
       end
     end
 

data/spec/scss_lint/linter/color_keyword_spec.rb

@@ -99,4 +99,14 @@ describe SCSSLint::Linter::ColorKeyword do
 
     it { should_not report_lint }
   end
+
+  context 'when color keyword is used in a map function call' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: map-get($my-colors, green);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
 end

data/spec/scss_lint/linter/placeholder_in_extend_spec.rb

@@ -31,6 +31,16 @@ describe SCSSLint::Linter::PlaceholderInExtend do
     it { should report_lint line: 2 }
   end
 
+  context 'when extending with a comma sequence starting with a placeholder' do
+    let(:scss) { <<-SCSS }
+      p {
+        @extend %placeholder, .item;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
   context 'when extending with a placeholder' do
     let(:scss) { <<-SCSS }
       p {

data/spec/scss_lint/linter/private_naming_convention_spec.rb

@@ -465,6 +465,22 @@ describe SCSSLint::Linter::PrivateNamingConvention do
 
       it { should_not report_lint }
     end
+
+    context 'is defined and used within another private function' do
+      let(:scss) { <<-SCSS }
+        @function _foo() {
+          @return red;
+        }
+
+        @function _bar() {
+          @return _foo();
+        }
+
+        $use: _bar();
+      SCSS
+
+      it { should_not report_lint }
+    end
   end
 
   context 'when a public function' do

data/spec/scss_lint/linter/shorthand_spec.rb

@@ -193,6 +193,16 @@ describe SCSSLint::Linter::Shorthand do
       SCSS
 
       it { should_not report_lint }
+
+      context 'and ends with !important' do
+        let(:scss) { <<-SCSS }
+          p {
+            margin: 4px 4px 4px !important;
+          }
+        SCSS
+
+        it { should_not report_lint }
+      end
     end
 
     context 'is fine but length is not allowed' do
@@ -205,5 +215,16 @@ describe SCSSLint::Linter::Shorthand do
 
       it { should report_lint }
     end
+
+    context 'when allowed_shorthands is a empty list' do
+      let(:allowed) { [] }
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 0;
+        }
+      SCSS
+
+      it { should report_lint line: 2, message: /forbidden/ }
+    end
   end
 end

data/spec/scss_lint/linter/space_after_comma_spec.rb

@@ -346,6 +346,30 @@ describe SCSSLint::Linter::SpaceAfterComma do
 
       it { should report_lint line: 4 }
     end
+
+    context 'column number' do
+      let(:scss) { <<-SCSS }
+      p {
+        property: $a,$b;
+      }
+      SCSS
+
+      it 'is the correct column' do
+        subject.lints.first.location.column.should == 15
+      end
+    end
+
+    context 'linter message' do
+      let(:scss) { <<-SCSS }
+      p {
+        property: $a,$b;
+      }
+      SCSS
+
+      it 'specifies the style' do
+        subject.lints.first.description.should == 'Commas in lists should be followed by one space'
+      end
+    end
   end
 
   context 'when more than one space is preferred' do
@@ -745,6 +769,19 @@ describe SCSSLint::Linter::SpaceAfterComma do
         it { should_not report_lint }
       end
     end
+
+    context 'linter message' do
+      let(:scss) { <<-SCSS }
+      p {
+        property: $a,$b;
+      }
+      SCSS
+
+      it 'specifies the style' do
+        subject.lints.first.description.should ==
+          'Commas in lists should be followed by at least one space'
+      end
+    end
   end
 
   context 'when no space is preferred' do
@@ -1078,5 +1115,17 @@ describe SCSSLint::Linter::SpaceAfterComma do
         it { should_not report_lint }
       end
     end
+
+    context 'linter message' do
+      let(:scss) { <<-SCSS }
+      p {
+        property: $a, $b;
+      }
+      SCSS
+
+      it 'specifies the style' do
+        subject.lints.first.description.should == 'Commas in lists should be followed by no space'
+      end
+    end
   end
 end

data/spec/scss_lint/linter/space_after_comment_spec.rb

@@ -0,0 +1,480 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::SpaceAfterComment do
+  context 'when no comments exist' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when one space is preferred' do
+    let(:linter_config) { { 'style' => 'one_space' } }
+
+    context 'when silent comment and no space' do
+      let(:scss) { <<-SCSS }
+        //no space
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when silent comment and one space' do
+      let(:scss) { <<-SCSS }
+        // one space
+      SCSS
+
+      it { should_not report_lint line: 1 }
+    end
+
+    context 'when silent comment and multiple spaces' do
+      let(:scss) { <<-SCSS }
+        //   multiple spaces
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when inline silent comment and no space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; //no space
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when inline silent comment and one space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; // one space
+        }
+      SCSS
+
+      it { should_not report_lint line: 2 }
+    end
+
+    context 'when inline silent comment and multiple spaces' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; //   multiple spaces
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when multiple silent comments' do
+      let(:scss) { <<-SCSS }
+       //no space
+       // space
+       //no space
+       //   multiple spaces
+      SCSS
+
+      it { should report_lint line: 1 }
+      it { should_not report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should report_lint line: 4 }
+    end
+
+    context 'when multiple silent comments and allow_empty_comments' do
+      let(:linter_config) { { 'style' => 'one_space', 'allow_empty_comments' => true } }
+      let(:scss) { <<-SCSS }
+       //
+       //no space
+       // space
+       //no space
+       //   multiple spaces
+      SCSS
+
+      it { should_not report_lint line: 1 }
+      it { should report_lint line: 2 }
+      it { should_not report_lint line: 3 }
+      it { should report_lint line: 4 }
+      it { should report_lint line: 5 }
+    end
+
+    context 'when normal comment and no space' do
+      let(:scss) { <<-SCSS }
+       /*no space */
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when normal comment and one space' do
+      let(:scss) { <<-SCSS }
+       /* one space */
+      SCSS
+
+      it { should_not report_lint line: 1 }
+    end
+
+    context 'when normal comment and multiple spaces' do
+      let(:scss) { <<-SCSS }
+       /*   multiple spaces */
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when inline normal comment and no space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; /*no space */
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when inline normal comment and one space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; /* one space */
+        }
+      SCSS
+
+      it { should_not report_lint line: 2 }
+    end
+
+    context 'when inline normal comment and multiple space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; /*   multiple spaces */
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when loud comment and no space' do
+      let(:scss) { <<-SCSS }
+       /*!no space */
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when loud comment and one space' do
+      let(:scss) { <<-SCSS }
+       /*! one space */
+      SCSS
+
+      it { should_not report_lint line: 1 }
+    end
+
+    context 'when loud comment and multiple spaces' do
+      let(:scss) { <<-SCSS }
+       /*!   multiple spaces */
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+
+  context 'when no spaces are allowed' do
+    let(:linter_config) { { 'style' => 'no_space' } }
+
+    context 'when silent comment and no space' do
+      let(:scss) { <<-SCSS }
+        //no space
+      SCSS
+
+      it { should_not report_lint line: 1 }
+    end
+
+    context 'when silent comment and one space' do
+      let(:scss) { <<-SCSS }
+        // one space
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when silent comment and multiple spaces' do
+      let(:scss) { <<-SCSS }
+        //   multiple spaces
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when inline silent comment and no space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; //no space
+        }
+      SCSS
+
+      it { should_not report_lint line: 2 }
+    end
+
+    context 'when inline silent comment and one space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; // one space
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when inline silent comment and multiple spaces' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; //   multiple spaces
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when multiple silent comments' do
+      let(:scss) { <<-SCSS }
+       //no space
+       // space
+       //no space
+       //   multiple spaces
+      SCSS
+
+      it { should_not report_lint line: 1 }
+      it { should report_lint line: 2 }
+      it { should_not report_lint line: 3 }
+      it { should report_lint line: 4 }
+    end
+
+    context 'when normal comment and no space' do
+      let(:scss) { <<-SCSS }
+       /*no space */
+      SCSS
+
+      it { should_not report_lint line: 1 }
+    end
+
+    context 'when normal comment and one space' do
+      let(:scss) { <<-SCSS }
+       /* one space */
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when normal comment and multiple spaces' do
+      let(:scss) { <<-SCSS }
+       /*   multiple spaces */
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when inline normal comment and no space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; /*no space */
+        }
+      SCSS
+
+      it { should_not report_lint line: 2 }
+    end
+
+    context 'when inline normal comment and one space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; /* one space */
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when inline normal comment and multiple space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; /*   multiple spaces */
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when loud comment and no space' do
+      let(:scss) { <<-SCSS }
+       /*!no space */
+      SCSS
+
+      it { should_not report_lint line: 1 }
+    end
+
+    context 'when loud comment and one space' do
+      let(:scss) { <<-SCSS }
+       /*! one space */
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when loud comment and multiple spaces' do
+      let(:scss) { <<-SCSS }
+       /*!   multiple spaces */
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+
+  context 'when at least one space is preferred' do
+    let(:linter_config) { { 'style' => 'at_least_one_space' } }
+
+    context 'when silent comment and no space' do
+      let(:scss) { <<-SCSS }
+        //no space
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when silent comment and one space' do
+      let(:scss) { <<-SCSS }
+        // one space
+      SCSS
+
+      it { should_not report_lint line: 1 }
+    end
+
+    context 'when silent comment and multiple spaces' do
+      let(:scss) { <<-SCSS }
+        //   multiple spaces
+      SCSS
+
+      it { should_not report_lint line: 1 }
+    end
+
+    context 'when inline silent comment and no space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; //no space
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when inline silent comment and one space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; // one space
+        }
+      SCSS
+
+      it { should_not report_lint line: 2 }
+    end
+
+    context 'when inline silent comment and multiple spaces' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; //   multiple spaces
+        }
+      SCSS
+
+      it { should_not report_lint line: 2 }
+    end
+
+    context 'when multiple silent comments' do
+      let(:scss) { <<-SCSS }
+       //no space
+       // space
+       //no space
+       //   multiple spaces
+      SCSS
+
+      it { should report_lint line: 1 }
+      it { should_not report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should_not report_lint line: 4 }
+    end
+
+    context 'when normal comment and no space' do
+      let(:scss) { <<-SCSS }
+       /*no space */
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when normal comment and one space' do
+      let(:scss) { <<-SCSS }
+       /* one space */
+      SCSS
+
+      it { should_not report_lint line: 1 }
+    end
+
+    context 'when normal comment and multiple spaces' do
+      let(:scss) { <<-SCSS }
+       /*   multiple spaces */
+      SCSS
+
+      it { should_not report_lint line: 1 }
+    end
+
+    context 'when inline normal comment and no space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; /*no space */
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when inline normal comment and one space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; /* one space */
+        }
+      SCSS
+
+      it { should_not report_lint line: 2 }
+    end
+
+    context 'when inline normal comment and multiple space' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin:0; /*   multiple spaces */
+        }
+      SCSS
+
+      it { should_not report_lint line: 2 }
+    end
+
+    context 'when loud comment and no space' do
+      let(:scss) { <<-SCSS }
+       /*!no space */
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when loud comment and one space' do
+      let(:scss) { <<-SCSS }
+       /*! one space */
+      SCSS
+
+      it { should_not report_lint line: 1 }
+    end
+
+    context 'when loud comment and multiple spaces' do
+      let(:scss) { <<-SCSS }
+       /*!   multiple spaces */
+      SCSS
+
+      it { should_not report_lint line: 1 }
+    end
+  end
+end

data/spec/scss_lint/linter/string_quotes_spec.rb

@@ -63,12 +63,6 @@ describe SCSSLint::Linter::StringQuotes do
     end
   end
 
-  context 'when @charset uses single quotes' do
-    let(:scss) { "@charset 'UTF-8';" }
-
-    it { should_not report_lint }
-  end
-
   context 'when string is written with double quotes' do
     let(:scss) { <<-SCSS }
       p {
@@ -131,12 +125,6 @@ describe SCSSLint::Linter::StringQuotes do
     end
   end
 
-  context 'when @charset uses double quotes' do
-    let(:scss) { '@charset "UTF-8";' }
-
-    it { should report_lint }
-  end
-
   context 'when property has a literal identifier' do
     let(:scss) { <<-SCSS }
       p {

data/spec/scss_lint/linter/unnecessary_mantissa_spec.rb

@@ -84,4 +84,14 @@ describe SCSSLint::Linter::UnnecessaryMantissa do
 
     it { should_not report_lint }
   end
+
+  context 'when a decimal value appears in a URL' do
+    let(:scss) { <<-SCSS }
+      p {
+        background: url(https://www.example.com/v1.0/image.jpg);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
 end

data/spec/scss_lint/reporter/stats_reporter_spec.rb

@@ -32,7 +32,7 @@ describe SCSSLint::Reporter::StatsReporter do
       end
 
       it 'prints the name of each linter with lints' do
-        subject.report_lints.scan(linter_1.name).count.should eq 1
+        subject.report_lints.should include linter_1.name
       end
 
       it 'prints the number of lints per linter' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss_lint
 version: !ruby/object:Gem::Version
-  version: 0.49.0
+  version: 0.50.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-05 00:00:00.000000000 Z
+date: 2016-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -118,6 +118,7 @@ files:
 - lib/scss_lint/linter/single_line_per_property.rb
 - lib/scss_lint/linter/single_line_per_selector.rb
 - lib/scss_lint/linter/space_after_comma.rb
+- lib/scss_lint/linter/space_after_comment.rb
 - lib/scss_lint/linter/space_after_property_colon.rb
 - lib/scss_lint/linter/space_after_property_name.rb
 - lib/scss_lint/linter/space_after_variable_colon.rb
@@ -207,6 +208,7 @@ files:
 - spec/scss_lint/linter/single_line_per_property_spec.rb
 - spec/scss_lint/linter/single_line_per_selector_spec.rb
 - spec/scss_lint/linter/space_after_comma_spec.rb
+- spec/scss_lint/linter/space_after_comment_spec.rb
 - spec/scss_lint/linter/space_after_property_colon_spec.rb
 - spec/scss_lint/linter/space_after_property_name_spec.rb
 - spec/scss_lint/linter/space_after_variable_colon_spec.rb
@@ -262,7 +264,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: '2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -323,6 +325,7 @@ test_files:
 - spec/scss_lint/linter/single_line_per_property_spec.rb
 - spec/scss_lint/linter/single_line_per_selector_spec.rb
 - spec/scss_lint/linter/space_after_comma_spec.rb
+- spec/scss_lint/linter/space_after_comment_spec.rb
 - spec/scss_lint/linter/space_after_property_colon_spec.rb
 - spec/scss_lint/linter/space_after_property_name_spec.rb
 - spec/scss_lint/linter/space_after_variable_colon_spec.rb