scss_lint 0.38.0 → 0.39.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cb1cc64b17da57ae25e2562d08665b6bb4712a55
-  data.tar.gz: d66077cdb7b9abcc5b4f69bf03035d08851726b0
+  metadata.gz: 246cc4b3c9ca9fe6b52f8ef4edd262694b701809
+  data.tar.gz: 18a0b888b01b4ddc391a17719b3853a77075ff92
 SHA512:
-  metadata.gz: 9ea54c1649b43fb5dc69e26623c6b7c8be57e9487b309af18160cdbc7afae8104175566bb571b24e923f59091df2d7cf9b751c1a852b7cce3729882295d5a941
-  data.tar.gz: a36364675cff2a840104d1e31262b2db9b3d0f35e14d77b04979f15ef1d4c52eafadac1ccdcf8960994c05a9a121a4c5f65f704922c13f244b0e38475408a7d2
+  metadata.gz: 49174f90f307f91898c0c409b4e8e711f9b0d99088005f5e1e979a1663b9be89c953a2a2431497c06b224a48d3e9dd7113392ac891c6bba6e08f9b0c67a2263b
+  data.tar.gz: 14098a3c8478fc0a65c222052054f3190a623a0bfc85fc4b107bb15b4cc5d802a1f95f341413a0dafe9f06d8fef74f6a9e845e1587c0ef1e317034c39dac2d15

data/config/default.yml

@@ -8,6 +8,10 @@ linters:
     space_before_bang: true
     space_after_bang: false
 
+  BemDepth:
+    enabled: false
+    max_elements: 1
+
   BorderZero:
     enabled: true
     convention: zero # or `none`
@@ -108,8 +112,7 @@ linters:
       'ms', 's',                               # Duration
       'Hz', 'kHz',                             # Frequency
       'dpi', 'dpcm', 'dppx',                   # Resolution
-      '%',                                     # Other
-    ]
+      '%']                                     # Other
     properties: {}
 
   PropertySortOrder:

data/lib/scss_lint/cli.rb

@@ -26,7 +26,7 @@ module SCSSLint
       options = SCSSLint::Options.new.parse(args)
       act_on_options(options)
     rescue => ex
-      handle_runtime_exception(ex)
+      handle_runtime_exception(ex, options)
     end
 
   private
@@ -63,7 +63,7 @@ module SCSSLint
       end
     end
 
-    def handle_runtime_exception(exception) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/LineLength, Metrics/MethodLength
+    def handle_runtime_exception(exception, options) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/LineLength, Metrics/MethodLength
       case exception
       when SCSSLint::Exceptions::InvalidCLIOption
         puts exception.message
@@ -88,26 +88,42 @@ module SCSSLint
         puts exception.message
         halt :usage
       else
+        config_file = relevant_configuration_file(options) if options
+
         puts exception.message
         puts exception.backtrace
         puts 'Report this bug at '.color(:yellow) + BUG_REPORT_URL.color(:cyan)
+        puts
+        puts 'To help fix this issue, please include:'.color(:green)
+        puts '- The above stack trace'
+        puts "- SCSS-Lint version: #{SCSSLint::VERSION.color(:cyan)}"
+        puts "- Sass version: #{Gem.loaded_specs['sass'].version.to_s.color(:cyan)}"
+        puts "- Ruby version: #{RUBY_VERSION.color(:cyan)}"
+        puts "- Contents of #{File.expand_path(config_file).color(:cyan)}" if config_file
         halt :software
       end
     end
 
     def setup_configuration(options)
-      config =
-        if options[:config_file]
-          Config.load(options[:config_file])
-        elsif File.exist?(Config::FILE_NAME)
-          Config.load(Config::FILE_NAME)
-        else
-          Config.default
-        end
-
+      config_file = relevant_configuration_file(options)
+      config = config_file ? Config.load(config_file) : Config.default
       merge_options_with_config(options, config)
     end
 
+    # Return the path of the configuration file that should be loaded.
+    #
+    # @param options [Hash]
+    # @return [String]
+    def relevant_configuration_file(options)
+      if options[:config_file]
+        options[:config_file]
+      elsif File.exist?(Config::FILE_NAME)
+        Config::FILE_NAME
+      elsif File.exist?(Config.user_file)
+        Config.user_file
+      end
+    end
+
     # @param options [Hash]
     # @param config [Config]
     # @return [Config]

data/lib/scss_lint/config.rb

@@ -25,6 +25,14 @@ module SCSSLint
         Config.new(config_options)
       end
 
+      # Returns the location of the user-wide scss-lint configuration.
+      #
+      # This needs to be a method instead of a constant so that we can change
+      # the user's home directory in tests.
+      def user_file
+        File.join(Dir.home, FILE_NAME)
+      end
+
       def linter_name(linter)
         linter = linter.is_a?(Class) ? linter : linter.class
         linter.name.split('::')[2..-1].join('::')

data/lib/scss_lint/linter/bem_depth.rb

@@ -0,0 +1,32 @@
+module SCSSLint
+  # Checks for BEM selectors with more elements than a specified maximum number.
+  class Linter::BemDepth < Linter
+    include LinterRegistry
+
+    def visit_root(_node)
+      @max_elements = config['max_elements']
+      yield # Continue linting children
+    end
+
+    def visit_class(klass)
+      check_depth(klass, 'selectors')
+    end
+
+    def visit_placeholder(placeholder)
+      check_depth(placeholder, 'placeholders')
+    end
+
+  private
+
+    def check_depth(node, plural_type)
+      selector = node.name
+      parts = selector.split('__')
+      num_elements = (parts[1..-1] || []).length
+      return if num_elements <= @max_elements
+
+      found_elements = pluralize(@max_elements, 'element')
+      add_lint(node, "BEM #{plural_type} should have no more than #{found_elements}, " \
+                     "but `#{selector}` has #{num_elements}")
+    end
+  end
+end

data/lib/scss_lint/linter/color_keyword.rb

@@ -20,6 +20,8 @@ module SCSSLint
   private
 
     def add_color_lint(node, original)
+      return if in_map?(node)
+
       hex_form = Sass::Script::Value::Color.new(color_keyword_to_code(original)).tap do |color|
         color.options = {} # `inspect` requires options to be set
       end.inspect
@@ -28,5 +30,9 @@ module SCSSLint
                "Color `#{original}` should be written in hexadecimal form " \
                "as `#{hex_form}`")
     end
+
+    def in_map?(node)
+      node_ancestor(node, 2).is_a?(Sass::Script::Tree::MapLiteral)
+    end
   end
 end

data/lib/scss_lint/linter/empty_line_between_blocks.rb

@@ -40,17 +40,28 @@ module SCSSLint
                     (next_start_line = following_node.line)
 
       # Special case: ignore comments immediately after a closing brace
-      line = engine.lines[next_start_line - 1].strip
-      return if following_node.is_a?(Sass::Tree::CommentNode) &&
-                line =~ %r{\s*\}?\s*/(/|\*)}
+      return if comment_after_closing_brace?(following_node, next_start_line)
+
+      # Special case: ignore `@else` nodes which are children of the parent `@if`
+      return if else_node?(following_node)
 
       # Otherwise check if line before the next node's starting line is blank
-      line = engine.lines[next_start_line - 2].strip
-      return if line.empty?
+      return if next_line_blank?(next_start_line)
 
       add_lint(next_start_line - 1, MESSAGE_FORMAT % [type, 'followed'])
     end
 
+    def comment_after_closing_brace?(node, next_start_line)
+      line = engine.lines[next_start_line - 1].strip
+
+      node.is_a?(Sass::Tree::CommentNode) &&
+        line =~ %r{\s*\}?\s*/(/|\*)}
+    end
+
+    def next_line_blank?(next_start_line)
+      engine.lines[next_start_line - 2].strip.empty?
+    end
+
     # In cases where the previous node is not a block declaration, we won't
     # have run any checks against it, so we need to check here if the previous
     # line is an empty line

data/lib/scss_lint/linter/indentation.rb

@@ -56,10 +56,16 @@ module SCSSLint
       end
     end
 
-    # Deal with `else` statements
-    def visit_if(node, &block)
-      check_and_visit_children(node, &block)
-      visit(node.else) if node.else
+    # Deal with `else` statements, which require special care since they are
+    # considered children of `if` statements.
+    def visit_if(node)
+      check_indentation(node)
+
+      if config['allow_non_nested_indentation']
+        yield # Continue linting else statement
+      else
+        visit(node.else) if node.else
+      end
     end
 
     # Need to define this explicitly since @at-root directives can contain
@@ -89,6 +95,12 @@ module SCSSLint
       end
     end
 
+    def visit_import(node)
+      prev = previous_node(node)
+      return if prev.is_a?(Sass::Tree::ImportNode) && source_from_range(prev.source_range) =~ /,$/
+      check_indentation(node)
+    end
+
     # Define node types that increase indentation level
     alias_method :visit_directive, :check_and_visit_children
     alias_method :visit_each,      :check_and_visit_children
@@ -107,7 +119,6 @@ module SCSSLint
     alias_method :visit_content,   :check_indentation
     alias_method :visit_cssimport, :check_indentation
     alias_method :visit_extend,    :check_indentation
-    alias_method :visit_import,    :check_indentation
     alias_method :visit_return,    :check_indentation
     alias_method :visit_variable,  :check_indentation
     alias_method :visit_warn,      :check_indentation
@@ -157,7 +168,7 @@ module SCSSLint
           return true
         end
       elsif !one_shift_greater_than_parent?(node, actual_indent)
-        parent_indent = node_indent(node.node_parent).length
+        parent_indent = node_indent(node_indent_parent(node)).length
         expected_indent = parent_indent + @indent_width
 
         add_lint(node.line,
@@ -181,7 +192,7 @@ module SCSSLint
     # @param node [Sass::Tree::Node]
     # @return [true,false]
     def one_shift_greater_than_parent?(node, actual_indent)
-      parent_indent = node_indent(node.node_parent).length
+      parent_indent = node_indent(node_indent_parent(node)).length
       expected_indent = parent_indent + @indent_width
       expected_indent == actual_indent
     end
@@ -193,5 +204,16 @@ module SCSSLint
     def node_indent(node)
       engine.lines[node.line - 1][/^(\s*)/, 1]
     end
+
+    def node_indent_parent(node)
+      if else_node?(node)
+        while node.node_parent.is_a?(Sass::Tree::IfNode) &&
+              node.node_parent.else == node
+          node = node.node_parent
+        end
+      end
+
+      node.node_parent
+    end
   end
 end

data/lib/scss_lint/sass/tree.rb

@@ -104,7 +104,7 @@ module Sass::Tree
 
   class IfNode
     def children
-      concat_expr_lists super, expr
+      concat_expr_lists super, expr, self.else
     end
   end
 
@@ -165,4 +165,15 @@ module Sass::Tree
       concat_expr_lists super, expr
     end
   end
+
+  class ImportNode
+    # Compares the names and values of two imports.
+    #
+    # @param other [Object] The object to compare with
+    # @return [Boolean] Whether or not this node and the other object
+    #   are the same
+    def ==(other)
+      self.class == other.class && imported_filename == other.imported_filename && super
+    end
+  end
 end

data/lib/scss_lint/utils.rb

@@ -35,6 +35,15 @@ module SCSSLint
       Sass::Script::Value::Color::COLOR_NAMES[string]
     end
 
+    # Returns whether a node is an IfNode corresponding to an @else/@else if
+    # statement.
+    #
+    # @param node [Sass::Tree::Node]
+    # @return [true,false]
+    def else_node?(node)
+      source_from_range(node.source_range).strip.start_with?('@else')
+    end
+
     # Given a selector array which is a list of strings with Sass::Script::Nodes
     # interspersed within them, return an array of strings representing those
     # selectors with the Sass::Script::Nodes removed (i.e., ignoring

data/lib/scss_lint/version.rb

@@ -1,4 +1,4 @@
 # Defines the gem version.
 module SCSSLint
-  VERSION = '0.38.0'
+  VERSION = '0.39.0'
 end

data/spec/scss_lint/cli_spec.rb

@@ -2,6 +2,8 @@ require 'spec_helper'
 require 'scss_lint/cli'
 
 describe SCSSLint::CLI do
+  include_context 'isolated environment'
+
   let(:config_options) do
     {
       'linters' => {
@@ -21,7 +23,9 @@ describe SCSSLint::CLI do
     @output = ''
     STDOUT.stub(:write) { |*args| @output.<<(*args) }
 
-    SCSSLint::Config.stub(:load).and_return(config)
+    SCSSLint::Config.stub(:load)
+                    .with(SCSSLint::Config::DEFAULT_FILE, merge_with_default: false)
+                    .and_return(config)
     SCSSLint::LinterRegistry.stub(:linters)
                             .and_return([SCSSLint::Linter::FakeTestLinter1,
                                          SCSSLint::Linter::FakeTestLinter2])
@@ -173,5 +177,44 @@ describe SCSSLint::CLI do
         safe_run
       end
     end
+
+    context 'when a config file is specified' do
+      let(:flags) { ['--config', 'custom_config.yml'] }
+
+      before do
+        File.stub(:exist?).with('.scss-lint.yml').and_return(true)
+        File.stub(:exist?).with(SCSSLint::Config.user_file).and_return(true)
+      end
+
+      it 'loads config from the specified file' do
+        SCSSLint::Config.should_receive(:load).with('custom_config.yml').and_return(config)
+        safe_run
+      end
+    end
+
+    context 'when a config file exists in the current directory and home directory' do
+      before do
+        File.stub(:exist?).with('.scss-lint.yml').and_return(true)
+        File.stub(:exist?).with(SCSSLint::Config.user_file).and_return(true)
+      end
+
+      it 'loads config from the current directory' do
+        SCSSLint::Config.should_receive(:load).with('.scss-lint.yml').and_return(config)
+        safe_run
+      end
+    end
+
+    context 'when a config file exists only in the user home directory' do
+      before do
+        File.stub(:exist?).with('.scss-lint.yml').and_return(false)
+        File.stub(:exist?).with(SCSSLint::Config.user_file).and_return(true)
+      end
+
+      it 'loads config from the home directory' do
+        config_path = File.expand_path('.scss-lint.yml', Dir.home)
+        SCSSLint::Config.should_receive(:load).with(config_path).and_return(config)
+        safe_run
+      end
+    end
   end
 end

data/spec/scss_lint/linter/bem_depth_spec.rb

@@ -0,0 +1,117 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::BemDepth do
+  context 'with the default maximum number of elements' do
+    context 'when a selector lacks elements' do
+      let(:scss) { <<-SCSS }
+        .block {
+          background: #f00;
+        }
+        %block {
+          background: #0f0;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when a selector contains one element' do
+      let(:scss) { <<-SCSS }
+        .block__element {
+          background: #f00;
+        }
+        %block__element {
+          background: #f00;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when a selector contains one element with a modifier' do
+      let(:scss) { <<-SCSS }
+        .block__element--modifier {
+          background: #f00;
+        }
+        %block__element--modifier {
+          background: #f00;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when a selector contains more than one element' do
+      let(:scss) { <<-SCSS }
+        .block__element__subelement {
+          background: #f00;
+        }
+        %block__element__subelement {
+          background: #f00;
+        }
+      SCSS
+
+      it { should report_lint line: 1 }
+      it { should report_lint line: 4 }
+    end
+
+    context 'when a selector contains more than one element with a modifier' do
+      let(:scss) { <<-SCSS }
+        .block__element__subelement--modifier {
+          background: #f00;
+        }
+        %block__element__subelement--modifier {
+          background: #f00;
+        }
+      SCSS
+
+      it { should report_lint line: 1 }
+      it { should report_lint line: 4 }
+    end
+  end
+
+  context 'with a custom maximum number of elements' do
+    let(:linter_config) { { 'max_elements' => 2 } }
+
+    context 'when selectors have up to the custom number of elements' do
+      let(:scss) { <<-SCSS }
+        .block__element__subelement {
+          background: #f00;
+        }
+        %block__element__subelement {
+          background: #f00;
+        }
+        .block__element__subelement--modifier {
+          background: #0f0;
+        }
+        %block__element__subelement--modifier {
+          background: #0f0;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when selectors have more than the custom number of elements' do
+      let(:scss) { <<-SCSS }
+        .block__element__subelement__other {
+          background: #f00;
+        }
+        %block__element__subelement__other {
+          background: #f00;
+        }
+        .block__element__subelement__other--modifier {
+          background: #0f0;
+        }
+        %block__element__subelement__other--modifier {
+          background: #0f0;
+        }
+      SCSS
+
+      it { should report_lint line: 1 }
+      it { should report_lint line: 4 }
+      it { should report_lint line: 7 }
+      it { should report_lint line: 10 }
+    end
+  end
+end

data/spec/scss_lint/linter/color_keyword_spec.rb

@@ -80,4 +80,23 @@ describe SCSSLint::Linter::ColorKeyword do
 
     it { should_not report_lint }
   end
+
+  context 'when a color keyword is used in a map declaration as keys' do
+    let(:scss) { <<-SCSS }
+      $palette: (
+        white: (
+          first:   #fff,
+          second:  #ccc,
+          third:   #000
+        ),
+        'black': (
+          first:   #000,
+          second:  #ccc,
+          third:   #fff
+        )
+      );
+    SCSS
+
+    it { should_not report_lint }
+  end
 end

data/spec/scss_lint/linter/empty_line_between_blocks_spec.rb

@@ -88,6 +88,20 @@ describe SCSSLint::Linter::EmptyLineBetweenBlocks do
     end
   end
 
+  context 'when a rule set is in an @if statement with an @else following it' do
+    let(:scss) { <<-SCSS }
+      @if $condition {
+        p {
+        }
+      } @else {
+        p {
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
   context 'when mixins are defined' do
     context 'and there is no blank line between them' do
       let(:scss) { <<-SCSS }

data/spec/scss_lint/linter/indentation_spec.rb

@@ -217,6 +217,15 @@ describe SCSSLint::Linter::Indentation do
     it { should report_lint line: 2 }
   end
 
+  context 'when an @import spans multiple lines' do
+    let(:scss) { <<-SCSS }
+      @import 'foo',
+          'bar';
+    SCSS
+
+    it { should_not report_lint }
+  end
+
   context 'when tabs are preferred' do
     let(:linter_config) { { 'character' => 'tab', 'width' => 1 } }
 
@@ -259,6 +268,20 @@ describe SCSSLint::Linter::Indentation do
       }
     end
 
+    context 'and an if statement is accompanied by a correctly indented else statement' do
+      let(:scss) { <<-SCSS }
+        @mixin my-func() {
+          @if $condition {
+            padding: 0;
+          } @else {
+            margin: 0;
+          }
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
     context 'and non-nested code is indented' do
       let(:scss) { <<-SCSS }
         .component {}

data/spec/scss_lint/reporter/json_reporter_spec.rb

@@ -77,7 +77,7 @@ describe SCSSLint::Reporter::JSONReporter do
       context 'when lints are warnings' do
         it 'marks each issue with a severity of "warning"' do
           json.values.inject(0) do |sum, issues|
-            sum + issues.select { |i| i['severity'] == 'warning' }.size
+            sum + issues.count { |i| i['severity'] == 'warning' }
           end.should == 3
         end
       end
@@ -87,7 +87,7 @@ describe SCSSLint::Reporter::JSONReporter do
 
         it 'marks each issue with a severity of "error"' do
           json.values.inject(0) do |sum, issues|
-            sum + issues.select { |i| i['severity'] == 'error' }.size
+            sum + issues.count { |i| i['severity'] == 'error' }
           end.should == 3
         end
       end

data/spec/spec_helper.rb

@@ -1,5 +1,4 @@
 require 'scss_lint'
-require 'nokogiri'
 
 Dir[File.dirname(__FILE__) + '/support/**/*.rb'].each { |f| require f }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss_lint
 version: !ruby/object:Gem::Version
-  version: 0.38.0
+  version: 0.39.0
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-03 00:00:00.000000000 Z
+date: 2015-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -39,20 +39,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.4.1
-- !ruby/object:Gem::Dependency
-  name: nokogiri
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.6.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.6.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -95,6 +81,7 @@ files:
 - lib/scss_lint/lint.rb
 - lib/scss_lint/linter.rb
 - lib/scss_lint/linter/bang_format.rb
+- lib/scss_lint/linter/bem_depth.rb
 - lib/scss_lint/linter/border_zero.rb
 - lib/scss_lint/linter/color_keyword.rb
 - lib/scss_lint/linter/color_variable.rb
@@ -154,7 +141,6 @@ files:
 - lib/scss_lint/reporter/default_reporter.rb
 - lib/scss_lint/reporter/files_reporter.rb
 - lib/scss_lint/reporter/json_reporter.rb
-- lib/scss_lint/reporter/xml_reporter.rb
 - lib/scss_lint/runner.rb
 - lib/scss_lint/sass/script.rb
 - lib/scss_lint/sass/tree.rb
@@ -166,6 +152,7 @@ files:
 - spec/scss_lint/engine_spec.rb
 - spec/scss_lint/file_finder_spec.rb
 - spec/scss_lint/linter/bang_format_spec.rb
+- spec/scss_lint/linter/bem_depth_spec.rb
 - spec/scss_lint/linter/border_zero_spec.rb
 - spec/scss_lint/linter/color_keyword_spec.rb
 - spec/scss_lint/linter/color_variable_spec.rb
@@ -224,7 +211,6 @@ files:
 - spec/scss_lint/reporter/default_reporter_spec.rb
 - spec/scss_lint/reporter/files_reporter_spec.rb
 - spec/scss_lint/reporter/json_reporter_spec.rb
-- spec/scss_lint/reporter/xml_reporter_spec.rb
 - spec/scss_lint/reporter_spec.rb
 - spec/scss_lint/runner_spec.rb
 - spec/scss_lint/selector_visitor_spec.rb
@@ -261,6 +247,7 @@ test_files:
 - spec/scss_lint/engine_spec.rb
 - spec/scss_lint/file_finder_spec.rb
 - spec/scss_lint/linter/bang_format_spec.rb
+- spec/scss_lint/linter/bem_depth_spec.rb
 - spec/scss_lint/linter/border_zero_spec.rb
 - spec/scss_lint/linter/color_keyword_spec.rb
 - spec/scss_lint/linter/color_variable_spec.rb
@@ -319,7 +306,6 @@ test_files:
 - spec/scss_lint/reporter/default_reporter_spec.rb
 - spec/scss_lint/reporter/files_reporter_spec.rb
 - spec/scss_lint/reporter/json_reporter_spec.rb
-- spec/scss_lint/reporter/xml_reporter_spec.rb
 - spec/scss_lint/reporter_spec.rb
 - spec/scss_lint/runner_spec.rb
 - spec/scss_lint/selector_visitor_spec.rb

data/lib/scss_lint/reporter/xml_reporter.rb

@@ -1,33 +0,0 @@
-module SCSSLint
-  # Reports lints in an XML format.
-  class Reporter::XMLReporter < Reporter
-    def report_lints
-      output = '<?xml version="1.0" encoding="utf-8"?>'
-
-      output << '<lint>'
-      lints.group_by(&:filename).each do |filename, file_lints|
-        output << "<file name=#{filename.encode(xml: :attr)}>"
-
-        file_lints.each do |lint|
-          output << issue_tag(lint)
-        end
-
-        output << '</file>'
-      end
-      output << '</lint>'
-
-      output
-    end
-
-  private
-
-    def issue_tag(lint)
-      "<issue linter=\"#{lint.linter.name if lint.linter}\" " \
-             "line=\"#{lint.location.line}\" " \
-             "column=\"#{lint.location.column}\" " \
-             "length=\"#{lint.location.length}\" " \
-             "severity=\"#{lint.severity}\" " \
-             "reason=#{lint.description.encode(xml: :attr)} />"
-    end
-  end
-end

data/spec/scss_lint/reporter/xml_reporter_spec.rb

@@ -1,103 +0,0 @@
-require 'spec_helper'
-
-describe SCSSLint::Reporter::XMLReporter do
-  subject { SCSSLint::Reporter::XMLReporter.new(lints) }
-
-  describe '#report_lints' do
-    let(:xml) { Nokogiri::XML(subject.report_lints) }
-
-    shared_examples_for 'XML document' do
-      it 'has an encoding of UTF-8' do
-        xml.encoding.should == 'utf-8'
-      end
-
-      it 'has an XML version of 1.0' do
-        xml.version.should == '1.0'
-      end
-
-      it 'contains a <lint> root element' do
-        xml.root.name.should == 'lint'
-      end
-    end
-
-    context 'when there are no lints' do
-      let(:lints) { [] }
-
-      it_should_behave_like 'XML document'
-    end
-
-    context 'when there are lints' do
-      let(:filenames)    { ['f1.scss', 'f2.scss', 'f1.scss'] }
-      # Include invalid XML characters in the third description to validate
-      # that escaping happens for preventing broken XML output
-      let(:descriptions) { ['lint 1', 'lint 2', 'lint 3 " \' < & >'] }
-      let(:severities)   { [:warning] * 3 }
-
-      let(:locations)    do
-        [
-          SCSSLint::Location.new(5,  2, 3),
-          SCSSLint::Location.new(7,  6, 2),
-          SCSSLint::Location.new(9, 10, 1)
-        ]
-      end
-
-      let(:lints) do
-        filenames.each_with_index.map do |filename, index|
-          SCSSLint::Lint.new(nil, filename, locations[index],
-                             descriptions[index], severities[index])
-        end
-      end
-
-      it_should_behave_like 'XML document'
-
-      it 'contains an <issue> node for each lint' do
-        xml.xpath('//issue').count.should == 3
-      end
-
-      it 'contains a <file> node for each file' do
-        xml.xpath('//file').map { |node| node[:name] }
-          .should =~ filenames.uniq
-      end
-
-      it 'contains <issue> nodes grouped by <file>' do
-        xml.xpath('//file').map do |file_node|
-          file_node.xpath('./issue').count
-        end.should =~ [1, 2]
-      end
-
-      it 'marks each issue with a line number' do
-        xml.xpath('//issue[@line]').map { |node| node[:line] }
-          .should =~ locations.map { |location| location.line.to_s }
-      end
-
-      it 'marks each issue with a column number' do
-        xml.xpath('//issue[@column]').map { |node| node[:column] }
-          .should =~ locations.map { |location| location.column.to_s }
-      end
-
-      it 'marks each issue with a length' do
-        xml.xpath('//issue[@length]').map { |node| node[:length] }
-          .should =~ locations.map { |location| location.length.to_s }
-      end
-
-      it 'marks each issue with a reason containing the lint description' do
-        xml.xpath('//issue[@reason]').map { |node| node[:reason] }
-          .should =~ descriptions
-      end
-
-      context 'when lints are warnings' do
-        it 'marks each issue with a severity of "warning"' do
-          xml.xpath("//issue[@severity='warning']").count == 3
-        end
-      end
-
-      context 'when lints are errors' do
-        let(:severities) { [:error] * 3 }
-
-        it 'marks each issue with a severity of "error"' do
-          xml.xpath("//issue[@severity='error']").count == 3
-        end
-      end
-    end
-  end
-end