scss-lint 0.4 → 0.5

data/lib/scss_lint/linter/duplicate_selector_linter.rb

@@ -0,0 +1,45 @@
+require 'sass'
+require 'set'
+
+module SCSSLint
+  class Linter::DuplicateSelectorLinter < Linter
+    include LinterRegistry
+
+    class << self
+      def run(engine)
+        lints = []
+        engine.tree.each do |node|
+          if node.is_a?(Sass::Tree::RuleNode)
+            lints << check_selector_already_used(node)
+          end
+        end
+        lints.compact
+      end
+
+      def description
+        'Rule was declared with same selector as another--you should merge them'
+      end
+
+    private
+
+      def check_selector_already_used(rule_node)
+        #selectors_seen = Set.new
+
+        puts rule_node.rule.inspect
+        puts rule_node.resolved_rules
+
+        #rule_node.children.each do |child|
+          #selectors = child.rule.first.to_s.gsub(/\s/, '')
+
+          #if selectors_seen.member?(selectors)
+            #return create_lint(child)
+          #else
+            #selectors_seen.add selectors
+          #end
+        #end
+
+        nil
+      end
+    end
+  end
+end

data/lib/scss_lint/linter/shorthand_linter.rb

@@ -23,23 +23,24 @@ module SCSSLint
 
       def check_valid_shorthand_value(prop_node)
         if prop_node.value.is_a?(Sass::Script::String) &&
-           prop_node.value.to_s.strip =~ /\A(\S+\s+\S+\s+\S+(\s+\S+)?)\Z/
+           prop_node.value.to_s.strip =~ /\A(\S+\s+\S+(\s+\S+){0,2})\Z/
           return create_lint(prop_node) unless valid_shorthand?($1)
         end
       end
 
       def valid_shorthand?(shorthand)
         values = shorthand.split(/\s+/)
+        top, right, bottom, left = values
 
-        if values[0] == values[1] &&
-           values[1] == values[2] &&
-           values[2] == values[3]
+        if top == right && right == bottom && bottom == left
           false
-        elsif values[0] == values[2] && values[1] == values[3]
+        elsif top == right && bottom.nil? && left.nil?
           false
-        elsif values[0] == values[2] && values[3].nil?
+        elsif top == bottom && right == left
           false
-        elsif values[1] == values[3]
+        elsif top == bottom && left.nil?
+          false
+        elsif right == left
           false
         else
           true

data/lib/scss_lint/version.rb

@@ -1,3 +1,3 @@
 module SCSSLint
-  VERSION = '0.4'
+  VERSION = '0.5'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss-lint
 version: !ruby/object:Gem::Version
-  version: '0.4'
+  version: '0.5'
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-15 00:00:00.000000000 Z
+date: 2013-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -73,6 +73,7 @@ files:
 - lib/scss_lint/lint.rb
 - lib/scss_lint/linter.rb
 - lib/scss_lint/linter/declaration_order_linter.rb
+- lib/scss_lint/linter/duplicate_selector_linter.rb
 - lib/scss_lint/linter/empty_rule_linter.rb
 - lib/scss_lint/linter/debug_linter.rb
 - lib/scss_lint/linter/single_line_per_selector_linter.rb