scss-lint 0.35.0 → 0.36.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b4c9a5150295e39ef201b5e859ec234fca634c4f
-  data.tar.gz: 7ba8ffe0e6d78046545adc099c8da31fa66ade90
+  metadata.gz: 8f923a4288fb1d256d16d482a77e3c73a8aff84d
+  data.tar.gz: 2da5da450f72c3947f454bafe1c33d5244dfc304
 SHA512:
-  metadata.gz: f845f596de85f75b73877b5119d7b489595235ae0bf528fc6b5d1bfa3a9d9876ae362a3971358fe3f3851b068fb61fad663ecf54360ed1c52ac0e3a0e1eaf4d4
-  data.tar.gz: 91ef3f85f89903fa81f3f6d125c6514af658da43c9ba13d46d86e11aa0cfcdafdb3f6f88ba5723ed634a9ca276523bdb689acbc49b351c631fdebc4b6669fda9
+  metadata.gz: 868fe445178e21cd235460029c6ab6ab914bc271a1e66c6fd462df517fd0deca3b08b2a974ddb3f362056da510d928f0e64c7aac33dbd6e932dc4752b2db042c
+  data.tar.gz: b7086af86736d1470bf627c7cd65cafeead516855e2431417eb1b6d4a4fd6283fff34157b59bea8eb19ccaddfe95c20722cce80565354fcda134859f911a51de

data/config/default.yml

@@ -98,6 +98,11 @@ linters:
     include_nested: false
     max_properties: 10
 
+  PropertyUnits:
+    enabled: true
+    global: ['em', 'ex', '%', 'px', 'ch', 'cm', 'mm', 'in', 'pt', 'pc', 'rem', 'vh', 'vw', 'vmin', 'vmax']
+    properties: {}
+
   PropertySortOrder:
     enabled: true
     ignore_unspecified: false

data/lib/scss_lint/cli.rb

@@ -10,13 +10,16 @@ module SCSSLint
 
     # Subset of semantic exit codes conforming to `sysexits` documentation.
     EXIT_CODES = {
-      ok:        0,
-      warning:   1,  # One or more warnings (but no errors) were reported
-      error:     2,  # One or more errors were reported
-      usage:     64, # Command line usage error
-      no_input:  66, # Input file did not exist or was not readable
-      software:  70, # Internal software error
-      config:    78, # Configuration error
+      ok:             0,
+      warning:        1,  # One or more warnings (but no errors) were reported
+      error:          2,  # One or more errors were reported
+      usage:          64, # Command line usage error
+      no_input:       66, # Input file did not exist or was not readable
+      unavailable:    69, # Required library is unavailable
+      software:       70, # Internal software error
+      config:         78, # Configuration error
+      no_files:       80, # No files matched by specified glob patterns
+      files_filtered: 81, # All matched files were filtered by exclusions
     }
 
     def run(args)
@@ -60,7 +63,7 @@ module SCSSLint
       end
     end
 
-    def handle_runtime_exception(exception) # rubocop:disable Metrics/AbcSize
+    def handle_runtime_exception(exception) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/LineLength, Metrics/MethodLength
       case exception
       when SCSSLint::Exceptions::InvalidCLIOption
         puts exception.message
@@ -69,7 +72,16 @@ module SCSSLint
       when SCSSLint::Exceptions::InvalidConfiguration
         puts exception.message
         halt :config
-      when NoFilesError, Errno::ENOENT
+      when SCSSLint::Exceptions::RequiredLibraryMissingError
+        puts exception.message
+        halt :unavailable
+      when SCSSLint::Exceptions::AllFilesFilteredError
+        puts exception.message
+        halt :files_filtered
+      when SCSSLint::Exceptions::NoFilesError
+        puts exception.message
+        halt :no_files
+      when Errno::ENOENT
         puts exception.message
         halt :no_input
       when NoSuchLinter
@@ -137,6 +149,9 @@ module SCSSLint
       Array(options[:required_paths]).each do |path|
         require path
       end
+    rescue LoadError => ex
+      raise SCSSLint::Exceptions::RequiredLibraryMissingError,
+            "Required library not found: #{ex.message}"
     end
 
     def load_reporters(options)

data/lib/scss_lint/config.rb

@@ -208,6 +208,10 @@ module SCSSLint
       end
     end
 
+    def exclude_patterns
+      @options.fetch('exclude', [])
+    end
+
     def excluded_file_for_linter?(file_path, linter)
       abs_path = File.expand_path(file_path)
 

data/lib/scss_lint/constants.rb

@@ -3,6 +3,6 @@ module SCSSLint
   SCSS_LINT_HOME = File.realpath(File.join(File.dirname(__FILE__), '..', '..'))
   SCSS_LINT_DATA = File.join(SCSS_LINT_HOME, 'data')
 
-  REPO_URL = 'https://github.com/causes/scss-lint'
+  REPO_URL = 'https://github.com/brigade/scss-lint'
   BUG_REPORT_URL = "#{REPO_URL}/issues"
 end

data/lib/scss_lint/exceptions.rb

@@ -1,4 +1,8 @@
 module SCSSLint::Exceptions
+  # Raised when all files matched by the specified glob patterns were filtered
+  # by exclude patterns.
+  class AllFilesFilteredError < StandardError; end
+
   # Raised when an invalid flag is given via the command line.
   class InvalidCLIOption < StandardError; end
 
@@ -7,4 +11,11 @@ module SCSSLint::Exceptions
 
   # Raised when an unexpected error occurs in a linter
   class LinterError < StandardError; end
+
+  # Raised when no files were specified or specified glob patterns did not match
+  # any files.
+  class NoFilesError < StandardError; end
+
+  # Raised when a required library (specified via command line) does not exist.
+  class RequiredLibraryMissingError < StandardError; end
 end

data/lib/scss_lint/file_finder.rb

@@ -22,9 +22,20 @@ module SCSSLint
       # If no explicit patterns given, use patterns listed in config
       patterns = @config.scss_files if patterns.empty?
 
-      extract_files_from(patterns).reject do |file|
-        @config.excluded_file?(file)
+      matched_files = extract_files_from(patterns)
+      if matched_files.empty?
+        raise SCSSLint::Exceptions::NoFilesError,
+              "No SCSS files matched by the patterns: #{patterns.join(' ')}"
       end
+
+      filtered_files = matched_files.reject { |file| @config.excluded_file?(file) }
+      if filtered_files.empty?
+        raise SCSSLint::Exceptions::AllFilesFilteredError,
+              "All files matched by the patterns [#{patterns.join(', ')}] " \
+              "were excluded by the patterns: [#{@config.exclude_patterns.join(', ')}]"
+      end
+
+      filtered_files
     end
 
   private

data/lib/scss_lint/linter/color_variable.rb

@@ -4,7 +4,9 @@ module SCSSLint
     include LinterRegistry
 
     def visit_script_color(node)
-      return if in_variable_declaration?(node)
+      return if in_variable_declaration?(node) ||
+                in_map_declaration?(node) ||
+                in_rgba_function_call?(node)
 
       # Source range sometimes includes closing parenthesis, so extract it
       color = source_from_range(node.source_range)[/(#?[a-z0-9]+)/i, 1]
@@ -32,5 +34,16 @@ module SCSSLint
       parent.is_a?(Sass::Script::Tree::Literal) &&
         parent.node_parent.is_a?(Sass::Tree::VariableNode)
     end
+
+    def in_rgba_function_call?(node)
+      grandparent = node_ancestor(node, 2)
+
+      grandparent.is_a?(Sass::Script::Tree::Funcall) &&
+        grandparent.name == 'rgba'
+    end
+
+    def in_map_declaration?(node)
+      node_ancestor(node, 2).is_a?(Sass::Script::Tree::MapLiteral)
+    end
   end
 end

data/lib/scss_lint/linter/declaration_order.rb

@@ -35,14 +35,25 @@ module SCSSLint
 
     def check_node(node)
       children = node.children.select { |n| important_node?(n) }
-                              .map { |n| node_declaration_type(n) }
+                              .map { |n| [n, node_declaration_type(n)] }
 
-      sorted_children = children.sort do |a, b|
-        DECLARATION_ORDER.index(a) <=> DECLARATION_ORDER.index(b)
+      sorted_children = children.sort do |(_, a_type), (_, b_type)|
+        DECLARATION_ORDER.index(a_type) <=> DECLARATION_ORDER.index(b_type)
       end
 
-      return unless children != sorted_children
-      add_lint(node.children.first, MESSAGE)
+      check_children_order(sorted_children, children)
+    end
+
+    # Find the child that is out of place
+    def check_children_order(sorted_children, children)
+      sorted_children.each_with_index do |sorted_item, index|
+        next if sorted_item == children[index]
+
+        add_lint(sorted_item.first.line,
+                 "Expected item on line #{sorted_item.first.line} to appear " \
+                 "before line #{children[index].first.line}. #{MESSAGE}")
+        break
+      end
     end
 
     def node_declaration_type(node)

data/lib/scss_lint/linter/property_units.rb

@@ -0,0 +1,58 @@
+module SCSSLint
+  # Check for allowed units
+  class Linter::PropertyUnits < Linter
+    include LinterRegistry
+
+    def visit_root(_node)
+      @globally_allowed_units = config['global'].to_set
+      @allowed_units_for_property = config['properties']
+
+      yield # Continue linting children
+    end
+
+    def visit_prop(node)
+      property = node.name.join
+
+      # Handle nested properties by ensuring the full name is extracted
+      if @nested_under
+        property = "#{@nested_under}-#{property}"
+      end
+
+      if units = node.value.value.to_s[/(?:\d+|\d*\.?\d+)([a-z%]+)/i, 1]
+        check_units(node, property, units)
+      end
+
+      @nested_under = property
+      yield # Continue linting nested properties
+      @nested_under = nil
+    end
+
+  private
+
+    # Checks if a property value's units are allowed.
+    #
+    # @param node [Sass::Tree::Node]
+    # @param property [String]
+    # @param units [String]
+    def check_units(node, property, units)
+      allowed_units = allowed_units_for_property(property)
+      return if allowed_units.include?(units)
+
+      add_lint(node,
+               "#{units} units not allowed on `#{property}`; must be one of " \
+               "(#{allowed_units.to_a.sort.join(', ')})")
+    end
+
+    # Return the list of allowed units for a property.
+    #
+    # @param property [String]
+    # @return Array<String>
+    def allowed_units_for_property(property)
+      if @allowed_units_for_property.key?(property)
+        @allowed_units_for_property[property]
+      else
+        @globally_allowed_units
+      end
+    end
+  end
+end

data/lib/scss_lint/linter/space_after_property_colon.rb

@@ -23,6 +23,8 @@ module SCSSLint
       when 'at_least_one_space'
         check_for_at_least_one_space(node, spaces)
       end
+
+      yield # Continue linting children
     end
 
   private

data/lib/scss_lint/runner.rb

@@ -1,6 +1,4 @@
 module SCSSLint
-  class NoFilesError < StandardError; end
-
   # Finds and aggregates all lints found by running the registered linters
   # against a set of SCSS files.
   class Runner
@@ -15,8 +13,6 @@ module SCSSLint
 
     # @param files [Array]
     def run(files)
-      raise NoFilesError, 'No SCSS files specified' if files.empty?
-
       files.each do |file|
         find_lints(file)
       end

data/lib/scss_lint/utils.rb

@@ -82,6 +82,22 @@ module SCSSLint
           .select { |child| child.is_a?(Sass::Tree::Node) }
     end
 
+    # Return nth-ancestor of a node, where 1 is the parent, 2 is grandparent,
+    # etc.
+    #
+    # @param node [Sass::Tree::Node, Sass::Script::Tree::Node]
+    # @param level [Integer]
+    # @return [Sass::Tree::Node, Sass::Script::Tree::Node, nil]
+    def node_ancestor(node, levels)
+      while levels > 0
+        node = node.node_parent
+        return unless node
+        levels -= 1
+      end
+
+      node
+    end
+
     def pluralize(value, word)
       value == 1 ? "#{value} #{word}" : "#{value} #{word}s"
     end

data/lib/scss_lint/version.rb

@@ -1,4 +1,4 @@
 # Defines the gem version.
 module SCSSLint
-  VERSION = '0.35.0'
+  VERSION = '0.36.0'
 end

data/spec/scss_lint/cli_spec.rb

@@ -134,5 +134,44 @@ describe SCSSLint::CLI do
         @output.should include SCSSLint::BUG_REPORT_URL
       end
     end
+
+    context 'when a required library is not found' do
+      let(:flags) { ['--require', 'some_non_existent_library'] }
+
+      before do
+        Kernel.stub(:require).with('some_non_existent_library').and_raise(
+          SCSSLint::Exceptions::RequiredLibraryMissingError
+        )
+      end
+
+      it 'exits with an appropriate status code' do
+        subject.should_receive(:halt).with(:unavailable)
+        safe_run
+      end
+    end
+
+    context 'when specified SCSS file globs match no files' do
+      before do
+        SCSSLint::FileFinder.any_instance.stub(:find)
+          .and_raise(SCSSLint::Exceptions::NoFilesError)
+      end
+
+      it 'exits with an appropriate status code' do
+        subject.should_receive(:halt).with(:no_files)
+        safe_run
+      end
+    end
+
+    context 'when all specified SCSS files are filtered by exclusions' do
+      before do
+        SCSSLint::FileFinder.any_instance.stub(:find)
+          .and_raise(SCSSLint::Exceptions::AllFilesFilteredError)
+      end
+
+      it 'exits with an appropriate status code' do
+        subject.should_receive(:halt).with(:files_filtered)
+        safe_run
+      end
+    end
   end
 end

data/spec/scss_lint/file_finder_spec.rb

@@ -14,7 +14,9 @@ describe SCSSLint::FileFinder do
       let(:patterns) { [] }
 
       context 'and there are no SCSS files under the current directory' do
-        it { should == [] }
+        it 'raises an error' do
+          expect { subject }.to raise_error SCSSLint::Exceptions::NoFilesError
+        end
       end
 
       context 'and there are SCSS files under the current directory' do
@@ -68,6 +70,16 @@ describe SCSSLint::FileFinder do
           end
 
           it { should == ['some-dir/test.scss'] }
+
+          context 'and those SCSS files are excluded by the config' do
+            before do
+              config.exclude_file('some-dir/test.scss')
+            end
+
+            it 'raises an error' do
+              expect { subject }.to raise_error SCSSLint::Exceptions::AllFilesFilteredError
+            end
+          end
         end
 
         context 'and they contain CSS files' do
@@ -85,14 +97,26 @@ describe SCSSLint::FileFinder do
           end
 
           it { should == ['some-dir/more-dir/test.scss'] }
+
+          context 'and those SCSS files are excluded by the config' do
+            before do
+              config.exclude_file('**/*.scss')
+            end
+
+            it 'raises an error' do
+              expect { subject }.to raise_error SCSSLint::Exceptions::AllFilesFilteredError
+            end
+          end
         end
 
-        context 'and they contain files with some other extension' do
+        context 'and they contain no SCSS files' do
           before do
             `touch some-dir/test.txt`
           end
 
-          it { should == [] }
+          it 'raises an error' do
+            expect { subject }.to raise_error SCSSLint::Exceptions::NoFilesError
+          end
         end
       end
 

data/spec/scss_lint/linter/color_variable_spec.rb

@@ -119,4 +119,27 @@ describe SCSSLint::Linter::ColorVariable do
 
     it { should_not report_lint }
   end
+
+  context 'when a color literal is used in the special rgba shorthand helper' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: rgba(#fff, .5);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a color literal is used in a map declaration' do
+    let(:scss) { <<-SCSS }
+      $shades-of-gray: (
+        darker:  #4c4c4c,
+        dark:    #626262,
+        light:   #7d7d7d,
+        lighter: #979797
+      );
+    SCSS
+
+    it { should_not report_lint }
+  end
 end

data/spec/scss_lint/linter/declaration_order_spec.rb

@@ -89,7 +89,7 @@ describe SCSSLint::Linter::DeclarationOrder do
       }
     SCSS
 
-    it { should report_lint }
+    it { should report_lint line: 6 }
   end
 
   context 'when nested rule set' do
@@ -116,7 +116,7 @@ describe SCSSLint::Linter::DeclarationOrder do
         }
       SCSS
 
-      it { should report_lint }
+      it { should report_lint line: 4 }
     end
 
     context 'contains @extend after nested rule set' do
@@ -131,7 +131,7 @@ describe SCSSLint::Linter::DeclarationOrder do
         }
       SCSS
 
-      it { should report_lint }
+      it { should report_lint line: 6 }
     end
   end
 
@@ -161,7 +161,7 @@ describe SCSSLint::Linter::DeclarationOrder do
         }
       SCSS
 
-      it { should report_lint }
+      it { should report_lint line: 3 }
     end
   end
 
@@ -176,7 +176,7 @@ describe SCSSLint::Linter::DeclarationOrder do
         }
       SCSS
 
-      it { should report_lint }
+      it { should report_lint line: 5 }
     end
 
     context 'after a property' do
@@ -202,7 +202,7 @@ describe SCSSLint::Linter::DeclarationOrder do
         }
       SCSS
 
-      it { should report_lint }
+      it { should report_lint line: 5 }
     end
 
     context 'before a rule set' do
@@ -232,7 +232,7 @@ describe SCSSLint::Linter::DeclarationOrder do
         }
       SCSS
 
-      it { should report_lint }
+      it { should report_lint line: 5 }
     end
 
     context 'with its own nested rule set' do
@@ -246,7 +246,7 @@ describe SCSSLint::Linter::DeclarationOrder do
           }
         SCSS
 
-        it { should report_lint }
+        it { should report_lint line: 5 }
       end
 
       context 'after a property' do
@@ -303,7 +303,7 @@ describe SCSSLint::Linter::DeclarationOrder do
         }
       SCSS
 
-      it { should report_lint }
+      it { should report_lint line: 7 }
     end
   end
 
@@ -331,7 +331,7 @@ describe SCSSLint::Linter::DeclarationOrder do
         }
       SCSS
 
-      it { should report_lint }
+      it { should report_lint line: 4 }
     end
 
     context 'contains @extend after nested rule set' do
@@ -346,7 +346,7 @@ describe SCSSLint::Linter::DeclarationOrder do
         }
       SCSS
 
-      it { should report_lint }
+      it { should report_lint line: 6 }
     end
   end
 
@@ -360,7 +360,7 @@ describe SCSSLint::Linter::DeclarationOrder do
       }
     SCSS
 
-    it { should report_lint }
+    it { should report_lint line: 5 }
   end
 
   context 'when a pseudo-element appears after a property' do
@@ -399,7 +399,7 @@ describe SCSSLint::Linter::DeclarationOrder do
       }
     SCSS
 
-    it { should report_lint }
+    it { should report_lint line: 5 }
   end
 
   context 'when a selector with parent reference appears after a property' do
@@ -425,7 +425,7 @@ describe SCSSLint::Linter::DeclarationOrder do
       }
     SCSS
 
-    it { should report_lint }
+    it { should report_lint line: 5 }
   end
 
   context 'when a pseudo-element appears after a property' do
@@ -451,7 +451,7 @@ describe SCSSLint::Linter::DeclarationOrder do
       }
     SCSS
 
-    it { should report_lint }
+    it { should report_lint line: 5 }
   end
 
   context 'when a direct descendent appears after a property' do
@@ -477,7 +477,7 @@ describe SCSSLint::Linter::DeclarationOrder do
       }
     SCSS
 
-    it { should report_lint }
+    it { should report_lint line: 5 }
   end
 
   context 'when an adjacent sibling appears after a property' do
@@ -503,7 +503,7 @@ describe SCSSLint::Linter::DeclarationOrder do
       }
     SCSS
 
-    it { should report_lint }
+    it { should report_lint line: 5 }
   end
 
   context 'when a general sibling appears after a property' do
@@ -529,7 +529,7 @@ describe SCSSLint::Linter::DeclarationOrder do
       }
     SCSS
 
-    it { should report_lint }
+    it { should report_lint line: 5 }
   end
 
   context 'when a descendent appears after a property' do
@@ -555,6 +555,6 @@ describe SCSSLint::Linter::DeclarationOrder do
       }
     SCSS
 
-    it { should report_lint }
+    it { should report_lint line: 5 }
   end
 end

data/spec/scss_lint/linter/property_units_spec.rb

@@ -0,0 +1,199 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::PropertyUnits do
+  context 'when global units are set and local are not set' do
+    let(:linter_config) { { 'global' => ['rem'], 'properties' => {} } }
+
+    context 'when unit is allowed' do
+      let(:scss) { <<-SCSS }
+        p {
+          font-size: 1.54rem;
+          margin: 1rem;
+          padding: .1rem;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when unit is not allowed' do
+      let(:scss) { <<-SCSS }
+        p {
+          font-size: 16.54px;
+          margin: 1px;
+          padding: .1px;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should report_lint line: 4 }
+    end
+
+    context 'when using a shorthand property' do
+      context 'and the unit is allowed' do
+        let(:scss) { <<-SCSS }
+          p {
+            font: italic 1rem Serif;
+          }
+        SCSS
+
+        it { should_not report_lint }
+      end
+
+      context 'and the unit is not allowed' do
+        let(:scss) { <<-SCSS }
+          p {
+            font: italic 16px Serif;
+          }
+        SCSS
+
+        it { should report_lint line: 2 }
+      end
+    end
+  end
+
+  context 'when global and local units are set' do
+    let(:linter_config) { { 'global' => ['rem'], 'properties' => { 'font-size' => ['px'] } } }
+
+    context 'when unit is allowed locally not globally' do
+      let(:scss) { <<-SCSS }
+        p {
+          font-size: 16px;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when unit is allowed globally not locally' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 1rem;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when unit is not allowed globally nor locally' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 1vh;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+  end
+
+  context 'when local units are set and global are not set' do
+    let(:linter_config) { { 'global' => [], 'properties' => { 'margin' => ['rem'] } } }
+
+    context 'when unit is allowed locally not globally' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 1rem;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when unit is not allowed locally nor globally' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 10px;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+  end
+
+  context 'when multiple units are set on a property' do
+    let(:linter_config) { { 'global' => [], 'properties' => { 'margin' => %w[rem em] } } }
+
+    context 'when one of multiple units is used' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 1rem;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when another of multiple units is used' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 1em;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when a not allowed unit is used' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 10px;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+  end
+
+  context 'when no local units are allowed' do
+    let(:linter_config) { { 'global' => ['px'], 'properties' => { 'line-height' => [] } } }
+
+    context 'when a disallowed unit is used' do
+      let(:scss) { <<-SCSS }
+        p {
+          line-height: 10px;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when no unit is used' do
+      let(:scss) { <<-SCSS }
+        p {
+          line-height: 1;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when nested properties are used' do
+    let(:linter_config) { { 'global' => ['rem'], 'properties' => { 'font-size' => ['em'] } } }
+
+    context 'and an allowed unit is used' do
+      let(:scss) { <<-SCSS }
+        p {
+          font: {
+            size: 1em;
+          }
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'and a disallowed unit is used' do
+      let(:scss) { <<-SCSS }
+        p {
+          font: {
+            size: 16px;
+          }
+        }
+      SCSS
+
+      it { should report_lint line: 3 }
+    end
+  end
+end

data/spec/scss_lint/linter/space_after_property_colon_spec.rb

@@ -69,6 +69,18 @@ describe SCSSLint::Linter::SpaceAfterPropertyColon do
         it { should report_lint }
       end
     end
+
+    context 'when there are nested properties with incorrect spacing' do
+      let(:scss) { <<-SCSS }
+        .class {
+          font: {
+            weight :bold;
+          }
+        }
+      SCSS
+
+      it { should report_lint line: 3 }
+    end
   end
 
   context 'when no spaces are allowed' do

data/spec/scss_lint/runner_spec.rb

@@ -36,14 +36,6 @@ describe SCSSLint::Runner do
       subject
     end
 
-    context 'when no files are given' do
-      let(:files) { [] }
-
-      it 'raises an error' do
-        expect { subject }.to raise_error SCSSLint::NoFilesError
-      end
-    end
-
     context 'when all linters are disabled' do
       let(:config_options) do
         {

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: scss-lint
 version: !ruby/object:Gem::Version
-  version: 0.35.0
+  version: 0.36.0
 platform: ruby
 authors:
-- Causes Engineering
+- Brigade Engineering
 - Shane da Silva
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-20 00:00:00.000000000 Z
+date: 2015-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -69,8 +69,8 @@ dependencies:
         version: '3.0'
 description: Configurable tool for writing clean and consistent SCSS
 email:
-- eng@causes.com
-- shane@causes.com
+- eng@brigade.com
+- shane.dasilva@brigade.com
 executables:
 - scss-lint
 extensions: []
@@ -123,6 +123,7 @@ files:
 - lib/scss_lint/linter/property_count.rb
 - lib/scss_lint/linter/property_sort_order.rb
 - lib/scss_lint/linter/property_spelling.rb
+- lib/scss_lint/linter/property_units.rb
 - lib/scss_lint/linter/qualifying_element.rb
 - lib/scss_lint/linter/selector_depth.rb
 - lib/scss_lint/linter/selector_format.rb
@@ -192,6 +193,7 @@ files:
 - spec/scss_lint/linter/property_count_spec.rb
 - spec/scss_lint/linter/property_sort_order_spec.rb
 - spec/scss_lint/linter/property_spelling_spec.rb
+- spec/scss_lint/linter/property_units_spec.rb
 - spec/scss_lint/linter/qualifying_element_spec.rb
 - spec/scss_lint/linter/selector_depth_spec.rb
 - spec/scss_lint/linter/selector_format_spec.rb
@@ -229,7 +231,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/isolated_environment.rb
 - spec/support/matchers/report_lint.rb
-homepage: https://github.com/causes/scss-lint
+homepage: https://github.com/brigade/scss-lint
 licenses:
 - MIT
 metadata: {}
@@ -255,15 +257,13 @@ specification_version: 4
 summary: SCSS lint tool
 test_files:
 - spec/scss_lint/config_spec.rb
-- spec/scss_lint/file_finder_spec.rb
+- spec/scss_lint/engine_spec.rb
 - spec/scss_lint/linter/bang_format_spec.rb
 - spec/scss_lint/linter/border_zero_spec.rb
 - spec/scss_lint/linter/color_keyword_spec.rb
-- spec/scss_lint/linter/color_variable_spec.rb
 - spec/scss_lint/linter/comment_spec.rb
 - spec/scss_lint/linter/compass/property_with_mixin_spec.rb
 - spec/scss_lint/linter/debug_statement_spec.rb
-- spec/scss_lint/linter/declaration_order_spec.rb
 - spec/scss_lint/linter/duplicate_property_spec.rb
 - spec/scss_lint/linter/else_placement_spec.rb
 - spec/scss_lint/linter/empty_line_between_blocks_spec.rb
@@ -275,6 +275,7 @@ test_files:
 - spec/scss_lint/linter/id_selector_spec.rb
 - spec/scss_lint/linter/import_path_spec.rb
 - spec/scss_lint/linter/important_rule_spec.rb
+- spec/scss_lint/linter/indentation_spec.rb
 - spec/scss_lint/linter/leading_zero_spec.rb
 - spec/scss_lint/linter/mergeable_selector_spec.rb
 - spec/scss_lint/linter/name_format_spec.rb
@@ -304,7 +305,9 @@ test_files:
 - spec/scss_lint/linter/variable_for_property_spec.rb
 - spec/scss_lint/linter/vendor_prefix_spec.rb
 - spec/scss_lint/linter/zero_unit_spec.rb
-- spec/scss_lint/linter/indentation_spec.rb
+- spec/scss_lint/linter/color_variable_spec.rb
+- spec/scss_lint/linter/property_units_spec.rb
+- spec/scss_lint/linter/declaration_order_spec.rb
 - spec/scss_lint/linter_registry_spec.rb
 - spec/scss_lint/linter_spec.rb
 - spec/scss_lint/location_spec.rb
@@ -316,10 +319,10 @@ test_files:
 - spec/scss_lint/reporter/json_reporter_spec.rb
 - spec/scss_lint/reporter/xml_reporter_spec.rb
 - spec/scss_lint/reporter_spec.rb
-- spec/scss_lint/cli_spec.rb
-- spec/scss_lint/engine_spec.rb
-- spec/scss_lint/runner_spec.rb
 - spec/scss_lint/selector_visitor_spec.rb
+- spec/scss_lint/file_finder_spec.rb
+- spec/scss_lint/runner_spec.rb
+- spec/scss_lint/cli_spec.rb
+- spec/spec_helper.rb
 - spec/support/isolated_environment.rb
 - spec/support/matchers/report_lint.rb
-- spec/spec_helper.rb