scrubby 0.2.1 → 0.3.0

data/README.rdoc

@@ -70,9 +70,7 @@ It's pretty straightforward, and there's nothing all that fancy happening behind
 
 Scrubbing happens only when attributes are set. That way, no time is wasted scrubbing every time an attribute is retrieved.
 
-For column attributes, the scrubbing is done at the +write_attribute+ level, without stepping on ActiveRecord's toes by creating a bunch of unnecessary setter methods.
-
-+scrubby+ also works with virtual attributes, simply by adding an +alias_method_chain+ to the corresponding setter method, so the original can still be accessed via <tt>attribute_without_scrub=</tt>.
+Scrubbing is done at the +write_attribute+ level, without stepping on ActiveRecord's toes by creating a bunch of unnecessary setter methods.
 
 Inheritance is respected, just as you'd expect, down through model subclasses. Scrubbers are overridden in subclasses with no problem.
 
@@ -80,7 +78,7 @@ Inheritance is respected, just as you'd expect, down through model subclasses. S
 
 Those of you who are familiar with +attribute_normalizer+[http://github.com/mdeering/attribute_normalizer] will recognize the how +scrubby+ looks and feels, and that's no accident! +attribute_normalizer+ has a simple, clean and effective interface.
 
-But +scrubby+ was written to be an improvement on what's happening behind the scenes, particularly with regards to inheritance and avoiding unnecessary method definitions. Basically, the idea was to really clean up and simplify the back-end of an already awesome interface.
+But +scrubby+ was written to be an improvement on what's happening behind the scenes, particularly with regards to inheritance and avoiding unnecessary method definitions. Basically, the idea was to really simplify the back-end of an already awesome interface, and to gear it specifically toward ActiveRecord.
 
 == Contributing
 

data/VERSION

@@ -1 +1 @@
-0.2.1
+0.3.0

data/lib/scrubby.rb

@@ -63,18 +63,6 @@ module Scrubby
     def scrub(*attributes, &block)
       scrubber = block_given? ? block : instance_method(:scrub)
       self.scrubbers = attributes.inject({}){|s,a| s.merge!(a.to_s => scrubber) }
-
-      attributes.reject{|a| column_names.include?(a.to_s) }.each do |virtual_attribute|
-        unless instance_methods.include?("#{virtual_attribute}_with_scrub=")
-          define_method "#{virtual_attribute}_with_scrub=" do |value|
-            scrubber = scrubbers[virtual_attribute.to_s]
-            value = scrubber.bind(self).call(value)
-            send("#{virtual_attribute}_without_scrub=", value)
-          end
-
-          alias_method_chain "#{virtual_attribute}=", :scrub
-        end
-      end
     end
   end
 
@@ -82,9 +70,6 @@ module Scrubby
     # An alias of the +write_attribute+ method, +write_attribute_with_scrub+ will check whether a
     # scrubber exists for the given attribute and if so, scrub the given value before passing it
     # on to the original +write_attribute+ method.
-    #
-    # This is used for column-based attributes, while virtual attributes are handled by aliasing
-    # the corresponding setter methods and scrubbing there.
     def write_attribute_with_scrub(attribute, value)
       if scrubber = scrubbers[attribute.to_s]
         value = scrubber.bind(self).call(value)

data/scrubby.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{scrubby}
-  s.version = "0.2.1"
+  s.version = "0.3.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Steve Richert"]
-  s.date = %q{2010-01-24}
+  s.date = %q{2010-01-26}
   s.description = %q{Clean up your incoming ActiveRecord model attributes}
   s.email = %q{steve.richert@gmail.com}
   s.extra_rdoc_files = [

data/test/test_scrubby.rb

@@ -83,10 +83,16 @@ class TestScrubby < Test::Unit::TestCase
         @user = User.new
       end
 
-      should 'clean the value' do
-        middle_name = ' Joel Michael '
-        @user.middle_name = middle_name
-        assert_not_equal middle_name, @user.middle_name
+      should 'do nothing' do
+        assert_nothing_raised do
+          middle_name = ' Joel Michael '
+          @user.update_attributes(
+            :first_name => 'Stephen',
+            :middle_name => middle_name,
+            :last_name => 'Richert'
+          )
+          assert_equal middle_name, @user.middle_name
+        end
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: scrubby
 version: !ruby/object:Gem::Version 
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors: 
 - Steve Richert
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-24 00:00:00 -05:00
+date: 2010-01-26 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency