screenshot 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: de0d3273a0f51eb030ed4ffbc1246b9a27b8d54a
-  data.tar.gz: dc957f799ef90603363030868155b71db5859067
+  metadata.gz: 6bb9409814f8b73227b3a3660ef7671e5f78f06f
+  data.tar.gz: f7cc631935cb2d503bce99e7e60741735b3c5667
 SHA512:
-  metadata.gz: c64ff46d750fca6f1741a38aa36ebb0c13a2563ee9b2ecee28349520f1fecfb7274d8edf30236585837621ddb2c1f0fbbc47d57d000fae79375ff90fdfdb50a1
-  data.tar.gz: b44c80ab8b3526e013dd502008b3680246be5dc15fc5b9a1367ebde8aae167b2683db8cd555d5b77c29077beb273d7d6cb2c45f50860c6048bc75282a8ec5eb6
+  metadata.gz: afb6aca9737cfa6b69c2ef357c1a64807b98180ef4cbb4fbeb35a797ecc1a4d12bc5347f2ee89db06f1e64b6749e3086d66595c0cf831a2581e6faed9f7fcfca
+  data.tar.gz: 1b48c5ed90b1baacfa4fbf7233fa858ae5303beca5ae2c73c2a88c8f91605b7ed489cfbff9e5a0017655c921d8188f9933d164ce30607c4250f917395180f7d5

data/.rubocop.yml

@@ -1 +1,9 @@
 inherit_from: .rubocop_todo.yml
+
+# The default is 15, which is too tight
+Metrics/AbcSize:
+  Max: 30
+
+# The default is 10, which is too tight
+Metrics/MethodLength:
+  Max: 20

data/.rubocop_todo.yml

@@ -5,20 +5,11 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-Metrics/AbcSize:
-  Max: 19
-
 # Offense count: 53
 # Configuration parameters: AllowURI, URISchemes.
 Metrics/LineLength:
   Max: 288
 
-# Offense count: 1
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 16
-
 # Offense count: 2
 Style/Documentation:
   Enabled: false
@@ -43,12 +34,6 @@ Style/RegexpLiteral:
 Style/SpecialGlobalVars:
   Enabled: false
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiterals:
-  Enabled: false
-
 # Offense count: 2
 # Cop supports --auto-correct.
 Style/UnneededPercentQ:

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+rvm:
+  - 2.2.0
+install: bundle install
+script:
+  - bundle exec rspec
+  - bundle exec rubocop

data/lib/screenshot.rb

@@ -1,13 +1,13 @@
 require 'screenshot/version'
 
 module Screenshot
-  def self.capture(browser, file_name, page_elements)
+  def self.capture(browser, file_name, page_elements, padding = 0)
     screenshot_directory = ENV['LANGUAGE_SCREENSHOT_PATH'] || 'screenshots'
     FileUtils.mkdir_p screenshot_directory
     screenshot_path = "#{screenshot_directory}/#{file_name}"
 
     browser.screenshot.save screenshot_path
-    self.crop_image screenshot_path, page_elements, nil
+    self.crop_image screenshot_path, page_elements, padding
   end
 
   def self.zoom_browser(browser, rate)
@@ -17,14 +17,9 @@ module Screenshot
     end
   end
 
-  def self.crop_image(path, page_elements, offset_element)
-    if offset_element
-      offset_rectangle = coordinates_from_page_element(offset_element)
-    else
-      offset_rectangle = [0, 0, 0, 0]
-    end
+  def self.crop_image(path, page_elements, padding)
     rectangles = self.coordinates_from_page_elements(page_elements)
-    crop_rectangle = rectangle(rectangles, offset_rectangle)
+    crop_rectangle = rectangle(rectangles, padding)
 
     top_left_x = crop_rectangle[0]
     top_left_y = crop_rectangle[1]
@@ -42,7 +37,7 @@ module Screenshot
     image.save path
   end
 
-  def self.rectangle(rectangles, offset_rectangle = [0, 0, 0, 0])
+  def self.rectangle(rectangles, padding = 0)
     top_left_x, top_left_y = top_left_x_y rectangles
     bottom_right_x, bottom_right_y = bottom_right_x_y rectangles
 
@@ -50,12 +45,8 @@ module Screenshot
     width = bottom_right_x - top_left_x
     height = bottom_right_y - top_left_y
 
-    # We are calculating the offset co-ordinates
-    x_offset = offset_rectangle[0]
-    y_offset = offset_rectangle[1]
-
     # The new rectangle is constructed with all the co-ordinates calculated above
-    [top_left_x + x_offset, top_left_y + y_offset, width, height]
+    [top_left_x - padding, top_left_y - padding, width + padding * 2, height + padding * 2]
   end
 
   def self.coordinates_from_page_elements(page_elements)

data/lib/screenshot/version.rb

@@ -1,3 +1,3 @@
 module Screenshot
-  VERSION = '0.0.5'
+  VERSION = '0.0.6'
 end

data/spec/rectangle_spec.rb

@@ -8,14 +8,6 @@ describe 'Rectangle' do
     expect(Screenshot.rectangle(input_rectangles)).to eq(input_rectangle)
   end
 
-  it 'should return the co-ordinates of the rectangle which is inside a iframe' do
-    input_rectangle  = [50, 50, 10, 10]
-    iframe_rectangle = [100, 100, 20, 20]
-    input_rectangles = [input_rectangle]
-    output_rectangle = [150, 150, 10, 10]
-    expect(Screenshot.rectangle(input_rectangles, iframe_rectangle)).to eq(output_rectangle)
-  end
-
   it 'if we provide 2 rectangles and if one contains the other then it should return co-ordinates of bigger rectangle' do
     input_rectangle_1 = [0, 0, 1, 1]
     input_rectangle_2 = [0, 0, 2, 2]
@@ -202,3 +194,13 @@ describe 'Bottom right co-ordinates y' do
     expect(Screenshot.bottom_right_y_coordinates(input_rectangles)).to eq(output_coordinates)
   end
 end
+
+describe 'Bottom right co-ordinates y' do
+  it 'if we provide 1 rectangle and a padding of 2 pixels, the rectangle is increased by 2 pixels on each side' do
+    input_rectangle = [7, 42, 19, 125]
+    output_rectangle = [5, 40, 23, 129]
+    padding = 2
+    input_rectangles = [input_rectangle]
+    expect(Screenshot.rectangle(input_rectangles, padding)).to eq(output_rectangle)
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: screenshot
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Vikas Yaligar
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-17 00:00:00.000000000 Z
+date: 2015-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chunky_png
@@ -95,6 +95,7 @@ files:
 - .gitignore
 - .rubocop.yml
 - .rubocop_todo.yml
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md