scraped 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bf5c0cab0f1d7991d8e20be4a18742d523dee613
-  data.tar.gz: 43a801257aace7d860415183fb8b936db92cea2b
+  metadata.gz: a7f429cba94e06130bef2f3b912e760f989f45bb
+  data.tar.gz: 4259d7da280f1e36755b589693c15cd37dcb049b
 SHA512:
-  metadata.gz: c07ff312f45e7a43ebd88d0894efa224324f0d433212d360c89a268ae121746d236587c16193e1f6bc6474550f8a8110017931fb3958b9ed434e3c4550cfea54
-  data.tar.gz: 281394ecbcb4ce1d9563963b311256b498770c3b18a26039b1c0622e9acace957ff81de9806379021f2a9f668ba80fb6a428b72afc3ccad8ae64d7080192c079
+  metadata.gz: cdd825c2323150baf9b746ab2867c0a840b87b92d1ea0484266232039336432b8a99d274c61e6ebd1e8f4e5805cef173255b4c5882744721f75d5f4be2fc24af
+  data.tar.gz: b20b9930ef67e38fb50ce6128cd76c4934d9c05fbd6f26db1a91516eeee1ebeee15efb7955e2da4b94fd1cf5c19b3493f1efe77dca8f570f03255a9fbefb7d3c

data/.travis.yml

@@ -6,3 +6,6 @@ rvm:
   - 2.2
   - 2.3.1
 before_install: gem install bundler -v 1.13.5
+script:
+  - bundle exec rake
+  - bash <(curl -fsSL https://github.com/everypolitician/ensure-regression-tests/raw/master/ensure-regression-tests)

data/CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## 0.3.0 - 2017-01-10
+
+### Changed
+
+- The AbsoluteUrls decorator now ensures the URL is correctly encoded
+  (e.g. by transforming spaces into %20)
+
 ## 0.2.0 - 2017-01-04
 
 ### Changed

data/lib/scraped/response/decorator/absolute_urls.rb

@@ -5,6 +5,28 @@ module Scraped
   class Response
     class Decorator
       class AbsoluteUrls < Decorator
+        class AbsoluteUrl
+          def initialize(base_url:, relative_url:)
+            @base_url = base_url
+            @relative_url = relative_url
+          end
+
+          def to_s
+            unless relative_url.to_s.empty?
+              URI.join(base_url, URI.encode(
+                # To prevent encoded URLs from being encoded twice
+                URI.decode(relative_url)
+              ).gsub('[', '%5B').gsub(']', '%5D')).to_s
+            end
+          rescue URI::InvalidURIError
+            relative_url
+          end
+
+          private
+
+          attr_reader :base_url, :relative_url
+        end
+
         def body
           Nokogiri::HTML(super).tap do |doc|
             doc.css('img').each { |img| img[:src] = absolute_url(img[:src]) }
@@ -15,9 +37,7 @@ module Scraped
         private
 
         def absolute_url(relative_url)
-          URI.join(url, relative_url) unless relative_url.to_s.empty?
-        rescue URI::InvalidURIError
-          relative_url
+          AbsoluteUrl.new(base_url: url, relative_url: relative_url).to_s
         end
       end
     end

data/lib/scraped/version.rb

@@ -1,3 +1,3 @@
 module Scraped
-  VERSION = '0.2.0'.freeze
+  VERSION = '0.3.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: scraped
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - EveryPolitician
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-01-06 00:00:00.000000000 Z
+date: 2017-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri