scorm_engine 0.8.3 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c6dc07764b79c2b24e72ebd15d39f1deb301eb268e2d5ac10eb1771057847e39
-  data.tar.gz: 747ccf82b2a4f489f9aa89fb4b9ac2831aa0771465f58dd8ff5ac314dff722a1
+  metadata.gz: a01b32c7b8dca247cfeff31eeec10efe24b2212e219b8fec0b76cc95571be773
+  data.tar.gz: 9d75ef9166e52ae9d52bdc8bf475c48d74803502eb37163f360205476705043e
 SHA512:
-  metadata.gz: 2de6d2331954d65d497165150282dff1a0d7c604464001713ef4610b7f47e7c7f44ab4e40f17b141b6ea78173ea598b4ff636f8300462731a0538bd0fe2ffe24
-  data.tar.gz: 25d76985d84f9150114e2dcbf38de35fdcf5a51e397b64d6df59762fa7495dca52367a8e53e5029ced8822cefeafbc5a506cd6343dae1efcfe93851e125bcaec
+  metadata.gz: 43be376e8bfb18097d9987a8fdf2bf71c7f07025160aa3df759b16d89222d7d85eb2e7cdc7b9d735921f143761d02608b784f50cf9497f098ad1092ca29f993d
+  data.tar.gz: 7d2a84544f3063591f595bb9f44163c17b88c0019b990f218d7137218aac2a1abf9cb9009f708291ea63db39307e9e39ca20ae56654d3880ac2afd8a5996b091

data/Rakefile

@@ -1,7 +1,9 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 require "yard"
+require "rubocop/rake_task"
 
+RuboCop::RakeTask.new
 RSpec::Core::RakeTask.new(:spec)
 
 task default: :spec

data/lib/scorm_engine/configuration.rb

@@ -37,10 +37,10 @@ module ScormEngine
       @logger = ::Logger.new(ENV.fetch("SCORM_ENGINE_LOGFILE", "/dev/null"))
 
       @log_options = begin
-                       JSON.parse(ENV.fetch("SCORM_ENGINE_LOG_OPTIONS"))
-                     rescue KeyError, JSON::ParserError
-                       { headers: false, bodies: false }
-                     end
+        JSON.parse(ENV.fetch("SCORM_ENGINE_LOG_OPTIONS"))
+      rescue KeyError, JSON::ParserError
+        { headers: false, bodies: false }
+      end
     end
   end
 end

data/lib/scorm_engine/faraday/request.rb

@@ -34,9 +34,7 @@ module ScormEngine
             request.headers["engineTenantName"] = tenant unless @without_tenant
           else
             # "more" pagination urls are fully or relatively qualified
-            unless path =~ %r{\Ahttps?://} || path.start_with?(base_uri.path)
-              path = "#{tenant}/#{path}"
-            end
+            path = "#{tenant}/#{path}" unless path =~ %r{\Ahttps?://} || path.start_with?(base_uri.path)
           end
 
           options = coerce_options(options)

data/lib/scorm_engine/models/dispatch_zip.rb

@@ -21,6 +21,7 @@ module ScormEngine
       # @return [String]
       attr_accessor :body
 
+      # rubocop:disable Lint/MissingSuper
       def initialize(options = {})
         @options = options.dup
         @dispatch_id = options[:dispatch_id]
@@ -28,6 +29,7 @@ module ScormEngine
         @filename = options[:filename]
         @body = options[:body]
       end
+      # rubocop:enable Lint/MissingSuper
     end
   end
 end

data/lib/scorm_engine/models/registration.rb

@@ -1,5 +1,6 @@
 module ScormEngine
   module Models
+    # rubocop:disable Metrics/AbcSize
     class Registration < Base
       # @attr
       # The external identification of the registration.
@@ -183,5 +184,6 @@ module ScormEngine
         Time.parse(completed_date)
       end
     end
+    # rubocop:enable Metrics/AbcSize
   end
 end

data/lib/scorm_engine/version.rb

@@ -1,3 +1,3 @@
 module ScormEngine
-  VERSION = "0.8.3".freeze
+  VERSION = "0.9.0".freeze
 end

data/spec/scorm_engine/api/endpoints/configuration_spec.rb

@@ -19,7 +19,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Configuration do
       end
 
       it "returns metadata in raw_response when included in options" do
-        expect(subject.raw_response.body['settingItems'].first["metadata"]).to_not be_nil
+        expect(subject.raw_response.body["settingItems"].first["metadata"]).to_not be_nil
       end
     end
   end
@@ -43,7 +43,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Configuration do
       expect(configuration["UserCountReportLookBackDays"]).to eq "90"
       expect(configuration["UserCountReportDaysBetweenReports"]).to eq "20"
 
-      resp = subject.post_app_configuration(
+      subject.post_app_configuration(
         settings: { "UserCountReportLookBackDays" => "365",
                     "UserCountReportDaysBetweenReports" => 30 }
       )

data/spec/scorm_engine/api/endpoints/registrations_spec.rb

@@ -22,7 +22,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations do
     against_real_scorm_engine do
       ensure_course_exists(client: subject, course_id: registration_options[:course_id])
       ensure_registration_exists(registration_options.merge(client: subject))
-      ensure_course_exists(client: subject, course_id: registration_options[:course_id] + "-no-registrations")
+      ensure_course_exists(client: subject, course_id: "#{registration_options[:course_id]}-no-registrations")
     end
   end
 
@@ -50,7 +50,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations do
       end
 
       it "excludes results" do
-        registrations = subject.get_registrations(course_id: registration_options[:course_id] + "-no-registrations")
+        registrations = subject.get_registrations(course_id: "#{registration_options[:course_id]}-no-registrations")
         reg = registrations.result.detect { |r| r.id == registration_options[:registration_id] }
         expect(reg).to be nil
       end

data/spec/scorm_engine/faraday/connection_spec.rb

@@ -32,7 +32,7 @@ RSpec.describe ScormEngine::Faraday::Connection do
         client = ScormEngine::Client.new(tenant: "test")
 
         expect(client).to receive(:base_uri).with(version: 2).and_call_original
-        client.send(:connection, { version: 2 })
+        client.send(:connection, version: 2)
       end
     end
   end

data/spec/scorm_engine/models/base_spec.rb

@@ -1,14 +1,16 @@
-RSpec.describe ScormEngine::Models::Base do
-  module ScormEngine
-    module Models
-      class Test < Base
-        def initialize(options = {})
-          @options = options
-        end
+module ScormEngine
+  module Models
+    class Test < Base
+      # rubocop:disable Lint/MissingSuper
+      def initialize(options = {})
+        @options = options
       end
+      # rubocop:enable Lint/MissingSuper
     end
   end
+end
 
+RSpec.describe ScormEngine::Models::Base do
   describe "#to_hash" do
     it "returns a hash of the options" do
       options = { i: 1, s: "str", a: [1, 2, 3] }

data/spec/spec_helper.rb

@@ -4,7 +4,10 @@ require "pry"
 require "scorm_engine"
 
 # Ensure we're picking up only the test scorm settings
-Dotenv.load(".env.test")
+Dotenv.load(".env.test.local",
+            ".env.test",
+            ".env.local",
+            ".env")
 
 RSpec.configure do |config|
   # Enable flags like --only-failures and --next-failure
@@ -42,6 +45,6 @@ RSpec.configure do |config|
 end
 
 # Require every spec support file
-Dir[File.join(File.dirname(__FILE__), "support", "**/*.rb")].each do |file|
+Dir[File.join(File.dirname(__FILE__), "support", "**/*.rb")].sort.each do |file|
   require file
 end

data/spec/support/scorm_engine.rb

@@ -7,13 +7,11 @@ module ScormEngineHelpers
   # importing a course and play it back other tests that expect the actual
   # record to exist in SCORM will fail.
   #
-  def against_real_scorm_engine
+  def against_real_scorm_engine(&block)
     return unless scorm_engine_is_available?
 
     cassette = VCR.eject_cassette
-    VCR.turned_off do
-      yield
-    end
+    VCR.turned_off(&block)
     VCR.insert_cassette(cassette.name, cassette.instance_variable_get(:@options))
   end
 

metadata

@@ -1,58 +1,70 @@
 --- !ruby/object:Gem::Specification
 name: scorm_engine
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: 0.9.0
 platform: ruby
 authors:
 - Philip Hallstrom
 - Mel Green
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-11-13 00:00:00.000000000 Z
+date: 1980-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.12'
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.12'
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.12'
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.12'
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: dotenv
   requirement: !ruby/object:Gem::Requirement
@@ -73,14 +85,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '0.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '0.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -115,14 +127,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.56'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.56'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rubyzip
   requirement: !ruby/object:Gem::Requirement
@@ -143,14 +155,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '6.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -408,8 +420,9 @@ files:
 homepage: https://github.com/instructure-bridge/scorm_engine
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  documentation_uri: https://instructure-bridge.github.io/scorm_engine/
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -417,16 +430,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
-signing_key: 
+rubygems_version: 3.1.3
+signing_key:
 specification_version: 4
 summary: Ruby Client for Rustici's SCORM Engine API
 test_files: []