scope_counter 0.1.0 → 0.2.0

data/README.md

@@ -3,11 +3,6 @@ scope_counter is a simple implementation of counter_cache functionality for mode
 Install
 --------
 
-```shell
-gem install scope_counter
-```
-or add the following line to Gemfile:
-
 ```ruby
 gem 'scope_counter'
 ```
@@ -16,14 +11,15 @@ and run `bundle install` from your shell.
 Usage
 --------
 
-Create columns in db according to scopes in your model ("#{scope_name}_count"):
+Create columns in db according to scopes in your model ("#{scope_name}_#{table_name}_count"):
 
 ```ruby
-t.integer :usefull_count, :default => 0
-t.integer :useless_count, :default => 0
+t.integer :usefull_utilities_count, :default => 0
+t.integer :useless_utilities_count, :default => 0
+t.integer :utilities_count, :default => 0
 ```
 
-List in array scopes, which you want to create counter cache for, as :conter_cache option:
+List in array scopes, which you want to create counter cache for, as :conter_cache option (if you want to add a default behavior just add :all in array):
 
 ```ruby
 class Advice  < ActiveRecord::Base
@@ -31,18 +27,20 @@ class Advice  < ActiveRecord::Base
 end
 
 class Utility  < ActiveRecord::Base
-  belongs_to :advice, :counter_cache => [:usefull, :useless]
+  belongs_to :advice, :counter_cache => [:all,:usefull, :useless]
   scope :usefull, where(:usefull => true)
   scope :useless, where(:usefull => false)
 end
 
 advice = Advice.create
 
-advice.usefull_count # => 0
+advice.usefull_utilities_count # => 0
 
 advice.utilities.usefull.create
 
-advice.usefull_count # => 1
+advice.usefull_utilities_count # => 1
+
+advice.utilities_count # => 1
 ```
 
 

data/lib/scope_counter.rb

@@ -11,11 +11,17 @@ module ScopeCounter
         def add_counter_cache_callbacks(reflection)
           if Array === options[:counter_cache]
             name = self.name
-            options[:counter_cache].each do |scope|
-              cache_column = "#{scope}_count"
+            counter_cache_options = options[:counter_cache]
+            counter_cache_options.each do |scope|
+              if scope == :all
+                options[:counter_cache] = true
+                old_add_counter_cache_callbacks(reflection)
+                next
+              end 
+              cache_column = "#{scope}_#{model.table_name}_count"
               
               method_name = "belongs_to_counter_cache_after_create_for_#{scope}"
-              model.redefine_method(method_name) do
+              mixin.redefine_method(method_name) do
                 record = send(name)
                 record.class.increment_counter(cache_column, record.id) unless record.nil?
               end
@@ -28,7 +34,7 @@ module ScopeCounter
               model.after_create(method_name, :if => :"#{in_scope_method}")
       
               method_name = "belongs_to_counter_cache_before_destroy_for_#{scope}"
-              model.redefine_method(method_name) do
+              mixin.redefine_method(method_name) do
                 record = send(name)
                 record.class.decrement_counter(cache_column, record.id) unless record.nil?
               end

data/lib/scope_counter/version.rb

@@ -1,3 +1,3 @@
 module ScopeCounter
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/lib/scope_counter_spec.rb

@@ -8,15 +8,17 @@ describe "scope_counter" do
   it "should increase usefull count after usefull utility creation" do
     @advice.utilities.create(:usefull => true)
     @advice.reload
-    @advice.usefull_count.should == 1
-    @advice.useless_count.should == 0
+    @advice.usefull_utilities_count.should == 1
+    @advice.useless_utilities_count.should == 0
+    @advice.utilities_count.should == 1
   end
   
   it "should increase useless count after useless utility creation" do
     @advice.utilities.create(:usefull => false)
     @advice.reload
-    @advice.useless_count.should == 1
-    @advice.usefull_count.should == 0
+    @advice.useless_utilities_count.should == 1
+    @advice.usefull_utilities_count.should == 0
+    @advice.utilities_count.should == 1
   end
 
 end

data/spec/support/models.rb

@@ -3,7 +3,7 @@ class Advice  < ActiveRecord::Base
 end
 
 class Utility  < ActiveRecord::Base
-  belongs_to :advice, :counter_cache => [:usefull, :useless]
+  belongs_to :advice, :counter_cache => [:all,:usefull, :useless]
   scope :usefull, where(:usefull => true)
   scope :useless, where(:usefull => false)
 end

data/spec/support/schema.rb

@@ -3,8 +3,9 @@ ActiveRecord::Schema.define do
 
   create_table :advices, :force => true do |t|
     t.string :text
-    t.integer :usefull_count, :default => 0
-    t.integer :useless_count, :default => 0
+    t.integer :utilities_count, :default => 0
+    t.integer :usefull_utilities_count, :default => 0
+    t.integer :useless_utilities_count, :default => 0
   end
 
   create_table :utilities, :force => true do |t|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scope_counter
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-23 00:00:00.000000000 Z
+date: 2012-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &72891890 !ruby/object:Gem::Requirement
+  requirement: &10995340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *72891890
+  version_requirements: *10995340
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &72891660 !ruby/object:Gem::Requirement
+  requirement: &10942180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *72891660
+  version_requirements: *10942180
 - !ruby/object:Gem::Dependency
   name: sqlite3-ruby
-  requirement: &72891400 !ruby/object:Gem::Requirement
+  requirement: &10899200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *72891400
+  version_requirements: *10899200
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &72891150 !ruby/object:Gem::Requirement
+  requirement: &10816600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,7 +54,7 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *72891150
+  version_requirements: *10816600
 description: Simple implementation of counter_cache functionality for model scopes
 email:
 - lolcoltd@gmail.com
@@ -95,7 +95,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: scope_counter
-rubygems_version: 1.8.10
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: Provide counter_cache functionality for model scopes