schmobile 0.4.1 → 1.0.0

data/.gitignore

@@ -0,0 +1,3 @@
+Gemfile.lock
+pkg/
+# rcov generated

data/.travis.yml

@@ -0,0 +1,7 @@
+before_install:
+  - gem update --system
+rvm:
+  - 1.8.7
+  - 1.9.3
+  - jruby
+  - ree

data/Gemfile

@@ -1,14 +1,3 @@
 source "http://rubygems.org"
-# Add dependencies required to use your gem here.
-# Example:
-#   gem "activesupport", ">= 2.3.5"
 
-# Add dependencies to develop your gem here.
-# Include everything needed to run rake, tests, features, etc.
-group :development do
-  gem "rack", "~> 1.1.0"
-  gem "mocha", "0.9.9"
-  gem "shoulda", ">= 0"
-  gem "bundler", "~> 1.0.0"
-  gem "jeweler", "~> 1.5.2"
-end
+gemspec

data/README.md

@@ -0,0 +1,55 @@
+# Schmobile [![Build Status](https://secure.travis-ci.org/morten/schmobile.png)](http://travis-ci.org/morten/schmobile)
+
+A mobile user agent detection Rack middleware. It provides `Rack::Request#is_mobile?`
+
+## Forcing mobile mode
+
+You can force toggle mobile mode by sending +is_mobile#true+ and +is_mobile#false+ as
+parameters in the request URL. This setting will be stored in the session for subsequent requests.
+This entirely overrides the user agent detection.
+
+## User agent detection
+
+You can add/remove user agents like so:
+
+```ruby
+Schmobile::UserAgents.add_user_agent_pattern("wibble")
+Schmobile::UserAgents.remove_user_agent_pattern("ipad")
+```
+
+## Filters
+
+The outcome of the +request.is_mobile?+ call is the product of a series of filters getting evaluated
+against the request. You can manipulate the Schmobile::Filters::CHAIN array to alter if a
+request is deemed mobile or not. Add your own filter to bypass the check depending on e.g. location
+or request format.
+
+## Redirecting
+
+It can be configured to return the user to an explicit destination:
+
+```ruby
+use Schmobile, :redirect_to => "/mobile"
+```
+
+It supports string interpolation for dynamic destinations:
+
+```ruby
+use Schmobile, :redirect_to => "/mobile/#!/{{path}}"
+```
+
+Finally the middleware provides a request level method to determine if the client is a mobile device
+
+```ruby
+Rack::Request#is_mobile?
+```
+
+## Rolling out
+
+```ruby
+use Schmobile, :redirect_to => "/mobile", :if => Proc.new { |request| request.host =~ /staging/ }
+```
+
+## License
+
+Released under the Apache License Version 2.0 http://www.apache.org/licenses/LICENSE-2.0.html

data/Rakefile

@@ -1,46 +1,12 @@
-require 'rubygems'
-require 'bundler'
-begin
-  Bundler.setup(:default, :development)
-rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts "Run `bundle install` to install missing gems"
-  exit e.status_code
-end
-require 'rake'
-
-require 'jeweler'
-Jeweler::Tasks.new do |gem|
-  # gem is a Gem::Specification... see http://docs.rubygems.org/read/chapter/20 for more options
-  gem.name = "schmobile"
-  gem.homepage = "http://github.com/morten/schmobile"
-  gem.license = "MIT"
-  gem.summary = %Q{A Rack middleware for detecting mobile user agents}
-  gem.description = %Q{Used to determine if a request is from a mobile client, and possibly redirect it if that's the case}
-  gem.email = "morten@zendesk.com"
-  gem.authors = ["Morten Primdahl"]
-  # Include your dependencies below. Runtime dependencies are required when using your gem,
-  # and development dependencies are only needed for development (ie running rake tasks, tests, etc)
-  #  gem.add_runtime_dependency 'jabber4r', '> 0.1'
-  #  gem.add_development_dependency 'rspec', '> 1.2.3'
-end
-Jeweler::RubygemsDotOrgTasks.new
-
+require 'bundler/gem_tasks'
 require 'rake/testtask'
-Rake::TestTask.new(:test) do |test|
+
+Rake::TestTask.new do |test|
   test.libs << 'lib' << 'test'
   test.pattern = 'test/**/test_*.rb'
   test.verbose = true
 end
 
-task :default => :test
-
-require 'rake/rdoctask'
-Rake::RDocTask.new do |rdoc|
-  version = File.exist?('VERSION') ? File.read('VERSION') : ""
-
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title = "schmobile #{version}"
-  rdoc.rdoc_files.include('README*')
-  rdoc.rdoc_files.include('lib/**/*.rb')
+task :default do
+  sh "bundle exec rake test"
 end

data/lib/schmobile/filters/is_mobile_param.rb

@@ -0,0 +1,13 @@
+module Schmobile
+  module Filters
+    module IsMobileParam
+      def self.call(request)
+        if request.params.key?(Schmobile::IS_MOBILE)
+           request.session[Schmobile::IS_MOBILE] = (request.params[Schmobile::IS_MOBILE] == "true")
+        end
+
+        nil
+      end
+    end
+  end
+end

data/lib/schmobile/filters/mobile_session.rb

@@ -0,0 +1,9 @@
+module Schmobile
+  module Filters
+    module MobileSession
+      def self.call(request)
+        request.session[Schmobile::IS_MOBILE]
+      end
+    end
+  end
+end

data/lib/schmobile/filters/mobile_user_agent.rb

@@ -0,0 +1,11 @@
+require 'schmobile/user_agents'
+
+module Schmobile
+  module Filters
+    module MobileUserAgent
+      def self.call(request)
+        request.session[Schmobile::IS_MOBILE] = Schmobile::UserAgents.is_mobile_agent?(request.user_agent)
+      end
+    end
+  end
+end

data/lib/schmobile/filters.rb

@@ -0,0 +1,30 @@
+require 'schmobile/filters/mobile_session'
+require 'schmobile/filters/is_mobile_param'
+require 'schmobile/filters/mobile_user_agent'
+
+module Schmobile
+  # Filters are tests that get run against a request to determine if it's a mobile request or not.
+  # A filter can return true, false or nil. The first non-nil value of the filter chain is the
+  # one that gets used and this also gets used to mark the session as a "mobile session"
+  #
+  # You can manipulate the chain to add new conditions that check on e.g. request format.
+  module Filters
+    CHAIN = [
+      Schmobile::Filters::IsMobileParam, # Must come before session check
+      Schmobile::Filters::MobileSession,
+      Schmobile::Filters::MobileUserAgent # Always returns either true or false
+    ]
+
+    def self.apply(request)
+      Schmobile::Filters::CHAIN.each do |filter|
+        result = filter.call(request)
+        unless result.nil?
+          request.session[Schmobile::IS_MOBILE] = result
+          break
+        end
+      end
+
+      request.session[Schmobile::IS_MOBILE] ||= false
+    end
+  end
+end

data/lib/schmobile/middleware.rb

@@ -0,0 +1,59 @@
+module Schmobile
+  class Middleware
+
+    def initialize(app, options = {})
+      @app     = app
+      @options = options
+    end
+
+    def call(env)
+      request = Rack::Request.new(env)
+
+      if request.is_mobile? && redirect?(request)
+        [ 301, { "Location" => redirect_location(request) }, [] ]
+      else
+        @app.call(env)
+      end
+    end
+
+    # Returns true if this middleware has been configured with a redirect_to and the requested path
+    # is not already below the configured redirect_to
+    def redirect?(request)
+      redirecting = true
+
+      if @options.key?(:redirect_if)
+        redirecting = @options[:redirect_if].call(request)
+      end
+
+      if @options.key?(:redirect_to)
+        redirecting &&= request.path !~ /^#{@options[:redirect_to]}/
+      else
+        redirecting = false
+      end
+
+      redirecting ? redirect_location(request) : nil
+    end
+
+    def redirect_location(request)
+      "#{@options[:redirect_to]}#{redirect_with(request)}"
+    end
+
+    def redirect_with(request)
+      build_path(@options[:redirect_with].to_s, request)
+    end
+
+    private
+
+    def build_path(destination, request)
+      final_destination = destination.dup
+      destination.scan(/\{\{\w+\}\}/) do |call|
+        func = call.scan(/\w+/).first.to_s
+        if request.respond_to?(func)
+          final_destination.sub!(/\{\{#{func}\}\}/, request.send(func))
+        end
+      end
+      final_destination
+    end
+
+  end
+end

data/lib/schmobile/request_extension.rb

@@ -0,0 +1,24 @@
+module Schmobile
+  module Request
+    def is_mobile?
+      if @is_mobile.nil?
+        @is_mobile = Schmobile::Filters.apply(self)
+      end
+
+      @is_mobile
+    end
+
+    def toggle_mobile_session!
+      session[Schmobile::IS_MOBILE] = !is_mobile?
+      @is_mobile = nil
+    end
+
+    def is_device?(identifier)
+      user_agent =~ /#{identifier}/i
+    end
+  end
+end
+
+Rack::Request.class_eval do
+  include Schmobile::Request
+end

data/lib/schmobile/user_agents.rb

@@ -0,0 +1,58 @@
+module Schmobile
+  class UserAgents
+
+    MOBILE_USER_AGENTS = %w(
+      alcatel amoi android astel audiovox blackberry cdm chtml danger docomo ericsson htc_touch
+      iphone ipod j2me kddi midp minimo mmp mobi mobile mobileexplorer mot- motorola netfront nokia
+      novarra palm pdxgw phone plucker pocket portable portalmmm sagem samsung sgh sie- softbank
+      sprint symbian telit ucweb up.b upg1 vodafone webos windows\ ce x240 x320 xiino
+    )
+
+    NON_MOBILE_USER_AGENTS = %w(
+      ipad
+    )
+
+    def self.remove_user_agent_pattern(pattern)
+      MOBILE_USER_AGENTS.delete(pattern)
+      @mobile_agent_matcher = nil
+    end
+
+    def self.add_user_agent_pattern(pattern)
+      MOBILE_USER_AGENTS.push(*pattern)
+      @mobile_agent_matcher = nil
+    end
+
+    def self.remove_non_mobile_user_agent_pattern(pattern)
+      NON_MOBILE_USER_AGENTS.delete(pattern)
+      @non_mobile_agent_matcher = nil
+    end
+
+    def self.add_non_mobile_user_agent_pattern(pattern)
+      NON_MOBILE_USER_AGENTS.push(*pattern)
+      @non_mobile_agent_matcher = nil
+    end
+
+    def self.is_mobile_agent?(user_agent)
+      agent  = user_agent.to_s.downcase
+      mobile = !(agent =~ mobile_agent_matcher).nil?
+      mobile = mobile && agent !~ non_mobile_agent_matcher unless NON_MOBILE_USER_AGENTS.empty?
+      mobile
+    end
+
+    def self.mobile_agent_matcher
+      @mobile_agent_matcher ||= Regexp.new(MOBILE_USER_AGENTS.uniq.compact.map { |v| Regexp.escape(v) }.join("|"))
+    end
+
+    def self.non_mobile_agent_matcher
+      @non_mobile_agent_matcher ||= Regexp.new(NON_MOBILE_USER_AGENTS.uniq.compact.map { |v| Regexp.escape(v) }.join("|"))
+    end
+
+    def self.matched_by?(user_agent)
+      MOBILE_USER_AGENTS.each do |agent|
+        return agent if user_agent =~ /#{agent}/
+      end
+      nil
+    end
+
+  end
+end

data/lib/schmobile.rb

@@ -1 +1,10 @@
-require 'rack/schmobile'
+require 'rack'
+
+require 'schmobile/middleware'
+require 'schmobile/request_extension'
+require 'schmobile/filters'
+
+module Schmobile
+  VERSION   = "0.5.0"
+  IS_MOBILE = "is_mobile"
+end

data/schmobile.gemspec

@@ -1,80 +1,24 @@
-# Generated by jeweler
-# DO NOT EDIT THIS FILE DIRECTLY
-# Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
-# -*- encoding: utf-8 -*-
+Gem::Specification.new "Schmobile", "1.0.0" do |s|
+  s.name        = 'schmobile'
+  s.date        = '2012-06-14'
+  s.files       = `git ls-files`.split("\n")
+  s.license     = "Apache License Version 2.0"
 
-Gem::Specification.new do |s|
-  s.name = %q{schmobile}
-  s.version = "0.4.1"
+  s.summary     = "A mobile user agent detection Rack middleware."
+  s.description = "A mobile user agent detection Rack middleware. See the README."
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = ["Morten Primdahl"]
-  s.date = %q{2011-11-03}
-  s.description = %q{Used to determine if a request is from a mobile client, and possibly redirect it if that's the case}
-  s.email = %q{morten@zendesk.com}
-  s.extra_rdoc_files = [
-    "LICENSE.txt",
-    "README.rdoc"
-  ]
-  s.files = [
-    ".document",
-    "Gemfile",
-    "Gemfile.lock",
-    "LICENSE.txt",
-    "README.rdoc",
-    "Rakefile",
-    "VERSION",
-    "lib/rack/schmobile.rb",
-    "lib/rack/schmobile/filters.rb",
-    "lib/rack/schmobile/filters/is_mobile_param.rb",
-    "lib/rack/schmobile/filters/mobile_session.rb",
-    "lib/rack/schmobile/filters/mobile_user_agent.rb",
-    "lib/rack/schmobile/middleware.rb",
-    "lib/rack/schmobile/request_extension.rb",
-    "lib/rack/schmobile/user_agents.rb",
-    "lib/schmobile.rb",
-    "schmobile.gemspec",
-    "test/helper.rb",
-    "test/test_filters.rb",
-    "test/test_middleware.rb",
-    "test/test_rack_request.rb",
-    "test/test_user_agents.rb"
-  ]
-  s.homepage = %q{http://github.com/morten/schmobile}
-  s.licenses = ["MIT"]
-  s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.5.3}
-  s.summary = %q{A Rack middleware for detecting mobile user agents}
-  s.test_files = [
-    "test/helper.rb",
-    "test/test_filters.rb",
-    "test/test_middleware.rb",
-    "test/test_rack_request.rb",
-    "test/test_user_agents.rb"
-  ]
+  s.authors  = ["Morten Primdahl"]
+  s.email    = 'primdahl@me.com'
+  s.homepage = 'http://github.com/zendesk/schmobile'
 
-  if s.respond_to? :specification_version then
-    s.specification_version = 3
+  s.require_paths = %w[lib]
 
-    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_development_dependency(%q<rack>, ["~> 1.1.0"])
-      s.add_development_dependency(%q<mocha>, ["= 0.9.9"])
-      s.add_development_dependency(%q<shoulda>, [">= 0"])
-      s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
-      s.add_development_dependency(%q<jeweler>, ["~> 1.5.2"])
-    else
-      s.add_dependency(%q<rack>, ["~> 1.1.0"])
-      s.add_dependency(%q<mocha>, ["= 0.9.9"])
-      s.add_dependency(%q<shoulda>, [">= 0"])
-      s.add_dependency(%q<bundler>, ["~> 1.0.0"])
-      s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
-    end
-  else
-    s.add_dependency(%q<rack>, ["~> 1.1.0"])
-    s.add_dependency(%q<mocha>, ["= 0.9.9"])
-    s.add_dependency(%q<shoulda>, [">= 0"])
-    s.add_dependency(%q<bundler>, ["~> 1.0.0"])
-    s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
-  end
-end
+  s.add_runtime_dependency("rack")
+
+  s.add_development_dependency('rake')
+  s.add_development_dependency('bundler')
+  s.add_development_dependency('shoulda')
+  s.add_development_dependency('mocha')
 
+  s.test_files = s.files.select { |path| path =~ /^test\/test_.*\.rb/ }
+end

data/test/helper.rb

@@ -6,9 +6,10 @@ require 'mocha'
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 
-require 'rack/schmobile'
+require 'schmobile'
 
 class Test::Unit::TestCase
+
   def ipod
     'Mozilla/5.0 (iPod; U; CPU iPhone OS 2_2 like Mac OS X; en-us) AppleWebKit/525.18.1 (KHTML, like Gecko) Version/3.1.1 Mobile/5G77 Safari/525.20'
   end

data/test/test_filters.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 class TestFukters < Test::Unit::TestCase
 
-  context "Rack::Schmobile::Filters" do
+  context "Schmobile::Filters" do
     context "#apply" do
       setup do
         @request = stub(:user_agent => msie8)
@@ -13,48 +13,48 @@ class TestFukters < Test::Unit::TestCase
 
       context "on a pristine request" do
         should "return true if the session is already mobile" do
-          Rack::Schmobile::UserAgents.expects(:is_mobile_agent?).never
-          @session[Rack::Schmobile::IS_MOBILE] = true
-          assert Rack::Schmobile::Filters.apply(@request)
+          Schmobile::UserAgents.expects(:is_mobile_agent?).never
+          @session[Schmobile::IS_MOBILE] = true
+          assert Schmobile::Filters.apply(@request)
         end
 
         should "return true if there's an is_mobile parameter with value true" do
-          Rack::Schmobile::UserAgents.expects(:is_mobile_agent?).never
+          Schmobile::UserAgents.expects(:is_mobile_agent?).never
           @request.stubs(:params).returns({ "is_mobile" => "true" })
-          assert Rack::Schmobile::Filters.apply(@request)
+          assert Schmobile::Filters.apply(@request)
         end
 
         should "return false if there's an is_mobile parameter with value false" do
-          Rack::Schmobile::UserAgents.expects(:is_mobile_agent?).never
+          Schmobile::UserAgents.expects(:is_mobile_agent?).never
           @request.stubs(:params).returns({ "is_mobile" => "false" })
-          assert !Rack::Schmobile::Filters.apply(@request)
+          assert !Schmobile::Filters.apply(@request)
         end
 
         should "defer to user agent check if there's no session or parameter" do
-          Rack::Schmobile::UserAgents.expects(:is_mobile_agent?).once
-          assert !Rack::Schmobile::Filters.apply(@request)
+          Schmobile::UserAgents.expects(:is_mobile_agent?).once
+          assert !Schmobile::Filters.apply(@request)
         end
       end
 
       context "on a request with mobile session set to false" do
         should "allow to change the session value with a parameter" do
-          Rack::Schmobile::UserAgents.expects(:is_mobile_agent?).never
-          @request.session[Rack::Schmobile::IS_MOBILE] = false
-          assert !Rack::Schmobile::Filters.apply(@request)
+          Schmobile::UserAgents.expects(:is_mobile_agent?).never
+          @request.session[Schmobile::IS_MOBILE] = false
+          assert !Schmobile::Filters.apply(@request)
           @request.stubs(:params).returns({ "is_mobile" => "true" })
-          assert Rack::Schmobile::Filters.apply(@request)
-          assert @request.session[Rack::Schmobile::IS_MOBILE]
+          assert Schmobile::Filters.apply(@request)
+          assert @request.session[Schmobile::IS_MOBILE]
         end
       end
 
       context "on a request with mobile session set to true" do
         should "allow to change the session value with a parameter" do
-          Rack::Schmobile::UserAgents.expects(:is_mobile_agent?).never
-          @request.session[Rack::Schmobile::IS_MOBILE] = true
-          assert Rack::Schmobile::Filters.apply(@request)
+          Schmobile::UserAgents.expects(:is_mobile_agent?).never
+          @request.session[Schmobile::IS_MOBILE] = true
+          assert Schmobile::Filters.apply(@request)
           @request.stubs(:params).returns({ "is_mobile" => "false" })
-          assert !Rack::Schmobile::Filters.apply(@request)
-          assert !@request.session[Rack::Schmobile::IS_MOBILE]
+          assert !Schmobile::Filters.apply(@request)
+          assert !@request.session[Schmobile::IS_MOBILE]
         end
       end
     end

data/test/test_middleware.rb

@@ -2,14 +2,14 @@ require 'helper'
 
 class TestMiddleware < Test::Unit::TestCase
 
-  context "Rack::Schmobile::Middleware" do
+  context "Schmobile::Middleware" do
     setup do
       @app  = Class.new { def call(app); true; end }.new
-      @rack = Rack::Schmobile::Middleware.new(@app)
+      @rack = Schmobile::Middleware.new(@app)
     end
 
     should "return an HTTP permanent redirect when given a redirect path and used by a mobile client" do
-      @rack = Rack::Schmobile::Middleware.new(@app, :redirect_to => "/hello")
+      @rack = Schmobile::Middleware.new(@app, :redirect_to => "/hello")
       Rack::Request.any_instance.expects(:is_mobile?).returns(true)
 
       assert_equal [301, { "Location"=>"/hello" }, []], @rack.call(environment)
@@ -30,7 +30,7 @@ class TestMiddleware < Test::Unit::TestCase
 
     context "with redirect_to" do
       setup do
-        @rack = Rack::Schmobile::Middleware.new(@app, :redirect_to => "/wonderland")
+        @rack = Schmobile::Middleware.new(@app, :redirect_to => "/wonderland")
       end
 
       context "#redirect?" do
@@ -48,19 +48,19 @@ class TestMiddleware < Test::Unit::TestCase
         end
 
         should "return false when :if resolves to false" do
-          @rack = Rack::Schmobile::Middleware.new(@app, :redirect_to => "/wonderland", :redirect_if => Proc.new { |request| false })
+          @rack = Schmobile::Middleware.new(@app, :redirect_to => "/wonderland", :redirect_if => Proc.new { |request| false })
           assert !@rack.redirect?(request("PATH_INFO" => "/somewhere"))
         end
       end
 
       context "#redirect" do
-        should "interpolate the argument string" do
-          @rack = Rack::Schmobile::Middleware.new(@app, :redirect_to => "/wonderland", :redirect_with => "/{{path}}")
+        should "interpolate the argument string xxxx" do
+          @rack = Schmobile::Middleware.new(@app, :redirect_to => "/wonderland", :redirect_with => "/{{path}}")
           assert_equal "/wonderland/wiffle", @rack.redirect_location(request("PATH_INFO" => "wiffle"))
         end
 
         should "interpolate a multipart argument string" do
-          @rack = Rack::Schmobile::Middleware.new(@app, :redirect_to => "/wonderland/", :redirect_with => "{{path}}/lemurs/{{path}}")
+          @rack = Schmobile::Middleware.new(@app, :redirect_to => "/wonderland/", :redirect_with => "{{path}}/lemurs/{{path}}")
           assert_equal "/wonderland/wiffle/lemurs/wiffle", @rack.redirect_location(request("PATH_INFO" => "wiffle"))
         end
       end

data/test/test_rack_request.rb

@@ -16,13 +16,13 @@ class TestRackRequest < Test::Unit::TestCase
 
     context "#is_mobile?" do
       should "only call the filter chain once" do
-        Rack::Schmobile::Filters.expects(:apply).once.returns(false)
+        Schmobile::Filters.expects(:apply).once.returns(false)
         one_request = request
         3.times { one_request.is_mobile? }
       end
 
       should "re-call the filter chain once reset" do
-        Rack::Schmobile::Filters.expects(:apply).twice.returns(false)
+        Schmobile::Filters.expects(:apply).twice.returns(false)
         one_request = request
         3.times { one_request.is_mobile? }
         one_request.toggle_mobile_session!
@@ -56,24 +56,24 @@ class TestRackRequest < Test::Unit::TestCase
         end
 
         should "return false when forced in the session" do
-          Rack::Request.any_instance.stubs(:session).returns({ Rack::Schmobile::IS_MOBILE => false })
+          Rack::Request.any_instance.stubs(:session).returns({ Schmobile::IS_MOBILE => false })
           assert !request("HTTP_USER_AGENT" => iphone).is_mobile?
         end
 
         should "return true when forced in the session" do
-          Rack::Request.any_instance.stubs(:session).returns({ Rack::Schmobile::IS_MOBILE => true })
+          Rack::Request.any_instance.stubs(:session).returns({ Schmobile::IS_MOBILE => true })
           assert request.is_mobile?
         end
       end
 
       context "with params" do
         should "return false when forced via a request parameter" do
-          Rack::Request.any_instance.stubs(:params).returns({ Rack::Schmobile::IS_MOBILE => "false" })
+          Rack::Request.any_instance.stubs(:params).returns({ Schmobile::IS_MOBILE => "false" })
           assert !request("HTTP_USER_AGENT" => iphone).is_mobile?
         end
 
         should "return true when forced via a request parameter" do
-          Rack::Request.any_instance.stubs(:params).returns({ Rack::Schmobile::IS_MOBILE => "true" })
+          Rack::Request.any_instance.stubs(:params).returns({ Schmobile::IS_MOBILE => "true" })
           assert request.is_mobile?
         end
       end