schema_plus_core 2.2.0 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 3e8e79d68457a1e4ce6d7ff39807855e36cd2e9a
-  data.tar.gz: 5155f4e1926b764f3170c699eafb3e4cb789ecf9
+SHA256:
+  metadata.gz: dfc1ffe7f432c8e74c488bcf10f95dbe2f2050a7d2b8981a90b154689a635965
+  data.tar.gz: 01dc5cb4e3dccaacd7c9fe1eb800dab7646fc001e82ec12bcd1cac90b0d47db3
 SHA512:
-  metadata.gz: cb5a7d23d7ab4f2fbb0c750386f4c5b721f9d8f4f72331290368569bbeba44e0da640c56b30c96728aa410e81bf9b39997fa9c214b835ca3e07ed62519da604e
-  data.tar.gz: 6e4369733968625498dcf83a73748640f2af0e9456fd9a2b045bc9052977850b3b597f1d00240af92001e163370e3556480d853103768a52ead5e4ed5b746ae7
+  metadata.gz: 675a1ccf6531d7bacc97e1354772c77690fa2ba956402f8054bdb47e60f8c32363a9c54287acf24019b66a74270ac3e39d06a8d8d803f57827d6a2f7eee68d6d
+  data.tar.gz: '09513084a2643ec5a9a1bb30a9f6aaa308f3e2ed6dc065067b9f2bcec956ef954a9db19ca20ec51cce17794f3a5e4b027bc58b2d44abfbd11c8ffbc1085662af'

data/README.md

@@ -444,6 +444,7 @@ SchemaPlus::Core provides a state object and of callbacks to various phases of t
 
 ## Release Notes
 
+* 2.2.1 Fixed expression index handling in AR5.x.
 * 2.2.0 Added AR5.2 support.  Thanks to [@jeremyyap](https://github.com/jeremyyap)
 * 2.1.1 Bug fix: Don't lose habtm options.  Thanks to [@iagopiimenta ](https://github.com/iagopiimenta)
 * 2.1.0 Added AR5.1 support.  Thanks to [@iagopiimenta ](https://github.com/iagopiimenta)

data/lib/schema_plus/core/active_record/connection_adapters/abstract_adapter.rb

@@ -35,6 +35,24 @@ module SchemaPlus
             end
           end
 
+          # replaced version to handle array of columns with expressions
+          def quoted_columns_for_index(column_names, **options)
+            output_columns = []
+
+            column_names.each do |column|
+              if column.is_a?(String) && column.include?('(')
+                output_columns << column
+              else
+                quoted = {column.to_sym => quote_column_name(column).dup}
+                output_columns.concat add_options_for_index_columns(quoted, options).values
+              end
+            end
+
+            output_columns
+          end
+          private :quoted_columns_for_index
+
+
           module SchemaCreation
 
             def add_column_options!(sql, options)

data/lib/schema_plus/core/version.rb

@@ -1,5 +1,5 @@
 module SchemaPlus
   module Core
-    VERSION = "2.2.0"
+    VERSION = "2.2.1"
   end
 end

data/schema_plus_core.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |gem|
 
   gem.add_development_dependency "bundler", "~> 1.7"
   gem.add_development_dependency "rake", "~> 10.0"
-  gem.add_development_dependency "rspec", "~> 3.0.0"
+  gem.add_development_dependency "rspec", "~> 3.0"
   gem.add_development_dependency "rspec-given"
   gem.add_development_dependency "schema_dev", "~> 3.11"
   gem.add_development_dependency "simplecov"

data/spec/index_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe SchemaMonkey::Middleware::Migration::Index do
+
+  let(:migration) {::ActiveRecord::Migration}
+  let(:connection) {::ActiveRecord::Base.connection}
+
+  describe '#add_index' do
+    before(:each) do
+      migration.create_table :things, :force => true do |t|
+        t.string :test_column
+      end
+    end
+
+    context "when add an index with an expression", postgresql: :only do
+      it 'should create the index successfully' do
+        migration.add_index 'things', 'lower(test_column)'
+        expect(connection.indexes(:things).first.columns).to eq('lower((test_column)::text)')
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: schema_plus_core
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - ronen barzel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-14 00:00:00.000000000 Z
+date: 2018-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec-given
   requirement: !ruby/object:Gem::Requirement
@@ -210,6 +210,7 @@ files:
 - schema_plus_core.gemspec
 - spec/column_spec.rb
 - spec/dumper_spec.rb
+- spec/index_spec.rb
 - spec/middleware_spec.rb
 - spec/spec_helper.rb
 - spec/sql_struct_spec.rb
@@ -235,13 +236,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Provides an internal extension API to ActiveRecord
 test_files:
 - spec/column_spec.rb
 - spec/dumper_spec.rb
+- spec/index_spec.rb
 - spec/middleware_spec.rb
 - spec/spec_helper.rb
 - spec/sql_struct_spec.rb