schema_plus 2.0.0.pre16 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c99278211ca16613b477d638db63506511855b55
-  data.tar.gz: 70bc7a4a0085cc04d381b2e013002d9516159174
+  metadata.gz: 6baf672aae665ce18e90211330b7a8a85413e19c
+  data.tar.gz: fe37aa4396dc65ce843ef0cb3b43c33abcc3dd21
 SHA512:
-  metadata.gz: abdc2561b776542283c32e85fb3ec6e37ae4a412114d45b268262a787777edfed250002f28906829294ad87f2ccf3104f783bb875539c78dada889bf3341856c
-  data.tar.gz: 9ff399f35e5a5efb6c2163912352355ab833769a6337b8105cebdcae05ca53849ae67e4c2a78fc533a9e123dd607d9d266f8b0772889454fb9f2d9be93496a23
+  metadata.gz: 98d96007fe6a44b042762015eb90767c2378357fe22521df84884d74792fc026425e99fb5f0e745f54a4b3bf9ee8aaaff505dd22ee76f4bc3f9d1e208630f62f
+  data.tar.gz: 8071c349aebb2df8c6f91ddbad29c813c74d4c7e6723f9c3559d9d59c2ccb15644d5698b35e1abeb06594912149b9e77e0dfc29b864be7a30911b871eaf70ebc

data/README.md

@@ -3,24 +3,33 @@
 
 # SchemaPlus family
 
-The SchemaPlus family of gems provide various extensions and enhancements to ActiveRecord.  
-
-Listed alphabetically:
-
-Gem | Description | Included In `schema_plus` gem?
-----| ----------- |:------------------------------:
-[schema_associations](https://github.com/SchemaPlus/schema_associations) | Automatically defines model associations based on foreign key relations |
-<p style="color:grey">schema_auto_foreign_keys</p> | Automatically creates foreign keys on referencing columns | Y
-[schema_plus_columns](https://github.com/SchemaPlus/schema_plus_columns) | Column attributes including `column.indexes` and `column.unique?` | Y
-[schema_plus_db_default](https://github.com/SchemaPlus/schema_plus_db_default) | Use `ActiveRecord::DB_DEFAULT` to set an attribute to the database default | Y
-[schema_plus_default_expr](https://github.com/SchemaPlus/schema_plus_default_expr)  | Use SQL expressions for database default values | Y
-[schema_plus_enums](https://github.com/SchemaPlus/schema_plus_enums) | Define enum types in migrations | Y
-[schema_plus_foreign_keys](https://github.com/SchemaPlus/schema_plus_foreign_keys) | Extended support for foreign keys, including creation as column options, `:deferrable`, and SQLite3 support | Y
-[schema_plus_indexes](https://github.com/SchemaPlus/schema_plus_indexes) | Convenience and consistency in using indexes | Y
-[schema_plus_pg_indexes](https://github.com/SchemaPlus/schema_plus_pg_indexes) |PostgreSQL index features: `case_insenstive`, `expression` and `operator_class` | Y
-[schema_plus_tables](https://github.com/SchemaPlus/schema_plus_tables) | Convenience and consistency in using tables | Y
-[schema_plus_views](https://github.com/SchemaPlus/schema_plus_views) | Create and drop views in migrations | Y
-[schema_validations](https://github.com/SchemaPlus/schema_validations) | Automatically defines ActiveRecord validations based on database constraints |
+The SchemaPlus family of gems provide various extensions and enhancements to ActiveRecord >= 4.2.  There are two varieties:
+
+* **Gems that provide new default automatic behavior**
+
+    These gems run with the spirit of DRY and convention over configuration -- and automatically take care of things for you.  Just include any of these gems and they'll get to work.
+
+    Gem | Description 
+    ----| ----------- 
+    [schema_associations](https://github.com/SchemaPlus/schema_associations) | DRY up your models!  Why manually define associations (and their inverses) in the models, when you've already defined those relations in the database?
+    [schema_auto_foreign_keys](https://github.com/SchemaPlus/schema_auto_foreign_keys) | DRY up your migrations!  It goes without saying that a foreign key relationship should have a foreign key constraint -- it should also go without typing.
+    [schema_validations](https://github.com/SchemaPlus/schema_validations) | DRY up your validations!  The database has constraints in it, your models should automatically validate based on those constraints.
+
+* **Gems that extend ActiveRecord's feature set**
+
+    These gems provide new features and capabilities to ActiveRecord that you may wish to take advantage of.  None of these have default automagic; once you include the gem the new features are available, but you need to invoke them to use them.
+
+    Gem | Description 
+    ----| ----------- 
+    [schema_plus_columns](https://github.com/SchemaPlus/schema_plus_columns) | Column attributes including `column.indexes` and `column.unique?`
+    [schema_plus_db_default](https://github.com/SchemaPlus/schema_plus_db_default) | Use `ActiveRecord::DB_DEFAULT` to set an attribute to the database default
+    [schema_plus_default_expr](https://github.com/SchemaPlus/schema_plus_default_expr)  | Use SQL expressions for database default values
+    [schema_plus_enums](https://github.com/SchemaPlus/schema_plus_enums) | Define enum types in migrations
+    [schema_plus_foreign_keys](https://github.com/SchemaPlus/schema_plus_foreign_keys) | Extended support for foreign keys, including creation as column options, `:deferrable`, and SQLite3 support
+    [schema_plus_indexes](https://github.com/SchemaPlus/schema_plus_indexes) | Convenience and consistency in using indexes
+    [schema_plus_pg_indexes](https://github.com/SchemaPlus/schema_plus_pg_indexes) |PostgreSQL index features: `case_insenstive`, `expression` and `operator_class`
+    [schema_plus_tables](https://github.com/SchemaPlus/schema_plus_tables) | Convenience and consistency in using tables
+    [schema_plus_views](https://github.com/SchemaPlus/schema_plus_views) | Create and drop views in migrations
 
 See detailed documentation in each gem's README.
 
@@ -34,21 +43,22 @@ See detailed documentation in each gem's README.
 [![Coverage Status](https://img.shields.io/coveralls/SchemaPlus/schema_plus.svg)](https://coveralls.io/r/SchemaPlus/schema_plus)
 [![Dependency Status](https://gemnasium.com/lomba/schema_plus.svg)](https://gemnasium.com/SchemaPlus/schema_plus)
 
+The `schema_plus` gem (v2.0) is a wrapper that pulls in a collection of gems from the SchemaPlus family.  For the most part we recommend skipping this gem and directly including the specific feature gems you're interested in using.
 
-> ## This is the README for schema_plus 2.0.0.pre16
-> which supports Rails >= 4.2.0.  This prerelease is completely usable. It's still officially a prerelease rather than formal release because some features have yet to be migrated into their own gems.
->  
-> For info about the 1.x releases which support Rails 3.1, 4.0, 4.1, and 4.2.0, see the [schema_plus 1.x](https://github.com/SchemaPlus/schema_plus/tree/1.x) branch
-
----
-
-
-The `schema_plus` gem is a wrapper that pulls in a common collection of gems from the SchemaPlus family.   But you can feel free to ignore this gem and mix and match to get just the gems you want.
-
-Note: Prior to version 2.0, `schema_plus` was a single monolothic gem that implemented in itself all the features that are now included by the wrapper.
+This wrapper is mostly provided for easy upgrade for those who were using schema_plus v1.8, which was a single monolothic gem.  This wrapper pulls in the gems that provide the same set of features and automatic behavior as the previous version:
 
+* [schema_auto_foreign_keys](https://github.com/SchemaPlus/schema_auto_foreign_keys) 
+* [schema_plus_columns](https://github.com/SchemaPlus/schema_plus_columns)     
+* [schema_plus_db_default](https://github.com/SchemaPlus/schema_plus_db_default)
+* [schema_plus_default_expr](https://github.com/SchemaPlus/schema_plus_default_expr)
+* [schema_plus_enums](https://github.com/SchemaPlus/schema_plus_enums) 
+* [schema_plus_foreign_keys](https://github.com/SchemaPlus/schema_plus_foreign_keys)
+* [schema_plus_indexes](https://github.com/SchemaPlus/schema_plus_indexes)
+* [schema_plus_pg_indexes](https://github.com/SchemaPlus/schema_plus_pg_indexes)
+* [schema_plus_tables](https://github.com/SchemaPlus/schema_plus_tables)
+* [schema_plus_views](https://github.com/SchemaPlus/schema_plus_views)
 
-> **IN PROGRESS:** In the prerelease versions of SchemaPlus 2.0, some features have yet to be migrated out to their own gems, and their code is still in the body of schema_plus.  Those gems are greyed out in the list above.  The documentation for their features is at the end of this README.
+Note that the earlier version (1.x) supports earlier versions of ActiveRecord: 3.1, 4.0, 4.1, and 4.2.0.  For more info about that version, see the [schema_plus 1.x](https://github.com/SchemaPlus/schema_plus/tree/1.x) branch README.
 
 
 ### Upgrading from `schema_plus` 1.8.x
@@ -114,31 +124,4 @@ or in a Gemfile
 
 *   And [lots of contributors](https://github.com/SchemaPlus/schema_plus/graphs/contributors) since then.
 
----
----
-
-# Prerelease:  Documentation of features still be moved into separate feature gems
-
-
-### Auto Foreign Key Constraints
-
-SchemaPlus adds support for the common convention that you name a column
-with suffix `_id` to indicate that it's a foreign key, SchemaPlus
-automatically defines the appropriate constraint.
-
-SchemaPlus also creates foreign key constraints for rails' `t.references` or
-`t.belongs_to`, which take the singular of the referenced table name and
-implicitly create the column suffixed with `_id`.
-
-You can explicitly specify whether or not to generate a foreign key
-constraint, and specify or override automatic options, using the
-`:foreign_key` keyword
-
-Here are some examples:
-
-    t.integer :author_id                              # automatically references table 'authors', key id
-    t.integer :parent_id                              # special name parent_id automatically references its own table (for tree nodes)
-    t.integer :author_id, foreign_key: true           # same as default automatic behavior
-    t.integer :author,    foreign_key: true           # non-conventional column name needs to force creation, table name is assumed to be 'authors'
-    t.integer :author_id, foreign_key: false          # don't create a constraint
-
+*   In 2015, the monolithic schema_plus gem was split into the SchemaPlus family of specific feature gems.

data/lib/schema_plus.rb

@@ -7,7 +7,7 @@ require 'schema_plus/indexes'
 require 'schema_plus/tables'
 require 'schema_plus/views'
 require 'schema_plus_pg_indexes'
-require 'schema_plus/auto_foreign_keys'
+require 'schema_auto_foreign_keys'
 
 require_relative 'schema_plus/version'
 

data/lib/schema_plus/version.rb

@@ -1,3 +1,3 @@
 module SchemaPlus
-  VERSION = "2.0.0.pre16"
+  VERSION = "2.0.0"
 end

data/schema_plus.gemspec

@@ -10,8 +10,8 @@ Gem::Specification.new do |gem|
   gem.authors     = ["Ronen Barzel", "Michal Lomnicki"]
   gem.email       = ["ronen@barzel.org", "michal.lomnicki@gmail.com"]
   gem.homepage    = "https://github.com/SchemaPlus/schema_plus"
-  gem.summary     = "Enhances ActiveRecord schema mechanism, including more DRY index creation and support for foreign key constraints and views."
-  gem.description = "SchemaPlus is an ActiveRecord extension that provides enhanced capabilities for schema definition and querying, including: enhanced and more DRY index capabilities, support and automation for foreign key constraints, and support for views."
+  gem.summary     = "Wrapper that pulls in many gems from the SchemaPlus family of ActiveRecord extensions"
+  gem.description = "SchemaPlus is a gem that simply pulls in a collection of other gems from the SchemaPlus family of ActiveRecord extensions"
   gem.license = 'MIT'
 
   gem.rubyforge_project = "schema_plus"
@@ -22,7 +22,7 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
 
   gem.add_dependency "activerecord", "~> 4.2"
-  gem.add_dependency "valuable"
+  gem.add_dependency "schema_auto_foreign_keys", "~> 0.1"
   gem.add_dependency "schema_plus_core", "~> 0.4"
   gem.add_dependency "schema_monkey", "~> 2.1"
   gem.add_dependency "schema_plus_columns", "~> 0.1"

data/spec/sanity_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper'
+
+
+describe "Sanity Check" do
+
+  it "database is connected" do
+    expect(ActiveRecord::Base).to be_connected
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: schema_plus
 version: !ruby/object:Gem::Version
-  version: 2.0.0.pre16
+  version: 2.0.0
 platform: ruby
 authors:
 - Ronen Barzel
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-17 00:00:00.000000000 Z
+date: 2015-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -26,19 +26,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '4.2'
 - !ruby/object:Gem::Dependency
-  name: valuable
+  name: schema_auto_foreign_keys
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.1'
 - !ruby/object:Gem::Dependency
   name: schema_plus_core
   requirement: !ruby/object:Gem::Requirement
@@ -289,9 +289,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 'SchemaPlus is an ActiveRecord extension that provides enhanced capabilities
-  for schema definition and querying, including: enhanced and more DRY index capabilities,
-  support and automation for foreign key constraints, and support for views.'
+description: SchemaPlus is a gem that simply pulls in a collection of other gems from
+  the SchemaPlus family of ActiveRecord extensions
 email:
 - ronen@barzel.org
 - michal.lomnicki@gmail.com
@@ -318,20 +317,12 @@ files:
 - gemfiles/activerecord-4.2.1/Gemfile.postgresql
 - gemfiles/activerecord-4.2.1/Gemfile.sqlite3
 - lib/schema_plus.rb
-- lib/schema_plus/auto_foreign_keys.rb
-- lib/schema_plus/auto_foreign_keys/active_record/connection_adapters/sqlite3_adapter.rb
-- lib/schema_plus/auto_foreign_keys/active_record/migration/command_recorder.rb
-- lib/schema_plus/auto_foreign_keys/middleware/migration.rb
-- lib/schema_plus/auto_foreign_keys/middleware/schema.rb
 - lib/schema_plus/version.rb
 - schema_dev.yml
 - schema_plus.gemspec
+- spec/sanity_spec.rb
 - spec/schema/auto_schema.rb
 - spec/schema/core_schema.rb
-- spec/schema_auto_foreign_keys/foreign_key_spec.rb
-- spec/schema_auto_foreign_keys/migration_spec.rb
-- spec/schema_auto_foreign_keys/schema_dumper_spec.rb
-- spec/schema_auto_foreign_keys/schema_spec.rb
 - spec/spec_helper.rb
 - spec/support/helpers.rb
 - spec/support/matchers/automatic_foreign_key_matchers.rb
@@ -352,23 +343,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: schema_plus
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: Enhances ActiveRecord schema mechanism, including more DRY index creation
-  and support for foreign key constraints and views.
+summary: Wrapper that pulls in many gems from the SchemaPlus family of ActiveRecord
+  extensions
 test_files:
+- spec/sanity_spec.rb
 - spec/schema/auto_schema.rb
 - spec/schema/core_schema.rb
-- spec/schema_auto_foreign_keys/foreign_key_spec.rb
-- spec/schema_auto_foreign_keys/migration_spec.rb
-- spec/schema_auto_foreign_keys/schema_dumper_spec.rb
-- spec/schema_auto_foreign_keys/schema_spec.rb
 - spec/spec_helper.rb
 - spec/support/helpers.rb
 - spec/support/matchers/automatic_foreign_key_matchers.rb

data/lib/schema_plus/auto_foreign_keys.rb

@@ -1,31 +0,0 @@
-require 'schema_plus/foreign_keys'
-
-require_relative 'auto_foreign_keys/active_record/migration/command_recorder'
-require_relative 'auto_foreign_keys/middleware/migration'
-require_relative 'auto_foreign_keys/middleware/schema'
-
-module SchemaAutoForeignKeys
-  module ActiveRecord
-    module ConnectionAdapters
-      autoload :Sqlite3Adapter, 'schema_plus/auto_foreign_keys/active_record/connection_adapters/sqlite3_adapter'
-    end
-  end
-end
-
-class SchemaPlus::ForeignKeys::Config
-    ##
-    # :attr_accessor: auto_create
-    #
-    # Whether to automatically create foreign key constraints for columns
-    # suffixed with +_id+.  Boolean, default is +true+.
-    has_value :auto_create, :klass => :boolean, :default => true
-
-    ##
-    # :attr_accessor: auto_index
-    #
-    # Whether to automatically create indexes when creating foreign key constraints for columns.
-    # Boolean, default is +true+.
-    has_value :auto_index, :klass => :boolean, :default => true
-end
-
-SchemaMonkey.register SchemaAutoForeignKeys

data/lib/schema_plus/auto_foreign_keys/active_record/connection_adapters/sqlite3_adapter.rb

@@ -1,22 +0,0 @@
-module SchemaAutoForeignKeys
-  module ActiveRecord
-    module ConnectionAdapters
-
-      # SchemaPlus::ForeignKeys includes an Sqlite3 implementation of the AbstractAdapter
-      # extensions.
-      module Sqlite3Adapter
-
-        def copy_table(*args, &block)
-          fk_override = { :auto_create => false, :auto_index => false }
-          save = Hash[fk_override.keys.collect{|key| [key, SchemaPlus::ForeignKeys.config.send(key)]}]
-          begin
-            SchemaPlus::ForeignKeys.config.update_attributes(fk_override)
-            super
-          ensure
-            SchemaPlus::ForeignKeys.config.update_attributes(save)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/schema_plus/auto_foreign_keys/active_record/migration/command_recorder.rb

@@ -1,14 +0,0 @@
-module SchemaAutoForeignKeys
-  module ActiveRecord
-    module Migration
-      module CommandRecorder
-
-        # overrides to add if_exists option
-        def invert_add_index(args)
-          table, columns, options = *args
-          [:remove_index, [table, (options||{}).merge(column: columns, if_exists: true)]]
-        end
-      end
-    end
-  end
-end

data/lib/schema_plus/auto_foreign_keys/middleware/migration.rb

@@ -1,66 +0,0 @@
-module SchemaAutoForeignKeys
-  module Middleware
-    module Migration
-
-      module Column
-
-        def before(env)
-          config = (env.caller.try(:schema_plus_foreign_keys_config) || SchemaPlus::ForeignKeys.config)
-          set_foreign_key(env) if auto_fk?(env, config)
-          set_auto_index(env) if auto_index?(env, config)
-        end
-
-        def after(env)
-          remove_auto_index(env) if env.operation == :change and remove_auto_index?(env)
-        end
-
-        private
-
-        def auto_fk?(env, config)
-          return false if env.options.include? :foreign_key
-          return false unless config.auto_create?
-          return true if env.type == :reference
-          return false if env.implements_reference
-          return true if env.column_name.to_s =~ /_id$/ # later on add a config option for this
-        end
-
-        def auto_index?(env, config)
-          return false if env.options.include? :index
-          return false unless env.options[:foreign_key]
-          return true if config.auto_index?
-        end
-
-        def remove_auto_index?(env)
-          env.options.include? :foreign_key and not env.options[:foreign_key]
-        end
-
-        def set_foreign_key(env)
-          env.options[:foreign_key] = true
-        end
-
-        def set_auto_index(env)
-          env.options[:index] = { name: auto_index_name(env) }
-        end
-
-        def remove_auto_index(env)
-          env.caller.remove_index(env.table_name, :name => auto_index_name(env), :column => env.column_name, :if_exists => true)
-        end
-
-        def auto_index_name(env)
-          SchemaAutoForeignKeys.auto_index_name(env.table_name, env.column_name)
-        end
-
-      end
-    end
-  end
-
-  def self.auto_index_name(from_table, column_name)
-    "fk__#{fixup_schema_name(from_table)}_#{Array.wrap(column_name).join('_and_')}"
-    # this should enforce a maximum length
-  end
-
-  def self.fixup_schema_name(table_name)
-    # replace . with _
-    table_name.to_s.gsub(/[.]/, '_')
-  end
-end

data/lib/schema_plus/auto_foreign_keys/middleware/schema.rb

@@ -1,18 +0,0 @@
-module SchemaAutoForeignKeys
-  module Middleware
-    module Schema
-      module Define
-        def around(env)
-          fk_override = { :auto_create => false, :auto_index => false }
-          save = Hash[fk_override.keys.collect{|key| [key, SchemaPlus::ForeignKeys.config.send(key)]}]
-          begin
-            SchemaPlus::ForeignKeys.config.update_attributes(fk_override)
-            yield env
-          ensure
-            SchemaPlus::ForeignKeys.config.update_attributes(save)
-          end
-        end
-      end
-    end
-  end
-end

data/spec/schema_auto_foreign_keys/foreign_key_spec.rb

@@ -1,206 +0,0 @@
-require 'spec_helper'
-
-describe "Foreign Key" do
-
-  let(:migration) { ::ActiveRecord::Migration }
-
-  context "created with table" do
-    before(:all) do
-      define_schema(:auto_create => true) do
-        create_table :users, :force => true do |t|
-          t.string :login
-        end
-        create_table :comments, :force => true do |t|
-          t.integer :user_id
-          t.foreign_key :user_id, :users
-        end
-      end
-      class User < ::ActiveRecord::Base ; end
-      class Comment < ::ActiveRecord::Base ; end
-    end
-
-    it "should report foreign key constraints" do
-      expect(Comment.foreign_keys.collect(&:column).flatten).to eq([ "user_id" ])
-    end
-
-    it "should report reverse foreign key constraints" do
-      expect(User.reverse_foreign_keys.collect(&:column).flatten).to eq([ "user_id" ])
-    end
-
-  end
-
-  context "modification" do
-
-    before(:each) do
-      define_schema(:auto_create => false) do
-        create_table :users, :force => true do |t|
-          t.string :login
-          t.datetime :deleted_at
-        end
-
-        create_table :posts, :force => true do |t|
-          t.text :body
-          t.integer :user_id
-          t.integer :author_id
-        end
-
-        create_table :comments, :force => true do |t|
-          t.text :body
-          t.integer :post_id
-          t.foreign_key :post_id, :posts
-        end
-      end
-      class User < ::ActiveRecord::Base ; end
-      class Post < ::ActiveRecord::Base ; end
-      class Comment < ::ActiveRecord::Base ; end
-      Comment.reset_column_information
-    end
-
-
-    context "works", :sqlite3 => :skip do
-
-      context "when is added", "posts(author_id)" do
-
-        before(:each) do
-          add_foreign_key(:posts, :users, :column => :author_id, :on_update => :cascade, :on_delete => :restrict)
-        end
-
-        it "references users(id)" do
-          expect(Post).to reference(:users, :id).on(:author_id)
-        end
-
-        it "cascades on update" do
-          expect(Post).to reference(:users).on_update(:cascade)
-        end
-
-        it "restricts on delete" do
-          expect(Post).to reference(:users).on_delete(:restrict)
-        end
-
-        it "is available in Post.foreign_keys" do
-          expect(Post.foreign_keys.collect(&:column)).to include('author_id')
-        end
-
-        it "is available in User.reverse_foreign_keys" do
-          expect(User.reverse_foreign_keys.collect(&:column)).to include('author_id')
-        end
-
-      end
-
-      context "when is dropped", "comments(post_id)" do
-
-        let(:foreign_key_name) { fk = Comment.foreign_keys.detect(&its.column == 'post_id') and fk.name }
-
-        before(:each) do
-          remove_foreign_key(:comments, name: foreign_key_name)
-        end
-
-        it "doesn't reference posts(id)" do
-          expect(Comment).not_to reference(:posts).on(:post_id)
-        end
-
-        it "is no longer available in Post.foreign_keys" do
-          expect(Comment.foreign_keys.collect(&:column)).not_to include('post_id')
-        end
-
-        it "is no longer available in User.reverse_foreign_keys" do
-          expect(Post.reverse_foreign_keys.collect(&:column)).not_to include('post_id')
-        end
-
-      end
-
-      context "when drop using hash", "comments(post_id)" do
-
-        let(:foreign_key_name) { fk = Comment.foreign_keys.detect(&its.column == 'post_id') and fk.name }
-
-        it "finds by name" do
-          remove_foreign_key(:comments, name: foreign_key_name)
-          expect(Comment).not_to reference(:posts).on(:post_id)
-        end
-
-        it "finds by column_names" do
-          remove_foreign_key(:comments, column: "post_id", to_table: "posts")
-          expect(Comment).not_to reference(:posts).on(:post_id)
-        end
-      end
-
-      context "when attempt to drop nonexistent foreign key" do
-        it "raises error" do
-          expect{remove_foreign_key(:comments, "posts", column: "nonesuch")}.to raise_error(/no foreign key/i)
-        end
-
-        it "does not error with :if_exists" do
-          expect{remove_foreign_key(:comments, "posts", column: "nonesuch", :if_exists => true)}.to_not raise_error
-        end
-      end
-
-      context "when referencing column and column is removed" do
-
-        let(:foreign_key_name) { Comment.foreign_keys.detect { |definition| definition.column == 'post_id' }.name }
-
-        it "should remove foreign keys" do
-          remove_foreign_key(:comments, name: foreign_key_name)
-          expect(Post.reverse_foreign_keys.collect { |fk| fk.column == 'post_id' && fk.from_table == "comments" }).to be_empty
-        end
-
-      end
-
-      context "when table name is a reserved word" do
-        before(:each) do
-          migration.suppress_messages do
-            migration.create_table :references, :force => true do |t|
-              t.integer :post_id, :foreign_key => false
-            end
-          end
-        end
-
-        it "can add, detect, and remove a foreign key without error" do
-          migration.suppress_messages do
-            expect {
-              migration.add_foreign_key(:references, :posts)
-              foreign_key = migration.foreign_keys(:references).detect{|definition| definition.column == "post_id"}
-              migration.remove_foreign_key(:references, name: foreign_key.name)
-            }.to_not raise_error
-          end
-        end
-      end
-
-    end
-
-    context "raises an exception", :sqlite3 => :only do
-
-      it "when attempting to add" do
-        expect {
-          add_foreign_key(:posts, :users, :column => :author_id, :on_update => :cascade, :on_delete => :restrict)
-        }.to raise_error(NotImplementedError)
-      end
-
-      it "when attempting to remove" do
-        expect {
-          remove_foreign_key(:posts, name: "dummy")
-        }.to raise_error(NotImplementedError)
-      end
-
-    end
-  end
-
-  protected
-  def add_foreign_key(*args)
-    migration.suppress_messages do
-      migration.add_foreign_key(*args)
-    end
-    User.reset_column_information
-    Post.reset_column_information
-    Comment.reset_column_information
-  end
-
-  def remove_foreign_key(*args)
-    migration.suppress_messages do
-      migration.remove_foreign_key(*args)
-    end
-    User.reset_column_information
-    Post.reset_column_information
-    Comment.reset_column_information
-  end
-
-end