schema_plus 1.8.2 → 1.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c0fa513513788b541ef9a1f0f9bc50ca6f3360e5
-  data.tar.gz: 26caef3cbcf5b870bd4484e903d57d33ff999b15
+  metadata.gz: 7a5f207e0ebe6cbe96157c4762ac33335023a439
+  data.tar.gz: 024b7be47e963277cc5a673cc5639bede4348d58
 SHA512:
-  metadata.gz: cd84595cfdb830f928a4f06bb6dc13960ca144121b5f4dd88d29415a540807f36e0b7d5abe1f5f34d34e2421b482755ec42a0111a4a5ed67f072836fb6f4f881
-  data.tar.gz: 1d7350d3629ae83ace5180dd907c6dbf76fe6b33ffc31d3196888530bfe3fb5e89a4cb1545df110ab67457a552c58ccd1365f579dc1fe8865fcda96ff80480cb
+  metadata.gz: 4e40fb778ee431cac5b5393f417036f62be5b256ad63dd98ea67cab6c7414e9a6abf7ac4a3b591a72f484c4b547cc1e8d727b27b7b8e993873e7b28c941d7e25
+  data.tar.gz: 18eee79285313cef82db8533032862e9662c9c8ac74c454afc2b80fd137a6081aa97594636becb63d56f260c4a213d98b49501da243c31c6ef1df196ce40330c

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Change Log
 
+## 1.8.3
+
+* Don't modifiy migration column options hashes (#191).  Thanks to [@lowjoel](https://github.com/lowjoel)
+
 ## 1.8.2
 
 * Bug fix when using t.references in change_table (#194).  Thanks to [@boone](https://github.com/boone)

data/lib/schema_plus/active_record/column_options_handler.rb

@@ -54,6 +54,7 @@ module SchemaPlus::ActiveRecord
 
       if column_options.has_key?(:foreign_key)
         args = column_options[:foreign_key]
+        args = args.dup if args.is_a?(Hash)
         return :none unless args
         args = {} if args == true
         return :none if args.has_key?(:references) and not args[:references]
@@ -98,6 +99,7 @@ module SchemaPlus::ActiveRecord
 
 
     def column_index(table_name, column_name, options) #:nodoc:
+      options = options.dup
       column_name = [column_name] + Array.wrap(options.delete(:with)).compact
       add_index(table_name, column_name, options)
     end

data/lib/schema_plus/active_record/connection_adapters/schema_statements.rb

@@ -54,6 +54,7 @@ module SchemaPlus::ActiveRecord::ConnectionAdapters
     end
 
     def add_index_options_with_schema_plus(table_name, column_name, options = {})
+      options = options.dup
       with_columns = options.delete(:with) { |_| [] }
       add_index_options_without_schema_plus(table_name, Array(column_name).concat(Array(with_columns).map(&:to_s)), options)
     end

data/lib/schema_plus/version.rb

@@ -1,3 +1,3 @@
 module SchemaPlus
-  VERSION = "1.8.2"
+  VERSION = "1.8.3"
 end

data/spec/migration_spec.rb

@@ -70,6 +70,24 @@ describe ActiveRecord::Migration do
       expect(@model).to reference(:users, :id).on(:author_id)
     end
 
+    it "should create foreign key without modifying input hash" do
+      hash = { :references => :users }
+      hash_original = hash.dup
+      recreate_table(@model) do |t|
+        t.integer :author_id, :foreign_key => hash
+      end
+      expect(hash).to eq(hash_original)
+    end
+
+    it "should create foreign key without modifying input hash" do
+      hash = { :references => :users }
+      hash_original = hash.dup
+      recreate_table(@model) do |t|
+        t.references :author, :foreign_key => hash
+      end
+      expect(hash).to eq(hash_original)
+    end
+
     it "should create foreign key with different reference using shortcut" do
       recreate_table(@model) do |t|
         t.integer :author_id, :references => :users
@@ -250,6 +268,16 @@ describe ActiveRecord::Migration do
       expect(@model).to have_index.on([:state, :city])
     end
 
+    it "should create the index without modifying the input hash" do
+      hash = { :with => :foo, :length => { :foo => 8, :bar => 12 }}
+      hash_original = hash.dup
+      recreate_table(@model) do |t|
+        t.string :foo
+        t.string :bar, :index => hash
+      end
+      expect(hash).to eq(hash_original)
+    end
+
     it "should auto-index foreign keys only" do
       recreate_table(@model) do |t|
         t.integer :user_id

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: schema_plus
 version: !ruby/object:Gem::Version
-  version: 1.8.2
+  version: 1.8.3
 platform: ruby
 authors:
 - Ronen Barzel
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-01 00:00:00.000000000 Z
+date: 2015-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord