scheduled_job 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8992a23a08c1f37078a3f9a41e3e79807ccdcd86
-  data.tar.gz: f0fa25cd3bd9e27fb4b827a76e0c581f558ea451
+  metadata.gz: c9ef9b5bd8566235b6a1befa68badc08cf96670f
+  data.tar.gz: 5f37b2668598ec438c4f34d6233696e7883dcb0f
 SHA512:
-  metadata.gz: 3bdada7d253e3124f3ef9ac9e303015a80082a8e3ef3ba61a2f34a30c9b6de9ee3e9ad238484e2d280b4b1bad61efc07144611f56f942b18d80c53d481a98b4e
-  data.tar.gz: b7da6a1ed79dab91050c9bec04668117b37ec2688f7726aeca25b99b8f5f76590ec2269b454bc68b218b0d24e02a831876aaca816804dd62b75d1aff379e2ea4
+  metadata.gz: 7f13ba7f35eadc34d793c0282ccc437b71dc20e1e6ff97461cd58acaaea857a49725170ad350db36b812da4ce9f5128bc5ebf3f5ecefcb5f5afa3eb019f2b682
+  data.tar.gz: dd3475e7da5a8db5f796f8d1d21d5ccfb4bf55ec33723260dede2bec9b4316943cbb6919796d0c6dff648cc6c6f5421c35676a4b8b2b19c16b2a9fc9f266baea

data/CHANGELOG.md

@@ -22,3 +22,6 @@ Adds local db for development
 # 0.1.0
 Makes available the `rake jobs:reschedule` rake task
 Adds a config to allow the scheduling for more than one instance of the same job
+
+# 0.1.1
+Allows jobs in config to be strings, symbols, or classes. If a string or symbol is provided, it will be resolved to a constant before scheduling the job.

data/lib/scheduled_job/version.rb

@@ -1,3 +1,3 @@
 module ScheduledJob
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/scheduled_job.rb

@@ -18,6 +18,8 @@ module ScheduledJob
   def self.reschedule
     config.jobs.each do |job, options|
       options[:count].times do
+        job = job.to_s if job.is_a?(Symbol)
+        job = job.constantize if job.is_a?(String)
         job.schedule_job
       end
     end if config.jobs
@@ -34,7 +36,7 @@ module ScheduledJob
 
   def self.validate_job_hash(jobs)
     jobs.each do |klass, options|
-      raise ConfigError.new("Jobs config found invalid class: #{klass}") unless klass.class == Class
+      raise ConfigError.new("Jobs config found invalid class: #{klass}") unless klass.is_a?(Class) || klass.is_a?(Symbol) || klass.is_a?(String)
       raise ConfigError.new("Jobs config found invalid job count: #{options[:count]}") unless options[:count].to_i >= 0
     end
   end

data/spec/lib/scheduled_job_spec.rb

@@ -39,35 +39,52 @@ describe ScheduledJob do
   end
 
   describe 'job config' do
-    it 'takes a jobs hash config' do
-      expect {
+    let(:job_class) { UnderTest }
+    let(:job_count) { 1 }
+
+    let(:configure) do
+      lambda do
         ScheduledJob.configure do |config|
-          config.jobs = {
-            UnderTest => { count: 1 }
-          }
+          config.jobs = { job_class => { count: job_count } }
         end
-      }.not_to raise_error
+      end
+    end
+
+    context 'job class is a class' do
+      it 'considers the jobs hash valid' do
+        expect(configure).not_to raise_error
+      end
+    end
+
+    context 'job class is a string' do
+      let(:job_class) { 'UnderTest' }
+
+      it 'considers the jobs hash valid' do
+        expect(configure).not_to raise_error
+      end
+    end
+
+    context 'job class is a symbol' do
+      let(:job_class) { :UnderTest }
+
+      it 'considers the jobs hash valid' do
+        expect(configure).not_to raise_error
+      end
     end
 
-    context 'validates the job hash' do
-      it 'detects an bad job class' do
-        expect {
-          ScheduledJob.configure do |config|
-            config.jobs = {
-              'UnderTest' => { count: 1 }
-            }
-          end
-        }.to raise_error(ScheduledJob::ConfigError)
+    context 'job class is not a class, string, or symbol' do
+      let(:job_class) { 1 }
+
+      it 'raises ConfigError' do
+        expect(configure).to raise_error(ScheduledJob::ConfigError)
       end
+    end
+
+    context 'job count is not a non-negative integer' do
+      let(:job_count) { -1 }
 
-      it 'detects a bad job count' do
-        expect {
-          ScheduledJob.configure do |config|
-            config.jobs = {
-              UnderTest => { count: -1 }
-            }
-          end
-        }.to raise_error(ScheduledJob::ConfigError)
+      it 'raises ConfigError' do
+        expect(configure).to raise_error(ScheduledJob::ConfigError)
       end
     end
   end
@@ -77,7 +94,7 @@ describe ScheduledJob do
       ScheduledJob.configure do |config|
         config.jobs = {
           UnderTest => { count: 1 },
-          Test      => { count: 5 }
+          :Test     => { count: 5 }
         }
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scheduled_job
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - CallumD
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-16 00:00:00.000000000 Z
+date: 2015-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: delayed_job