scenic 1.5.4 → 1.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e93cc4bb35daed3860cfabd944a9e8bfba6ef4adb48ea03c16fc75f7a0be22df
-  data.tar.gz: 733141c2c27baa2c09dec37acbaf006e3b9f5c746076b8da7508cec9ba7fff55
+  metadata.gz: 4da3d3cd88cae9dfaee68959a899fddbe617a1c711fa03ec36fc40cefba90315
+  data.tar.gz: 74b8894aee096545789a61bbd6d2dcbc276949d7f6d5fe62b06128a9751df49f
 SHA512:
-  metadata.gz: 45191843b2feb1597827b4a71d8d34cb426aeb200f775b0b888f163cfb02ee36a356e9697c286a17a909406ce2fad4c0d71e0293dc5cecbda1777d2b522b9df0
-  data.tar.gz: b6c650f5be7c718250c88ec6e6ddd801b2c8b884e11b316c5ef04711667eee87a0a7573dd6bfc3ddf706f809e986208c402b5af6fa792a8f8df9d7abec655fe7
+  metadata.gz: 886b10ebffb2a4a612bdb68ca519c38f0e5114d14850cfe7f3d4e985209f69530c18249bab750f4fe6b9b8fee98adc4675cb08f14cd56e1faf2693f1910d38fb
+  data.tar.gz: faa4bfbf6812f81ad9efc27a70e79ccb66e1679db69824a551f7494c11482361660aa9780900aa45ad3609ab37074ac83aea85a5cf62dcc4808772259a2a37cb

data/.github/workflows/ci.yml

@@ -2,7 +2,7 @@ name: CI
 
 on:
   push:
-    branches: master
+    branches: main
   pull_request:
     branches: "*"
 
@@ -13,16 +13,9 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ["2.7","2.4"]
-        rails: ["5.2", "6.0", "master"]
-        exclude:
-          - ruby: "2.4"
-            rails: "6.0"
-          - ruby: "2.4"
-            rails: "master"
-        include:
-          - rails: "master"
-            continue-on-error: true
+        ruby: ["2.7", "3.0"]
+        rails: ["6.0", "6.1", "master"]
+        continue-on-error: [false]
 
     runs-on: ubuntu-latest
 
@@ -50,7 +43,7 @@ jobs:
         uses: actions/checkout@v2
 
       - name: Install Ruby ${{ matrix.ruby }}
-        uses: ruby/setup-ruby@v1.14.1
+        uses: ruby/setup-ruby@v1.61.1
         with:
           ruby-version: ${{ matrix.ruby }}
 

data/.gitignore

@@ -17,3 +17,4 @@ test/version_tmp
 tmp
 gemfiles/*.lock
 .DS_Store
+.ruby-version

data/CHANGELOG.md

@@ -5,6 +5,15 @@ changelog, see the [commits] for each version via the version links.
 
 [commits]: https://github.com/scenic-views/scenic/commits/master
 
+## [1.5.5] - December 15, 2021
+
+### Fixed
+
+- Fixed an issue reverting migrations under Ruby 3
+- Fixed an issue in index reapplication where sometimes `say` was undefined
+
+[1.5.5]: https://github.com/scenic-views/scenic/compare/v1.5.4...v1.5.5
+
 ## [1.5.4] - September 16, 2020
 
 [1.5.4]: https://github.com/scenic-views/scenic/compare/v1.5.3...v1.5.4

data/Gemfile

@@ -3,7 +3,7 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in scenic.gemspec
 gemspec
 
-rails_version = ENV.fetch("RAILS_VERSION", "6.0")
+rails_version = ENV.fetch("RAILS_VERSION", "6.1")
 
 if rails_version == "master"
   rails_constraint = { github: "rails/rails" }

data/README.md

@@ -2,7 +2,7 @@
 
 ![Scenic Landscape](https://user-images.githubusercontent.com/152152/49344534-a8817480-f646-11e8-8431-3d95d349c070.png)
 
-[![Build Status](https://github.com/scenic-views/scenic/workflows/CI/badge.svg)](https://github.com/scenic-views/scenic/actions?query=workflow%3ACI+branch%3Amaster)
+[![Build Status](https://github.com/scenic-views/scenic/actions/workflows/ci.yml/badge.svg)](https://github.com/scenic-views/scenic/actions/workflows/ci.yml)
 [![Documentation Quality](http://inch-ci.org/github/scenic-views/scenic.svg?branch=master)](http://inch-ci.org/github/scenic-views/scenic)
 [![Reviewed by Hound](https://img.shields.io/badge/Reviewed_by-Hound-8E64B0.svg)](https://houndci.com)
 

data/lib/scenic/adapters/postgres/index_reapplication.rb

@@ -13,7 +13,7 @@ module Scenic
         # @param connection [Connection] The connection to execute SQL against.
         # @param speaker [#say] (ActiveRecord::Migration) The object used for
         #   logging the results of reapplying indexes.
-        def initialize(connection:, speaker: ActiveRecord::Migration)
+        def initialize(connection:, speaker: ActiveRecord::Migration.new)
           @connection = connection
           @speaker = speaker
         end

data/lib/scenic/command_recorder/statement_arguments.rb

@@ -36,15 +36,25 @@ module Scenic
         @options ||= @args[1] || {}
       end
 
+      def keyword_hash(hash)
+        if Hash.respond_to? :ruby2_keywords_hash
+          Hash.ruby2_keywords_hash(hash)
+        else
+          hash
+        end
+      end
+
       def options_for_revert
-        options.clone.tap do |revert_options|
+        opts = options.clone.tap do |revert_options|
           revert_options[:version] = revert_to_version
           revert_options.delete(:revert_to_version)
         end
+
+        keyword_hash(opts)
       end
 
       def options_without_version
-        options.except(:version)
+        keyword_hash(options.except(:version))
       end
     end
   end

data/lib/scenic/command_recorder.rb

@@ -6,18 +6,22 @@ module Scenic
     def create_view(*args)
       record(:create_view, args)
     end
+    ruby2_keywords :create_view if respond_to?(:ruby2_keywords, true)
 
     def drop_view(*args)
       record(:drop_view, args)
     end
+    ruby2_keywords :drop_view if respond_to?(:ruby2_keywords, true)
 
     def update_view(*args)
       record(:update_view, args)
     end
+    ruby2_keywords :update_view if respond_to?(:ruby2_keywords, true)
 
     def replace_view(*args)
       record(:replace_view, args)
     end
+    ruby2_keywords :replace_view if respond_to?(:ruby2_keywords, true)
 
     def invert_create_view(args)
       drop_view_args = StatementArguments.new(args).remove_version.to_a

data/lib/scenic/version.rb

@@ -1,3 +1,3 @@
 module Scenic
-  VERSION = "1.5.4".freeze
+  VERSION = "1.5.5".freeze
 end

data/spec/scenic/statements_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 module Scenic
   describe Scenic::Statements do
     before do
-      adapter = instance_double("Scenic::Adapaters::Postgres").as_null_object
+      adapter = instance_double("Scenic::Adapters::Postgres").as_null_object
       allow(Scenic).to receive(:database).and_return(adapter)
     end
 

data/spec/spec_helper.rb

@@ -11,6 +11,8 @@ RSpec.configure do |config|
   DatabaseCleaner.strategy = :transaction
 
   config.around(:each, db: true) do |example|
+    ActiveRecord::SchemaMigration.create_table
+
     DatabaseCleaner.start
     example.run
     DatabaseCleaner.clean

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scenic
 version: !ruby/object:Gem::Version
-  version: 1.5.4
+  version: 1.5.5
 platform: ruby
 authors:
 - Derek Prior
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-16 00:00:00.000000000 Z
+date: 2021-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -270,7 +270,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.2.32
 signing_key:
 specification_version: 4
 summary: Support for database views in Rails migrations