sbsm 1.5.1 → 1.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d54dfb08f0b27dc20f788152dc58721b5a71d9f7
-  data.tar.gz: 78d415485525ac67216b43dc677a79e1bccd4bfb
+  metadata.gz: 97b5380c3233416078670d095b29e76843a7476b
+  data.tar.gz: 2f4f64aaf4eab500ff12dc698d1fc6249b3990af
 SHA512:
-  metadata.gz: e05045a10f97fc9f884743d46c5cbf791fc9a6d826d6e2c7d6227a7b3ef9bac47f8aa211e94e0b7e8e765025195ec29e1c42a92502eb18b96d0bca2e6fb65d51
-  data.tar.gz: f7852b80aaa5d5199aafdda19d733048704375e5c26e9bf4e4d42c739747ce4949fd3c7dd3fa525eb855ff0aab372ef6a550a1437fe339c8214b737b5b090227
+  metadata.gz: '08d78ff9c24108e41163516ed78e2a90f1697b311f00c409aec9480d7f694be12bcf3b95b73589bd84eccf982201ef5b0801fd2d7fb89656dde83d4d3ec559fc'
+  data.tar.gz: 1897c958748d506cf989c0057a3f86f386c8172d04855e507f8126ec38731284d8c37ad4a7b0466fb7c779a7e3e3f6c72a4446925ec0eb1d03e70e102ac8f5f2

data/History.txt

@@ -1,6 +1,10 @@
+=== 1.5.2 / 04.07.2017
+
+* Fix handling true/false values in cookie
+
 === 1.5.1 / 04.07.2017
 
-* Return 302 if http_headers contain 'Location
+* Return 302 if http_headers contain 'Location'
 
 === 1.5.0 / 04.07.2017
 

data/lib/sbsm/session.rb

@@ -443,7 +443,19 @@ module SBSM
 			end
 		end
     def cookie_pairs
-      cookie_input.collect { |key, value| "#{key}=#{value ?CGI.escape(value) : ''}" }.join(';')
+      cookie_input.collect do |key, value|
+        if value
+          if value.is_a?(String)
+            "#{key}=#{CGI.escape(value)}"
+          else
+            "#{key}=#{value}"
+          end
+        else
+          "#{key}="
+        end
+      end.join(';')
+    rescue => error
+      binding.pry
     end
 		def http_headers
         @state.http_headers

data/lib/sbsm/version.rb

@@ -1,3 +1,3 @@
 module SBSM
-  VERSION = '1.5.1'
+  VERSION = '1.5.2'
 end

data/test/test_rack_app.rb

@@ -171,16 +171,21 @@ class TestSession < Minitest::Test
   end
   def test_cookie_pairs
     @session.cookie_input = { 'name_last' => 'Müller', 'name_first' => 'Cécile',
-                              'nil_value' => nil, 'empty_string' => ''}
-    assert_equal('name_last=M%C3%BCller;name_first=C%C3%A9cile;nil_value=;empty_string=',  @session.cookie_pairs)
+                              'nil_value' => nil, 'empty_string' => '',
+                              'boolean_true' => true,
+                              'boolean_false' => false,
+                              }
+    assert_equal('name_last=M%C3%BCller;name_first=C%C3%A9cile;nil_value=;empty_string=;boolean_true=true;boolean_false=',  @session.cookie_pairs)
     @request.cookies[@session.persistent_cookie_name] = @session.cookie_pairs
     @session.cookie_input = {}
     assert_equal({}, @session.cookie_input)
     @session.process_rack(rack_request: @request)
-    assert_equal([:name_last, :name_first, :nil_value, :empty_string], @session.cookie_input.keys)
+    assert_equal([:name_last, :name_first, :nil_value, :empty_string, :boolean_true, :boolean_false], @session.cookie_input.keys)
     assert_equal('Müller', @session.cookie_input[:name_last])
     assert_equal('Cécile', @session.cookie_input[:name_first])
+    assert_equal('true', @session.cookie_input[:boolean_true])
     assert_equal('', @session.cookie_input[:nil_value])
     assert_equal('', @session.cookie_input[:empty_string])
+    assert_equal('', @session.cookie_input[:boolean_false])
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sbsm
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.5.2
 platform: ruby
 authors:
 - Masaomi Hatakeyama, Zeno R.R. Davatz