saxy 0.6.1 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 071f31e0e4239d7aa2206cddd8d0bbab99982896
-  data.tar.gz: 9314c5c857ffa12cd30ba32f473a34c01bbfdaca
+  metadata.gz: 145b19ea70344eb97cb37dab58b172d07766a654
+  data.tar.gz: 9b0a3482befc1f5270f8bfe5665a68b4cc0a87f4
 SHA512:
-  metadata.gz: db0123c050ea39667f55e1e2569d5bdd8649a94a3650ec1d73f8c317b42d4c17270e40796a0c58a50fbbaf4be43468941d85473a7164390166db7ee4df96acf8
-  data.tar.gz: 5fb5c951cf06dff3b7b3385b8ac19a59887a91e8b70f790c4d8e698964551327328900508c7d8a1547bd27aabdcaca7304b2ec823c9d59afd408ba591f97eed4
+  metadata.gz: 229a5ceede847656383a9b86a8521d17030c97329233cc36a0a32f6beceb2efcacff06a9e2d030a05c81014f41b9dc3f7c31f83b5cbce933827136149e48bab8
+  data.tar.gz: dd980f2f3fc39731e19776316bde8f16abb8f28be32d7f036cfca65db6867fa7dd1d7362360a96e3759b2f389a6e48e6aa3ab88df568ebfb3334174e9492af6c

data/.travis.yml

@@ -2,6 +2,8 @@ script: "bundle exec rspec ./spec/"
 sudo: false
 language: ruby
 rvm:
+  - 2.4
+  - 2.3
   - 2.2
   - 2.1
   - 2.0.0

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Saxy Changelog
 
+## 0.7.0
+
+* [BREAKING] Yielded hashes now have strings as keys instead of symbols (performance and security fix).
+
 ## 0.6.1
 
 * Fixed passing options from `Saxy.parse` to parser's initializer

data/README.md

@@ -3,9 +3,9 @@
 [![Gem Version](https://badge.fury.io/rb/saxy.svg)](https://badge.fury.io/rb/saxy)
 [![Build Status](https://api.travis-ci.org/humante/saxy.svg)](http://travis-ci.org/humante/saxy)
 
-Memory-efficient XML parser. Finds object definitions in XML and translates them into Ruby objects.
+Memory-efficient XML parser. Finds object definitions in XML and translates them into Ruby hashes.
 
-It uses SAX parser (provided by Nokogiri gem) under the hood, which means that it doesn't load the whole XML file into memory. It goes once through it and yields objects along the way.
+It uses SAX parser (provided by Nokogiri gem) under the hood, which means that it doesn't load the whole XML file into memory. It goes once through it and yields hashes along the way.
 
 In result the memory footprint of the parser remains small and more or less constant irrespective of the size of the XML file, be it few KB or hundreds of GB.
 
@@ -96,9 +96,9 @@ Usage with a file path:
 
 ````ruby
 Saxy.parse("filename.xml", "product").each do |product|
-  puts product[:name]
-  puts product[:images][:thumb_size][:contents]
-  puts "#{product[:images][:thumb_size][:width]}x#{product[:images][:thumb_size][:height]}"
+  puts product["name"]
+  puts product["images"]["thumb_size"]["contents"]
+  puts "#{product["images"]["thumb_size"]["width"]}x#{product["images"]["thumb_size"]["height"]}"
 end
 
 # =>
@@ -115,7 +115,7 @@ Usage with an IO-like object `ARGF` or `$stdin`:
 ````ruby
 # > cat filename.xml | ruby this_script.rb
 Saxy.parse(ARGF, "product").each do |product|
-  puts product.name
+  puts product["name"]
 end
 
 # =>
@@ -141,7 +141,7 @@ Multiple definitions of child objects are grouped in arrays:
 
 ````ruby
 webstore = Saxy.parse("filename.xml", "webstore").first
-webstore[:products][:product].size # => 2
+webstore["products"]["product"].size # => 2
 ````
 
 ## Debugging

data/lib/saxy/element.rb

@@ -23,23 +23,23 @@ module Saxy
     def to_h
       return value unless attributes.any?
       data = attributes.reduce({}) do |memo, (name, value)|
-        memo[name.to_sym] = value.size == 1 ? value.first : value
+        memo[name] = value.size == 1 ? value.first : value
         memo
       end
-      data[:contents] = value
+      data["contents"] = value
       data
     end
 
     def attribute_name(name)
-      underscore(name).to_sym
+      underscore(name)
     end
 
     private
 
     def underscore(word)
       word = word.dup
-      word.gsub!(/([A-Z\d]+)([A-Z][a-z])/,'\1_\2')
-      word.gsub!(/([a-z\d])([A-Z])/,'\1_\2')
+      word.gsub!(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2')
+      word.gsub!(/([a-z\d])([A-Z])/, '\1_\2')
       word.tr!("-", "_")
       word.downcase!
       word

data/lib/saxy/version.rb

@@ -1,3 +1,3 @@
 module Saxy
-  VERSION = "0.6.1"
+  VERSION = "0.7.0"
 end

data/spec/saxy/element_spec.rb

@@ -23,8 +23,8 @@ describe Saxy::Element do
     expect(element).to receive(:attributes).at_least(:once).and_return("foo" => 1, "bar" => 2)
     object = element.to_h
 
-    expect(object[:foo]).to eq(1)
-    expect(object[:bar]).to eq(2)
+    expect(object["foo"]).to eq(1)
+    expect(object["bar"]).to eq(2)
   end
 
   it "should dump as object with value when attributes and contents are set" do
@@ -32,18 +32,18 @@ describe Saxy::Element do
     element.append_value("value")
     object = element.to_h
 
-    expect(object[:foo]).to eq("bar")
-    expect(object[:contents]).to eq("value")
+    expect(object["foo"]).to eq("bar")
+    expect(object["contents"]).to eq("value")
   end
 
   it "should add attributes under underscored names" do
     element.set_attribute("FooBar", "baz")
-    expect(element.to_h[:foo_bar]).to eq("baz")
+    expect(element.to_h["foo_bar"]).to eq("baz")
   end
 
   it "should create array if adding multiple attributtes with the same name" do
     element.set_attribute("foo", "bar")
     element.set_attribute("foo", "baz")
-    expect(element.to_h[:foo]).to eq(["bar", "baz"])
+    expect(element.to_h["foo"]).to eq(["bar", "baz"])
   end
 end

data/spec/saxy/parser_spec.rb

@@ -161,7 +161,7 @@ describe Saxy::Parser do
 
     it "should set element's attributes when opening tag with attributes" do
       parser.start_element("foo", [["bar", "baz"]])
-      expect(parser.current_element.to_h[:bar]).to eq("baz")
+      expect(parser.current_element.to_h["bar"]).to eq("baz")
     end
   end
 

data/spec/saxy_spec.rb

@@ -9,26 +9,26 @@ describe Saxy do
       arr
     end
 
-    expect(products[0][:uid]).to eq("FFCF177")
-    expect(products[0][:name]).to eq("Kindle")
-    expect(products[0][:description]).to eq("The world's best-selling e-reader.")
-    expect(products[0][:price]).to eq("$109")
-    expect(products[0][:images][:thumb]).to eq("http://amazon.com/kindle_thumb.jpg")
-    expect(products[0][:images][:large]).to eq("http://amazon.com/kindle.jpg")
-
-    expect(products[1][:uid]).to eq("YD26NT")
-    expect(products[1][:name]).to eq("Kindle Touch")
-    expect(products[1][:description]).to eq("Simple-to-use touchscreen with built-in WIFI.")
-    expect(products[1][:price]).to eq("$79")
-    expect(products[1][:images][:thumb]).to eq("http://amazon.com/kindle_touch_thumb.jpg")
-    expect(products[1][:images][:large]).to eq("http://amazon.com/kindle_touch.jpg")
+    expect(products[0]["uid"]).to eq("FFCF177")
+    expect(products[0]["name"]).to eq("Kindle")
+    expect(products[0]["description"]).to eq("The world's best-selling e-reader.")
+    expect(products[0]["price"]).to eq("$109")
+    expect(products[0]["images"]["thumb"]).to eq("http://amazon.com/kindle_thumb.jpg")
+    expect(products[0]["images"]["large"]).to eq("http://amazon.com/kindle.jpg")
+
+    expect(products[1]["uid"]).to eq("YD26NT")
+    expect(products[1]["name"]).to eq("Kindle Touch")
+    expect(products[1]["description"]).to eq("Simple-to-use touchscreen with built-in WIFI.")
+    expect(products[1]["price"]).to eq("$79")
+    expect(products[1]["images"]["thumb"]).to eq("http://amazon.com/kindle_touch_thumb.jpg")
+    expect(products[1]["images"]["large"]).to eq("http://amazon.com/kindle_touch.jpg")
   end
 
   it "should group multiple definitions of child objects into arrays" do
     webstore = Saxy.parse(fixture_file("webstore.xml"), "webstore").first
 
-    expect(webstore[:products][:product]).to be_an(Array)
-    expect(webstore[:products][:product].size).to eq(2)
+    expect(webstore["products"]["product"]).to be_an(Array)
+    expect(webstore["products"]["product"].size).to eq(2)
   end
 
   it "should return Enumerator when calling #parse without a block" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: saxy
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.7.0
 platform: ruby
 authors:
 - Michał Szajbe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-23 00:00:00.000000000 Z
+date: 2017-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri