saucy 0.13.0 → 0.13.1

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+0.13.1
+
+* Respect merchant account timezone in daily billing task
+* Allow configuration of merchant account timezone
+
 0.13.0
 
 * Populate braintree customer email with admin email its not set

data/README.md

@@ -66,7 +66,6 @@ followup emails being sent to users that have already set up their accounts.
 It will also send an "Activated" event to Kissmetrics through Saucy-kiss, if
 Saucy-kiss is installed.
 
-
 Development environment
 -----------------------
 
@@ -142,3 +141,9 @@ Make sure you don't do this in ApplicationController:
 
 Saucy's internal controllers don't skip any before filters.
 
+If your billing merchant account is not configured to run in the Eastern
+timezone, you can override the timezone in Saucy configuration as
+merchant_account_time_zone.  You'll want this set accurately so that the daily
+cronjob which syncs the Braintree subscription billing cycle dates runs for the
+correct accounts.  If this is set incorrectly, you will occasionally see
+duplicate receipt emails being delivered.

data/lib/saucy/configuration.rb

@@ -11,6 +11,7 @@ module Saucy
     cattr_accessor :trial_length
     cattr_accessor :expiring_notice_on
     cattr_accessor :unactivated_notice_on
+    cattr_accessor :merchant_account_time_zone
 
     def initialize
       @@manager_email_address = 'manager@example.com'
@@ -21,6 +22,7 @@ module Saucy
       @@trial_length          = 30
       @@expiring_notice_on    = 7
       @@unactivated_notice_on = 7
+      @@merchant_account_time_zone = 'Eastern Time (US & Canada)'
     end
 
   end

data/lib/saucy/engine.rb

@@ -31,7 +31,10 @@ module Saucy
       ActionView::Base.send :include, CouponsHelper
     end
 
-    {:short_date => "%x"}.each do |k, v|
+    {
+      :short_date => "%x",
+      :braintree_date => "%Y-%m-%d"
+    }.each do |k, v|
       Time::DATE_FORMATS[k] = v
     end
 

data/lib/saucy/fake_braintree.rb

@@ -102,7 +102,7 @@ ShamRack.at("www.braintreegateway.com", 443).sinatra do
     subscription["transactions"] = []
     subscription["add_ons"] = []
     subscription["discounts"] = []
-    subscription["next_billing_date"] = 1.month.from_now
+    subscription["next_billing_date"] = 1.month.from_now.to_s(:braintree_date)
     subscription["status"] = Braintree::Subscription::Status::Active
     FakeBraintree.subscriptions[subscription["id"]] = subscription
     [201, { "Content-Encoding" => "gzip" }, ActiveSupport::Gzip.compress(subscription.to_xml(:root => 'subscription'))]

data/lib/saucy/subscription.rb

@@ -94,7 +94,8 @@ module Saucy
       def update_subscription_cache!
         flush_cache :subscription
         update_attribute(:subscription_status, subscription.status)
-        update_attribute(:next_billing_date, subscription.next_billing_date)
+        update_attribute(:next_billing_date, Time.parse(subscription.next_billing_date).in_time_zone(
+          Saucy::Configuration.merchant_account_time_zone))
       end
 
       def changing_plan?(attributes)
@@ -204,7 +205,8 @@ module Saucy
         result = Braintree::Subscription.create(subscription_attributes)
         if result.success?
           self.subscription_token = result.subscription.id
-          self.next_billing_date = result.subscription.next_billing_date
+          self.next_billing_date = Time.parse(result.subscription.next_billing_date).in_time_zone(
+            Saucy::Configuration.merchant_account_time_zone)
           self.subscription_status = result.subscription.status
         else
           false
@@ -232,7 +234,8 @@ module Saucy
         recently_billed.each do |account|
           begin
             account.subscription_status = account.subscription.status
-            account.next_billing_date = account.subscription.next_billing_date
+            account.next_billing_date = Time.parse(account.subscription.next_billing_date).in_time_zone(
+              Saucy::Configuration.merchant_account_time_zone)
             account.save!
             if account.past_due?
               BillingMailer.problem(account).deliver!

data/spec/models/subscription_spec.rb

@@ -122,8 +122,9 @@ describe Account, "with a paid plan" do
     subject.subscription.should_not be_nil
   end
 
-  it "has a next_billing_date" do
-    subject.next_billing_date.should_not be_nil
+  it "has a next_billing_date in the merchant account timezone" do
+    Time.stubs(:now => Time.parse("2011-09-16 02:00 -0000"))
+    subject.next_billing_date.should == Time.parse("Sun, 16 Oct 2011 00:00:00 EDT -04:00")
   end
 
   it "has an active subscription status" do
@@ -295,14 +296,16 @@ describe Account, "with a paid subscription" do
   end
 
   it "gets marked as past due and updates its next_billing_date when subscriptions are updated and it has been rejected by the gateway" do
+    next_billing_date_string = 2.months.from_now.to_s(:braintree_date)
     subscription = FakeBraintree.subscriptions[subject.subscription_token]
     subscription["status"] = Braintree::Subscription::Status::PastDue
-    subscription["next_billing_date"] = 2.months.from_now
+    subscription["next_billing_date"] = next_billing_date_string
 
     Timecop.travel(subject.next_billing_date + 1.day) do
       Account.update_subscriptions!
       subject.reload.subscription_status.should == Braintree::Subscription::Status::PastDue
-      subject.next_billing_date.to_s.should == subscription["next_billing_date"].to_s
+      subject.next_billing_date.should == Time.parse(next_billing_date_string).in_time_zone(
+        Saucy::Configuration.merchant_account_time_zone)
       subject.past_due?.should be
     end
   end
@@ -343,7 +346,7 @@ describe Account, "with a paid subscription" do
 
     before do
       subscription["status"] = Braintree::Subscription::Status::PastDue
-      subscription["next_billing_date"] = 2.months.from_now
+      subscription["next_billing_date"] = 2.months.from_now.to_s(:braintree_date)
       FakeBraintree.transaction = { :status => Braintree::Transaction::Status::Failed,
                                     :subscription_id => subject.subscription_token }
       subscription["transactions"] = [FakeBraintree.generated_transaction]
@@ -387,7 +390,7 @@ describe Account, "with a paid subscription" do
     end
 
     before do
-      subscription["next_billing_date"] = 2.months.from_now
+      subscription["next_billing_date"] = 2.months.from_now.to_s(:braintree_date)
       subscription["status"] = Braintree::Subscription::Status::Active
       subscription["transactions"] = [
         build_transaction(:created_at => later_transaction_date),
@@ -408,12 +411,49 @@ describe Account, "with a paid subscription" do
     end
   end
 
+  context "with a merchant account timezone different from the system timezone" do
+    def build_subscription(account)
+      subscription = FakeBraintree.subscriptions[account.subscription_token]
+      subscription["status"] = Braintree::Subscription::Status::Active
+      subscription["transactions"] = [FakeBraintree.generated_transaction]
+      subscription
+    end
+
+    before do
+      Saucy::Configuration.merchant_account_time_zone = "Eastern Time (US & Canada)"
+      subject.next_billing_date = "2011-08-15"
+      subject.save!
+
+      subscription = build_subscription(subject)
+      subscription["next_billing_date"] = "2011-09-15"
+
+      Time.stubs(:now => Time.parse("2011-08-16 02:00 -0000"))
+      Account.update_subscriptions!
+      ActionMailer::Base.deliveries.clear
+
+      subject.reload.next_billing_date.should == Time.parse("2011-09-15 00:00 -0400")
+    end
+
+    it "does not update accounts if their billing date hasn't elapsed from the merchant account's perspective" do
+      Time.stubs(:now => Time.parse("2011-09-15 02:00 -0000"))
+      Account.update_subscriptions!
+      ActionMailer::Base.deliveries.should be_empty
+    end
+
+    it "does update accounts if their billing date has elapsed from the merchant account's perspective" do
+      Time.stubs(:now => Time.parse("2011-09-16 02:00 -0000"))
+      Account.update_subscriptions!
+      ActionMailer::Base.deliveries.should_not be_empty
+    end
+  end
+
   context "and an active subscription due 2 months from now" do
     let(:subscription) { FakeBraintree.subscriptions[subject.subscription_token] }
+    let(:next_billing_date_string) { 2.months.from_now.to_s(:braintree_date) }
 
     before do
       subscription["status"] = Braintree::Subscription::Status::Active
-      subscription["next_billing_date"] = 2.months.from_now
+      subscription["next_billing_date"] = next_billing_date_string
       FakeBraintree.transaction = { :status => Braintree::Transaction::Status::Settled,
                                     :subscription_id => subject.subscription_token }
       subscription["transactions"] = [FakeBraintree.generated_transaction]
@@ -423,7 +463,8 @@ describe Account, "with a paid subscription" do
       Timecop.travel(subject.next_billing_date + 1.day) do
         Account.update_subscriptions!
         subject.reload.subscription_status.should == Braintree::Subscription::Status::Active
-        subject.next_billing_date.to_s.should == subscription["next_billing_date"].to_s
+        subject.next_billing_date.should == Time.parse(next_billing_date_string).in_time_zone(
+          Saucy::Configuration.merchant_account_time_zone)
       end
     end
 
@@ -484,7 +525,7 @@ describe Account, "with a paid subscription that is past due" do
   before do
     subscription = FakeBraintree.subscriptions[subject.subscription_token]
     subscription["status"] = Braintree::Subscription::Status::PastDue
-    subscription["next_billing_date"] = 2.months.from_now
+    subscription["next_billing_date"] = 2.months.from_now.to_s(:braintree_date)
 
     Timecop.travel(subject.next_billing_date + 1.day) do
       Account.update_subscriptions!
@@ -493,9 +534,10 @@ describe Account, "with a paid subscription that is past due" do
   end
 
   it "retries the subscription charge and updates the subscription when the billing information is correctly updated" do
+    next_billing_date_string = 1.day.from_now.to_s(:braintree_date)
     subscription = FakeBraintree.subscriptions[subject.subscription_token]
     subscription["status"] = Braintree::Subscription::Status::Active
-    subscription["next_billing_date"] = 2.months.from_now
+    subscription["next_billing_date"] = next_billing_date_string
     FakeBraintree.transaction = { :status => Braintree::Transaction::Status::Settled,
                                   :subscription_id => subject.subscription_token }
     transaction = FakeBraintree.generated_transaction
@@ -513,13 +555,15 @@ describe Account, "with a paid subscription that is past due" do
                                             :expiration_year => 2012).should be
 
     subject.reload.subscription_status.should == Braintree::Subscription::Status::Active
-    subject.next_billing_date.to_s.should == subscription["next_billing_date"].to_s
+    subject.next_billing_date.should == Time.parse(next_billing_date_string).in_time_zone(
+      Saucy::Configuration.merchant_account_time_zone)
   end
 
   it "retries the subscription charge and updates the subscription when the payment processing fails" do
+    next_billing_date_string = 2.months.from_now.to_s(:braintree_date)
     subscription = FakeBraintree.subscriptions[subject.subscription_token]
     subscription["status"] = Braintree::Subscription::Status::PastDue
-    subscription["next_billing_date"] = 1.day.from_now
+    subscription["next_billing_date"] = next_billing_date_string
     FakeBraintree.transaction = { :status => Braintree::Transaction::Status::Failed,
                                   :subscription_id => subject.subscription_token }
     transaction = FakeBraintree.generated_transaction
@@ -538,13 +582,15 @@ describe Account, "with a paid subscription that is past due" do
 
     subject.errors[:card_number].should include("was denied by the payment processor with the message: no good")
     subject.reload.subscription_status.should == Braintree::Subscription::Status::PastDue
-    subject.next_billing_date.to_s.should == subscription["next_billing_date"].to_s
+    subject.next_billing_date.should == Time.parse(next_billing_date_string).in_time_zone(
+      Saucy::Configuration.merchant_account_time_zone)
   end
 
   it "retries the subscription charge and updates the subscription when the settlement fails" do
+    next_billing_date_string = 1.day.from_now.to_s(:braintree_date)
     subscription = FakeBraintree.subscriptions[subject.subscription_token]
     subscription["status"] = Braintree::Subscription::Status::PastDue
-    subscription["next_billing_date"] = 1.day.from_now
+    subscription["next_billing_date"] = next_billing_date_string
     FakeBraintree.transaction = { :status => Braintree::Transaction::Status::Failed,
                                   :subscription_id => subject.subscription_token }
     transaction = FakeBraintree.generated_transaction
@@ -563,7 +609,8 @@ describe Account, "with a paid subscription that is past due" do
 
     subject.errors[:card_number].should include("no good")
     subject.reload.subscription_status.should == Braintree::Subscription::Status::PastDue
-    subject.next_billing_date.to_s.should == subscription["next_billing_date"].to_s
+    subject.next_billing_date.should == Time.parse(next_billing_date_string).in_time_zone(
+      Saucy::Configuration.merchant_account_time_zone)
   end
 end
 

data/spec/saucy/configuration_spec.rb

@@ -78,4 +78,18 @@ describe Saucy::Configuration do
       subject.unactivated_notice_on = old_length
     end
   end
+
+  it "can assign a merchant_account_time_zone" do
+    old_merchant_account_time_zone = subject.merchant_account_time_zone
+    begin
+      subject.merchant_account_time_zone = "International Date Line West"
+      subject.merchant_account_time_zone.should == "International Date Line West"
+    ensure
+      subject.merchant_account_time_zone = old_merchant_account_time_zone
+    end
+  end
+
+  it "defaults merchant_account_time_zone to 'Eastern Time (US & Canada)'" do
+    subject.merchant_account_time_zone.should == "Eastern Time (US & Canada)"
+  end
 end

metadata

@@ -1,13 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: saucy
 version: !ruby/object:Gem::Version 
-  hash: 43
   prerelease: 
-  segments: 
-  - 0
-  - 13
-  - 0
-  version: 0.13.0
+  version: 0.13.1
 platform: ruby
 authors: 
 - thoughtbot, inc.
@@ -20,134 +15,95 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-10-14 00:00:00 Z
+date: 2011-10-17 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: clearance
-  prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 55
-        segments: 
-        - 0
-        - 11
-        - 2
         version: 0.11.2
   type: :runtime
+  prerelease: false
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: formtastic
-  prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 11
-        segments: 
-        - 1
-        - 2
         version: "1.2"
   type: :runtime
+  prerelease: false
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: railties
-  prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 1
-        segments: 
-        - 3
-        - 0
-        - 3
         version: 3.0.3
   type: :runtime
+  prerelease: false
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
   name: braintree
-  prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 19
-        segments: 
-        - 2
-        - 6
-        - 2
         version: 2.6.2
   type: :runtime
+  prerelease: false
   version_requirements: *id004
 - !ruby/object:Gem::Dependency 
   name: sham_rack
-  prerelease: false
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
       - !ruby/object:Gem::Version 
-        hash: 29
-        segments: 
-        - 1
-        - 3
-        - 3
         version: 1.3.3
   type: :runtime
+  prerelease: false
   version_requirements: *id005
 - !ruby/object:Gem::Dependency 
   name: sinatra
-  prerelease: false
   requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 23
-        segments: 
-        - 1
-        - 1
-        - 2
         version: 1.1.2
   type: :runtime
+  prerelease: false
   version_requirements: *id006
 - !ruby/object:Gem::Dependency 
   name: airbrake
-  prerelease: false
   requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 15
-        segments: 
-        - 3
-        - 0
-        - 4
         version: 3.0.4
   type: :runtime
+  prerelease: false
   version_requirements: *id007
 - !ruby/object:Gem::Dependency 
   name: aruba
-  prerelease: false
   requirement: &id008 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
       - !ruby/object:Gem::Version 
-        hash: 27
-        segments: 
-        - 0
-        - 2
-        - 6
         version: 0.2.6
   type: :development
+  prerelease: false
   version_requirements: *id008
 description: Clearance-based Rails engine for Software as a Service (Saas) that provides account and project management
 email: support@thoughtbot.com
@@ -344,7 +300,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
+      hash: 3518640004043339834
       segments: 
       - 0
       version: "0"
@@ -353,14 +309,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.11
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: Clearance-based Rails engine for SaaS