saucy 0.12.2 → 0.12.3

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+0.12.3
+
+* Notify airbrake if updating a subscription fails and continue
+
 0.12.2
 
 * Fix for misssed reference to 30 days

data/lib/saucy/subscription.rb

@@ -1,3 +1,5 @@
+require 'airbrake'
+
 module Saucy
   module Subscription
     extend ActiveSupport::Concern
@@ -228,14 +230,18 @@ module Saucy
       def update_subscriptions!
         recently_billed = where("next_billing_date <= ?", Time.now)
         recently_billed.each do |account|
-          account.subscription_status = account.subscription.status
-          account.next_billing_date = account.subscription.next_billing_date
-          account.save!
-          if account.past_due?
-            BillingMailer.problem(account).deliver!
-          else
-            BillingMailer.receipt(account, account.most_recent_transaction).deliver!
-            Saucy::Notifications.notify_observers("billed", :account => account)
+          begin
+            account.subscription_status = account.subscription.status
+            account.next_billing_date = account.subscription.next_billing_date
+            account.save!
+            if account.past_due?
+              BillingMailer.problem(account).deliver!
+            else
+              BillingMailer.receipt(account, account.most_recent_transaction).deliver!
+              Saucy::Notifications.notify_observers("billed", :account => account)
+            end
+          rescue Exception => e
+            Airbrake.notify(e)
           end
         end
       end

data/spec/models/subscription_spec.rb

@@ -307,6 +307,37 @@ describe Account, "with a paid subscription" do
     end
   end
 
+  context "when there is an error" do
+    before(:each) do
+      Airbrake.stubs(:notify => true)
+      @subscription = mock
+      @subscription.stubs(:status).raises(RuntimeError)
+      Account.any_instance.stubs(:subscription).returns(@subscription)
+    end
+
+    it "notifies Airbrake if expiring account notifications fail" do
+      Timecop.travel(subject.next_billing_date + 1.day) do
+        Account.update_subscriptions!
+        Airbrake.should have_received(:notify).once()
+      end
+    end
+
+    it "delivers the rest of the emails even if one fails" do
+      Factory(:account, 
+              :cardholder_name => "Ralph Robot", 
+              :billing_email => "ralph@example.com", 
+              :card_number => "4111111111111111", 
+              :verification_code => "123",
+              :expiration_month => 5, 
+              :expiration_year => 2012,
+              :plan => Factory(:paid_plan))
+      Timecop.travel(subject.next_billing_date + 1.day) do
+        Account.update_subscriptions!
+        @subscription.should have_received(:status).twice()
+      end
+    end
+  end
+
   context "when billing didn't work" do
     let(:subscription) { FakeBraintree.subscriptions[subject.subscription_token] }
 

metadata

@@ -1,14 +1,10 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: saucy
-version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 0
-  - 12
-  - 2
-  version: 0.12.2
+version: !ruby/object:Gem::Version
+  version: 0.12.3
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - thoughtbot, inc.
 - Joe Ferris
 - Mike Burns
@@ -18,130 +14,103 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-10-06 00:00:00 -04:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2011-10-07 00:00:00.000000000Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: clearance
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    requirements: 
+  requirement: &70365143039700 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        - 11
-        - 2
+      - !ruby/object:Gem::Version
         version: 0.11.2
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: formtastic
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 1
-        - 2
-        version: "1.2"
+  version_requirements: *70365143039700
+- !ruby/object:Gem::Dependency
+  name: formtastic
+  requirement: &70365143072740 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '1.2'
   type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: railties
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 3
-        - 0
-        - 3
+  version_requirements: *70365143072740
+- !ruby/object:Gem::Dependency
+  name: railties
+  requirement: &70365143072280 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 3.0.3
   type: :runtime
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: braintree
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 2
-        - 6
-        - 2
+  version_requirements: *70365143072280
+- !ruby/object:Gem::Dependency
+  name: braintree
+  requirement: &70365143071820 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 2.6.2
   type: :runtime
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: sham_rack
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - "="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 1
-        - 3
-        - 3
+  version_requirements: *70365143071820
+- !ruby/object:Gem::Dependency
+  name: sham_rack
+  requirement: &70365143071360 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - =
+      - !ruby/object:Gem::Version
         version: 1.3.3
   type: :runtime
-  version_requirements: *id005
-- !ruby/object:Gem::Dependency 
-  name: sinatra
   prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 1
-        - 1
-        - 2
+  version_requirements: *70365143071360
+- !ruby/object:Gem::Dependency
+  name: sinatra
+  requirement: &70365143070900 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 1.1.2
   type: :runtime
-  version_requirements: *id006
-- !ruby/object:Gem::Dependency 
-  name: airbrake
   prerelease: false
-  requirement: &id007 !ruby/object:Gem::Requirement 
-    requirements: 
+  version_requirements: *70365143070900
+- !ruby/object:Gem::Dependency
+  name: airbrake
+  requirement: &70365143070440 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 3
-        - 0
-        - 4
+      - !ruby/object:Gem::Version
         version: 3.0.4
   type: :runtime
-  version_requirements: *id007
-- !ruby/object:Gem::Dependency 
-  name: aruba
   prerelease: false
-  requirement: &id008 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - "="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        - 2
-        - 6
+  version_requirements: *70365143070440
+- !ruby/object:Gem::Dependency
+  name: aruba
+  requirement: &70365143069980 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - =
+      - !ruby/object:Gem::Version
         version: 0.2.6
   type: :development
-  version_requirements: *id008
-description: Clearance-based Rails engine for Software as a Service (Saas) that provides account and project management
+  prerelease: false
+  version_requirements: *70365143069980
+description: Clearance-based Rails engine for Software as a Service (Saas) that provides
+  account and project management
 email: support@thoughtbot.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -313,37 +282,31 @@ files:
 - spec/support/clearance_matchers.rb
 - spec/support/notifications.rb
 - spec/views/accounts/_account.html.erb_spec.rb
-has_rdoc: true
 homepage: http://github.com/thoughtbot/saucy
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      segments: 
-      - 0
-      version: "0"
+required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.8.6
 signing_key: 
 specification_version: 3
 summary: Clearance-based Rails engine for SaaS
-test_files: 
+test_files:
 - features/run_features.feature
 - features/step_definitions/clearance_steps.rb
 - features/step_definitions/rails_steps.rb