sashite-pan 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4294266795d470a55b2b4d52b1b07e006791ace8a41491473057f839112a8f7d
-  data.tar.gz: 30063832b6dba93e56ef2c4450581a3a4f24c1e13592b55576b7a391cbfd23fa
+  metadata.gz: ddc5404d30aecb881216eeeda12f98c7295f8dd415302f343c8ac0d0434a7289
+  data.tar.gz: a70d32986e8e6c1f90dedd8039562089e1f40b8c64a4dcfb518f0bfdd0592904
 SHA512:
-  metadata.gz: 44ce213800f73cfd3094eb4f0d7f52090dae9a229c533827e2c2840cde605fefd2b515c8839277f85c3e4ee67b4d73245f026aa1810111e55cf739e4689c9ee1
-  data.tar.gz: 8b97bf4eaec6b839ebfb551bce73341033bcfa3702d6b6c01945355aab3d1857d661e48c5a4ea3783fac8540f4537189e0eb4dfb029812373314a473066275c0
+  metadata.gz: f1ec2c07c1e3ecfbd9dde636595c182178891217eeea5c2724c994b8e8010f2d8ae371e48a5399ef3682ef22b6f9c35550a83123b0e2035dd0603a00c1cf101c
+  data.tar.gz: ca173e3c7ecd0e49e9026a1f8b5ae9b7f8375c7d893e45b20b8ca7723e10dfe8701f4b4ef837414f2436014653b2accc2a9d2fb2b9b71cf9307c88d4840b745b

data/lib/sashite/pan.rb

@@ -7,8 +7,8 @@ module Sashite
       Dumper.call(*actions)
     end
 
-    def self.parse(pan_string)
-      Parser.call(pan_string)
+    def self.parse(string)
+      Parser.call(string)
     end
   end
 end

data/lib/sashite/pan/action.rb

@@ -5,6 +5,20 @@ module Sashite
     # Action class
     class Action
       attr_reader :src_square, :dst_square, :piece_name, :piece_hand
+
+      private_class_method def self.separator
+        ';'
+      end
+
+      private
+
+      def separator
+        ','
+      end
+
+      def drop_char
+        '*'
+      end
     end
   end
 end

data/lib/sashite/pan/dumper.rb

@@ -7,29 +7,19 @@ module Sashite
     # Dumper class
     class Dumper < Action
       def self.call(*actions)
-        actions.map { |action_items| new(*action_items).call }.join(';')
+        actions.map { |action_items| new(*action_items).call }
+               .join(separator)
       end
 
       def initialize(src_square, dst_square, piece_name, piece_hand)
-        unless src_square.nil?
-          raise TypeError, src_square.inspect unless src_square.is_a?(Integer)
-        end
-
-        raise TypeError, dst_square.inspect unless dst_square.is_a?(Integer)
-        raise TypeError, piece_name.inspect unless piece_name.is_a?(String)
-
-        unless piece_hand.nil?
-          raise TypeError, piece_hand.inspect unless piece_hand.is_a?(String)
-        end
-
-        @src_square = (src_square.nil? ? '*' : src_square)
-        @dst_square = dst_square
-        @piece_name = piece_name
-        @piece_hand = piece_hand
+        @src_square = src_square.nil? ? drop_char : Integer(src_square)
+        @dst_square = Integer(dst_square)
+        @piece_name = piece_name.to_s
+        @piece_hand = piece_hand&.to_s
       end
 
       def call
-        action_items.join(',')
+        action_items.join(separator)
       end
 
       private

data/lib/sashite/pan/parser.rb

@@ -6,28 +6,22 @@ module Sashite
   module PAN
     # Parser class
     class Parser < Action
-      def self.call(pan_string)
-        pan_string.split(';').map do |serialized_action|
-          new(serialized_action).call
-        end
+      def self.call(serialized_move)
+        serialized_move.split(separator)
+                       .map { |serialized_action| new(serialized_action).call }
       end
 
       def initialize(serialized_action)
-        action_args = serialized_action.split(',')
+        action_args = serialized_action.split(separator)
         src_square  = action_args.fetch(0)
-        @src_square = src_square.eql?('*') ? nil : src_square.to_i
-        @dst_square = action_args.fetch(1).to_i
+        @src_square = src_square.eql?(drop_char) ? nil : Integer(src_square)
+        @dst_square = Integer(action_args.fetch(1))
         @piece_name = action_args.fetch(2)
         @piece_hand = action_args.fetch(3, nil)
       end
 
       def call
-        [
-          src_square,
-          dst_square,
-          piece_name,
-          piece_hand
-        ]
+        [src_square, dst_square, piece_name, piece_hand]
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sashite-pan
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Cyril Kato
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-19 00:00:00.000000000 Z
+date: 2020-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: awesome_print