sas-linter 0.2.5 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b12c05da17de3409a5eb163f3e3325cb7e2e24770d3de42e01efb786fc796d60
-  data.tar.gz: b14b81be912177959a039484c70ea7bf71f209910cf995822d8083c8d6ea2897
+  metadata.gz: 688281e326c33b3af52864a9d25c85f00967a2c4f8ac9233e57cf52a83407b18
+  data.tar.gz: a9f331a62f73a5bdb7b637bbd62783f3969b169746e7035adf687afc3030ceb4
 SHA512:
-  metadata.gz: 5fa28c6588e96bdd973197577e0e3fb1aa689fd641455ed10225f0354e0243e41fdb1e682b20d0de02d2a443b30ae9d263f419a31d42ea12763d91320bef7078
-  data.tar.gz: aa8eb2ffe598911984fd57acff5ea350136865ccc64da7d7003b23033840013ac5c544a9bfd56d7f57bcb67c1f01de5af74c5b32f59d87300eac3525ae9e9bfe
+  metadata.gz: d952062a88c0bca6c33ef3f3e92c6cfeeec3f2142053e47c71dde3c04202ba0209b4672cad326161d62d05df90fb0940665cd0f65b73a62412d97b0ff6c8a1da
+  data.tar.gz: 7c41bac13b275a4dc9fc8bbf374339595b2b185fb6058e3ea27b412b18124a44bdb5b901eec7bdc9c0d7db3d9239ea0d56a30e6896ad88f0b9386dc74c2b1687

data/lib/sas_linter/rules/malformed_label_statement.rb

@@ -0,0 +1,127 @@
+# frozen_string_literal: true
+
+require_relative "../../sas_linter"
+require "sas_lexer"
+
+class SasLinter
+  module Rules
+    # Flag `label` statements where the `=` between the variable name
+    # and the string literal is missing.
+    #
+    # Motivating bug: `label aHSDELIRIUM 'Delirium Screener';` in
+    # SUITE9_HS_DELIRIUM_SCREENER_2014-04-15.TXT — SAS rejects this
+    # with "ERROR 22-322: Syntax error, expecting one of the following:
+    # =, ?", and the label is silently never attached. The treatment
+    # variant of the same algorithm shipped the same typo, and several
+    # other interRAI sources have shipped it over time.
+    #
+    # Detection: every `label` statement is a `KW_LABEL` keyword
+    # followed by one or more `IDENT '=' STRING_LITERAL` triples
+    # separated by whitespace, terminated by `;`. We walk each label
+    # statement and, for each IDENT inside it, require the next
+    # default-channel token to be `ASSIGN` (`=`). If instead the next
+    # token is a STRING_LITERAL, the `=` was dropped.
+    class MalformedLabelStatement < Rule
+      rule_id :malformed_label_statement
+      description "`label` statement missing `=` between variable and string literal."
+      severity :warning
+
+      TT = SasLexer::Lexer::TokenType
+
+      def self.supports_autofix?
+        true
+      end
+
+      def check(tokens, path:, all_tokens: nil, source: nil) # rubocop:disable Lint/UnusedMethodArgument
+        findings = []
+        each_label_violation(tokens) do |ident_t, string_t|
+          findings << finding(
+            line: ident_t[:start_line],
+            column: ident_t[:start_column] + 1,
+            message: "`label #{ident_t[:text]} #{shorten(string_t[:text])}` is missing the `=` " \
+                     "between the variable name and the label string.",
+            path: path
+          )
+        end
+        findings
+      end
+
+      def autofix(source)
+        return source if source.nil? || source.empty?
+
+        lexer = SasLexer::Lexer.new
+        begin
+          all_tokens = lexer.tokenize(source)
+        ensure
+          lexer.free
+        end
+        tokens = all_tokens.reject do |t|
+          t[:channel] == SasLexer::Lexer::TokenChannel::HIDDEN ||
+            t[:channel] == SasLexer::Lexer::TokenChannel::COMMENT
+        end
+
+        source_lines = source.split("\n", -1)
+        # Collect (line_idx, col_after_ident) for each malformed label,
+        # then apply edits right-to-left within each line so earlier
+        # column offsets stay valid.
+        edits_by_line = Hash.new { |h, k| h[k] = [] }
+
+        each_label_violation(tokens) do |ident_t, _string_t|
+          edits_by_line[ident_t[:start_line] - 1] << ident_t[:end_column]
+        end
+
+        edits_by_line.each do |line_idx, cols|
+          line = source_lines[line_idx]
+          next if line.nil?
+
+          # Right-to-left so earlier insertions don't shift later columns.
+          cols.sort.reverse.each do |col|
+            # Insert ` =` immediately after the IDENT (consuming the
+            # following space if there is one, preserving alignment).
+            replacement =
+              if col < line.length && line[col] == " "
+                # `aHSDELIRIUM 'Delirium Screener'` → `aHSDELIRIUM = 'Delirium Screener'`.
+                # Replace the single space with ` = ` (one space before, one after).
+                " = #{line[(col + 1)..]}"
+              else
+                " = #{line[col..]}"
+              end
+            line = "#{line[0...col]}#{replacement}"
+          end
+          source_lines[line_idx] = line
+        end
+
+        source_lines.join("\n")
+      end
+
+      private
+
+      def each_label_violation(tokens)
+        tokens.each_with_index do |t, i|
+          next unless t[:type] == TT::KW_LABEL
+
+          # Walk forward through the label statement until SEMI.
+          j = i + 1
+          while j < tokens.length && tokens[j][:type] != TT::SEMI
+            cur = tokens[j]
+            if cur[:type] == TT::IDENTIFIER
+              nxt = tokens[j + 1]
+              if nxt && nxt[:type] == TT::STRING_LITERAL
+                yield cur, nxt
+                j += 2
+                next
+              end
+            end
+            j += 1
+          end
+        end
+      end
+
+      def shorten(text)
+        return text if text.nil? || text.length <= 40
+
+        "#{text[0, 37]}..."
+      end
+    end
+  end
+end

data/lib/sas_linter/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class SasLinter
-  VERSION = "0.2.5"
+  VERSION = "0.2.6"
 end

data/lib/sas_linter.rb

@@ -307,6 +307,7 @@ require_relative "sas_linter/rules/line_endings"
 require_relative "sas_linter/rules/encoding_issues"
 require_relative "sas_linter/rules/malformed_if_condition"
 require_relative "sas_linter/rules/missing_assignment_semicolon"
+require_relative "sas_linter/rules/malformed_label_statement"
 require_relative "sas_linter/rules/variable_value_out_of_known_range"
 require_relative "sas_linter/rules/invalid_numeric_literal"
 require_relative "sas_linter/rules/inconsistent_variable_case"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sas-linter
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.2.6
 platform: ruby
 authors:
 - Craig McNamara
@@ -69,6 +69,7 @@ files:
 - lib/sas_linter/rules/invalid_numeric_literal.rb
 - lib/sas_linter/rules/line_endings.rb
 - lib/sas_linter/rules/malformed_if_condition.rb
+- lib/sas_linter/rules/malformed_label_statement.rb
 - lib/sas_linter/rules/missing_assignment_semicolon.rb
 - lib/sas_linter/rules/source_headers.rb
 - lib/sas_linter/rules/tab_expansion.rb