sanitize 3.1.1 → 3.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f58c1c50884ecfb9f4b0e0370d7d9aecf26af343
-  data.tar.gz: 2dff24adc2c0f463049a6d2df74284a6fdf35263
+  metadata.gz: 4449bae9ce55a4f01d76a2984b68a6ea79b0d71b
+  data.tar.gz: 85752ade687b9c6d54d9a4c13dac42dcee670853
 SHA512:
-  metadata.gz: 5065f900b48a965b39e2cdbb817e8b52f71cd228fe6f7082f415c180e92f073b654e792f12237c3a4c16a140833de437087d0aa67a7867a0fe715c47fad634a1
-  data.tar.gz: 841711b2ff6216536443df8465d02bb948eb77bda5f6a91fe48db1a4b03a89b56008bd70f78a442a929d0cfd4d1bb34f506c989bf056d889d6d0bcb3c8085b9a
+  metadata.gz: 989d449b758fa4c69c5484e50fcc7f72b41888fe86708e2e459789c1187a8d15e7d70dcce6f335e98ef8b9b927d198b6452a4e3955eb728eaee10b9df3169beb
+  data.tar.gz: c8f1100f741d8211c990e34fc2bbdd1e42b013f704c2b56da30e0af984d220e03af9e88a4cfe0fac4025ed467bc6a1406d5da6bdef8280f1ec78f0dc315ef074

data/HISTORY.md

@@ -1,6 +1,17 @@
 Sanitize History
 ================================================================================
 
+Version 3.1.2 (2015-02-22)
+--------------------------
+
+* Fixed: Deleting a node in a custom transformer could trigger a memory leak
+  in Nokogiri if that node's children were later reparented, which the built-in
+  CleanElement transformer did by default. The CleanElement transformer is now
+  careful not to reparent the children of deleted nodes. [#129][129]
+
+[129]:https://github.com/rgrove/sanitize/issues/129
+
+
 Version 3.1.1 (2015-02-04)
 --------------------------
 

data/lib/sanitize/transformers/clean_element.rb

@@ -55,8 +55,13 @@ class Sanitize; module Transformers; class CleanElement
 
     name = env[:node_name]
 
-    # Delete any element that isn't in the config whitelist.
-    unless @elements.include?(name)
+    # Delete any element that isn't in the config whitelist, unless the node has
+    # already been deleted from the document.
+    #
+    # It's important that we not try to reparent the children of a node that has
+    # already been deleted, since that seems to trigger a memory leak in
+    # Nokogiri.
+    unless @elements.include?(name) || node.parent.nil?
       # Elements like br, div, p, etc. need to be replaced with whitespace in
       # order to preserve readability.
       if @whitespace_elements.include?(name)

data/lib/sanitize/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 class Sanitize
-  VERSION = '3.1.1'
+  VERSION = '3.1.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sanitize
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 3.1.2
 platform: ruby
 authors:
 - Ryan Grove
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-04 00:00:00.000000000 Z
+date: 2015-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: crass