samwise 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e3d140a73ec93dea97ceec0cc507149f4b3c8948
-  data.tar.gz: 4ef7219dc67b322cf0031736992a029d2ac85cc7
+  metadata.gz: 60a8b81ebade127d133b53d61ee74274c3eb302e
+  data.tar.gz: 5446af496a94bf610574b4e973bb29687904a8a4
 SHA512:
-  metadata.gz: bf7ecd00e1863cda3c4a3572316f3565f24bf674d849c2360ca4ac646b0ef6ba6a1e8e2d661c07e614d5c5a36ec14256e2ea89de951447d19856ae19dd80aa5b
-  data.tar.gz: c88f5d609f6d203fc3392ebe7efcea5e4f192d94861775b88f5b4c9db97e314fd14c12900904fb90b659afd39d89573f509c52cefea56047a330c19885472af8
+  metadata.gz: 6039c73c495aa7d9c2d5bb1367068f3c4945a9ce283f654cd152c31789557089a6670215241508048241cee97744ae4b46203185a2fdefdf70bde267d4847f14
+  data.tar.gz: e76cf4eadaf53d229bb9cb2d45437ad70178b19f1ec9b4dd3caa0c84f974b5f25a46b95a2c834e4fa0f6086f83f6ca905c3175b5c837eb2be60085e2b851fa06

data/.ruby-version

@@ -0,0 +1 @@
+2.3.0

data/lib/samwise/client.rb

@@ -1,5 +1,6 @@
 require 'json'
 require 'httpclient'
+require_relative './duns_lookup'
 
 module Samwise
   class Client
@@ -19,7 +20,7 @@ module Samwise
 
       {
         in_sam: parse_response_for_sam_status(response),
-        small_business: parse_response_for_small_business(response)
+        small_business: small_business?(response)
       }
     end
 
@@ -38,37 +39,14 @@ module Samwise
       JSON.parse(response.body)["hasKnownExclusion"] == false
     end
 
-    def small_business?(duns: nil)
-      response = lookup_duns(duns: duns)
-      parse_response_for_small_business(response)
-    end
-
     private
 
     def parse_response_for_sam_status(response)
       response.status == 200
     end
 
-    def parse_response_for_small_business(response)
-      return false if response.code != 200
-
-      data = JSON.parse(response.body)["sam_data"]["registration"]
-
-      far_responses = data['certifications']['farResponses']
-      response_to_small_biz = far_responses.find do |response|
-        response['id'] == Samwise::Protocol::FAR_SMALL_BIZ_CITATION
-      end
-
-      answers = response_to_small_biz['answers']
-
-      naics_answers = answers.find {|answer| answer.has_key?('naics')}['naics']
-      small_business_naics_answers = naics_answers.select do |answer|
-        Samwise::Protocol::NAICS_WHITELIST.include?(answer['naicsCode'])
-      end
-
-      !small_business_naics_answers.detect do |answer|
-        answer['isSmallBusiness'] == 'Y'
-      end.nil?
+    def small_business?(response)
+      Samwise::DunsLookup.new(response).small_business?
     end
 
     def lookup_duns(duns: nil)

data/lib/samwise/duns_lookup.rb

@@ -0,0 +1,67 @@
+module Samwise
+  class DunsLookup
+    attr_reader :response
+
+    def initialize(response)
+      @response = response
+    end
+
+    def small_business?
+      if response.status == 200
+        small_business_response
+      else
+        false
+      end
+    end
+
+    private
+
+    def small_business_response
+      if registration_data && certifications && far_responses
+        small_business_response?
+      else
+        false
+      end
+    end
+
+    def small_business_response?
+      !small_business_naics_answers.detect do |answer|
+        answer['isSmallBusiness'] == 'Y'
+      end.nil?
+    end
+
+    def small_business_naics_answers
+      naics_answers.select do |answer|
+        Samwise::Protocol::NAICS_WHITELIST.include?(answer['naicsCode'])
+      end
+    end
+
+    def naics_answers
+      small_business_answers.find do |answer|
+        answer.has_key?('naics')
+      end['naics']
+    end
+
+    def small_business_answers
+      response_to_small_business_questions['answers']
+    end
+
+    def response_to_small_business_questions
+      far_responses.find do |far_response|
+        far_response['id'] == Samwise::Protocol::FAR_SMALL_BIZ_CITATION
+      end
+    end
+
+    def far_responses
+      certifications['farResponses']
+    end
+
+    def certifications
+      registration_data['certifications']
+    end
+
+    def registration_data
+      @_data ||= JSON.parse(response.body)["sam_data"]["registration"]
+    end
+  end
+end

data/lib/samwise/version.rb

@@ -1,3 +1,3 @@
 module Samwise
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

data/spec/client_spec.rb

@@ -49,6 +49,15 @@ describe Samwise::Client, vcr: { cassette_name: "Samwise::Client", record: :new_
       end
     end
 
+    context 'when API response does not certification data' do
+      it 'set small_business to false' do
+        incomplete_data_duns = '506163962'
+        response = client.get_vendor_summary(duns: incomplete_data_duns)
+
+        expect(response[:small_business]).to eq(false)
+      end
+    end
+
     context 'when the DUNS is in SAM' do
       it 'has in_sam set to true' do
         response = client.get_vendor_summary(duns: nine_duns)
@@ -165,20 +174,4 @@ describe Samwise::Client, vcr: { cassette_name: "Samwise::Client", record: :new_
       expect(response).to be(false)
     end
   end
-
-  context '#small_business?' do
-    context 'the DUNS belongs to a big business' do
-      it 'should return false' do
-        response = client.small_business?(duns: big_biz_duns)
-        expect(response).to be(false)
-      end
-    end
-
-    context 'the DUNS belongs to a small business' do
-      it 'should return true' do
-        response = client.small_business?(duns: nine_duns)
-        expect(response).to be(true)
-      end
-    end
-  end
 end

data/spec/vcr/Samwise_Client.yml

@@ -915,4 +915,58 @@ http_interactions:
         FAIR LAKES CIRCLE","stateorProvince":"VA","line2":"GWAC SOLUTIONS CENTER","city":"FAIRFAX"},"purposeOfRegistration":"ALL_AWARDS"}}}'
     http_version: 
   recorded_at: Tue, 24 May 2016 20:30:30 GMT
-recorded_with: VCR 2.9.3
+- request:
+    method: get
+    uri: https://api.data.gov/sam/v4/registrations/5061639620000?api_key=<data_dot_gov_api_key>
+    body:
+      encoding: UTF-8
+      string: ''
+    headers:
+      User-Agent:
+      - HTTPClient/1.0 (2.8.0, ruby 2.3.0 (2015-12-25))
+      Accept:
+      - "*/*"
+      Date:
+      - Tue, 07 Jun 2016 00:09:45 GMT
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - openresty
+      Date:
+      - Tue, 07 Jun 2016 00:09:45 GMT
+      Content-Type:
+      - application/json
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      Vary:
+      - Accept-Encoding
+      - Accept-Encoding
+      X-Ratelimit-Limit:
+      - '25'
+      X-Ratelimit-Remaining:
+      - '24'
+      Age:
+      - '0'
+      Via:
+      - http/1.1 api-umbrella (ApacheTrafficServer [cMsSf ])
+      X-Cache:
+      - MISS
+    body:
+      encoding: UTF-8
+      string: '{"sam_data":{"registration":{"govtBusinessPoc":{"lastName":"RAKIC","address":{"zip":"11111","countryCode":"SRB","line1":"Molerova
+        12/2","stateorProvince":"AA","city":"Belgrade"},"email":"GRAKIC@DEVBASE.NET","nonUsPhone":"381-637074291","firstName":"GORAN"},"hasKnownExclusion":false,"publicDisplay":true,"status":"WIP","corporateStructureCode":"2J","corporateStructureName":"Sole
+        Proprietorship","ncage":"A0C7S","legalBusinessName":"GORAN RAKIC PR DEVBASE","dunsPlus4":"0000","congressionalDistrict":"
+        ","bondingInformation":{},"fiscalYearEndCloseDate":"12/31","businessStartDate":"2015-10-28","businessTypes":["VW","2X"],"lastUpdateDate":"2016-03-16
+        17:29:25.0","samAddress":{"zip":"11111","countryCode":"SRB","line1":"MOLEROVA
+        12","city":"Belgrade"},"naics":[{"isPrimary":true,"naicsCode":"541511","naicsName":"CUSTOM
+        COMPUTER PROGRAMMING SERVICES"}],"registrationDate":"2016-03-16 00:00:00.0","creditCardUsage":true,"duns":"506163962","countryOfIncorporation":"SRB","electronicBusinessPoc":{"lastName":"RAKIC","address":{"zip":"11111","countryCode":"SRB","line1":"Molerova
+        12/2","stateorProvince":"AA","city":"Belgrade"},"email":"GRAKIC@DEVBASE.NET","nonUsPhone":"381-637074291","firstName":"GORAN"},"mailingAddress":{"zip":"11111","countryCode":"SRB","line1":"MOLEROVA
+        12/2","city":"Belgrade"},"purposeOfRegistration":"ALL_AWARDS"}}}'
+    http_version: 
+  recorded_at: Tue, 07 Jun 2016 00:09:45 GMT
+recorded_with: VCR 3.0.3

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: samwise
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Alan deLevie
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-25 00:00:00.000000000 Z
+date: 2016-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
@@ -161,6 +161,7 @@ files:
 - ".gitignore"
 - ".rdoc_options"
 - ".rspec"
+- ".ruby-version"
 - ".travis.yml"
 - CONTRIBUTING.md
 - ChangeLog.md
@@ -172,6 +173,7 @@ files:
 - lib/samwise.rb
 - lib/samwise/cli.rb
 - lib/samwise/client.rb
+- lib/samwise/duns_lookup.rb
 - lib/samwise/error.rb
 - lib/samwise/protocol.rb
 - lib/samwise/util.rb
@@ -208,7 +210,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Ruby access to the SAM.gov API