samson_hipchat 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5dde8617b79688e447d24772d04c4636257074a7
-  data.tar.gz: 54c8e367ee9a185ee3a195af3aff827558a8a097
+  metadata.gz: 3df471005965151a366d321f8d68e01d334031ba
+  data.tar.gz: ba241af2e33b3a685b3d95d9c361dba6739e0245
 SHA512:
-  metadata.gz: 7d4b4f361f3a33e2273a116fd5be3b458d03208a1ce1ce250801295bc69f07cb27523ec433da1ab019dda773e4ebcf53093818f6659b20d80ce8f0d04b0820cb
-  data.tar.gz: 487fa2af69ba5a66e2bb79913a4a16f58164bb4aa4fcfb396a9823c7d64161254267039538e779a09ea8c8575bfa8841494df7db6c82fe5d46dd17570c103170
+  metadata.gz: 7568d94df81592ec9d3ed0b6562acc322770a2a8f03ff1ee009bc5ea44b1cd1e157e67d20e7852332d9073367db582c9cc6a3efbaba01e024ef72dd329ce70fd
+  data.tar.gz: 9a41b596e5dfa4619b7adde5d5455fe0df767db5c3999bd8cc08ac81de38db19f0ec9771e2f90bceaa55ed8838438fe2b8ed50e264ce78a78231061824cb50ef

data/app/decorators/stage_decorator.rb

@@ -21,15 +21,17 @@ Stage.class_eval do
 
   def update_room_id
     if room_for(room_name)
+      # we attempt to save room id
       self.hipchat_rooms.first.room_id = room_for(room_name)['id']
     else
-      self.hipchat_rooms.first.room_id = nil
+      # if we fail, this maybe a notification token, just set it to 0
+      self.hipchat_rooms.first.room_id = 0 if room_name
     end
   end
 
   def room_exists?
     if room_name
-      errors.add(:hipchat_rooms_name, "was not found. Create the room first. If this is a notification token, you can ignore this message") unless room_for(room_name)
+      #errors.add(:hipchat_rooms_name, "was not found. Create the room first. If this is a notification token, you can ignore this message") unless room_for(room_name)
     end
   end
 
@@ -41,7 +43,7 @@ Stage.class_eval do
   def room_for(name)
     return nil unless name
 
-    Rails.cache.fetch(hipchat_rooms_cache_key, expires_in: 5.minutes) do
+    Rails.cache.fetch(hipchat_rooms_cache_key + name, expires_in: 15.minutes) do
       begin
         hipchat[name].get_room
       rescue HipChat::UnknownRoom, HipChat::UnknownResponseCode

data/db/migrate/20150702231956_remove_room_id_from_hipchat_room.rb

@@ -0,0 +1,5 @@
+class RemoveRoomIdFromHipchatRoom < ActiveRecord::Migration
+  def change
+    remove_column :hipchat_rooms, :room_id, :string
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: samson_hipchat
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Vinh Nguyen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-01 00:00:00.000000000 Z
+date: 2015-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hipchat
@@ -38,6 +38,7 @@ files:
 - app/views/samson_hipchat/notification.text.erb
 - config/initializers/hipchat.rb
 - db/migrate/20150519105221_create_hipchat_rooms.rb
+- db/migrate/20150702231956_remove_room_id_from_hipchat_room.rb
 - lib/samson_hipchat/samson_plugin.rb
 homepage: 
 licenses: []