samlr 2.4.0 → 2.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 574871d6c97431297604a86ffd9a5d6e1adb7008
-  data.tar.gz: d8c7efd947792092d911ce6a12b5b21917852198
+  metadata.gz: 0f3f8a1071f3f774c3a9d624731c7e6aab77ce61
+  data.tar.gz: c4c25e98aa62abfaa17733a41fe1732003148bb5
 SHA512:
-  metadata.gz: 25f838972bc1b93d970da4dace7cd6a2cd94dfcccd5fbfb823c1fb931239233012779cf96abe3f56e1c5a0a8d13a3c62e67839f38868041191aaf5ec17c7f9b3
-  data.tar.gz: cffb65ac150882ac090629f691c4ae0e0196130e08a6d020236e7136a21caebdcad6d9b62238fb464634b3ea6e4e8e4e5f436fd9fad8aa3a226aef367405d3f1
+  metadata.gz: f7b190788159255d83cef081bdae91f344865168926f2e63dc083e4ef4bf7e12780a6154af4ce398c7726260bf92df0eec38237b5e6197e2fc2b70e1d7ad72fa
+  data.tar.gz: 8c8f29c3e09782ed5f870ed9a73763a78f24fa6f28f158d8e06b91e2d81f7d2d7781600d9e25b692d4f1102e3dd24443fc444ee7114f6c259f9818979f07644e

data/lib/samlr/assertion.rb

@@ -48,7 +48,11 @@ module Samlr
     end
 
     def name_id
-      @name_id ||= name_id_node.text
+      if !name_id_node
+        raise Samlr::FormatError.new("Invalid SAML response: name_id missing")
+      else
+        @name_id ||= name_id_node.text
+      end
     end
 
     def name_id_options

data/lib/samlr/tools/response_builder.rb

@@ -19,13 +19,13 @@ module Samlr
         auth_context      = options[:auth_context]   || "urn:oasis:names:tc:SAML:2.0:ac:classes:Password"
         issuer            = options[:issuer]         || "ResponseBuilder IdP"
         attributes        = options[:attributes]     || {}
+        name_id           = options[:name_id]
         name_qualifier    = options[:name_qualifier]
         sp_name_qualifier = options[:sp_name_qualifier]
 
         # Mandatory for responses
         destination     = options.fetch(:destination)
         in_response_to  = options.fetch(:in_response_to)
-        name_id         = options.fetch(:name_id)
         not_on_or_after = options.fetch(:not_on_or_after)
         not_before      = options.fetch(:not_before)
         audience        = options.fetch(:audience)
@@ -55,7 +55,7 @@ module Samlr
                   name_id_options.merge!("NameQualifier" => name_qualifier) unless name_qualifier.nil?
                   name_id_options.merge!("SPNameQualifier" => sp_name_qualifier) unless sp_name_qualifier.nil?
 
-                  xml["saml"].NameID(name_id, name_id_options)
+                  xml["saml"].NameID(name_id, name_id_options) unless name_id.nil?
 
                   xml["saml"].SubjectConfirmation("Method" => subject_conf_m) do
                     xml["saml"].SubjectConfirmationData("InResponseTo" => in_response_to, "NotOnOrAfter" => not_on_or_after, "Recipient" => destination)

data/lib/samlr/version.rb

@@ -1,3 +1,3 @@
 module Samlr
-  VERSION = "2.4.0"
+  VERSION = "2.4.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: samlr
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
 platform: ruby
 authors:
 - Morten Primdahl
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-24 00:00:00.000000000 Z
+date: 2016-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -158,4 +158,3 @@ signing_key:
 specification_version: 4
 summary: Ruby tools for SAML
 test_files: []
-has_rdoc: