samanage 2.1.19 → 2.1.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a13aff3441a2b195624d0ddd7f890f218cecd85949110dc1dd493e67c04b2c90
-  data.tar.gz: 279f7937d734914300265dd92d4144135eea997ac9282a721a6c696aaaf5b476
+  metadata.gz: 2123d5a06d5316e8f8c68eeddc675da008aaaaad062208796f8f89bc142ce51e
+  data.tar.gz: d8e19971dbadfdfe6b102fb40931786a30506f70090db7a56e2ada9babe539d2
 SHA512:
-  metadata.gz: e91607ebc97987f438434c4c99391bd68ef9c6e96eb7f31b63d9abb66516399ccc872be9d074ce863ba4ad59fe9b1a90773c39252daef27585c1f43a850d9cfd
-  data.tar.gz: d2b2f7890fb41e851a24caeb4101945f7bed0c3d933e397d1471eb22b19cbb69cd39309bd0b8b0038a7229f2fd284239a3ad86f74f7ee1cc1e3413832dfcb697
+  metadata.gz: 8444a5784699c2b93ee52ac126c4221d4c6cc55bdc5053c2c930a91c6b0474a046b04b28e2dd68bf419ad1453d5a42c838724ff5a0406cc08e2ce88d75214b6e
+  data.tar.gz: f3e85b2df019e7776b286a58c0dff2631d125c1b0dca583ddae4e95f3736044d8069defa862642f9fa600422854da560deceafc075c880a984dc3fb5238e96a2

data/.rubocop.yml

@@ -0,0 +1,224 @@
+require:
+  - rubocop-performance
+AllCops:
+  TargetRubyVersion: 2.5
+  # RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
+  # to ignore them, so only the ones explicitly set in this file are enabled.
+  DisabledByDefault: true
+
+Metrics/LineLength:
+  Max: 120 # Try to reduce this over time
+
+  # Prefer &&/|| over and/or.
+Style/AndOr:
+  Enabled: true
+
+# Do not use braces for hash literals when they are the last argument of a
+# method call.
+Style/BracesAroundHashParameters:
+  Enabled: true
+  EnforcedStyle: context_dependent
+
+# Align `when` with `case`.
+Layout/CaseIndentation:
+  Enabled: true
+
+# Align comments with method definitions.
+Layout/CommentIndentation:
+  Enabled: true
+
+Layout/ElseAlignment:
+  Enabled: true
+
+# Align `end` with the matching keyword or starting expression except for
+# assignments, where it should be aligned with the LHS.
+Layout/EndAlignment:
+  Enabled: true
+  EnforcedStyleAlignWith: variable
+  AutoCorrect: true
+
+Layout/EmptyLineAfterMagicComment:
+  Enabled: true
+
+Layout/EmptyLinesAroundAccessModifier:
+  Enabled: true
+  EnforcedStyle: only_before
+
+Layout/EmptyLinesAroundBlockBody:
+  Enabled: true
+
+# In a regular class definition, no empty lines around the body.
+Layout/EmptyLinesAroundClassBody:
+  Enabled: true
+
+# In a regular method definition, no empty lines around the body.
+Layout/EmptyLinesAroundMethodBody:
+  Enabled: true
+
+# In a regular module definition, no empty lines around the body.
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: true
+
+# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
+Style/HashSyntax:
+  Enabled: true
+
+Layout/IndentFirstArgument:
+  Enabled: true
+
+# Method definitions after `private` or `protected` isolated calls need one
+# extra level of indentation.
+Layout/IndentationConsistency:
+  Enabled: true
+  EnforcedStyle: indented_internal_methods
+
+# Two spaces, no tabs (for indentation).
+Layout/IndentationWidth:
+  Enabled: true
+
+Layout/LeadingCommentSpace:
+  Enabled: true
+
+Layout/SpaceAfterColon:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAfterSemicolon:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Enabled: true
+
+Layout/SpaceAroundOperators:
+  Enabled: true
+
+Layout/SpaceBeforeComma:
+  Enabled: true
+
+Layout/SpaceBeforeComment:
+  Enabled: true
+
+Layout/SpaceBeforeFirstArg:
+  Enabled: true
+
+Style/DefWithParentheses:
+  Enabled: true
+
+# Defining a method with parameters needs parentheses.
+Style/MethodDefParentheses:
+  Enabled: true
+
+Style/FrozenStringLiteralComment:
+  Enabled: true
+  EnforcedStyle: always
+
+Style/RedundantFreeze:
+  Enabled: true
+
+# Use `foo {}` not `foo{}`.
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
+# Use `foo { bar }` not `foo {bar}`.
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+  EnforcedStyleForEmptyBraces: space
+
+# Use `{ a: 1 }` not `{a:1}`.
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Layout/SpaceInsideParens:
+  Enabled: true
+
+# Check quotes usage according to lint rule below.
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+# Detect hard tabs, no hard tabs.
+Layout/Tab:
+  Enabled: true
+
+# Blank lines should not have any spaces.
+Layout/TrailingBlankLines:
+  Enabled: true
+
+# No trailing whitespace.
+Layout/TrailingWhitespace:
+  Enabled: true
+
+# Use quotes for string literals when they are enough.
+Style/UnneededPercentQ:
+  Enabled: true
+
+Lint/AmbiguousOperator:
+  Enabled: true
+
+Lint/AmbiguousRegexpLiteral:
+  Enabled: true
+  # Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
+Lint/RequireParentheses:
+  Enabled: true
+
+Lint/ShadowingOuterLocalVariable:
+  Enabled: true
+
+Lint/StringConversionInInterpolation:
+  Enabled: true
+
+Lint/UriEscapeUnescape:
+  Enabled: true
+
+Lint/UselessAssignment:
+  Enabled: true
+
+Lint/DeprecatedClassMethods:
+  Enabled: true
+
+Style/ParenthesesAroundCondition:
+  Enabled: true
+
+Style/RedundantBegin:
+  Enabled: true
+
+Style/RedundantReturn:
+  Enabled: true
+  AllowMultipleReturnValues: true
+
+Style/Semicolon:
+  Enabled: true
+  AllowAsExpressionSeparator: true
+
+# Prefer Foo.method over Foo::method
+Style/ColonMethodCall:
+  Enabled: true
+
+Style/TrivialAccessors:
+  Enabled: true
+
+Performance/FlatMap:
+  Enabled: true
+
+Performance/RedundantMerge:
+  Enabled: true
+
+Performance/StartWith:
+  Enabled: true
+
+Performance/EndWith:
+  Enabled: true
+
+Performance/RegexpMatch:
+  Enabled: true
+
+Performance/ReverseEach:
+  Enabled: true
+
+Performance/UnfreezeString:
+  Enabled: true

data/Gemfile

@@ -1,14 +1,19 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
-gem 'rspec'
+gem "rspec"
+gem "httparty", "0.16.4"
+gem "ffi", "1.9.24"
 
-gem 'httparty', '0.16.4'
-gem 'ffi', '1.9.24'
 group :development do
-  gem 'guard-rspec', require: false
+  gem "guard-rspec", require: false
+  gem "rubocop", require: false
+  gem "rubocop-performance"
 end
 
+
 group :test do
-  gem 'guard-rspec', require: false
-  gem 'faker'
-end
+  gem "guard-rspec", require: false
+  gem "faker"
+end

data/Gemfile.lock

@@ -1,14 +1,15 @@
 GEM
   remote: https://rubygems.org/
   specs:
+    ast (2.4.0)
     coderay (1.1.2)
-    concurrent-ruby (1.0.5)
+    concurrent-ruby (1.1.5)
     diff-lcs (1.3)
-    faker (1.9.1)
-      i18n (>= 0.7)
+    faker (2.1.2)
+      i18n (>= 0.8)
     ffi (1.9.24)
     formatador (0.2.5)
-    guard (2.14.2)
+    guard (2.15.0)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (>= 1.0.12, < 2.0)
@@ -25,44 +26,60 @@ GEM
     httparty (0.16.4)
       mime-types (~> 3.0)
       multi_xml (>= 0.5.2)
-    i18n (1.1.0)
+    i18n (1.6.0)
       concurrent-ruby (~> 1.0)
+    jaro_winkler (1.5.3)
     listen (3.1.5)
       rb-fsevent (~> 0.9, >= 0.9.4)
       rb-inotify (~> 0.9, >= 0.9.7)
       ruby_dep (~> 1.2)
     lumberjack (1.0.13)
-    method_source (0.9.0)
+    method_source (0.9.2)
     mime-types (3.2.2)
       mime-types-data (~> 3.2015)
-    mime-types-data (3.2018.0812)
+    mime-types-data (3.2019.0331)
     multi_xml (0.6.0)
     nenv (0.3.0)
-    notiffany (0.1.1)
+    notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    pry (0.11.3)
+    parallel (1.17.0)
+    parser (2.6.3.0)
+      ast (~> 2.4.0)
+    pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
+    rainbow (3.0.0)
     rb-fsevent (0.10.3)
-    rb-inotify (0.9.10)
-      ffi (>= 0.5.0, < 2)
-    rspec (3.7.0)
-      rspec-core (~> 3.7.0)
-      rspec-expectations (~> 3.7.0)
-      rspec-mocks (~> 3.7.0)
-    rspec-core (3.7.1)
-      rspec-support (~> 3.7.0)
-    rspec-expectations (3.7.0)
+    rb-inotify (0.10.0)
+      ffi (~> 1.0)
+    rspec (3.8.0)
+      rspec-core (~> 3.8.0)
+      rspec-expectations (~> 3.8.0)
+      rspec-mocks (~> 3.8.0)
+    rspec-core (3.8.2)
+      rspec-support (~> 3.8.0)
+    rspec-expectations (3.8.4)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-mocks (3.7.0)
+      rspec-support (~> 3.8.0)
+    rspec-mocks (3.8.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-support (3.7.1)
+      rspec-support (~> 3.8.0)
+    rspec-support (3.8.2)
+    rubocop (0.74.0)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.6)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    rubocop-performance (1.4.1)
+      rubocop (>= 0.71.0)
+    ruby-progressbar (1.10.1)
     ruby_dep (1.5.0)
     shellany (0.0.1)
-    thor (0.20.0)
+    thor (0.20.3)
+    unicode-display_width (1.6.0)
 
 PLATFORMS
   ruby
@@ -73,6 +90,8 @@ DEPENDENCIES
   guard-rspec
   httparty (= 0.16.4)
   rspec
+  rubocop
+  rubocop-performance
 
 BUNDLED WITH
-   1.16.1
+   2.0.2

data/Guardfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A sample Guardfile
 # More info at https://github.com/guard/guard#readme
 
@@ -15,10 +17,10 @@
 #
 # and, you'll have to watch "config/Guardfile" instead of "Guardfile"
 
-guard :rspec, cmd: 'bundle exec rspec', all_on_start: true do
+guard :rspec, cmd: "bundle exec rspec", all_on_start: true do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/samanage_#{m[1]}_spec.rb" }
   watch(%r{^lib/api/(.+)\.rb$})     { |m| "spec/lib/api/samanage_#{m[1]}_spec.rb" }
   watch(%r{^lib/(.+)\.rb$})
-  watch('spec/spec_helper.rb')  { "spec" }
-end
+  watch("spec/spec_helper.rb")  { "spec" }
+end

data/changelog.md

@@ -1,40 +1,59 @@
+### 2.1.20
+
+- Added tasks
+- Updated bundle & gems
+
+### 2.1.19
+
+- +Linting
+
 ### 2.1.18
+
 - Force multipart for attachments
 - Custom sleep time
 - Added catching all errors
 - Normalizing stout
 
 ### 2.1.17
+
 - Retry all errors
 - Ability to configure retry count & wait time.
 - Normalize messages
 
 ### 2.1.16
+
 - Use options where callbacks could be sent
 
 ### 2.1.15
+
 - Use options in find methods
 
 ### 2.1.14
+
 - Swap header merging
 
 ### 2.1.13
+
 - Pass Query params separate from Body
 - Add coverage for `{add_calbacks: true}` option
 - Add Release support
 
 ### 2.1.12
+
 - Add vendor support
 - Close opened files
 
 ### 2.1.11
+
 - Update runtime
 
 ### 2.1.10
+
 - Attachments for Windows
 - Handle Socket Errors
 
 ### 2.1.09
+
 - Updated HTTParty to 0.16.4
 - Optimize heavy audit+layout incident collection
 - Adding purchase order support
@@ -44,97 +63,151 @@
 - Handle HTTPTooManyRequests
 
 ### 2.1.08
+
 - Correct Message
 
 ### 2.1.07
+
 - Added problems
 
-### 2.1.06 
+### 2.1.06
+
 - Added time track support
+
 ### 2.1.05
+
 - Adding new error checks
 - Using Faker for tests
+
 ### 2.1.04
+
 - params bug fix
+
 ### 2.1.03
+
 - Use paths
+
 ### 2.1.02
+
 - Use parmas in all collections
+
 ### 2.1.01
+
 - Added solutions
+
 ### 2.1.0
+
 - Use `URI###encode_www_form`
+
 ### 2.0.04
+
 - Fix case sensitivity relationships
- 
+
 ### 2.0.03
+
 - Bugfix for custom fields (fix httparty version)
+
 ### 2.0.0
+
 - Support for responding to blocks in all paginated collection methods
 - Added Changes (itsm)
+
 ### 1.9.35
+
 - Solve warnings
+
 ### 1.9.34
+
 - Solve warnings
+
 ### 1.9.33
+
 - Using new cert
+
 ### 1.9.32
+
 - Adding layout long for single incident
 - Adding attachment downloads
+
 ### 1.9.31
+
 - Alias original comment method
 - Remove (keyword: nil)
 - Collapse error retry output
+
 ### 1.9.3
+
 - Handle HTTP Read Timeout
-### 1.9.2 
+
+### 1.9.2
+
 - Adding delete functionality for modules Contracts, Departments, Groups, Hardwares, Incidents, Mobiles, Other_assets, Sites, Users
-### 1.9.1 
+
+### 1.9.1
+
 - Adding items to contracts & faster tests
+
 ### 1.9.0
-- Adding contracts 
-### 1.8.91 
+
+- Adding contracts
+
+### 1.8.91
+
 - Group case sensitivity fix
+
 ### 1.8.9
+
 - Adding output verbosity for collection methods
+
 ### 1.8.8
+
 - Base level .execute delete functionality
 - Error message for invalid http methods
 - Added audit_archive to incident options
+
 ### 1.8.7
+
 - Fixing retry bug
+
 ### 1.8.6
+
 - Removing layout=long verbosity
+
 ### 1.8.5
+
 - Adding option for incidents layout=long
-### 1.8.3 
+
+### 1.8.3
+
 - Additional Request Timeout retry support
 - Support for non-parsed responseq
 - Moving non object specific methods to samanage/api/utils
 - Added activation emails
+
 ### 1.8.2
+
 - Adding Category support
-###1.8.1
+  ###1.8.1
 - More flexible membership adding
 - Collection method aliasing for simpler api (old methods will be removed in v2.0)
-###1.8.0
+  ###1.8.0
 - Adding coverage for invalid api requests
-###1.7.9
+  ###1.7.9
 - Solving eu datacenter support against base_url
-###1.7.8
+  ###1.7.8
 - Fixing nil condition in user_id methods
-###1.7.6
+  ###1.7.6
 - Adding group_id find methods for group name and user email
-###1.7.5
+  ###1.7.5
 - Adding site, department, group creation
-###1.7.4
+  ###1.7.4
 - Solving admin listing issue
-###1.7.2
+  ###1.7.2
 - Catching refused connections as Samanage::Error
-###1.7.1
+  ###1.7.1
 - Client Side SSL certificate Forced
-###1.7.0
+  ###1.7.0
 - Switched to HTTParty
 - Payload now responds to `Hash`. `Strings` will be parsed using `JSON.parse(payload)`
-###1.6.9
-- Added support for Mobile Devices
+  ###1.6.9
+- Added support for Mobile Devices