samanage 1.7.9 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c33712f14d8e3954583638e677767e18d8994685
-  data.tar.gz: 2eb7879f1973dd1700aaa60ea7650550d8fd4e9e
+  metadata.gz: 9d70a2a85e1f7606feeb1ba847efa75067eb79e8
+  data.tar.gz: 6d66b498fbbe47bcb48d2202718273a3bd462664
 SHA512:
-  metadata.gz: 8895ef4b07eaf76bdd3df1b91ec9b2d94daaa3b75683e0b9c1a48321aec85dd6000d7f79b7ebf8e3a892cc84c6f16350432d1036e31f8b9e0b6cbf1ebb1c55df
-  data.tar.gz: 7c085ca06d726b5e6c36afcd8da1565a30f9af3cc79f7368fad9fa36a7930c93a33fc66b425c214afbb86103474681685169142e6858e08f610561bcce6f4c4e
+  metadata.gz: 57efde3151897203323b7545db3892a0d0ccf733cadfda29b61c6bd9e9f596d284e1e4808319717ed4e731771b19c4d594d5e68f4bfcc11d134813e4fb47317d
+  data.tar.gz: 7db1d6ee21585b792de8584ca07260dc31d6c58cc73f9298e17801a53327d568c8821fb51b28508528af9456743c0f9f1c36e3dfa23aeffe93e169230884135c

data/changelog.md

@@ -1,3 +1,6 @@
+#1.8.0
+- Adding coverage for invalid api requests
+
 #1.7.9
 - Solving eu datacenter support against base_url
 #1.7.8

data/lib/samanage/api/groups.rb

@@ -1,6 +1,5 @@
 module Samanage
 	class Api
-
 		def get_groups(path: PATHS[:group], options: {})
 			url = Samanage::UrlBuilder.new(path: path, options: options).url
 			self.execute(path: url)

data/lib/samanage/api/users.rb

@@ -39,14 +39,14 @@ module Samanage
 		# Returns nil if no matching group_id
 		def find_user_group_id_by_email(email: )
 			user = self.check_user(value: email)
-			group_ids = user[:data].select{|u| u['email'].to_s.downcase == email.to_s.downcase}.first.to_h['group_ids']
+			group_ids = user[:data].select{|u| u['email'].to_s.downcase == email.to_s.downcase}.first.to_h['group_ids'].to_a
 			group_ids.each do |group_id|
 				group = self.find_group(id: group_id)
 				if group[:data]['is_user'] && email == group[:data]['email']
 					return group_id
 				end
 			end
-			return
+			return nil
 		end
 
     # Check for user by field (ex: users.json?field=value)

data/samanage.gemspec

@@ -1,7 +1,7 @@
 $:.push File.expand_path("../lib", __FILE__)
 Gem::Specification.new do |s|
   s.name                    = 'samanage'
-  s.version                 = '1.7.9'
+  s.version                 = '1.8.0'
   s.date                    =  Date.today.strftime("%Y-%m-%d")
   s.summary                 = "Samanage Ruby Gem"
   s.description             = "Connect to Samanage using Ruby!"

data/spec/api/samanage_group_spec.rb

@@ -1,5 +1,4 @@
 require 'samanage'
-
 describe Samanage::Api do
 	context 'group' do
 		before(:each) do
@@ -50,6 +49,11 @@ describe Samanage::Api do
 
 			expect(group_id).to eq(found_group_id)
 		end
+		it 'returns nil for finding invalid group by name' do
+			group_name = "Invalid-#{rand(100)*100}"
+			found_group_id = @controller.find_group_id_by_name(group: group_name)
+			expect(found_group_id).to be(nil)
+		end
 		it 'adds member to group' do
 			random_group_id = @controller.collect_groups.sample['id']
 			random_user_email = @controller.collect_users.sample['email']

data/spec/api/samanage_user_spec.rb

@@ -86,6 +86,25 @@ describe Samanage::Api do
 
 				expect(function_id).to eq(found_id)
 			end
+
+
+			it 'returns nil for invalid find_user_group_id_by_email' do
+				invalid_user_email = 'abc@123.gov'
+				function_id = @controller.find_user_group_id_by_email(email: invalid_user_email)
+
+				expect(function_id).to be(nil)
+			end
+
+			it 'returns nil for invalid find_user_id_by_email' do
+				invalid_user_email = 'abc@123.gov'
+				function_id = @controller.find_user_id_by_email(email: invalid_user_email)
+
+				expect(function_id).to be(nil)
+			end
+
+
+
+
 			it 'update_user: update_user by id' do
 				users = @controller.collect_users
 				sample_id = users.sample['id']

data/spec/samanage_api_spec.rb

@@ -41,6 +41,16 @@ describe Samanage do
   			samanage_admin = api_controller.execute(path: "users.json?email=#{admin_email}")
   			expect(samanage_admin[:data].first['role']['name']).to eq('Administrator')
   		end
+
+  		it 'sets eu datacenter' do
+  			api_controller = Samanage::Api.new(token: 'token', datacenter: 'eu')
+  			expect(api_controller.base_url).to eq('https://appeu.samanage.com')
+  		end
+
+  		it 'does not set non/eu datacenter' do
+  			api_controller = Samanage::Api.new(token: 'token', datacenter: 'invalid')
+  			expect(api_controller.base_url).to eq('https://app.samanage.com')
+  		end
 	  end
 	end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: samanage
 version: !ruby/object:Gem::Version
-  version: 1.7.9
+  version: 1.8.0
 platform: ruby
 authors:
 - Chris Walls