salsify_rubocop 0.58.0.rc1 → 0.59.2.1.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 87305955e8ac9148e7c0e35f8cb0452574965f0bfc07452e225bb939603c3dc0
-  data.tar.gz: 622dc482540ce25f41213cacb1a16f08352bfb39ba644478429183cab24b0ead
+  metadata.gz: 3bad74d395450e607785a9cce155e9637feda5a809b073c979acc8dbc811bb30
+  data.tar.gz: 48029cf2df4a10cdfa5aa82b3a0cec831349820196359f78ac76bd970ede329b
 SHA512:
-  metadata.gz: e7a437af5fb882a1ad682038b28352e1ae8271286ca30d939e594b97f660e37c9e0bae2138f1887d28055681b2201184d95d0a868d9570b0171895e53f566150
-  data.tar.gz: ddcd4352d6689267ced3567a114f0d55da058c673e320425b28d52f15962cd17710b8ec2a9428a1c89628d7466551fa7c52ceb47ee011e6e231f7bbf832471cf
+  metadata.gz: 64f196f2442d97efb44df337d1e35ea58860a17909a793d658c65053c8006097a873ace55c7b7bff4d15fe69f0bc358d232ca9568ab465c062a7907af65e9e6b
+  data.tar.gz: 64475b91d7e555e2665240d288a9ca043a4ce41177786b64646dbd185c5e17b3a7ed44237064c76e9699784d5b141c93aeef7c157a8250f5c5bf7105dbe8df6e

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # salsify_rubocop
 
+## v0.59.2.1
+- Update `rubocop` to v0.59.2.
+- Add `Salsify/RailsUnscoped` cop.
+
 ## v0.58.0
 - Update `rubocop` to v0.58.0.
 - Update `rubocop-rspec` to v1.29.0.

data/conf/rubocop_rails.yml

@@ -17,3 +17,6 @@ Rails/TimeZone:
 
 Rails/UniqBeforePluck:
   EnforcedStyle: aggressive
+
+Salsify/RailsUnscoped:
+  Enabled: true

data/config/default.yml

@@ -10,6 +10,10 @@ Salsify/RailsApplicationRecord:
   Description: 'Models must subclass ApplicationRecord.'
   Enabled: false
 
+Salsify/RailsUnscoped:
+  Description: 'Activerecord scopes cannot use unscoped.'
+  Enabled: false
+
 Salsify/RspecDocString:
   Description: 'Check that RSpec doc strings use the correct quoting.'
   Enabled: true

data/lib/rubocop/cop/salsify/rails_unscoped.rb

@@ -0,0 +1,28 @@
+module RuboCop
+  module Cop
+    module Salsify
+      # Check that Activerecord scopes do not use `unscoped`
+      #
+      # @example
+      #
+      #  # good
+      #  User.strip_default_scope
+      #
+      #  # bad
+      #  User.unscoped
+      class RailsUnscoped < Cop
+        MSG = 'Explicitly remove scopes instead of using `unscoped`.'.freeze
+
+        def_node_matcher :unscoped?, <<-PATTERN
+          (send _ :unscoped)
+        PATTERN
+
+        def on_send(node)
+          return unless unscoped?(node)
+
+          add_offense(node, location: :expression, message: MSG)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/salsify/rspec_doc_string.rb

@@ -61,6 +61,7 @@ module RuboCop
         def wrong_quotes?(node)
           src = node.source
           return false if src.start_with?('%', '?')
+
           if style == :single_quotes
             src !~ /^'/ && !needs_escaping?(node.str_content)
           else

data/lib/rubocop/cop/salsify/style_dig.rb

@@ -29,6 +29,7 @@ module RuboCop
 
         def on_send(node)
           return unless nested_access_match(node) && !assignment?(node)
+
           match_node = node
           # walk to outermost access node
           match_node = match_node.parent while access_node?(match_node.parent)

data/lib/salsify_rubocop.rb

@@ -15,6 +15,7 @@ RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, config)
 # cops
 require 'rubocop/cop/salsify/rails_application_mailer'
 require 'rubocop/cop/salsify/rails_application_serializer'
+require 'rubocop/cop/salsify/rails_unscoped'
 require 'rubocop/cop/salsify/rspec_doc_string'
 require 'rubocop/cop/salsify/rspec_dot_not_self_dot'
 require 'rubocop/cop/salsify/rspec_string_literals'

data/lib/salsify_rubocop/version.rb

@@ -1,3 +1,3 @@
 module SalsifyRubocop
-  VERSION = '0.58.0.rc1'.freeze
+  VERSION = '0.59.2.1.rc1'.freeze
 end

data/salsify_rubocop.gemspec

@@ -32,6 +32,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
 
-  spec.add_runtime_dependency 'rubocop', '~> 0.58.0'
+  spec.add_runtime_dependency 'rubocop', '~> 0.59.2'
   spec.add_runtime_dependency 'rubocop-rspec', '~> 1.29.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: salsify_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.58.0.rc1
+  version: 0.59.2.1.rc1
 platform: ruby
 authors:
 - Salsify, Inc
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-08-29 00:00:00.000000000 Z
+date: 2018-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.58.0
+        version: 0.59.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.58.0
+        version: 0.59.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -105,6 +105,7 @@ files:
 - config/default.yml
 - lib/rubocop/cop/salsify/rails_application_mailer.rb
 - lib/rubocop/cop/salsify/rails_application_serializer.rb
+- lib/rubocop/cop/salsify/rails_unscoped.rb
 - lib/rubocop/cop/salsify/rspec_doc_string.rb
 - lib/rubocop/cop/salsify/rspec_dot_not_self_dot.rb
 - lib/rubocop/cop/salsify/rspec_string_literals.rb
@@ -134,7 +135,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Shared shared RuboCop configuration